From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E634244077; Mon, 20 May 2024 12:43:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90E3540A81; Mon, 20 May 2024 12:43:08 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2057.outbound.protection.outlook.com [40.107.94.57]) by mails.dpdk.org (Postfix) with ESMTP id 147DD40DDB for ; Mon, 20 May 2024 12:43:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TuRMSDjlmMUJlMw2nN0X1sMom+kcNSOUGi0R5SLegLUIodd4JOcBoN1vj6RGd2IJtEotb51VDen9thVqsnQ3BoO+G9HNfPYNhiULztHFZyPmLzp+b0j1NJQaOkKrgJM7cvTnpfp/P8b/SqmezNwPYDm0lmB3ykoc6QnOIiZznETlcEBQMd2rV8bLzkAUQ0PlMrk0Qv+5ze8RW3Hm8s4CBXQZpknSOATDbmEhm8+dsXSiHmRAzsB7WR6ysQy4gyI23l6nkUpA1HUomYSrpTnZusU1qX8Feyl51Rrv6jzCtkbT27ar6W1BZmbGBgr1W5NKdTGF6BgVUzpwMMa5MXnW0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sTjjhq0LBQgP82JZbg06WdmvsjGMB2Yznmv0MPFlGTk=; b=Ag0IUOn/Z9Tl75O9bWd06USUnjbt83th5COY7ir5DDtf7FWbVdDp5+7oQyODxd+cLZ4O3ilSRqCoi3eXjqLXzCsr81+9LYwqWlW2JSMRqCfEPpPXRnhtxbOeiJ135oR8XSRHmdCk8ut1XPuozKi7yqGP05MO3xe4RoiwEuV6xrLEILJ9Pg43BIlKreLklEvOc+sq8s9V/A31zx8CdN43r98oC1iumbbllR03SzVszmNH7nTbrXbntOfhPO1FQKtqJOrQPyWOG8b3pgliwfN259tzOyRgDgpw8eEZqnTxLSVo6HgQbkUdfH5TYuc0EVdx07AWdVOKBQ/v7EgGbzI7cQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sTjjhq0LBQgP82JZbg06WdmvsjGMB2Yznmv0MPFlGTk=; b=2fIhvAxBhSI85p+q+u1DEnxElj1aXTVPTK+ntrOj2tP7IEqm5sJQ5qnCWUQwwiaVzf7CpGTHWifm1OGoW69rjlMvTAdDl0yFnSPeOVbDWEPjkqRwpEUJltiEtif+otO2ZQTTx6VbxYN804SDdFOIOsqNYxZOKlbWG9krRcn9a+M= Received: from DM4PR12MB5055.namprd12.prod.outlook.com (2603:10b6:5:39a::20) by DS0PR12MB7607.namprd12.prod.outlook.com (2603:10b6:8:13f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.36; Mon, 20 May 2024 10:43:05 +0000 Received: from DM4PR12MB5055.namprd12.prod.outlook.com ([fe80::acbd:ea93:4496:51a5]) by DM4PR12MB5055.namprd12.prod.outlook.com ([fe80::acbd:ea93:4496:51a5%7]) with mapi id 15.20.7587.035; Mon, 20 May 2024 10:43:05 +0000 From: "Sebastian, Selwin" To: "Ande, Venkat Kumar" , "dev@dpdk.org" Subject: RE: [PATCH v2 20/25] net/axgbe: replace mii generic macro for c45 with AXGBE Thread-Topic: [PATCH v2 20/25] net/axgbe: replace mii generic macro for c45 with AXGBE Thread-Index: AQHaoHxMpb/STh7JuEeHLLQpCwhPqbGgBADw Date: Mon, 20 May 2024 10:43:05 +0000 Message-ID: References: <20240412125013.10498-1-VenkatKumar.Ande@amd.com> <20240507124305.2318-1-venkatkumar.ande@amd.com> <20240507124305.2318-20-venkatkumar.ande@amd.com> In-Reply-To: <20240507124305.2318-20-venkatkumar.ande@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ActionId=44e1aa77-d1a7-4b15-95e8-26435e045962; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=0; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=true; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD Internal Distribution Only; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2024-05-20T10:43:01Z; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5055:EE_|DS0PR12MB7607:EE_ x-ms-office365-filtering-correlation-id: 1d3b6898-0fc5-459d-4246-08dc78b9a164 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|376005|366007|1800799015|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?m0GAsFxOuhnzbCYxjaKbNoxZg51s0s7Dcfh+r1gLtHNdj8+BUlJuKWY3Zp+V?= =?us-ascii?Q?pW38DeXKN8FgAcVlgZckXYrCTihO/SVoZjhlTbEu2t96lHPB590AgyALv5b3?= =?us-ascii?Q?tk+zS7O/fDqfhPrTHOeFhl8Kfe+uMy+xFblm98qQnQzCIpnC7XrH7JkH7BJa?= =?us-ascii?Q?cd8a10r25ayi98//RUtjOOxqgW+XKHrHctZIGYA2f5C/JgJPmI/E0S8WdXmF?= =?us-ascii?Q?ZZ+O+LY8VTZv+NbDZbOK7k1XtNvgKEhKueN9kLLfRKFQzvQuCqfqHgqaiW6T?= =?us-ascii?Q?gf4vM17BkeU9EJUOJojKUY7ap5sMH/Rweh4Aqd0xOjti6K3HomCNQmJVpuir?= =?us-ascii?Q?fyRTq6veuBQxlG7v6uT5y+pj0WZ5kVmotVCd8xJ3cWgJJ/AD2/GRzdvRIgm/?= =?us-ascii?Q?VyjgduvMOduR4d8mdnC3gLMHB0DLV8aHJISIfALzMW+kHux2S9dAlLoGgTym?= =?us-ascii?Q?1bSacPOaP49rXk43aVCCJ5yCZyL1b+bGCG3Tz6TwCdy1dsZBlluEAWIMqUrE?= =?us-ascii?Q?kOgR5mRlZ52yXcL5Z2FXdckTLIBaSJ86VT0GysG2oQ93XVrGMOguAy07V25n?= =?us-ascii?Q?CFC7f9zoHtXpchz1gkZ29LGjmlRjHjnO2GAwdvpk3s89CxoVhDH4cBoFn/Mn?= =?us-ascii?Q?pwsu8zZE5EknOwujIJjkR/i0q8rst2EZcCFQKG6Uk0d4N3Ag7m4U+pFNKX6l?= =?us-ascii?Q?nc0/K1u4mOuzi03c9HT9viWkX16fDnRSWvF8PWiNYNulYKWOTgT8UtLYrwjB?= =?us-ascii?Q?ug7M294u7qWymC+v3+oipy+S5+k1gnMQL8xhmJJB4dqUDR+rwmYKe5n1qzK0?= =?us-ascii?Q?DZfs9yMifmKiuv13apwaDbrfAJgxHY9wYuD9kTcHwrdKquNoJYAYKz/GXIT8?= =?us-ascii?Q?rRzMc4aBDPHzvEAU7G8K0fMyvk4zddX9JVPctNo6FrIYzUmpR/Ek+oFd98x7?= =?us-ascii?Q?CafUPIJ1VwG6ZGm5pgahdk4GU1LCeT6rohPFhTRloW50Cqx2NG29M9Ap1A06?= =?us-ascii?Q?xGFThw7I+mLeEQNsNhdlwQc813+Fu97N1WnXmY/edL0vpTQEdWhMA0xaHmQ2?= =?us-ascii?Q?miHcBIJSR3yMm4sfKb8o/O22+ufvC1C/Bm9Ihk1c/p4OASWZmoYPKro30Q1G?= =?us-ascii?Q?9ffmkHfSHA2AfHvywJBBV4ckmKyycDYTzBkcGlygMIMoWiFJ6k1SR/BU7rIe?= =?us-ascii?Q?3Pmywt1Q0WCooDiP82ObwB3EpG1wmJvmlwou0ak/j8s9XC2EIpfzzSDnWs4e?= =?us-ascii?Q?XMDfhuyTX3GzpUsNpKzgpQdyRR5eR6g3dcjRBCcu0jsWLi2ieysqkF5OJxB8?= =?us-ascii?Q?hGr9qOONGvnTzrtVyVyel98OT/sRd1itSh7AliNHBJNy1w=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5055.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IFMfAt3UJ19vlhJYRucm3BinFxWmplViIphGCumvOfFRJAahLYop4voCqXGJ?= =?us-ascii?Q?aD72JY2R31QmHXkHGExm5Xnw7E3MauSac/e4ic5akY9Odju/kw3Jq1fUALT8?= =?us-ascii?Q?wdohOQkqYtMHYqonb3BtNg9QpOG8486KHklcVuM3tUnKGgikPZlQAYFnP0N4?= =?us-ascii?Q?OaKsDHRDsUbS/gjO/dIG4h+6KolFXoyhqcuEH0XEBcdH5IEfjNH9PFWA/43c?= =?us-ascii?Q?k21JpkqxSrrvAHayXuNnC+HkVsbHfKndkvsCGRz0QL2fweg859SbQ6WkVa6i?= =?us-ascii?Q?eY/cXhxDo0npsJPcziC+kJg6sNnlF7jJitlt69b9E2A0Fa2nhDyB4sJGwGmk?= =?us-ascii?Q?f6pTpRyhKdHpRYz0X/4Air2+ohqOcDSz0wRaUhIwQmoyYlNb/0D5a4BgiB6N?= =?us-ascii?Q?Ko64sF0Q7W7OEZZ0bBpRAYEQoZwlF6qfawDWpx0t60EYquqUkTjbNOFGk/vB?= =?us-ascii?Q?hdWqjRjICEKzPJjLYTxAWJeZEpPV+qMqTK968Mg/kg64gnRQsBO7e+ERzHIa?= =?us-ascii?Q?LU7HD4iPTJ4cU941khHENYlmGbYiJdnS4cCtCE5giTvkaIpzKU7lU/0gCAic?= =?us-ascii?Q?RBK7VXpJch4B0igUz8w+u7MvSGlNvRl1utIddbIf6HqKMRYzlJIyKGZYqvEl?= =?us-ascii?Q?5/uTB4aebjqxF23CS9rvLwFC77AHz0TM6VhusCDHgeCbhqoZ1iGBCI9k8P7Y?= =?us-ascii?Q?sgM7Rq5pmql78x550Tn2GiErulhXqO753PvPQksjBfww1+BrwamAn+zpKIjs?= =?us-ascii?Q?txA4UvlwL9bohQAZhdqP7/E8YNSD8AMg4s4sQDudk+VHyH63OoCEmRUgvQGq?= =?us-ascii?Q?VFjrtFHFAOG8Kymchw/ctxYaX1p9PlXRHec0wbUpF4wV8Rdj8LRrqtMZH6KH?= =?us-ascii?Q?70QGFpi+x5pftkUI+7lpPm/AOonNRtQVs+qmZoj7y+mrBOW/L9vj1X2H16Pi?= =?us-ascii?Q?ISq8QXSWVauZ+bP1KmXKwBZSrOHbm69xLmBUMhVOIP5UZZ01jcusxz5qccvR?= =?us-ascii?Q?Zws5yFS3RqRJXtWHcT0Yb6LboCWa91VL5jCDXh95hQfA4EWD2o++DgBgvxA3?= =?us-ascii?Q?P7tRPQVSqPRHWOdpZtLpAejbuROixWb1FLEjhDOlG3mpWXyhzBeWMBk8U8HS?= =?us-ascii?Q?62PQObek9gepV9D7RZrKc2HwyiNsgsDkc6+ovt26MWLH+lWjq3crwnDW4Egd?= =?us-ascii?Q?XBQy8JzLc+CuheybRJsBM0n9Hk8nl2uQumuq6o4wq8m+horCU1Q9oypRHjcw?= =?us-ascii?Q?GjrtRbMKbw2yFIZNMSFvaPUO+Cc0fJSzbhg4oeHC2rAfQnHvDRYME2ZPUy7U?= =?us-ascii?Q?MqOC+Wwh6pyXmj21reKICgymht5Szw1mU5uHt6E6Z//CzUl9NXiDW8Hzj1V2?= =?us-ascii?Q?CM89e88r8+W4PLAzdxEjRfOIs0qYmRHSO5X86sD5tjwFqDNMwNc/c2+hAgTZ?= =?us-ascii?Q?MFe2o41NwhMtlN58/iM2gFTMDIVwpbcWoZJTzuk6TiV+gP+ZvBflQlJcxfsE?= =?us-ascii?Q?D3xKcmtnmouxZwNeSwXAW6VtNAcrd3WK4nHRWAer0+O7aegNGsj+d2jwftZW?= =?us-ascii?Q?ifZdp/u6hYeJe2mzwuA1Tg3v4FK2Ug2RrkMlYhFb?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5055.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d3b6898-0fc5-459d-4246-08dc78b9a164 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2024 10:43:05.1510 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: T0Z1u2Zsd54MI+I2qxxFgphhX077Y4sb2KiXk3HnP8xajDoBTD80uk6qA4odiwClXdX40++xO4leDJIScsK07w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7607 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org [AMD Official Use Only - AMD Internal Distribution Only] Acked-by: Selwin Sebastian -----Original Message----- From: Ande, Venkat Kumar Sent: Tuesday, May 7, 2024 6:13 PM To: dev@dpdk.org Cc: Sebastian, Selwin ; Ande, Venkat Kumar Subject: [PATCH v2 20/25] net/axgbe: replace mii generic macro for c45 with= AXGBE The axgbe driver reuses MII_ADDR_C45 for its own purpose. The values derive= d with it are never passed to phylib or a linux MDIO bus driver. In order that MII_ADDR_C45 can be removed, add an AXGBE specific Signed-off-by: Venkat Kumar Ande --- drivers/net/axgbe/axgbe_common.h | 4 ++-- drivers/net/axgbe/axgbe_dev.c | 8 ++++---- drivers/net/axgbe/axgbe_phy.h | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/axgbe/axgbe_common.h b/drivers/net/axgbe/axgbe_com= mon.h index 51532fb34a..1a43192630 100644 --- a/drivers/net/axgbe/axgbe_common.h +++ b/drivers/net/axgbe/axgbe_common.h @@ -1732,14 +1732,14 @@ do { = \ */ #define XMDIO_READ(_pdata, _mmd, _reg) \ ((_pdata)->hw_if.read_mmd_regs((_pdata), 0, \ - MII_ADDR_C45 | ((_mmd) << 16) | ((_reg) & 0xffff))) + AXGBE_ADDR_C45 | ((_mmd) << 16) | ((_reg) & 0xffff))) #define XMDIO_READ_BITS(_pdata, _mmd, _reg, _mask) \ (XMDIO_READ((_pdata), _mmd, _reg) & _mask) #define XMDIO_WRITE(_pdata, _mmd, _reg, _val) \ ((_pdata)->hw_if.write_mmd_regs((_pdata), 0, \ - MII_ADDR_C45 | ((_mmd) << 16) | ((_reg) & 0xffff), (_val))) + AXGBE_ADDR_C45 | ((_mmd) << 16) | ((_reg) & 0xffff), (_val)= )) #define XMDIO_WRITE_BITS(_pdata, _mmd, _reg, _mask, _val) \ do { \ diff --git a/drivers/net/axgbe/axgbe_dev.c b/drivers/net/axgbe/axgbe_dev.c = index fa7324efa7..ebe64295aa 100644 --- a/drivers/net/axgbe/axgbe_dev.c +++ b/drivers/net/axgbe/axgbe_dev.c @@ -207,8 +207,8 @@ static int axgbe_read_mmd_regs_v2(struct axgbe_port *pd= ata, unsigned int mmd_address, index, offset; int mmd_data; - if (mmd_reg & MII_ADDR_C45) - mmd_address =3D mmd_reg & ~MII_ADDR_C45; + if (mmd_reg & AXGBE_ADDR_C45) + mmd_address =3D mmd_reg & ~AXGBE_ADDR_C45; else mmd_address =3D (pdata->mdio_mmd << 16) | (mmd_reg & 0xffff= ); @@ -241,8 +241,8 @@ static void axgbe_write_mmd_regs_v2(struct axgbe_port *= pdata, { unsigned int mmd_address, index, offset; - if (mmd_reg & MII_ADDR_C45) - mmd_address =3D mmd_reg & ~MII_ADDR_C45; + if (mmd_reg & AXGBE_ADDR_C45) + mmd_address =3D mmd_reg & ~AXGBE_ADDR_C45; else mmd_address =3D (pdata->mdio_mmd << 16) | (mmd_reg & 0xffff= ); diff --git a/drivers/net/axgbe/axgbe_phy.h b/drivers/net/axgbe/axgbe_phy.h = index 5b844e81cd..eee3afc370 100644 --- a/drivers/net/axgbe/axgbe_phy.h +++ b/drivers/net/axgbe/axgbe_phy.h @@ -16,7 +16,7 @@ /* Or MII_ADDR_C45 into regnum for read/write on mii_bus to enable the 21 = bit * IEEE 802.3ae clause 45 addressing mode used by 10GIGE phy chips. */ -#define MII_ADDR_C45 (1 << 30) +#define AXGBE_ADDR_C45 (1 << 30) /* Basic mode status register. */ #define BMSR_LSTATUS 0x0004 /* Link status */ -- 2.34.1