RE: [PATCH v2 19/25] net/axgbe: separate C22 and C45 transactions

["Sebastian, Selwin" <Selwin.Sebastian@amd.com>]

[AMD Official Use Only - AMD Internal Distribution Only]

Acked-by: Selwin Sebastian<selwin.sebastian@amd.com>

-----Original Message-----
From: Ande, Venkat Kumar <VenkatKumar.Ande@amd.com>
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin <Selwin.Sebastian@amd.com>; Ande, Venkat Kumar <VenkatKumar.Ande@amd.com>
Subject: [PATCH v2 19/25] net/axgbe: separate C22 and C45 transactions

The xgbe MDIO bus driver can perform both C22 and C45 transfers, when using its MDIO bus hardware. The SFP I2C mdio bus driver only supports C22. Create separate functions for each and register the C45 versions using the new API calls where appropriate.

Signed-off-by: Venkat Kumar Ande <venkatkumar.ande@amd.com>
---
 drivers/net/axgbe/axgbe_dev.c      | 77 +++++++++++++++++++++++++-----
 drivers/net/axgbe/axgbe_ethdev.h   |  7 ++-
 drivers/net/axgbe/axgbe_phy_impl.c |  4 +-
 3 files changed, 71 insertions(+), 17 deletions(-)

diff --git a/drivers/net/axgbe/axgbe_dev.c b/drivers/net/axgbe/axgbe_dev.c index 6b413160c2..fa7324efa7 100644
--- a/drivers/net/axgbe/axgbe_dev.c
+++ b/drivers/net/axgbe/axgbe_dev.c
@@ -63,11 +63,20 @@ static int mdio_complete(struct axgbe_port *pdata)
        return 0;
 }

-static unsigned int axgbe_create_mdio_sca(int port, int reg)
+static unsigned int axgbe_create_mdio_sca_c22(int port, int reg)
 {
-       unsigned int mdio_sca, da;
+       unsigned int mdio_sca;

-       da = (reg & MII_ADDR_C45) ? reg >> 16 : 0;
+       mdio_sca = 0;
+       AXGMAC_SET_BITS(mdio_sca, MAC_MDIOSCAR, RA, reg);
+       AXGMAC_SET_BITS(mdio_sca, MAC_MDIOSCAR, PA, port);
+
+       return mdio_sca;
+}
+
+static unsigned int axgbe_create_mdio_sca_c45(int port, unsigned int
+da, int reg) {
+       unsigned int mdio_sca;

        mdio_sca = 0;
        AXGMAC_SET_BITS(mdio_sca, MAC_MDIOSCAR, RA, reg); @@ -77,13 +86,12 @@ static unsigned int axgbe_create_mdio_sca(int port, int reg)
        return mdio_sca;
 }

-static int axgbe_write_ext_mii_regs(struct axgbe_port *pdata, int addr,
-                                   int reg, u16 val)
+static int axgbe_write_ext_mii_regs(struct axgbe_port *pdata,
+                                               unsigned int mdio_sca, u16 val)
 {
-       unsigned int mdio_sca, mdio_sccd;
+       unsigned int mdio_sccd;
        uint64_t timeout;

-       mdio_sca = axgbe_create_mdio_sca(addr, reg);
        AXGMAC_IOWRITE(pdata, MAC_MDIOSCAR, mdio_sca);

        mdio_sccd = 0;
@@ -103,13 +111,34 @@ static int axgbe_write_ext_mii_regs(struct axgbe_port *pdata, int addr,
        return -ETIMEDOUT;
 }

-static int axgbe_read_ext_mii_regs(struct axgbe_port *pdata, int addr,
-                                  int reg)
+
+static int axgbe_write_ext_mii_regs_c22(struct axgbe_port *pdata,
+                                                       int addr, int reg, u16 val)
+{
+       unsigned int mdio_sca;
+
+       mdio_sca = axgbe_create_mdio_sca_c22(addr, reg);
+
+       return axgbe_write_ext_mii_regs(pdata, mdio_sca, val); }
+
+static int axgbe_write_ext_mii_regs_c45(struct axgbe_port *pdata,
+                                       int addr, int devad, int reg, u16 val)
 {
-       unsigned int mdio_sca, mdio_sccd;
+       unsigned int mdio_sca;
+
+       mdio_sca = axgbe_create_mdio_sca_c45(addr, devad, reg);
+
+       return axgbe_write_ext_mii_regs(pdata, mdio_sca, val); }
+
+
+static int axgbe_read_ext_mii_regs(struct axgbe_port *pdata,
+                                                       unsigned int mdio_sca)
+{
+       unsigned int mdio_sccd;
        uint64_t timeout;

-       mdio_sca = axgbe_create_mdio_sca(addr, reg);
        AXGMAC_IOWRITE(pdata, MAC_MDIOSCAR, mdio_sca);

        mdio_sccd = 0;
@@ -132,6 +161,25 @@ static int axgbe_read_ext_mii_regs(struct axgbe_port *pdata, int addr,
        return AXGMAC_IOREAD_BITS(pdata, MAC_MDIOSCCDR, DATA);  }

+static int axgbe_read_ext_mii_regs_c22(struct axgbe_port *pdata, int
+addr, int reg) {
+       unsigned int mdio_sca;
+
+       mdio_sca = axgbe_create_mdio_sca_c22(addr, reg);
+
+       return axgbe_read_ext_mii_regs(pdata, mdio_sca); }
+
+static int axgbe_read_ext_mii_regs_c45(struct axgbe_port *pdata, int addr,
+                                                               int devad, int reg)
+{
+       unsigned int mdio_sca;
+
+       mdio_sca = axgbe_create_mdio_sca_c45(addr, devad, reg);
+
+       return axgbe_read_ext_mii_regs(pdata, mdio_sca); }
+
 static int axgbe_set_ext_mii_mode(struct axgbe_port *pdata, unsigned int port,
                                  enum axgbe_mdio_mode mode)
 {
@@ -1373,8 +1421,11 @@ void axgbe_init_function_ptrs_dev(struct axgbe_hw_if *hw_if)
        hw_if->set_speed = axgbe_set_speed;

        hw_if->set_ext_mii_mode = axgbe_set_ext_mii_mode;
-       hw_if->read_ext_mii_regs = axgbe_read_ext_mii_regs;
-       hw_if->write_ext_mii_regs = axgbe_write_ext_mii_regs;
+       hw_if->read_ext_mii_regs_c22 = axgbe_read_ext_mii_regs_c22;
+       hw_if->write_ext_mii_regs_c22 = axgbe_write_ext_mii_regs_c22;
+       hw_if->read_ext_mii_regs_c45 = axgbe_read_ext_mii_regs_c45;
+       hw_if->write_ext_mii_regs_c45 = axgbe_write_ext_mii_regs_c45;
+
        /* For FLOW ctrl */
        hw_if->config_tx_flow_control = axgbe_config_tx_flow_control;
        hw_if->config_rx_flow_control = axgbe_config_rx_flow_control; diff --git a/drivers/net/axgbe/axgbe_ethdev.h b/drivers/net/axgbe/axgbe_ethdev.h
index 4dcbf6d9a2..cb3df47a63 100644
--- a/drivers/net/axgbe/axgbe_ethdev.h
+++ b/drivers/net/axgbe/axgbe_ethdev.h
@@ -325,8 +325,11 @@ struct axgbe_hw_if {

        int (*set_ext_mii_mode)(struct axgbe_port *, unsigned int,
                                enum axgbe_mdio_mode);
-       int (*read_ext_mii_regs)(struct axgbe_port *, int, int);
-       int (*write_ext_mii_regs)(struct axgbe_port *, int, int, uint16_t);
+       int (*read_ext_mii_regs_c22)(struct axgbe_port *pdata, int addr, int reg);
+       int (*write_ext_mii_regs_c22)(struct axgbe_port *pdata, int addr, int reg, uint16_t val);
+       int (*read_ext_mii_regs_c45)(struct axgbe_port *pdata, int addr, int devad, int reg);
+       int (*write_ext_mii_regs_c45)(struct axgbe_port *pdata, int addr, int devad,
+                                                                       int reg, uint16_t val);

        /* For FLOW ctrl */
        int (*config_tx_flow_control)(struct axgbe_port *); diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c
index 9c2c411b4f..d173545e83 100644
--- a/drivers/net/axgbe/axgbe_phy_impl.c
+++ b/drivers/net/axgbe/axgbe_phy_impl.c
@@ -1148,8 +1148,8 @@ static int axgbe_phy_set_redrv_mode_mdio(struct axgbe_port *pdata,
        redrv_reg = AXGBE_PHY_REDRV_MODE_REG + (phy_data->redrv_lane * 0x1000);
        redrv_val = (u16)mode;

-       return pdata->hw_if.write_ext_mii_regs(pdata, phy_data->redrv_addr,
-                                              redrv_reg, redrv_val);
+       return pdata->hw_if.write_ext_mii_regs_c22(pdata,
+               phy_data->redrv_addr, redrv_reg, redrv_val);
 }

 static int axgbe_phy_set_redrv_mode_i2c(struct axgbe_port *pdata,
--
2.34.1