From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 131C744077; Mon, 20 May 2024 12:41:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 00D4D40649; Mon, 20 May 2024 12:41:19 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2066.outbound.protection.outlook.com [40.107.94.66]) by mails.dpdk.org (Postfix) with ESMTP id 69106400EF; Mon, 20 May 2024 12:41:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oG1eW4YfhPGSGv0BstWrHYE8+9WFPRqvcB1Up6o619xclZ6ktFOhc6b5xa7muAVilmcaDMLS8J1cKK2Zh54T5x1gW8Ng7ZxNbX/yluS8x4qeshQSFYfdfp8419puaYBPconQhzXvvZM8Qayi7ZGz47TROpsddjiYUOM0ZFL/wMxVx2EzWt9h6AdbqokpN/UaQ123/2TvZBYvBvo7WfvQzoJsK592ANS3YT8DZbWw+O3A+ka08UAIqsWFhvhOYIK1lh9E2U6puYvehyvjjKaQHujgVA4/n+AS/v4X1pRxQ55YFiayaLTVoJppT8WssxzKFVoWFwZlhJnMH/rk+vsoqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QDMYsPIw0I73e64FxtnG/RDNorYwkpj4LJQbLp0oCJw=; b=FdNuDsGIL+MmQQvXnUTIiu6kNB07GUlENcun0da4dQAy14QhPl8YunmOlu3Wb8zmvXR6iEv5E0Y81+k6ixvFl9n9dIslqatu0VyYE8Uy2CgKmitVcSZk6zmxThqOttfyTmRh1HOP/Ke5MaP9wj/I+pAzeLLPDizW19vNRhyeIl3y1O3oHMURkfK5qzk8M/PllbacZl/mFbTc7A4kvNCMxbmxjjqn/KwpnBblGbDdLbLCkpDTNppEjx8DV2BnLrgQHoMTfF3bdfSXXJ9gjryO3illxkeyEVX+AfMOsf1fLiSwjnLTigYV8/g6HhjMon+xJoNQPEtEFGSC6oqjrXMIPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QDMYsPIw0I73e64FxtnG/RDNorYwkpj4LJQbLp0oCJw=; b=tlUHA2h5OFsaoKiznkzU5jEsdQgucEx4eVfOo6kMaMtbz/YFI5uQr421H4Uy6p3E9I3nwYk1b9fDCEda+ff1AWfSc9VJeungoMDj0Lz1fOk4PV3edTtrRknffSMucnOvDZHhRAtIHACUlfWjKS024F1VIrzmsYg/hAQfEH1Mgm0= Received: from DM4PR12MB5055.namprd12.prod.outlook.com (2603:10b6:5:39a::20) by CY8PR12MB7123.namprd12.prod.outlook.com (2603:10b6:930:60::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.35; Mon, 20 May 2024 10:41:14 +0000 Received: from DM4PR12MB5055.namprd12.prod.outlook.com ([fe80::acbd:ea93:4496:51a5]) by DM4PR12MB5055.namprd12.prod.outlook.com ([fe80::acbd:ea93:4496:51a5%7]) with mapi id 15.20.7587.035; Mon, 20 May 2024 10:41:07 +0000 From: "Sebastian, Selwin" To: "Ande, Venkat Kumar" , "dev@dpdk.org" CC: "stable@dpdk.org" Subject: RE: [PATCH v2 03/25] net/axgbe: fix fluctuations for 1G BELFUSE SFP Thread-Topic: [PATCH v2 03/25] net/axgbe: fix fluctuations for 1G BELFUSE SFP Thread-Index: AQHaoHwuiv4uqsPGn0igKwF5oXeChrGgA3Tw Date: Mon, 20 May 2024 10:41:07 +0000 Message-ID: References: <20240412125013.10498-1-VenkatKumar.Ande@amd.com> <20240507124305.2318-1-venkatkumar.ande@amd.com> <20240507124305.2318-3-venkatkumar.ande@amd.com> In-Reply-To: <20240507124305.2318-3-venkatkumar.ande@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ActionId=1d6a9a49-eeeb-47e9-8176-c38104872626; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=0; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=true; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD Internal Distribution Only; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2024-05-20T10:41:03Z; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5055:EE_|CY8PR12MB7123:EE_ x-ms-office365-filtering-correlation-id: 688e51db-cf32-4590-08c1-08dc78b95b86 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|1800799015|366007|376005|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?uYKGUzAOOs2H88W6oB99G3r95MwmEBX9PbywsvN89P7Y1p1Vho1wnWTrkHGd?= =?us-ascii?Q?DNysy1bMvA6TQRe22j280nggKK322+EtY/Ypb4O99YLNv6tcCjqqkalkHmjc?= =?us-ascii?Q?QM7SdSkCdSY0AxjFQGAqD+7RueCwWlTWL/QZIR01wl0sVaakQZPuJc4Y2YJZ?= =?us-ascii?Q?AFXMbvIhtoTXDZ5Q/UF6oCGqUvMFVe1mcz+gClltozwWzttCqQUMYkKKgNiX?= =?us-ascii?Q?zoEZrT+qAk//mi7V8OHey1Z/ZXypa6hstw3X/uHd/XxU9Brl/8qzPw3P5Pgb?= =?us-ascii?Q?8FeypVWythmozOI+U/9Az1w+PkKpMNECvJ1jEOAn/bBkYBS6veDv1AvsFbTA?= =?us-ascii?Q?lPpqv3sDSfV+V+LZqJU8yJg8rUC7k/7IIGlGXO9m8OslhhbsVZAr/ENS7d69?= =?us-ascii?Q?DXRKRXP4fGbZFUys0ZL+r98P/wBy/bLytK6af65tnQySs001bGj/HQpHkbQU?= =?us-ascii?Q?VWWq5VvNuAc4a2Qh2uPFRDgNswyDVrgwp2YldY7j5e93jbxVGqjLwqZtgp8S?= =?us-ascii?Q?gVnXAge+62S41A7bmJ1UPJ5nhDhhwZM/Swaq2ATY3bAGHW9nx6oIU4a0l0gf?= =?us-ascii?Q?BFFJASqjx/t7MR2ev6c/B+3xQBxnHGhfNnUEkwop4uG23URZ81r4ExMQdwx4?= =?us-ascii?Q?ZCv6rk9mkOVtGoYW2i+WyM8I3VgaiiWHdsD7VYKDVaS99jEVgXpPhQA83aF0?= =?us-ascii?Q?3BESCmvWzUXcsk9kVLcsER49aYyHyqwHZzm03VNpL16QfGFc82O6W0C9GVh8?= =?us-ascii?Q?iqhXk7R9y9imB7eNgH+d9S07TewgxL43t1IYrdrnMOobWWSC31tfCSLpFnr4?= =?us-ascii?Q?/nnK0bU6JCog+zsZrxnJpie9AS0LOj1ON4wX48ek4+5CXas1B2/fda9+bdZq?= =?us-ascii?Q?NkHhGrLNq9V1HXdDBUA24t28EJiv6KsosFuzLzQU0LuDiNy80CdWlNSsKnOZ?= =?us-ascii?Q?vVZlByTXc2mOsafsj6NAyuy5mRhNVHHmXnrbsSJFnLX3CgjiF2mYEw96l+zz?= =?us-ascii?Q?9m6iiNm14ytFqYOnUqVIvCgTDY/2xlJsbwl2iVacaCAOCjhPpKtTibRmk1ne?= =?us-ascii?Q?INkin1yOoFuxecZPexv82AD0EWGS6sZzYUGakKsZ3o+v5sJp1LIWBMAY5za/?= =?us-ascii?Q?hPUmglL4m+jLtKCvmCXyiN8kI67zqaxIvMo+DD9wLO96kvq61F0PLaonqD3O?= =?us-ascii?Q?jI8AV4oMibzziZFBZftNev0ogOO7Tr2UWOzHwbo0+xZKmS4mItcC4g2q9J7v?= =?us-ascii?Q?xMcJjm3i3oVEO0+Gn9jc2D272nzeI9AG4FQOMAT2lJyOgDIhMcxLIY896XYN?= =?us-ascii?Q?5i3fRjtVfEw++/uGW/i01hVBDqN+ZoXnMdC7d7QB4kTqFA=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5055.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(366007)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FEujUtgDBUARodbFnwMyvix/IbNIFgwcpPecwHenolSAXt3WEekrmUeV5C3Q?= =?us-ascii?Q?20Cz3KA0mdzJER6m6qb4vbhIuWoxqms5er/j5GHkAKAbZ8QK8r0Cn80wqSxx?= =?us-ascii?Q?fCntlXUFu7SG82g73ZuczknGfptfwPnXCzUqLl3wkmOsNdfN6WXfmvWfrVTy?= =?us-ascii?Q?FAntliOn6lBVY4U72gbfJH/82K8m+SFMQ9E2Ey/32wIEKkO7s0E5Y4i1ZyGt?= =?us-ascii?Q?As65PsLoMgTkByjfbZBBcldCPepGWoAzQw5xPLa3vibErA+gaM30VjsbOew7?= =?us-ascii?Q?stjSoDdLwtWNxeu7UKbWfn+svS0IZ31bHDkyI1xJRtR6VMsma48Gdo1Wk4uB?= =?us-ascii?Q?3b/VOgLtIfKTSS0lpwBzpvRiJ7w3rIpjMeN6zBWsfqrt/S6VShvhjIY6SEfI?= =?us-ascii?Q?DUWGwlUMcwKi91AxmB2ZgvWbJAsfeL5ELfdtV14p3jjDW0nBrurUS9EudSVP?= =?us-ascii?Q?niOlRH7/vX5YWmbIsVaZGAoemz3+aRcxXiOaN2Iqo4G8NHVRISrGRg6mG4b9?= =?us-ascii?Q?XTd461irzKYMKkD0DEEiv0yBkxdULZQsPPUKA/MiuNP70tV8UKnxgPj+hkwx?= =?us-ascii?Q?jUw2tGmR3a/1/Kn+EXZvEdRj2rTTucGIlmTbiYbDVQQr7DkWE0yyiAnC25FL?= =?us-ascii?Q?s4fGJg4tB3+nvtDy4e/kf1XKp/o9AV9Y9w1RzGExLOxHsGgtlPBtN4U08Whd?= =?us-ascii?Q?ZDcHJNKN33SoNKKtkKYmvjy8LQCWk5OCsG3YjmOF/dkC1N1Ke9qffjMnLB5Q?= =?us-ascii?Q?7OFSO04sSBrPAodEpTzUYpmpgNeL+bvYvKyP5GibHZOF0CRZyVc0ZcXpMM1e?= =?us-ascii?Q?VsJ+yIJpizPyGE/wzewwhornbezgeSsyal7IWlxMiYggSsCeROFbcMmsuKM3?= =?us-ascii?Q?ratd91+yuzNP5/HcK+RN03MCiBcX1YGO12jG/1VtbFPs9KiVxK58Um/PDXxk?= =?us-ascii?Q?3HFiaQZgW+VeMOvC7iGcWvydZ3a44GHgy76G9niDptfdRYK5CgribUdceCQj?= =?us-ascii?Q?Hai0ZLpQU+FLwGA9yZgyKD4xkSFpoZgADPOlf8W7bo71oPhZPAmwTc4M1POf?= =?us-ascii?Q?jdkfMvRKwsqihqB6IRYHXzOrvszUbPDO0PEhwLh2Ev+IDQWLG5WNZmrrEiAK?= =?us-ascii?Q?DgbrCaixCbKCq6xycWNuJnN+HUDz4idz2/BZRDAkbXhnXrzF9qH6e8KQkHCo?= =?us-ascii?Q?xc186CPtOrZDcluLpxnCnBv3j+fucnU4m1KT3Ba7iHpUdafO23hIF2ZLb9c9?= =?us-ascii?Q?4zo1+dJdmpMy2zlQh5Dqo6FbefqqTOj8l7VSBKl9ckuvEOevbOmvPAdKmwkm?= =?us-ascii?Q?ADgIhQRHGz8I3Dd/BZG0YbJ5qUOi00UdyyWO86W318alo1FSCaE2JwI/TYa4?= =?us-ascii?Q?gvk3XfDXiinmwx47xnSYr3++OrschnN/DXat5QuTqALDrWbKCkUMI2KBMmBX?= =?us-ascii?Q?1wx1od/R446MbDjE1I71bGdMK1UjoSMNKO6XSsyhrs1XeYAoC376UvbW3Pje?= =?us-ascii?Q?TgFBHZ2TjQE1VKdqRtCu6PntxSibi4j8n0L0r/SR9JjHys0ZJhaF2fVwuEzF?= =?us-ascii?Q?f7UrgxCuaxbo1nvx7OU=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5055.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 688e51db-cf32-4590-08c1-08dc78b95b86 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2024 10:41:07.9031 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rYZqd7UgXdKlfLqm4B2nfgjAFJySpMhajMU5ViOGDGm1gAScpWXKWh40FrHvzr9xfwGlIAeZL+TXyycI5+JQlA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7123 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org [AMD Official Use Only - AMD Internal Distribution Only] Acked-by: Selwin Sebastian -----Original Message----- From: Ande, Venkat Kumar Sent: Tuesday, May 7, 2024 6:13 PM To: dev@dpdk.org Cc: Sebastian, Selwin ; Ande, Venkat Kumar ; stable@dpdk.org Subject: [PATCH v2 03/25] net/axgbe: fix fluctuations for 1G BELFUSE SFP Frequent link up/down events can happen when a Bel Fuse SFP part is connect= ed to the amd-xgbe device. Try to avoid the frequent link issues by resetti= ng the PHY as documented in Bel Fuse SFP datasheets. Without the fix user will see continuous port link up and down. Fixes: a5c7273771e8 ("net/axgbe: add phy programming APIs") Cc: stable@dpdk.org Signed-off-by: Venkat Kumar Ande --- drivers/net/axgbe/axgbe_phy_impl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_p= hy_impl.c index 54fe9faae0..ee9dcbe3da 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -578,6 +578,9 @@ static bool axgbe_phy_belfuse_parse_quirks(struct axgbe= _port *pdata) AXGBE_BEL_FUSE_VENDOR, strlen(AXGBE_BEL_FUSE_VENDOR))) return false; + /* Reset PHY - wait for self-clearing reset bit to clear */ + pdata->phy_if.phy_impl.reset(pdata); + if (!memcmp(&sfp_eeprom->base[AXGBE_SFP_BASE_VENDOR_PN], AXGBE_BEL_FUSE_PARTNO, strlen(AXGBE_BEL_FUSE_PARTNO))) = { phy_data->sfp_base =3D AXGBE_SFP_BASE_1000_SX; -- 2.34.1