From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 089AD44077; Mon, 20 May 2024 12:43:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 077A440A73; Mon, 20 May 2024 12:42:47 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2056.outbound.protection.outlook.com [40.107.94.56]) by mails.dpdk.org (Postfix) with ESMTP id 2DE8C40A7F for ; Mon, 20 May 2024 12:42:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=acOHFqLiL30cCpnSnlKrZpWa7qvANTd8I1a77KxNqsWruNJ5q1JeJTf8iOM8+AtCHdQFUJVbNSQC5puu8p03tmb+nPXufRX/f72739+5pd8T7DdQHaJBn6owSMNgPvwpodbzMoHJKCnErpMQkSkq5byRmg1amedfs3aI7x4AOgWFrDz8dnNHi1W1Qnb+ZVVqnyueZSsh+jO8S0dvz8/37EW9nDKMsXGIgwjEEbDKFwwt+AZjUUS7FhDN7PO539/OGe8hBA8Rbw435VZG4+Bz+p9ltSSeiyCNk3MVnNcrAxJV2WZdW98V2O5dGODOJDOs7mNd7TsZNRIVK8gi0TT7Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p2gDaiJ5NI5OsR/tiqjl5dYtEFu44ndLAFQDYtzca8U=; b=ikNSJgp6FtC51udZHCXTM1XJ4ky8l5aU+XcNkczRXUosC//RzZu3tJYhgTrJuHsFKXuoFbg+B718sPI+E7QZ78/jQZanbSyT9H3ZRWMKCr8/gYCoHYQrWd5aZPmN/yCzczHiAQJwHYviBUwivtvsnFbg74VNEs/Q8j3OHTcmAPg5/LLOBQeSNM2Tje92nhbFyatoxKDl0UO6dixBVDuPguO6N794XBA8bz+F+9rnb/6SajCrg5wV0lkcex8q4TBhkv7d0si71fMuKeGfRDZcvK4O1kvhL5oG9Kkb/ZkCuqnT/pwp6DzMQStC7pO1mPkCpLACB7rH2NIUKcYEsmrzqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p2gDaiJ5NI5OsR/tiqjl5dYtEFu44ndLAFQDYtzca8U=; b=gieLunm1NOtLwt6/i5OqRTgth+lBrLibyMbjlGLYEoJjQFQv4bdIBCBtw5/ehQOlVPWEalBP/HdcJO8Ujl7VF7cA7hIovF3iZSNOCphjDFtJyiO6xGOZP1Q3dvJD8nmw8eLVwzWEZ/0+WmpC1N2tyCMU5mqTS0WD+V0Z/Qcn10A= Received: from DM4PR12MB5055.namprd12.prod.outlook.com (2603:10b6:5:39a::20) by CY8PR12MB7123.namprd12.prod.outlook.com (2603:10b6:930:60::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.35; Mon, 20 May 2024 10:42:43 +0000 Received: from DM4PR12MB5055.namprd12.prod.outlook.com ([fe80::acbd:ea93:4496:51a5]) by DM4PR12MB5055.namprd12.prod.outlook.com ([fe80::acbd:ea93:4496:51a5%7]) with mapi id 15.20.7587.035; Mon, 20 May 2024 10:42:43 +0000 From: "Sebastian, Selwin" To: "Ande, Venkat Kumar" , "dev@dpdk.org" Subject: RE: [PATCH v2 16/25] net/axgbe: remove unnecessary conversion to bool Thread-Topic: [PATCH v2 16/25] net/axgbe: remove unnecessary conversion to bool Thread-Index: AQHaoHxFZmxPV5L7wUih9bT139XTEbGgA+aQ Date: Mon, 20 May 2024 10:42:43 +0000 Message-ID: References: <20240412125013.10498-1-VenkatKumar.Ande@amd.com> <20240507124305.2318-1-venkatkumar.ande@amd.com> <20240507124305.2318-16-venkatkumar.ande@amd.com> In-Reply-To: <20240507124305.2318-16-venkatkumar.ande@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ActionId=a6877b6d-9d1f-439f-8800-bf941b2a4c30; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=0; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=true; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD Internal Distribution Only; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2024-05-20T10:42:39Z; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5055:EE_|CY8PR12MB7123:EE_ x-ms-office365-filtering-correlation-id: 81b9dc4a-1837-4ed0-5c30-08dc78b9943b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|1800799015|366007|376005|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?Q9sQ6rvi2RiZxa+GqwiERuRVUMXWJcJjEXvi6nZM49ygL59ri/TP+TCpjH44?= =?us-ascii?Q?au8oyBvfAhTtFxJaoiFUA8t9Ww9FbPcnXTCs1aP4UzMWzvQtV9Uz7a30GaNl?= =?us-ascii?Q?WWoHQLn+c4hmzct8MxhSd8hCdFLrExisz+uSE5TqmKWDU9H67He7x1ti7vxy?= =?us-ascii?Q?hkVyRxAmnEC2q37v9Ur9/ZL45iePqeFFlaLrztfHAyFZfFYBosBrD6F0yJEe?= =?us-ascii?Q?MphPcNTceqClB/2Zrds3KDU44PWaM6gOpSR6++dw2uNf8oNvXExiAYCdxJ8y?= =?us-ascii?Q?/4EgpDQpOZr5oGeiaFYxRv4vdV3Dw+q/M9lug83SvJ9dL6kLIQgbNbPvMI9g?= =?us-ascii?Q?SN9F3wmW/Dbi6wlg2ygElEvonzyH94+pDBVgYt1G0GKjWEpsqgmUkxo83Bai?= =?us-ascii?Q?zud8TriUAbwcHnTehjqGwiuf2ywYEYbFfvkzxow2v15i8XUNwn1wSDTSs5L0?= =?us-ascii?Q?nparGstuFjSzMtEuyPNU1oEGUhiJToc9WbJ4BKxNhEtzgdvq3DCkf4G0Td20?= =?us-ascii?Q?PqZXUHWAwAnBqbFBkoJLE4VkxhCNfwt4EZP4fCDVnCWvRM7lfYRpzNPjABFy?= =?us-ascii?Q?6FXEPczr5YBzaP4tWyPASTUDShGuFSHbJ3yimFpVzBnx5f3pHjJoG+k8zZBj?= =?us-ascii?Q?Bn0VfGobk77QFUGXQYEAV1u/XBcz3iHGTf2ElK46cPAeIIWLwMN0PP8j9mVc?= =?us-ascii?Q?JEO9DT+D25FDKu4zhc5eAJ2Y78PrxlzKDM5ZY106qjxY1D6uJgsNtwXnByib?= =?us-ascii?Q?6BmVFKhCvalLupWk5I8AjF9opOR+Dyd0DStl0Emt0AQMZMgR4LxrJy7+nMrZ?= =?us-ascii?Q?bjbiKeFhzN7uXmBzmJJpfLoCw5uQMMjNOvMWbVQ0t7NG7m8i8tgHUxpyWiJM?= =?us-ascii?Q?N/5nuGYrn5aMJYDPxbXfWPBvZQSZseJWxgd8DyEQhP0Jwp1oDNDeHqtQt8Nq?= =?us-ascii?Q?jgetAX0cLJqYuKK3y4vS7fJxya783Syhxb1sUhc0Qt0PSNphRT9lyfqTej0K?= =?us-ascii?Q?xCm2DTF1WSdVRVIS3Pz0kUee0y6CltmkkGeSiE8wfVeQeROKbzISR1g7Qs9N?= =?us-ascii?Q?4inOZD/JQZsIlO2s3IaNj4b94Mkp+oAOiTBn6FY2PM7HMKXqewWjamj4ghXF?= =?us-ascii?Q?nayQSgQo1yhZAXvauoFvN12OWgPuh80ZYK34j8B5JbPZ/49THJ0ngu7XwECR?= =?us-ascii?Q?X2fnvTv007AV2kewexbUanbYjWzREmtvfGw+FfSFESZ53QLznxRFiZNEon/b?= =?us-ascii?Q?BEkdm1IomAgLyshixt3mrguw7IOzlUttFjjlSJe/WoqX5Cogkn8d3VR5DL1y?= =?us-ascii?Q?CylhDDSBtg4/dgwgmrewq29KGc8MiKJwW10i+XK7yaAfQw=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5055.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(366007)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/7iUJw6pmNZMa3AjDWo9KkX3HlxBceKyiFGL5N5l7bq8KzMGfXYethO5xyYD?= =?us-ascii?Q?xhGHH9ItAkpXrLDs1KnqOGTOacl2w2IaBirFdBkvmcGZ6zaFCs7IouoxuM5/?= =?us-ascii?Q?AEbp5uLDHIKMVfs6RXWJ//SQdChx2S5nwN9XximTjlXf8LWFfYycxNVTVlKb?= =?us-ascii?Q?PyXUwdiBpJ5rkUzP+hrXdz4y1DEJN4g6uzxFNUdhtFrO4PtBW3xZQiDE9xvn?= =?us-ascii?Q?IsF29zL1L8GRz5s+NY4y71vRZg8ZCdbMP6d2OwtOwdRvsAVxk2IzEGmwli9v?= =?us-ascii?Q?C97mtdUMRCUR8gyvvku1Aqv7dALhQb+2o3KZIPtY+J/wvcrNW5UEpWr90io9?= =?us-ascii?Q?jOzrD1N6ZQaN0N7ixg1dTH78MzL0waHlsp6Bn62KDvkfAQHLOvINvbUEKf9X?= =?us-ascii?Q?A22cbrs9TpmHOP5fyfmWxf4VhHfhIPrzbL+cUBt29UuZ+pdgmB4eGYMd0tSz?= =?us-ascii?Q?Wd1dTLZTfEjP6Ix1mwQL+spgu49IeulN4iG6xEDrmrfTDc7bsEd4fxQGie4/?= =?us-ascii?Q?dNcmr9k9Y/KMOuQzavCzXz9vA0+wh1XJ6o2AY3EZcDaGSJuCeNNTRq3VV79Y?= =?us-ascii?Q?qdAFTt8PFwCU4DpJW3TpIR93GAYJ9+XRKQlopNsDtHQDYHlh4noe3ajBrpyy?= =?us-ascii?Q?8tBzpO/QBKi8jnoPz9lXF1butjAFQght5wPaUxUiVy+ugXzOnKfmZ0P/qFn4?= =?us-ascii?Q?tWpRxOhvW+/t7L3nw5Gnw6QNxh2tDilV0+ndtJLkxBLf0nJXNScIAwOgQDZg?= =?us-ascii?Q?+QVGRk3LzPVBZBzwjySWbesjJ+gH86h+bE1BsiBpeqZ1Qdkypn3Mg4GjRw0E?= =?us-ascii?Q?9M5nd1pb+fxFQsPybI32ghRwDaYATABgbkoUSn3uK0sabIUKWj6+dj7eLmX3?= =?us-ascii?Q?yKYA0USP3g8/B8HbuLtRtJjcTktjKnkG3LyiKezdxle0z8fAcB37RIyGBKiE?= =?us-ascii?Q?WQSf+umGPy647u4EJcg7DWwktbzZ1YO2TY60yHJtbuttdFjzBYwqj6ZmtZH6?= =?us-ascii?Q?K5YxNcNe4EThgpUQTsXVlL/XLHpmJ7R7UZDpowB42RiK5jkn66vJCHAmunIw?= =?us-ascii?Q?SQf3KmnYpwVp2GbZH3pt32yPcSvKinT3Axdbdww/f2UOmm4K5aG83tY9iTdq?= =?us-ascii?Q?4fELgsX5YG+RfTJ4yI5WqjHOiPV061iFVMo4g5qufSkgD5PL8uokXAXKjlp/?= =?us-ascii?Q?6gEofPa6QW4102l5Gott+DFX11DZ6bakjAbVnrsWehHSt9vueTBh+JNsEV4r?= =?us-ascii?Q?xsGVVWOgd7U+5q59M/HMdrWmVzEECGVnAPK/9d2wJ9lxABLbbZ1J5cyncS6s?= =?us-ascii?Q?iVWeYMCoLGhQoaYc8E1CQ9JcKCgCS9vs/rCiDsLNcrby9ZixSZyzpl2IFP7n?= =?us-ascii?Q?XgnMLiknFhn4KpRrwRm5mpd4xIa5/K8QRI0PNPV6zhkMCfEvD0K1N2qz4qTf?= =?us-ascii?Q?1BiASHwNlB6KXP6EBtjv4EcWAo4kU7a9Zkwr8yzNUifmyNBDp8XN3vaY2YDA?= =?us-ascii?Q?eIsfLJB9FR+RFxj6IX6RFyaqkwIdPFOA+jahpiY+VSU27Jc10PjWiQF2+2Ao?= =?us-ascii?Q?0bCxr48XTivV7YQ5zZSqpX8oqBXW8Og4BGHWdOUD?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5055.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81b9dc4a-1837-4ed0-5c30-08dc78b9943b X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2024 10:42:43.0704 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KdeEku/5zqkoDg1mZIzy0Te68rKKdMsmzmZi/30043YeZ8xMJdtbqoS9aNHIspxinizM+JYWKQf1Yd8B+X2HGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7123 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org [AMD Official Use Only - AMD Internal Distribution Only] Acked-by: Selwin Sebastian -----Original Message----- From: Ande, Venkat Kumar Sent: Tuesday, May 7, 2024 6:13 PM To: dev@dpdk.org Cc: Sebastian, Selwin ; Ande, Venkat Kumar Subject: [PATCH v2 16/25] net/axgbe: remove unnecessary conversion to bool The conversion to bool is not needed, remove it. Signed-off-by: Venkat Kumar Ande --- drivers/net/axgbe/axgbe_phy_impl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_p= hy_impl.c index 87ef8b6048..2620d44dfb 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -658,7 +658,7 @@ static bool axgbe_phy_sfp_verify_eeprom(uint8_t cc_in, = uint8_t *buf, for (cc =3D 0; len; buf++, len--) cc +=3D *buf; - return (cc =3D=3D cc_in) ? true : false; + return cc =3D=3D cc_in; } static int axgbe_phy_sfp_read_eeprom(struct axgbe_port *pdata) -- 2.34.1