From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85C6844077; Mon, 20 May 2024 12:42:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0313840695; Mon, 20 May 2024 12:42:34 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2085.outbound.protection.outlook.com [40.107.94.85]) by mails.dpdk.org (Postfix) with ESMTP id 5796740698 for ; Mon, 20 May 2024 12:42:32 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CvtM8oEBVCtzQB5cfGJuQpHyebph4TYctBYGxFSca0JxsaiWej3k+S+UTBzj7rmqThIEzmCLwKdJoaLvqvSQWA+cwmP0adncFWkdAk7v062UMyA0ki1Hgu/eHw8OEazHHj4ZmWBwem0mk0yIKSndK6naLly3YQx9gjy/7V2kXOLS2LbRR5iv/zwIDhHj32vgHGE3m/zDq/cFFknEGeXT0Vdg0Sms9Bzy20a3c6RkGIsIWx8Zl4D1HNFtK7GuuF0QlC+I6SnRCOXmQFc3+uFk9q6LKSly1iE8lbR3F7mhGTwADn63NVZpxtFYUcN45HUAxVzeEneJTwOa0KTeAwoBDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LWDQ0v4cmKqSJYEqM54jrsfVdG5ySWhjJ/u9fxppbBE=; b=Cu7HrFGkkdnngGG9ZNxR51mYoiyJuaLpsRshc8LOozMpYJuptPEQegtF+3QTdc6BAZi1/EKbeZyhBwUgmRUkhGkHTQryBk9iIBAnvkjtAL1KDhZui4V7qVqQDYLWM7XalVwlco1uz89To4wghFJYk0ZKA/DulTob3aJQfAunwHQPwXBw8JuwSGKNcYihnNqJCYFXk6NW8VISWdrBkxvIHgKWT3Qealfhod/EYOqX4KWoNJCtJiCz+pCEuHj4sKGb8I4DMADe1KvxBk8TJKRaljphpt0JnW/Tx/esxn/hIIR57edDAAsRfULm8q9fGX3ZUU3PDQ0NSbVm/a0sM0y63g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LWDQ0v4cmKqSJYEqM54jrsfVdG5ySWhjJ/u9fxppbBE=; b=e0Pimr5OWXWtM7EMoiSaCjeIOlPK98axUN0K9wsFKS0xUEFLlpaLUwcQhUfDtQzEqepeWDAQse08mzmQZP2QKyh5K+pmYxNTA6qaCefWA8q8bLRV7KxuJYAlFpZDzT8jQ/QmKD8uNbfPk0GIuQQNTCts66Mt63uNSnsOEwtTyMs= Received: from DM4PR12MB5055.namprd12.prod.outlook.com (2603:10b6:5:39a::20) by CY8PR12MB7123.namprd12.prod.outlook.com (2603:10b6:930:60::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.35; Mon, 20 May 2024 10:42:30 +0000 Received: from DM4PR12MB5055.namprd12.prod.outlook.com ([fe80::acbd:ea93:4496:51a5]) by DM4PR12MB5055.namprd12.prod.outlook.com ([fe80::acbd:ea93:4496:51a5%7]) with mapi id 15.20.7587.035; Mon, 20 May 2024 10:42:30 +0000 From: "Sebastian, Selwin" To: "Ande, Venkat Kumar" , "dev@dpdk.org" Subject: RE: [PATCH v2 14/25] net/axgbe: remove field of SFP diagnostic support Thread-Topic: [PATCH v2 14/25] net/axgbe: remove field of SFP diagnostic support Thread-Index: AQHaoHxD+7Xgb+Wm6EevN+y32TwrGbGgA9ew Date: Mon, 20 May 2024 10:42:30 +0000 Message-ID: References: <20240412125013.10498-1-VenkatKumar.Ande@amd.com> <20240507124305.2318-1-venkatkumar.ande@amd.com> <20240507124305.2318-14-venkatkumar.ande@amd.com> In-Reply-To: <20240507124305.2318-14-venkatkumar.ande@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ActionId=08ef5380-a644-4bfa-9ae2-7ea271d12890; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=0; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=true; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD Internal Distribution Only; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2024-05-20T10:42:26Z; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5055:EE_|CY8PR12MB7123:EE_ x-ms-office365-filtering-correlation-id: fec225b3-5754-47d2-a467-08dc78b98c87 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|1800799015|366007|376005|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?tWUriWwKUv++5Edotv05BLgRS42ETJTo/ZRG7fqJ8GgrLNnGwbuYshpxk6zH?= =?us-ascii?Q?bgaPpys2YxjsvEX4UuhgLYjq0xGsxvxnGJ5tdxu4oD7ZeRhtA8jg3cyNUx7d?= =?us-ascii?Q?f+eH5+3CUXJLE4uxP3B91B20Vlp8g6BRVAwg0OAo8IVV+ZmGv723W7scS8Cw?= =?us-ascii?Q?4sMwIZUEYhPMkTMMJPDTTanJrE0OI63Bj5l+0vYk4YcJX7oXSVxrED5ySw5y?= =?us-ascii?Q?A5YYzw3giSs3uDWob2b/c9/43xbJyc2GM1N5rMQmao0zv8ozSgYxLlcOqoMj?= =?us-ascii?Q?6zNjShrnnh881fW8+uo9iHnrgaqQk9J0R2dRvJTGEGfHYV7Q4Hj3z/sryEQy?= =?us-ascii?Q?aqvN/pC867eGFSgVogQPC2Akn+GdZVCrb/0lVlxiYCY/Hp7UoSTN+G6aLknC?= =?us-ascii?Q?LCtYgI2lB+Q++xsynvSt7nErtIwwGXsmD0CUO1hNlkEvZHl53cHHo6UmjNgj?= =?us-ascii?Q?2YEtEa8J4YEccR28t3Bc3xNbLEapQzYTfQIKUhl5iPTEJVOdN3C4pqfb3HA0?= =?us-ascii?Q?+vsgY7EbXJR9l9gqivL3cJtL+kuwxAytsh2Vg1AeDscjAOKNCRHrQTzCYB5m?= =?us-ascii?Q?Ms56al53WBGMh4jetzRSRE13l6cPjE4h1JNXx7Xp3M6s911KvPmnYxGVxGLp?= =?us-ascii?Q?7p2v2JW4TCB3MOO2kPCWg1Gn4/EXr1+tffIpsJi0c2Zrc9I2n3EivG+T2h3N?= =?us-ascii?Q?yQiuC+Hv0jY6Gw+nT5RQ3mGjNfHrIVWArTsPES5ZjLTBX3VDmjmFmeTXZV9F?= =?us-ascii?Q?cph11XWz27gmvdwjXLJWzCuNK5RtTx922Ly8uEOyhcCn1sR/5fmLS5w6T/rk?= =?us-ascii?Q?8XTssJ2h840pKVjA0Ji57kTVsU/3P0kqIGT27MXi+bg/yqfZC3wv5RDMGmjy?= =?us-ascii?Q?xFifyihnLupsVYnzuL0KchWptQj3vjyz1PmXlrfsGNGAqLpVSevdLV34QvmU?= =?us-ascii?Q?86ddwYPhT0eJbAGOZoNb47p0OiA5kJSZe43qoMOPEqhRkCQtP3NIexPb96BE?= =?us-ascii?Q?W9VzXMOV5ip4TxItFsQS+r8hI2qaScjAHBlmqoZyHlWpvobdqGtlAWr8WJDZ?= =?us-ascii?Q?YdPaDUQVY8Yl7y2c4ocYyaGkSzHFrxA9vjtv06DNS1pLSPU9uocJcmntbOIB?= =?us-ascii?Q?JdSVI8m3Ar2idmTHVSPrBCn5Ybt9mN1tMLABC0fWHQUV7bkFYRkuBqsQ6Snw?= =?us-ascii?Q?7596fp5UYRqH+nG+k0DnICS6I/P4+dzrgl+WRyvpGk4xi+O/FR0MLjZvYVYU?= =?us-ascii?Q?moCI/DjTmy61hXPRQBopSdguIo0xWKO9GMuQl/WJmeAmbwP1GogA/zEGnEmH?= =?us-ascii?Q?Mcde6JWNOsMIhDaqniDYgXmKb2OoZCPt15A0NAHWI/ATbA=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5055.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(366007)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UzA0OBNTbW0+WCV9yX34qbHtY9/cPCY0fBcB11KdWuacvXjcIwCxuDgAYu2J?= =?us-ascii?Q?g7doQCDH+e6GOw5ixNwzZTNJvzc12udhk8HP1Tnl42TAnyBFDJqPIruj3/eG?= =?us-ascii?Q?szuaN+QyE/gZHjzFyfSWafnArErPhXfIvwnY5ava+MPpCP2atYZcG8gznjdj?= =?us-ascii?Q?D529N/RMYO2hVbaml702t5ugcv1K1TirZGim3tP8qsKZ5QSNIUyJhRDLUSyp?= =?us-ascii?Q?BFo5GuN9hPofMvXC4UDh5/NIGtwDebLw+3jX3Yrg6jDwcvsM0TMOPIVHwrg+?= =?us-ascii?Q?SxC5GU/UfOxfWtkof3FMApOZ3YldIpPuosr1BLLIKpK/CJzg+8RF1kj2l2PB?= =?us-ascii?Q?P+3s7itANHkHEIXTQSVlSqb8Z3OztSKkKho6TOAMS94k3atCdUcFsAFvDAWj?= =?us-ascii?Q?AtT8LljqpW1dB8hP/Zi+XT6Rptc1LxVgMF3iv/ACCsrRSPrmu9R+3yVje4KX?= =?us-ascii?Q?ZjQxt8fY0JsLGlXE2rYHQn4551WXIO1Pd891q2gHHKIXSlItSZC2i9v0PVia?= =?us-ascii?Q?aDP1W/an3OqhKB9WP+XJ+VeqZd44gWp2Hq5QwJRDkTR+7cDke87FOZ48NoPB?= =?us-ascii?Q?cctLMQsftTntYaMj2oWmifUy4EvHPWl0LG3rIlaW0/onHcyzuks76Z/8sXRf?= =?us-ascii?Q?NUp38jtk3+flsl1UsRd0bNmqHmhzf/BdXhp3XXm/S/dBx7B2PH9qlhpqaSg/?= =?us-ascii?Q?8I+0fi/QZPc/Gb1EAZJ9/ip9YODMrT9hGa1A9TnnY5utGrEs764vsYb1Zz+9?= =?us-ascii?Q?flaZsPsnxxLQU9rVTutCx3xKaxPIlbOIE821M/m180jGK5Feh8jPWqaEq0Em?= =?us-ascii?Q?vduoWFq8Vml36hrsAoCtY8jdpdwml2Gy5yQAFk6+x8O+GsqsBK9u1KXBXC/o?= =?us-ascii?Q?Q5p8X22JsVQ4xkbMSjAob0rSS7Pn4CGNHQIwJQNhPGpSEhetMNmh264ewtTr?= =?us-ascii?Q?zEsVKxEjIkVU5eOGD8SBF7+nI5rb4kCxXCjB9r6ihXYWEv9+b70LEHEJP9jE?= =?us-ascii?Q?4lFhpocPjHHRNcGK1iIRaJmYFQjRt4TnMu0987mY17gSDJdLp0xmeeeyuUi7?= =?us-ascii?Q?Vpsghos2teJ2FfNz12Olo8a1dZHzAfJZF/DQIug4biI8LGkiJWnBCVkq0qZ7?= =?us-ascii?Q?nnUNQtxmx66YXEWfWQKE16Ivr/o0W6mmfiFQg5IBUDCDzboN/VdoptRAoUvx?= =?us-ascii?Q?C39Uz9YglP3kjkDDb5rX93s8DKDPM/lsfrERrKe2+D9t15/UEk8sKaGJDTXR?= =?us-ascii?Q?62SXlBPysWJlStBwUvgK39UTwX2vEHCt4NL0/VbRTpgChYY64fkac0Li0LEv?= =?us-ascii?Q?l2ER/qxyOHWT8xfFIjTgqvo2G+EZSG4OdgAtVbXAca/fISt98pC76z3XlNKI?= =?us-ascii?Q?QBh7EXIQxzHAbvWIHf1WxPZNqFru6mImQr9cbnopZQ+UbTxBEJQhhnc4qdJu?= =?us-ascii?Q?2wJceXF5Yo0QnFW8TOBveJb5tr2mfNwMbna7uphhWZ2r4tiazF+eYattF7aQ?= =?us-ascii?Q?DZqPgpPt61pt6Gbj2dauKt5M4yGFTHCpuFngJkTKKgZOyh0LHia/I9T0Vrkj?= =?us-ascii?Q?Ezz154c4BgQPP0Oa7eZgJqiktIPw662TXL7BQBcN?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5055.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fec225b3-5754-47d2-a467-08dc78b98c87 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2024 10:42:30.1307 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WPNgDH6OQjQzn544l7QzKqcoO726G5uPWYHTTxMpiixklO0WrojoFXdO/3ApusSt2t8Uc9jo3ivwzyVZfwgoIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7123 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org [AMD Official Use Only - AMD Internal Distribution Only] Acked-by: Selwin Sebastian -----Original Message----- From: Ande, Venkat Kumar Sent: Tuesday, May 7, 2024 6:13 PM To: dev@dpdk.org Cc: Sebastian, Selwin ; Ande, Venkat Kumar Subject: [PATCH v2 14/25] net/axgbe: remove field of SFP diagnostic support The driver currently sets an indication of whether the SFP supports, and th= at the driver can obtain, diagnostics data. This isn't currently used by t= he driver. Remove this field and the logic supporting it. Signed-off-by: Venkat Kumar Ande --- drivers/net/axgbe/axgbe_phy_impl.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_p= hy_impl.c index d2a2b124be..4dab2ccad0 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -219,7 +219,6 @@ struct axgbe_phy_data { unsigned int sfp_rx_los; unsigned int sfp_tx_fault; unsigned int sfp_mod_absent; - unsigned int sfp_diags; unsigned int sfp_changed; unsigned int sfp_phy_avail; unsigned int sfp_cable_len; @@ -702,14 +701,6 @@ static int axgbe_phy_sfp_read_eeprom(struct axgbe_port= *pdata) if (memcmp(&phy_data->sfp_eeprom, &sfp_eeprom, sizeof(sfp_eeprom)))= { phy_data->sfp_changed =3D 1; memcpy(&phy_data->sfp_eeprom, &sfp_eeprom, sizeof(sfp_eepro= m)); - - if (sfp_eeprom.extd[AXGBE_SFP_EXTD_SFF_8472]) { - uint8_t diag_type; - diag_type =3D sfp_eeprom.extd[AXGBE_SFP_EXTD_DIAG]; - - if (!(diag_type & AXGBE_SFP_EXTD_DIAG_ADDR_CHANGE)) - phy_data->sfp_diags =3D 1; - } } else { phy_data->sfp_changed =3D 0; } @@ -770,7 +761,6 @@ static void axgbe_phy_sfp_reset(struct axgbe_phy_data *= phy_data) phy_data->sfp_rx_los =3D 0; phy_data->sfp_tx_fault =3D 0; phy_data->sfp_mod_absent =3D 1; - phy_data->sfp_diags =3D 0; phy_data->sfp_base =3D AXGBE_SFP_BASE_UNKNOWN; phy_data->sfp_cable =3D AXGBE_SFP_CABLE_UNKNOWN; phy_data->sfp_speed =3D AXGBE_SFP_SPEED_UNKNOWN; -- 2.34.1