From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3388044077; Mon, 20 May 2024 12:44:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 688CD40DDA; Mon, 20 May 2024 12:43:47 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2082.outbound.protection.outlook.com [40.107.94.82]) by mails.dpdk.org (Postfix) with ESMTP id 1FCCF406FF for ; Mon, 20 May 2024 12:43:46 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tip8TURqJtNQKi/NP2owT7cxQPGccahTJxHTqn4EOkv6O4DporLvUQPKMfoFIav39hQ6CO0KUw9tEE/ZbRcfZ4LnFPHaIp+/W6rT8uQhioX/5m4Al/XPqtTxss3PwUEZABMhZ4lG8+AMdbEcqQgdz0CXEKAqz4ffFkbkypNiWQVnGWgp77GqFy40KL4PEUTHQEdmYRqIpsHzoYWzFIQPaJmubZJNdVOfpqV5AgKEa5y3ecLMgiExw1cI3SaTnj8GTRInqDaphmFoadr4qmurn/jaP+6ZV5XNtY4nQ5qNJn0H4HZ/bfcVF/vIuGh6XfsHzHjaaGH3HwyUNl0x5r7mOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gYCu/iYYMlfRflLFeXpk9XTtGbuQZ2d32fQPsOWGGEA=; b=HUrXaG95uJM+V7ZtHaVXi5qnYJJzHe9RiiP3d9wePKDiFFe8yhHXeyAe2QJ8UF7QHJGyXaqzsB5/pCk+fgeu7cEzYW3oXvqkvQyt7jb5ti1zJtCHKui9QCa0B/A/ZGhguSENa9Qj/Ard3wP/RTiqmxRZROwexp2CHhvBjshV0zwN2bjuM514ux8KBMtYsQQsXSYarzMI2tYeVUdx+7xlMWshsqr+yGbfkl4dITnj4GO2SCvQIAE1EAUdkZYf/At53wyH6CmsQhYbU+WbLP6i8HlNwJv0eDZCFehHU2G3TsFED65USIT5GnySXJGcGjoqj2F2qF0zQRtX17Vei6y/tA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gYCu/iYYMlfRflLFeXpk9XTtGbuQZ2d32fQPsOWGGEA=; b=wKBkS6hWV55TKoIckbzHQqgmQSjNBbl4hdfV3W7Q4M3Cu9uqzgpCtCl2MKHH/QuVNAbAIKjWHMgGoBTzYgIzkWcfSx+dsDdGrvffcToALjak/51X6OJbuN5WVGX1dYKa4+fUscXFcG3U1eGLIzJx9y0AotNzMguh0MhaXMqCnFs= Received: from DM4PR12MB5055.namprd12.prod.outlook.com (2603:10b6:5:39a::20) by DS0PR12MB7607.namprd12.prod.outlook.com (2603:10b6:8:13f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.36; Mon, 20 May 2024 10:43:44 +0000 Received: from DM4PR12MB5055.namprd12.prod.outlook.com ([fe80::acbd:ea93:4496:51a5]) by DM4PR12MB5055.namprd12.prod.outlook.com ([fe80::acbd:ea93:4496:51a5%7]) with mapi id 15.20.7587.035; Mon, 20 May 2024 10:43:44 +0000 From: "Sebastian, Selwin" To: "Ande, Venkat Kumar" , "dev@dpdk.org" Subject: RE: [PATCH v2 25/25] net/axgbe: modify debug messages Thread-Topic: [PATCH v2 25/25] net/axgbe: modify debug messages Thread-Index: AQHaoHxVPM757bzDskGGRDQa8kX/G7GgBC4g Date: Mon, 20 May 2024 10:43:44 +0000 Message-ID: References: <20240412125013.10498-1-VenkatKumar.Ande@amd.com> <20240507124305.2318-1-venkatkumar.ande@amd.com> <20240507124305.2318-25-venkatkumar.ande@amd.com> In-Reply-To: <20240507124305.2318-25-venkatkumar.ande@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ActionId=399c6681-67a2-4e54-8e63-f770fc1331d0; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=0; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=true; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD Internal Distribution Only; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2024-05-20T10:43:39Z; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5055:EE_|DS0PR12MB7607:EE_ x-ms-office365-filtering-correlation-id: 0068b9e6-1efd-40b2-3cb5-08dc78b9b8a8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|376005|366007|1800799015|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?hWtW6eEvdIwwXGvVBTFZMZh1NgsMNtZaJ7F8HFzzZufLhxfsLduSpYmB9jCQ?= =?us-ascii?Q?6dCeDqP0mq0u0tBLzsh+KxPBRtfhiCm/hP77p69xWYzHjUVqVI3cMc4nf9EB?= =?us-ascii?Q?uOxYDXVN83UA+Ra8Fs2mWCK12Uw7qALkEl0HrgL5XEyaZJMZRV5llrgoSjKg?= =?us-ascii?Q?hW8j/eEEu+2Cvavd+dk1zXWcm2geQ/jl0u7rKm56kwD/5qYVObQ4EC1QgXkH?= =?us-ascii?Q?0NDU9n5QG5k6E+VMMh5UbZs95biB211SJirwVCZdpECeBxQl3WhFy/TnS5Fh?= =?us-ascii?Q?PMnrBBKj49EKUtohaCo0jUgxOEzAnqNcMI8RQaLpxeYUw8lx7zZ06wlkbtpM?= =?us-ascii?Q?8uXj6axowRT6mx7Zr+Pw54PWvkIKfKC8ksns5feLRnhhk/rmrlWEiEph6Yxc?= =?us-ascii?Q?wrjDYkWfbdVbklW+klkooDXp11tS/CWf/34Np8SH7P0x/UIezEpy1aYIrExr?= =?us-ascii?Q?duTORR7W18AAuaoApqQYxvBpgOnkoHTuOeJqqkt3qYKZHrNCtiwY1lleKPJt?= =?us-ascii?Q?p/Wd0V4nYNLGMMLkGAenm7G3jzEGBIGjbpabWew0fa2fuEYe/ZoqGRcbqrYy?= =?us-ascii?Q?BgAgHvzaQu55U6wlbzA8cXazi/w5OQVphB4+PD6y6f5AHel0jUWylf1lAnbb?= =?us-ascii?Q?IvfDicpvb23DIAuIQA7pSgGBnXp/NYqAwlIhWA02eHIIVMRx/WBLgO4TSoz4?= =?us-ascii?Q?oS6qHsYmj8s91TGrKERGxdWJIaXuELq++QDDM1BgO0A1gSfJmWrz7wjP1JPi?= =?us-ascii?Q?g7kh7ZQ8RsdIG52prWcQHX1BNr4lCZW0WUtIvTwwVrc1jbQl+qlN+8wvNLZf?= =?us-ascii?Q?jMuMITVv95rYbYRqcl2ABJnebX0SyGG6aG4x9OTufj/5kVZ/uAJxETbnzn1q?= =?us-ascii?Q?+jLdTitAi1rLUEu0XfAldZDS/UOfYTouukTvwpvTIKHnZjQsa78D4+5apzFu?= =?us-ascii?Q?XXLE6hdaNVYrYqfa7VAz25XriDxqm2F3bjU6uxV+lTWwGe5uaBTJvVwGG7zc?= =?us-ascii?Q?sGD7zcis2RvE7oKwmNGoq05QCjy7uo9sCmQ+WIV903CEgx/5i+UbMq6DlBjY?= =?us-ascii?Q?PcGVaonup3WoeHzZjsDgCebB4N1jy5caHhyZDC7OzYqE/jDitMsgdeuXyRaw?= =?us-ascii?Q?zY29JgNMW/N83IhkJ+dslJ2F3taX3TJiXNTaRNakdDS4BIoFm91J31+lfpUQ?= =?us-ascii?Q?xJ3aV5g+4P/hy57lxnRVaij0vP2TbRQCFsNWpGXa6BNq8A2eNHRwaoSwPOmY?= =?us-ascii?Q?3hcHZUOAeoKUEv1kbJUGyCsAKbUUTQIwB3Oz/nPNItI8w4LvESg3KJz/Mu5q?= =?us-ascii?Q?JO6NBfyFmBQoZn0A1vRJH7v+HvsYLom6Gs8YGzS8Q/ZSIQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5055.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/hTUFcHL21lhoi9pbc/cfnTFmLYbC2C4CcxuSuKgytNtuF+m0sZ+HV6NMlrA?= =?us-ascii?Q?bp9lmRFXQNsFP0Nht+3j+gKy1CoQD7CxRG2VZT3IwraqoHvvzyPI+udm6UiE?= =?us-ascii?Q?eJqo+eFTOBzigLClxGYzy1629ROgmms+xiF3649CKDan9PvYvtk6+eOyDOqF?= =?us-ascii?Q?62ZGEBtNaGUh5D1QaQKC8IMtej8oAE8xaG3oYhp8eurOxA5oc3MXL41NTWkk?= =?us-ascii?Q?gNdltIx+k/5kfA6vuTPofyUJ2aBSP4PbO70KR47HORI8pI1d2Gsfq6XlZBhq?= =?us-ascii?Q?2y8FSLR3Q211hxCJ2JUkgSOf63Ssk4TmVTrkFzfQ4QAbyg/erpnisRVe1FfC?= =?us-ascii?Q?5z4QzIotZ7R0F526vHsz2VnMvhSYxUp/616TAdSVImYSH38nWE7koYKhQyIA?= =?us-ascii?Q?6E8jud/BQdPdo3ZD5L4JfU+f1OMrXjOglJxqCGK7RndfPcGh4LKV1py+OOMs?= =?us-ascii?Q?R+gfp7qXjvp55dfx5CS59RDkymEPyptcdYBltEh6Hht97HJJavAhkucCS9uL?= =?us-ascii?Q?EoDMlC4lI7ksXyFraCcL9Lg+A+fADEe7dgrIWUeZn4BbCUJu2GGyWKWLigKZ?= =?us-ascii?Q?n28tBNCmZf284hFgWGuTN+AFcSjxnJZyR6/d9ICcUfQfgCVJTn4vTE2nD6n3?= =?us-ascii?Q?dsYJtQDfSYlj0dQEQH3WaG8C1qff1NyCKIYv0R5afPLSshiSXNCMGBtZTXwm?= =?us-ascii?Q?FmDk4X/GjhY9XWfJCP3KvlP4ac90JWGOZRln7Xhu764be9C2EyZG3OItxgIO?= =?us-ascii?Q?cG4Gmp94N3A4iSI2fTbv27JGrJcCLsPM5nCoqAvp5YUVbFyvs3mfV/A9I0rJ?= =?us-ascii?Q?p2G4GUp6I0S4j1IIqauTY05BELP19I+H0vX+3pn+e+hOudETwrQhQf95N5mf?= =?us-ascii?Q?59z+YJ46sJ+LgnBBB+HAE7IQb6OhBv2T2ROhEnAHwU+L51O0kyoApVc2qnFl?= =?us-ascii?Q?tXFoTOz8340ICmt0h56rZw2GxyDShLheLhze4VUhT4/pX6vlAwzhnPDnQFV/?= =?us-ascii?Q?DxejhuU7f3m12L9jsc3iUDLu8FM4COO4tILir/R/7fGoIFhcixtYBNRApPBo?= =?us-ascii?Q?apThavyuYUlkzDgG49LmO/47VLY1SL/+rqMRQC8GIE1/pZwa3dtY1TG96Thl?= =?us-ascii?Q?fvO+BGEPR/1rVQzAIv6vBp+xQgqEZ+dpxYpb/NZkiNR53KC5QWNRG8q2Yhwn?= =?us-ascii?Q?YHqwSC3GVkj1o7a8rwg7vxS1kiH+uWa7o2NW8AlWhfLXyyI71uevIARgEWaH?= =?us-ascii?Q?mJ2TPuiRs15MAvmurKa1Lx3Tn4rAaWPRMySVDqWl+HwiaDS9TpZlG7iikokb?= =?us-ascii?Q?0Aq88O3rCqWjEqJFU3x10faNdovdr6rer7MZaX0d+zY59YzESDDgQxovRbKZ?= =?us-ascii?Q?5i5gEMC6am3b7kcS+UmBrGnPv5bjBZwpqZr2Qd58M+mBrEXgNZvkQyDrvu9l?= =?us-ascii?Q?4L3eXXtPxgS8zxGh9cC/5SQladW4VsuL1joBhv5XtWmdigMdpRlQWdgRgz/J?= =?us-ascii?Q?uZ6i9N2rLAnlSXYsIr3H9PH0c4E95I2JHZwhERqv3LDvrDiALtQPSukxIMFI?= =?us-ascii?Q?9SodksHanO676wnEPFyhfFW14Q1y1W6ZzllmiZBl?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5055.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0068b9e6-1efd-40b2-3cb5-08dc78b9b8a8 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2024 10:43:44.1952 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: l7iBHO0n1cH9pDvwpUDJZbAYWPXiUBU8DiGr3jT7COagapk6HjWc6xOBzCq3cIziRkZw2UTymD8Zsu0hZ5o+6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7607 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org [AMD Official Use Only - AMD Internal Distribution Only] Acked-by: Selwin Sebastian -----Original Message----- From: Ande, Venkat Kumar Sent: Tuesday, May 7, 2024 6:13 PM To: dev@dpdk.org Cc: Sebastian, Selwin ; Ande, Venkat Kumar Subject: [PATCH v2 25/25] net/axgbe: modify debug messages Modify debug messages to get better information from debug logs Signed-off-by: Venkat Kumar Ande --- drivers/net/axgbe/axgbe_ethdev.c | 4 ++-- drivers/net/axgbe/axgbe_phy_impl.c | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_eth= dev.c index 86c2ec64e0..8b1f3b2742 100644 --- a/drivers/net/axgbe/axgbe_ethdev.c +++ b/drivers/net/axgbe/axgbe_ethdev.c @@ -783,8 +783,8 @@ axgbe_dev_link_update(struct rte_eth_dev *dev, link.link_autoneg =3D !(dev->data->dev_conf.link_speeds & RTE_ETH_LINK_SPEED_FIXED); ret =3D rte_eth_linkstatus_set(dev, &link); - if (ret =3D=3D -1) - PMD_DRV_LOG(ERR, "No change in link status\n"); + if (ret =3D=3D 0) + PMD_DRV_LOG(ERR, "Link status changed\n"); return ret; } diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_p= hy_impl.c index d41c6e9bc7..0af1a7cac5 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -1375,8 +1375,6 @@ static void axgbe_phy_perform_ratechange(struct axgbe= _port *pdata, if (cmd !=3D AXGBE_MB_CMD_POWER_OFF && cmd !=3D AXGBE_MB_CMD_RRC) axgbe_phy_pll_ctrl(pdata, true); - - PMD_DRV_LOG(NOTICE, "firmware mailbox command did not complete\n"); } static void axgbe_phy_rrc(struct axgbe_port *pdata) -- 2.34.1