Re: [dpdk-dev] [PATCH v4 2/4] mempool: add non-IO flag

[Dmitry Kozlyuk <dkozlyuk@oss.nvidia.com>]

Hello David,

> [...]
> - When rebasing on main, you probably won't be able to call this new flag.
> The diff should be something like:
> 
> diff --git a/app/test/test_mempool.c b/app/test/test_mempool.c index
> d886f4800c..35c80291fa 100644
> --- a/app/test/test_mempool.c
> +++ b/app/test/test_mempool.c
> @@ -214,7 +214,7 @@ static int
> test_mempool_creation_with_unknown_flag(void)
>                 MEMPOOL_ELT_SIZE, 0, 0,
>                 NULL, NULL,
>                 NULL, NULL,
> -               SOCKET_ID_ANY, MEMPOOL_F_NO_IOVA_CONTIG << 1);
> +               SOCKET_ID_ANY, MEMPOOL_F_NON_IO << 1);
> 
>         if (mp_cov != NULL) {
>                 rte_mempool_free(mp_cov); diff --git
> a/lib/mempool/rte_mempool.c b/lib/mempool/rte_mempool.c index
> 8d5f99f7e7..27d197fe86 100644
> --- a/lib/mempool/rte_mempool.c
> +++ b/lib/mempool/rte_mempool.c
> @@ -802,6 +802,7 @@ rte_mempool_cache_free(struct rte_mempool_cache
> *cache)
>         | MEMPOOL_F_SC_GET \
>         | MEMPOOL_F_POOL_CREATED \
>         | MEMPOOL_F_NO_IOVA_CONTIG \
> +       | MEMPOOL_F_NON_IO \

I wonder why CREATED and NON_IO should be listed here:
they are not supposed to be passed by the user,
which is what MEMPOOL_KNOWN_FLAGS is used for.
The same question stands for the test code.
Could you confirm your suggestion?

>         )
>  /* create an empty mempool */
>  struct rte_mempool *
> 
> 
> - While grepping, I noticed that proc-info also dumps mempool flags.
> This could be something to enhance, maybe amending current
> rte_mempool_dump() and having this tool use it.
> But for now, can you update this tool too?

I will, thanks for the hints.