From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C90054331B; Mon, 13 Nov 2023 14:51:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 518D1402AE; Mon, 13 Nov 2023 14:51:30 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2063.outbound.protection.outlook.com [40.107.243.63]) by mails.dpdk.org (Postfix) with ESMTP id 54C6B4021F; Mon, 13 Nov 2023 14:51:29 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dSJh0o0MNbfvvC7ls1T1hToQwWsDVDEZDaYrKU93X5ijc4AqF8Se50/sToOc4NF5Y13Og4Jd7fDo5C4vzdEVl64P5YHw6CItCyMmb4SehrKbEDmOoLnHk9ZrMC2hU0cy0dKSd2i8Akw08JYAzYqqTx4e7HY1iHj4tz650e+e6QSSH0sVyitMti76HEiZJCLGIKiWjCmG2ErmP83SfNs7qt14U8n8JvtZrJ0glIR1hMll2AGsH9CBrr1geEKucqV6vx6k8ObHj7VctFnWCzn2ijEjAlM10dwRHWSNyXsGDapINsi4eJqFCFm7OJf4alL2+x/bMZZkCruyeCG+tfWyeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+vRUfeyHliKZ5BwggGGQtcN0DFgrTmMTnFVS3g58QhQ=; b=JENpoVEB+c+NSQKp3aD/i+IK4dTWY2ff9awQchFoUukAyDUJvHuCuy6wTaRf1yRW0n0fWe9mMb1K6lhNEY31MURoU3NATxNcxAlb6DoYEZm20p8VNGD89C/Mx6v5/uvVpTUc0wlfdd424q5QUo0Nhtm+vhUSJ/C/5zV/dW86ZFOx0331H1RR+65dGGtdzUoKXMmFqxJ7DNjC4a3lgkLt8K/gURyHPyAYH8RZl9N6ogv9zghUFmHLdn07L+Qp/ryjJMGiCjeEi53X4qIw0+3vosgFLBxh2sAq3RG+wCrRf6sWJamrF/qDYwZHsB1akMnjdph47ida4FBVPHLSU0fR0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+vRUfeyHliKZ5BwggGGQtcN0DFgrTmMTnFVS3g58QhQ=; b=FYwcyn3M+AIhcxnMivXeoBt63mqkWvHM3O4cduoyS8BrMHK2Zn26OzGt7Ir43lqDrZHk2qKSdGUPLifM5fnIBMBDbg4/8++lCxlF/4lsKNnv6r9KoahfmFg0cpUDsD4BjAm8ovxpcTV9Q+A0+os8G5E3zsjHPUIE1sjmQT52PSF8CLAPmUUb0QTAxQNu/vJimHwWvVDLn5C48yByHoynVECXOuiPSiviCiHcdkAOxdh4Bau6dpNBG9tzE74fPWAzkXoLzs4p9cfeivF+rRsNb476G6/JlTzH7lYDnACeTckXVz9R+lVr9Bb41rbUWUmEvNQq3hZLWZTgwt2Pzz2jXg== Received: from DM4PR12MB5184.namprd12.prod.outlook.com (2603:10b6:5:397::18) by IA1PR12MB6017.namprd12.prod.outlook.com (2603:10b6:208:3d7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.29; Mon, 13 Nov 2023 13:51:25 +0000 Received: from DM4PR12MB5184.namprd12.prod.outlook.com ([fe80::4c3b:70b8:29c8:1a6a]) by DM4PR12MB5184.namprd12.prod.outlook.com ([fe80::4c3b:70b8:29c8:1a6a%4]) with mapi id 15.20.6977.029; Mon, 13 Nov 2023 13:51:25 +0000 From: Bing Zhao To: Suanming Mou , Matan Azrad , Slava Ovsiienko , Raslan Darawsheh , Ori Kam CC: "dev@dpdk.org" , Dariusz Sosnowski , "stable@dpdk.org" Subject: RE: [PATCH] net/mlx5: fix the LACP redirection in Rx domain Thread-Topic: [PATCH] net/mlx5: fix the LACP redirection in Rx domain Thread-Index: AQHaFi7QHua6fJCFhEmo7QZ38XXnnbB4OgyAgAAJllA= Date: Mon, 13 Nov 2023 13:51:25 +0000 Message-ID: References: <20231113124136.8071-1-bingz@nvidia.com> In-Reply-To: Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5184:EE_|IA1PR12MB6017:EE_ x-ms-office365-filtering-correlation-id: 1e58726e-b024-4149-2487-08dbe44fa111 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eCapnVmLRUlfB5NnQQgMMX20//29whEZsQpN4hUjHllch9FByNCZik67rLu0HKAIh7E5RtqHFSAeT3ozwKY7d2791QcgbBClWu+IMc2cvChYRmwqbqEIcQmkvpNmnNfitd8w0NhhV3otpK8UoAqEWhAxk+7bExROoTOTesgjdZQ3Y5tB0o5qgPocIdLVIuSmEWi2CLDivrNsxKMGaEoZ02lKwQnmb18vSpwxzpq1edEuX1xEEGdhVvGpc3yHNqlLz17HNwdRcOVvD9S3xNZ9p2DzmFs4RAJQ7jZNntmJRhffm746SoTwq/JfRKaSToIRD7lk1BUcyZHGvgU2edK0OUwep7/rPkSPaurlK28xZV90QybbyDBRRGGQG04Vgihte2wvGhB1APyn3+A+x7Ev3wfVjx2Mp1e8QP+KyxM9LHdyk3CSD+WMYiw4DT3Hnl2NoWoSIZkkOqWBidRStBUXOKLwfIZv3PcFjEBwkZ4bSiqQoHZ0uz7RS1ZyCSCAcqb9gUDIuDlVkgrV8h8tiY05hMEBKXctigUM11ofqAbVqZTrJsePycrWRLypBIf1woJyLktOduNBUQYJv3+ySg0RUdUEZutakd0JmzH8Rd1ycARu9arEpNmAe/PQpWHOEkZb x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5184.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(376002)(136003)(346002)(39860400002)(396003)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(38100700002)(450100002)(66446008)(64756008)(86362001)(4326008)(8936002)(8676002)(110136005)(122000001)(66476007)(54906003)(6636002)(316002)(66946007)(76116006)(66556008)(52536014)(71200400001)(9686003)(7696005)(6506007)(53546011)(83380400001)(478600001)(2906002)(41300700001)(33656002)(5660300002)(38070700009)(55016003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mzNYd2JS5DxrboKmopRVdBrI5CmW8/wPcTYETuYcC36j4d5B3esRrwZ4x0rp?= =?us-ascii?Q?Qn4F1QmeLD1SlZP0h0caCxWw7GZ4yI0kFcPpj0eOc9IvNB0Uyb5yqxbHgUMD?= =?us-ascii?Q?ANojgtIjyrNzGgjgpZ8lZ9u+uN4niaLS8oiErfQN6C64KnfXSH35qZMr40df?= =?us-ascii?Q?5Wr0Amqhc7qE6FA6pBoA6UCd4nYdqHi2T1WYBMyAh6T38JC3Qt8vj73r3LCz?= =?us-ascii?Q?WBb+5cxHeU2eklcY5PO0ghPWcQg4Wj3B/c7UYkxNr8IFnKwN8fJPOoiPefwi?= =?us-ascii?Q?ShxdT/xsPktc/ByLaEZ/a+RC27fnL+/EkWp4BEEkFCclOQagc8z0LdEb4P0m?= =?us-ascii?Q?EN0PzNFSvsR82rTpDove7i9WvdNxiFWgRq/aGNLk83hkp4+xFGsu6u3U4qaB?= =?us-ascii?Q?CyJW3oJWjHl5SNEN5Jwb7q0Y9ZwOM0AjCRvgE7UwqBQC0Q0Xp+nGHNTP2XhM?= =?us-ascii?Q?yO4nUACMZtXNHnBWsDFhc8VAeQw4mmKCZtWDhYDJsA2Vkq5RPlcXf53v8++e?= =?us-ascii?Q?WgmbFKZE/W1ZAZ1RwnhRqFtDQGaHCCg6yIfVo1NRegPJHRVBWfn+f5+/ei3w?= =?us-ascii?Q?5zeAVPMHkywZO55GnbrKpn2WrJFHUMghH3i5lCsqtjJGsJpopMA6uztk8xKZ?= =?us-ascii?Q?gwVYmcIcdWtMFnhN/Nf2fHRICpXA/x1ofcHMlkPoyE9LPbDNzvRaCAY1HC7v?= =?us-ascii?Q?EAjOFKU7/j+y15HzSVlWu06R9OGVoJTCeZfQMxBToHeg2zu0gJ5+tkOpPAU4?= =?us-ascii?Q?0ni89XLEHJ96laNR62fW3mhPnJkjIURLkUjHE0iQfB086iHguLNaQeg0wVfZ?= =?us-ascii?Q?dga2+5e1t504NHFyGXoQ7/1DTL013mbLVbmgHs8/46LqJ+svp+Ew7+4Ee+I+?= =?us-ascii?Q?hWP1B0U3vMxCOBTGd6hon8z419tE7eZsTgWeV+PeiKX6sb7fhM6/3+jAjIRL?= =?us-ascii?Q?DvFMy5FAvnCcUs1EPCBRhOWGRnmXQtRrawvYuOPO9pCoPuhM1l4t/N7LRsBH?= =?us-ascii?Q?YBVS+u20qrShagATlPvHRDfBN8Cfb6uF7jGHwc9gIpgN/hPGU5H/zCjwMcPC?= =?us-ascii?Q?W3xL8a92KjzeN+hLWZy87y001wZjQB+I88yQM/ZV5pBbokvXKyzpGjBiednl?= =?us-ascii?Q?HLDiiGqCnfgSPmKbHsy/J1Z+d5eBdsJvQgT+Kpb2LqkYvuBfibBoTq/gQKAF?= =?us-ascii?Q?l4DeNTVxnIE3iU+YBkRcXgLiYbNRxLkqfLTdk/kwwPGQRHBLe61+ArIJ3JY+?= =?us-ascii?Q?fT4wfh4Otg5J9bU8eQd2uBVVNzZyhGY7SkeLmqWMyL4xRGCaOV3GI3hKq6Wi?= =?us-ascii?Q?OJnJQC09WQUgTfBVR4QYi/ml7alAjDi7XS2N+eYuHznocRdVld6ccdUFd8/p?= =?us-ascii?Q?8HeukGKXiGEMFKJiLdvlqiREDnvfG/uPCJykw+aq7j+pTkErdTfWJNRzRWy9?= =?us-ascii?Q?T3AzILilXKF2BdXWdly48euSM5psYRE65GU4FxDVt/BnLJVR/8/joGMsdoB7?= =?us-ascii?Q?Rl5gKPNt5qbJYlYV8mNz2qqNVMFdfX2dbSPBLKl0lXr+lTzUicP+7NsPlA?= =?us-ascii?Q?=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5184.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e58726e-b024-4149-2487-08dbe44fa111 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2023 13:51:25.8560 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ThSQOxN1smMQKOaWy11yqcMLNKZDecmaUQPFj2+oReV5F9k/dXlQzynxi/OfqiOJB0Mf/eh9Eib3+c/cChvWYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6017 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Suanming, My answers are inline. > -----Original Message----- > From: Suanming Mou > Sent: Monday, November 13, 2023 9:14 PM > To: Bing Zhao ; Matan Azrad ; Slava > Ovsiienko ; Raslan Darawsheh > ; Ori Kam > Cc: dev@dpdk.org; Dariusz Sosnowski ; > stable@dpdk.org > Subject: RE: [PATCH] net/mlx5: fix the LACP redirection in Rx domain >=20 > Hi, >=20 > One small comment, v2 is needed. >=20 > > -----Original Message----- > > From: Bing Zhao > > Sent: Monday, November 13, 2023 8:42 PM > > To: Matan Azrad ; Slava Ovsiienko > > ; Raslan Darawsheh ; > > Suanming Mou ; Ori Kam > > Cc: dev@dpdk.org; Dariusz Sosnowski ; > > stable@dpdk.org > > Subject: [PATCH] net/mlx5: fix the LACP redirection in Rx domain > > > > When the "lacp_by_user" is not set from the application in bond mode, > > the LACP traffic should be handled by the kernel driver by default. > > > > This commit adds the missing support in the template API when > "dv_flow_en=3D2". > > The behavior will be the same as that in the DV mode with > > "dv_flow_en=3D1". The LACP packets will be redirected to the kernel whe= n > > starting the steering in the NIC Rx domain. > > > > With this commit, the DEFAULT_MISS action usage is refactored a bit. > > In the HWS, one unique action can be created with supported bits set in= the > "flag" > > per port. The *ROOT_FDB and *HWS_FDB flag bits will only be set when > > the port is in switchdev mode and working as the E-Switch manager > > proxy port. The SF/VF and all other representors won't have the FDB > > flag bits when creating the DEFAULT_MISS action. > > > > Fixes: 9fa7c1cddb85 ("net/mlx5: create control flow rules with HWS") > > Cc: dsosnowski@nvidia.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Bing Zhao > > --- > > drivers/net/mlx5/linux/mlx5_os.c | 8 +- > > drivers/net/mlx5/mlx5.h | 1 + > > drivers/net/mlx5/mlx5_flow.h | 1 + > > drivers/net/mlx5/mlx5_flow_hw.c | 249 > +++++++++++++++++++++++++++++-- > > drivers/net/mlx5/mlx5_trigger.c | 3 + > > 5 files changed, 249 insertions(+), 13 deletions(-) > > > > diff --git a/drivers/net/mlx5/linux/mlx5_os.c > > b/drivers/net/mlx5/linux/mlx5_os.c >=20 > [snip] >=20 > > @@ -8327,6 +8503,10 @@ flow_hw_create_ctrl_tables(struct rte_eth_dev > > *dev, struct rte_flow_error *error > > ret =3D rte_flow_error_set(error, EINVAL, > > > > RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, > > "Failed to create control tables."); > > + if (priv->hw_tx_meta_cpy_tbl) { >=20 > I assume it should be hw_lacp_rx_tbl here. Can you please send v2 for th= at? > And LGTM for left code. It's OK to add my ack for v2. > Acked-by: Suanming Mou Since it is a "goto" label, when arriving here from the LACP error branch, = the previous tables were created successfully. The LACP table is the last one from the code and it will never be NULL when= reaching here. What should be rollbaked is the previous one. This is some disadvantage of using goto in the code, not quite straightforw= ard. >=20 >=20 > > + flow_hw_table_destroy(dev, priv->hw_tx_meta_cpy_tbl, > NULL); > > + priv->hw_tx_meta_cpy_tbl =3D NULL; > > + } >=20 > [snip] >=20 > > 2.34.1 BR. Bing