RE: [PATCH] vdpa/mlx5: fix return value check of mkey create

[Bing Zhao <bingz@nvidia.com>]

Hi Chenbo,


> -----Original Message-----
> From: Xia, Chenbo <chenbo.xia@intel.com>
> Sent: Tuesday, November 16, 2021 3:54 PM
> To: Bing Zhao <bingz@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> Subject: RE: [PATCH] vdpa/mlx5: fix return value check of mkey
> create
> 
> External email: Use caution opening links or attachments
> 
> 
> > -----Original Message-----
> > From: Bing Zhao <bingz@nvidia.com>
> > Sent: Friday, November 12, 2021 10:43 PM
> > To: viacheslavo@nvidia.com; matan@nvidia.com
> > Cc: dev@dpdk.org; rasland@nvidia.com
> > Subject: [PATCH] vdpa/mlx5: fix return value check of mkey create
> >
> > The return value of "mlx5_os_wrapped_mkey_create" is checked in
> the
> > caller. A zero means success without any error.
> >
> > The typo in the if-condition should be fixed in case there is a
> > misjudgment.
> >
> > Fixes: f26e06d97d57 ("vdpa/mlx5: workaround dirty bitmap MR
> creation")
> 
> Wrong commit id, should be the one in main tree:
> 
> Fixes: 398ea8450c53 ("vdpa/mlx5: workaround dirty bitmap MR
> creation")
> 
> With this fixed:
> 
> Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>

Thanks for the comments.
Is there any need to send a v2 or Maxime will help on this?

> 
> >
> > Signed-off-by: Bing Zhao <bingz@nvidia.com>
> > Acked-by: Matan Azrad <matan@nvidia.com>
> > ---
> >  drivers/vdpa/mlx5/mlx5_vdpa_lm.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> > b/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> > index e65e4faa47..43a2b98255 100644
> > --- a/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> > +++ b/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> > @@ -47,7 +47,7 @@ mlx5_vdpa_dirty_bitmap_set(struct mlx5_vdpa_priv
> > *priv, uint64_t log_base,
> >                                             (void
> *)(uintptr_t)log_base,
> >                                             log_size, &priv-
> >lm_mr);
> >
> > -     if (!ret) {
> > +     if (ret) {
> >               DRV_LOG(ERR, "Failed to allocate wrapped MR for
> lm.");
> >               return -1;
> >       }
> > --
> > 2.27.0

BR. Bing