* [PATCH] vdpa/mlx5: fix return value check of mkey create
@ 2021-11-12 14:42 Bing Zhao
2021-11-16 7:54 ` Xia, Chenbo
2021-11-16 10:24 ` Maxime Coquelin
0 siblings, 2 replies; 7+ messages in thread
From: Bing Zhao @ 2021-11-12 14:42 UTC (permalink / raw)
To: viacheslavo, matan; +Cc: dev, rasland
The return value of "mlx5_os_wrapped_mkey_create" is checked in the
caller. A zero means success without any error.
The typo in the if-condition should be fixed in case there is a
misjudgment.
Fixes: f26e06d97d57 ("vdpa/mlx5: workaround dirty bitmap MR creation")
Signed-off-by: Bing Zhao <bingz@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
drivers/vdpa/mlx5/mlx5_vdpa_lm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_lm.c b/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
index e65e4faa47..43a2b98255 100644
--- a/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
+++ b/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
@@ -47,7 +47,7 @@ mlx5_vdpa_dirty_bitmap_set(struct mlx5_vdpa_priv *priv, uint64_t log_base,
(void *)(uintptr_t)log_base,
log_size, &priv->lm_mr);
- if (!ret) {
+ if (ret) {
DRV_LOG(ERR, "Failed to allocate wrapped MR for lm.");
return -1;
}
--
2.27.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] vdpa/mlx5: fix return value check of mkey create
2021-11-12 14:42 [PATCH] vdpa/mlx5: fix return value check of mkey create Bing Zhao
@ 2021-11-16 7:54 ` Xia, Chenbo
2021-11-16 8:01 ` Bing Zhao
2021-11-16 10:24 ` Maxime Coquelin
1 sibling, 1 reply; 7+ messages in thread
From: Xia, Chenbo @ 2021-11-16 7:54 UTC (permalink / raw)
To: Bing Zhao, viacheslavo, matan; +Cc: dev, rasland
> -----Original Message-----
> From: Bing Zhao <bingz@nvidia.com>
> Sent: Friday, November 12, 2021 10:43 PM
> To: viacheslavo@nvidia.com; matan@nvidia.com
> Cc: dev@dpdk.org; rasland@nvidia.com
> Subject: [PATCH] vdpa/mlx5: fix return value check of mkey create
>
> The return value of "mlx5_os_wrapped_mkey_create" is checked in the
> caller. A zero means success without any error.
>
> The typo in the if-condition should be fixed in case there is a
> misjudgment.
>
> Fixes: f26e06d97d57 ("vdpa/mlx5: workaround dirty bitmap MR creation")
Wrong commit id, should be the one in main tree:
Fixes: 398ea8450c53 ("vdpa/mlx5: workaround dirty bitmap MR creation")
With this fixed:
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
>
> Signed-off-by: Bing Zhao <bingz@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
> drivers/vdpa/mlx5/mlx5_vdpa_lm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> b/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> index e65e4faa47..43a2b98255 100644
> --- a/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> +++ b/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> @@ -47,7 +47,7 @@ mlx5_vdpa_dirty_bitmap_set(struct mlx5_vdpa_priv *priv,
> uint64_t log_base,
> (void *)(uintptr_t)log_base,
> log_size, &priv->lm_mr);
>
> - if (!ret) {
> + if (ret) {
> DRV_LOG(ERR, "Failed to allocate wrapped MR for lm.");
> return -1;
> }
> --
> 2.27.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] vdpa/mlx5: fix return value check of mkey create
2021-11-16 7:54 ` Xia, Chenbo
@ 2021-11-16 8:01 ` Bing Zhao
2021-11-16 8:04 ` Xia, Chenbo
0 siblings, 1 reply; 7+ messages in thread
From: Bing Zhao @ 2021-11-16 8:01 UTC (permalink / raw)
To: Xia, Chenbo, Slava Ovsiienko, Matan Azrad, maxime.coquelin
Cc: dev, Raslan Darawsheh
Hi Chenbo,
> -----Original Message-----
> From: Xia, Chenbo <chenbo.xia@intel.com>
> Sent: Tuesday, November 16, 2021 3:54 PM
> To: Bing Zhao <bingz@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> Subject: RE: [PATCH] vdpa/mlx5: fix return value check of mkey
> create
>
> External email: Use caution opening links or attachments
>
>
> > -----Original Message-----
> > From: Bing Zhao <bingz@nvidia.com>
> > Sent: Friday, November 12, 2021 10:43 PM
> > To: viacheslavo@nvidia.com; matan@nvidia.com
> > Cc: dev@dpdk.org; rasland@nvidia.com
> > Subject: [PATCH] vdpa/mlx5: fix return value check of mkey create
> >
> > The return value of "mlx5_os_wrapped_mkey_create" is checked in
> the
> > caller. A zero means success without any error.
> >
> > The typo in the if-condition should be fixed in case there is a
> > misjudgment.
> >
> > Fixes: f26e06d97d57 ("vdpa/mlx5: workaround dirty bitmap MR
> creation")
>
> Wrong commit id, should be the one in main tree:
>
> Fixes: 398ea8450c53 ("vdpa/mlx5: workaround dirty bitmap MR
> creation")
>
> With this fixed:
>
> Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
Thanks for the comments.
Is there any need to send a v2 or Maxime will help on this?
>
> >
> > Signed-off-by: Bing Zhao <bingz@nvidia.com>
> > Acked-by: Matan Azrad <matan@nvidia.com>
> > ---
> > drivers/vdpa/mlx5/mlx5_vdpa_lm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> > b/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> > index e65e4faa47..43a2b98255 100644
> > --- a/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> > +++ b/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> > @@ -47,7 +47,7 @@ mlx5_vdpa_dirty_bitmap_set(struct mlx5_vdpa_priv
> > *priv, uint64_t log_base,
> > (void
> *)(uintptr_t)log_base,
> > log_size, &priv-
> >lm_mr);
> >
> > - if (!ret) {
> > + if (ret) {
> > DRV_LOG(ERR, "Failed to allocate wrapped MR for
> lm.");
> > return -1;
> > }
> > --
> > 2.27.0
BR. Bing
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] vdpa/mlx5: fix return value check of mkey create
2021-11-16 8:01 ` Bing Zhao
@ 2021-11-16 8:04 ` Xia, Chenbo
2021-11-16 8:13 ` Bing Zhao
0 siblings, 1 reply; 7+ messages in thread
From: Xia, Chenbo @ 2021-11-16 8:04 UTC (permalink / raw)
To: Bing Zhao, Slava Ovsiienko, Matan Azrad, maxime.coquelin
Cc: dev, Raslan Darawsheh
> -----Original Message-----
> From: Bing Zhao <bingz@nvidia.com>
> Sent: Tuesday, November 16, 2021 4:01 PM
> To: Xia, Chenbo <chenbo.xia@intel.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>;
> maxime.coquelin@redhat.com
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> Subject: RE: [PATCH] vdpa/mlx5: fix return value check of mkey create
>
> Hi Chenbo,
>
>
> > -----Original Message-----
> > From: Xia, Chenbo <chenbo.xia@intel.com>
> > Sent: Tuesday, November 16, 2021 3:54 PM
> > To: Bing Zhao <bingz@nvidia.com>; Slava Ovsiienko
> > <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>
> > Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> > Subject: RE: [PATCH] vdpa/mlx5: fix return value check of mkey
> > create
> >
> > External email: Use caution opening links or attachments
> >
> >
> > > -----Original Message-----
> > > From: Bing Zhao <bingz@nvidia.com>
> > > Sent: Friday, November 12, 2021 10:43 PM
> > > To: viacheslavo@nvidia.com; matan@nvidia.com
> > > Cc: dev@dpdk.org; rasland@nvidia.com
> > > Subject: [PATCH] vdpa/mlx5: fix return value check of mkey create
> > >
> > > The return value of "mlx5_os_wrapped_mkey_create" is checked in
> > the
> > > caller. A zero means success without any error.
> > >
> > > The typo in the if-condition should be fixed in case there is a
> > > misjudgment.
> > >
> > > Fixes: f26e06d97d57 ("vdpa/mlx5: workaround dirty bitmap MR
> > creation")
> >
> > Wrong commit id, should be the one in main tree:
> >
> > Fixes: 398ea8450c53 ("vdpa/mlx5: workaround dirty bitmap MR
> > creation")
> >
> > With this fixed:
> >
> > Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
>
> Thanks for the comments.
> Is there any need to send a v2 or Maxime will help on this?
I think it can be fixed when applying.
Thanks,
Chenbo
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] vdpa/mlx5: fix return value check of mkey create
2021-11-16 8:04 ` Xia, Chenbo
@ 2021-11-16 8:13 ` Bing Zhao
0 siblings, 0 replies; 7+ messages in thread
From: Bing Zhao @ 2021-11-16 8:13 UTC (permalink / raw)
To: Xia, Chenbo, Slava Ovsiienko, Matan Azrad, maxime.coquelin
Cc: dev, Raslan Darawsheh
Hi,
> -----Original Message-----
> From: Xia, Chenbo <chenbo.xia@intel.com>
> Sent: Tuesday, November 16, 2021 4:05 PM
> To: Bing Zhao <bingz@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>;
> maxime.coquelin@redhat.com
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> Subject: RE: [PATCH] vdpa/mlx5: fix return value check of mkey
> create
>
> External email: Use caution opening links or attachments
>
>
> > -----Original Message-----
> > From: Bing Zhao <bingz@nvidia.com>
> > Sent: Tuesday, November 16, 2021 4:01 PM
> > To: Xia, Chenbo <chenbo.xia@intel.com>; Slava Ovsiienko
> > <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>;
> > maxime.coquelin@redhat.com
> > Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> > Subject: RE: [PATCH] vdpa/mlx5: fix return value check of mkey
> create
> >
> > Hi Chenbo,
> >
> >
> > > -----Original Message-----
> > > From: Xia, Chenbo <chenbo.xia@intel.com>
> > > Sent: Tuesday, November 16, 2021 3:54 PM
> > > To: Bing Zhao <bingz@nvidia.com>; Slava Ovsiienko
> > > <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>
> > > Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> > > Subject: RE: [PATCH] vdpa/mlx5: fix return value check of mkey
> > > create
> > >
> > > External email: Use caution opening links or attachments
> > >
> > >
> > > > -----Original Message-----
> > > > From: Bing Zhao <bingz@nvidia.com>
> > > > Sent: Friday, November 12, 2021 10:43 PM
> > > > To: viacheslavo@nvidia.com; matan@nvidia.com
> > > > Cc: dev@dpdk.org; rasland@nvidia.com
> > > > Subject: [PATCH] vdpa/mlx5: fix return value check of mkey
> create
> > > >
> > > > The return value of "mlx5_os_wrapped_mkey_create" is checked
> in
> > > the
> > > > caller. A zero means success without any error.
> > > >
> > > > The typo in the if-condition should be fixed in case there is
> a
> > > > misjudgment.
> > > >
> > > > Fixes: f26e06d97d57 ("vdpa/mlx5: workaround dirty bitmap MR
> > > creation")
> > >
> > > Wrong commit id, should be the one in main tree:
> > >
> > > Fixes: 398ea8450c53 ("vdpa/mlx5: workaround dirty bitmap MR
> > > creation")
> > >
> > > With this fixed:
> > >
> > > Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
> >
> > Thanks for the comments.
> > Is there any need to send a v2 or Maxime will help on this?
>
> I think it can be fixed when applying.
Then that's good. Thank you.
Please let me know whenever a v2 is needed.
>
> Thanks,
> Chenbo
BR. Bing
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] vdpa/mlx5: fix return value check of mkey create
2021-11-12 14:42 [PATCH] vdpa/mlx5: fix return value check of mkey create Bing Zhao
2021-11-16 7:54 ` Xia, Chenbo
@ 2021-11-16 10:24 ` Maxime Coquelin
2021-11-16 10:25 ` Bing Zhao
1 sibling, 1 reply; 7+ messages in thread
From: Maxime Coquelin @ 2021-11-16 10:24 UTC (permalink / raw)
To: Bing Zhao, viacheslavo, matan; +Cc: dev, rasland
On 11/12/21 15:42, Bing Zhao wrote:
> The return value of "mlx5_os_wrapped_mkey_create" is checked in the
> caller. A zero means success without any error.
>
> The typo in the if-condition should be fixed in case there is a
> misjudgment.
>
> Fixes: f26e06d97d57 ("vdpa/mlx5: workaround dirty bitmap MR creation")
>
> Signed-off-by: Bing Zhao <bingz@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
> drivers/vdpa/mlx5/mlx5_vdpa_lm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_lm.c b/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> index e65e4faa47..43a2b98255 100644
> --- a/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> +++ b/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> @@ -47,7 +47,7 @@ mlx5_vdpa_dirty_bitmap_set(struct mlx5_vdpa_priv *priv, uint64_t log_base,
> (void *)(uintptr_t)log_base,
> log_size, &priv->lm_mr);
>
> - if (!ret) {
> + if (ret) {
> DRV_LOG(ERR, "Failed to allocate wrapped MR for lm.");
> return -1;
> }
>
Applied to dpdk-next-virtio/main with Fixes tag fixed.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] vdpa/mlx5: fix return value check of mkey create
2021-11-16 10:24 ` Maxime Coquelin
@ 2021-11-16 10:25 ` Bing Zhao
0 siblings, 0 replies; 7+ messages in thread
From: Bing Zhao @ 2021-11-16 10:25 UTC (permalink / raw)
To: Maxime Coquelin, Slava Ovsiienko, Matan Azrad; +Cc: dev, Raslan Darawsheh
Hi Maxime,
> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Tuesday, November 16, 2021 6:25 PM
> To: Bing Zhao <bingz@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> Subject: Re: [PATCH] vdpa/mlx5: fix return value check of mkey
> create
>
> External email: Use caution opening links or attachments
>
>
> On 11/12/21 15:42, Bing Zhao wrote:
> > The return value of "mlx5_os_wrapped_mkey_create" is checked in
> the
> > caller. A zero means success without any error.
> >
> > The typo in the if-condition should be fixed in case there is a
> > misjudgment.
> >
> > Fixes: f26e06d97d57 ("vdpa/mlx5: workaround dirty bitmap MR
> creation")
> >
> > Signed-off-by: Bing Zhao <bingz@nvidia.com>
> > Acked-by: Matan Azrad <matan@nvidia.com>
> > ---
> > drivers/vdpa/mlx5/mlx5_vdpa_lm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> > b/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> > index e65e4faa47..43a2b98255 100644
> > --- a/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> > +++ b/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
> > @@ -47,7 +47,7 @@ mlx5_vdpa_dirty_bitmap_set(struct mlx5_vdpa_priv
> *priv, uint64_t log_base,
> > (void
> *)(uintptr_t)log_base,
> > log_size, &priv-
> >lm_mr);
> >
> > - if (!ret) {
> > + if (ret) {
> > DRV_LOG(ERR, "Failed to allocate wrapped MR for
> lm.");
> > return -1;
> > }
> >
>
> Applied to dpdk-next-virtio/main with Fixes tag fixed.
>
> Thanks,
> Maxime
Thank you.
BR. Bing
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-11-16 10:25 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-12 14:42 [PATCH] vdpa/mlx5: fix return value check of mkey create Bing Zhao
2021-11-16 7:54 ` Xia, Chenbo
2021-11-16 8:01 ` Bing Zhao
2021-11-16 8:04 ` Xia, Chenbo
2021-11-16 8:13 ` Bing Zhao
2021-11-16 10:24 ` Maxime Coquelin
2021-11-16 10:25 ` Bing Zhao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).