From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B723D428D7; Thu, 6 Apr 2023 11:35:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D2E641153; Thu, 6 Apr 2023 11:35:49 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2051.outbound.protection.outlook.com [40.107.92.51]) by mails.dpdk.org (Postfix) with ESMTP id CB24440F18 for ; Thu, 6 Apr 2023 11:35:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fTQluJFNEtNyOq0gdhf/ZNmAlcER3eeb/Sv2zdD8enXuLU30HAHql0pDbkEfi4nGLDnWiQcul6QqgyboBA+NnX0wYliHIVhIcXRAhRLwGQCJjaVXr9dgu67HW6PbyW8vSwLHc8E1gwNWgJe53jaRQ+4MLnRnkaFRJKWBFgTwjDIZsZmrEhtYFC3U3o+epMqGgolwLhjtsJiJ1r7cGrLslc0u55FgmllfexUJb8Ff86+JbEguITmkdgGWLBZfxld9jsfQyUBBwbICYVEnY1VpTd8c9vpQNL3z9s7bwk7yVO3FA7ChUgoNScV09BjGPJk+KWU1dYO+4noXrzojJGxRXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z6gArFa+pzdoS5FmIDwF9BRj+V1tNWZE1QRRBBVY58w=; b=Z5nHLf9xcCrwDtBnzfJ6nIks6g8bu4XE6+WASa3yLevdA+r3PRhnUOu56QwMuShVaBg9JV9JiQrtsNctVZQLUpEqtj/iVtTyvuBGm8A5MJyKFY/JPNhTyNqQ2Sw/OfR/5TTj0MIdqtO8uNSBGKvWeNc3QB3rgxSRyAm/TkNqF1bnuJ7KkAU0y5ij+89/Nn90b116Zr2x8wmqhCpuUSzjc4Z+Snu5fp8B+35+vnaQZf/ibfNwdAJ+KyLAOYwiS0nX4WbaTEKDBO26wiyHTbRb5GRfq+Q9qrHym+o+eG4G/oohXbwmfR2Z2nhHTdOYA6rdghvuYsVMOKj4tTVeYg1u/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z6gArFa+pzdoS5FmIDwF9BRj+V1tNWZE1QRRBBVY58w=; b=p6PNUw4WbFpRH9IocpBr4ZvLHMFqcM9cHUBpHMKZsb/Plk3hNHmjRlgl6UKQc52Xvr7Hl+IYUHquwUfOPE17dva/WU13Y9cr7uiYRD6a/dPC4z//ggcrQPC4fNtCjyWuUshZ1QCXgZ4ZXLPZHmm9H1Y9bHpPCNUnPOgRcH1PEhN81XUlsOp0NJ2552jLu+4Jpinj7zmxkF39dj3gDSaXuoSeFqgnvyW6i9RdAqWFly5UEC2d8nYh4ZoFrfN+3h0pmQ9Tuj/AFp+TB4iI4LB7oYOn3pkKnzLWxG3cMMGZuMZQUmM+//YHQ2QX2/YM5poZ3NDflYqgiNAev+saes4LuQ== Received: from DM4PR12MB5184.namprd12.prod.outlook.com (2603:10b6:5:397::18) by DM6PR12MB4563.namprd12.prod.outlook.com (2603:10b6:5:28e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Thu, 6 Apr 2023 09:35:47 +0000 Received: from DM4PR12MB5184.namprd12.prod.outlook.com ([fe80::3a24:2117:c3e3:50d8]) by DM4PR12MB5184.namprd12.prod.outlook.com ([fe80::3a24:2117:c3e3:50d8%3]) with mapi id 15.20.6254.038; Thu, 6 Apr 2023 09:35:47 +0000 From: Bing Zhao To: Elena Agostini , "dev@dpdk.org" , Olivier Matz , "NBU-Contact-Thomas Monjalon (EXTERNAL)" CC: "statble@dpdk.org" Subject: RE: [PATCH] net: fix return type of IPv6 L4 packet checksum Thread-Topic: [PATCH] net: fix return type of IPv6 L4 packet checksum Thread-Index: AQHZaGlj4AqrK+YH1Eu8eeS04S1eh68eA37Q Date: Thu, 6 Apr 2023 09:35:47 +0000 Message-ID: References: <20230406092129.820449-1-eagostini@nvidia.com> In-Reply-To: <20230406092129.820449-1-eagostini@nvidia.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5184:EE_|DM6PR12MB4563:EE_ x-ms-office365-filtering-correlation-id: 20fcf0ee-694b-4bcb-3633-08db36824d3a x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Iuir13giU1sTDqSLYS63ukf4aIEq3UZZ1aYsCc0FNugsvDrvS93BuepFGmWbk9B8b7mXY1pox1qefSUtWvssrsfacxRJjTmn+/I/XNGvqkCfkGecBYGJvFoaH/KHAPzqxWHwTUpzrFDyGwuJS88N565o/2Q+JK22li33vskLFI6j4TSwROwR8TEjaQGTrYiy965EPyZrf+NC0xApzBXrsAI83pE7Ly7M6jg0JmLe/5Tpa22JRi9oY3bW4fDbFfizGSzR5iFS4XNANZ/h3IeKxG91ageALgE86FnGPCHPmEkz5ZfQg7w3MVjBd3f2eNxmmQ515gAAUoWYZwnaBKj3cJWV1309LQcGExqc5GQByt6yqQsq0SuhAvBMO6g45UiwB/jRgTFaxF3aSWg0ox6HUkVFEx3+oPVaLB7/jf2XbdIPz5ogfCrRtWBvDJcaosjffy7weOyRv6d1+lwSA1ZwXc0PMzRGAdcdeY4Pui0g9V90MVvAcvj0tEAHWY/dOW2wEbm8i0NexvBO6963nBzRiGJI66qqiQ+r8Cr2mv72aNIGlCWWuZHObdXDsKarhTugwMspio4K0HkgQWpHA7cirXFLECpcBPhe+oveKRiQDvRb5uRyzVnfzvIJeu/Jtxdj x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5184.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(366004)(396003)(376002)(346002)(136003)(451199021)(52536014)(38100700002)(33656002)(5660300002)(2906002)(55016003)(38070700005)(66446008)(66476007)(122000001)(4326008)(8676002)(64756008)(86362001)(66556008)(66946007)(8936002)(41300700001)(76116006)(83380400001)(186003)(6506007)(9686003)(26005)(53546011)(110136005)(478600001)(7696005)(316002)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yZQEXiPtL8FKcSAvIz/QDIqxjgmCCnYDq0hVhmMztRU3XvXr8+vy+LH2sM/f?= =?us-ascii?Q?PvoZ8g7YzLIB/mFrTBCepK3wHUlwX/FroTEqOBkZJxb3YuRBiVMNVSEst7rm?= =?us-ascii?Q?iEKEbQEd9CIZjtrBJapHNJh1fc8uwax76F0JjjvitC8s04gUPbsK4wAstC5h?= =?us-ascii?Q?L8Hu775fqK0MzbFkge5gz55Y93UCfTxvcz06a2Tx2FQo5gxxv6S+MQEEiyIl?= =?us-ascii?Q?0iO2EJvsLYG0yoXd2ZLQbzM3LwuAL9RGeWY00HDvKqKY9Qdoh5VkavgRdpTE?= =?us-ascii?Q?9q9uOkWEHjNSt8Uj6FO2VQFsPq77LZUqKaI0+nDVvUQTub6w19cCYsjqxOmo?= =?us-ascii?Q?g68ucPK4KbwORd3TRHrRPTTJgvOZgD+2ukRNZO2ArQZxr+vWBAHXimF/A9hh?= =?us-ascii?Q?BNFjvruqjsHvTZpxKgTnpnj1s1P9CPif9gyqyFxFm+xpUOTP94RgJGMyIF4P?= =?us-ascii?Q?Qql08bIsrwfFaW4tm5MYhNmrGF2QJZ7pckjVMWBIG1J/DPgHoR0nTxm6FKHV?= =?us-ascii?Q?kdXyUBlnKhCp7B5HL76eTeW2Zei8kwQ+Ic1eQdjS+Dg/BEcQeNRzIv8cKrqR?= =?us-ascii?Q?GCriZHNt+j2tlFchEnDoER+h4mlijKto2VIw8+9VPb/dyYwq/ZGNIIsZLcnu?= =?us-ascii?Q?etSYAk0a56WoVaKU+YJdlNJ1tbk161WPq9y1aOEnjMD1jWlSzgDFB5kIG9OP?= =?us-ascii?Q?+bCKuK89fpOKCYByXn9DHZS4cTOX09oD+805YmVUum5TXmCxHE1Ni4S8Urwa?= =?us-ascii?Q?UqliCjGz2vuB/tequ/ybhwpVqNIXrjsBEgP9GJeEnJWJcstz7cRwFb0ZuS5V?= =?us-ascii?Q?/gRxwanpMAXTSfSRHxuXgaS++Rm0WUMiH8sMhs2mAd3IZxj8p9lJm4E996+t?= =?us-ascii?Q?cblEM1AFbmZdotz53wNLA3AtN55RQIkZD1LNE7uXeRSHIZ2539xb6LQ9P8a1?= =?us-ascii?Q?QLb1DZmoD0dk76ZzYIlqkWKWEHT6Xse6LH71PMFCzJ917W7L+w4JgBIEs2mj?= =?us-ascii?Q?CK22YTbrfW9xWxGHiLxQTaUwRfRnhYXOSOGATZAW3g1o0f5gueP+KVoE4YML?= =?us-ascii?Q?ZwOVlEHm17bI025pLoRioApJAhZeuYhQ5/nQd/svuYp0jY2w28bHEOmjTSIT?= =?us-ascii?Q?764fJpUmRyBC1OcifKOQ8mzklpmnNs1oaKXjkFZmcrqo+LVNXO4kZ7vstoOQ?= =?us-ascii?Q?fe6zRimpspge1dPmHJ0BTtKDsUq8DbGdwZczSO2pb1RQMS7y078GrrUA9lpm?= =?us-ascii?Q?DDu77daT6ELH9p1krXLFsWUS0V6OofNhKIxF5KLs4mv2iY2NT9UBGsJnv1Ga?= =?us-ascii?Q?6wYSnJNzjMDIZ+SFpNoaGLORBiUCbehghCFLPnACQSjfoj3V+H9NslvOOLep?= =?us-ascii?Q?k5QBmBPME2Gpb7if0joqExGS72JMGattElJHfJXn+BMBJCYKAVx76EwXZ+QF?= =?us-ascii?Q?XZWlCp18Gg1fJ6ulHzMOdtoUUdOxVjcSpCPb0bu+n69JS5lYM2ZRRwBI5594?= =?us-ascii?Q?7hq06jj9ZmLQtulUbW9c8AShKNazZcMf/wTdvydnyCZQLur1o0BFmEJLmefs?= =?us-ascii?Q?byRTLM1V4CLATMkuOek=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5184.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20fcf0ee-694b-4bcb-3633-08db36824d3a X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2023 09:35:47.1910 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BfP/hprYVKr127H/Y7LNvkdxjQed9fiHer8yeIjug3yW9olpc3XpGpF3NUen6XVE1ALhCvqbT0F1WMixq7SkUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4563 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Elena, Maybe it is better to add a fixline here. BR. Bing > -----Original Message----- > From: eagostini@nvidia.com > Sent: Thursday, April 6, 2023 5:21 PM > To: dev@dpdk.org > Cc: statble@dpdk.org; Elena Agostini > Subject: [PATCH] net: fix return type of IPv6 L4 packet checksum >=20 > External email: Use caution opening links or attachments >=20 >=20 > From: Elena Agostini >=20 > Function returns 0 or -1 but the return type is uint16_t. >=20 > Signed-off-by: Elena Agostini > --- > lib/net/rte_ip.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h index a310e9d498..e71062= 56aa > 100644 > --- a/lib/net/rte_ip.h > +++ b/lib/net/rte_ip.h > @@ -514,7 +514,7 @@ rte_ipv4_udptcp_cksum_verify(const struct > rte_ipv4_hdr *ipv4_hdr, > * Return 0 if the checksum is correct, else -1. > */ > __rte_experimental > -static inline uint16_t > +static inline int > rte_ipv4_udptcp_cksum_mbuf_verify(const struct rte_mbuf *m, > const struct rte_ipv4_hdr *ipv4_hdr, > uint16_t l4_off) > -- > 2.34.1