From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E7DDA0C4B; Thu, 21 Oct 2021 12:36:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E121F4116A; Thu, 21 Oct 2021 12:36:05 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2058.outbound.protection.outlook.com [40.107.237.58]) by mails.dpdk.org (Postfix) with ESMTP id 75E72410E2; Thu, 21 Oct 2021 12:36:04 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CQs5hKJDgKoMS2uUZdBPrYRttHEPclU9xaLFxTLzcSqEpsTY54l3WCqVhgVBvMBZ18DoQT8zXVc+liwiNuoYw55BYeDk8uMz2/LqES6aaFvJ5VccFUfTyekTA29dQvJ5WRVZq7eccRko3KvMk+46JniZHH8p5n9jZKsLio+zGgRObK+JR35AMohNrjAJmGBeaaVRpnfyGCmM1Up7rWui7QYKqnqzreO5uhI1dqOTACJIgSl/CAFVn1EM2zLMb+hwXeTB/u6HA46rG7C5gTDNwa8Gh7StB2qCOkyfY6CYnl+4uiThLMN8TIvwcEZqUJwr+b/NkWu2rfmgH5IvOHOP4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eqrN8Muhhr+98uuGZ+Vm7HVV+F1PSAvmObZnpuu+y/I=; b=ketECW8MkguGYlBmBkMQztGZSZcYPmoBp/8SgQKdx137uOkPK8nAR78L/8PquQxs6Y+bA8LAhr8V08vLFY6p9J53DyWSi+ofOmLxHi2qqSri0PrK5lBysS28k2f4S9akurBexVuWc/j6QcC6OLRoEqTnN/VvzaPGXNG6l/2VgzOoM3FO3UgTu6E8vOOz/UQD9AioM2szAGXHT5XB5HLdFpvATyY6Sz//1Qx+FO17BkdgWbPxH1o8H2ihVaqacKmhesktvoKOQAk8sIfHaClTz1gOxcJDFNl8vJVYCNP9W39wM4rsUEQ8M0TkukMvNT9UriknfCzM/ND8iitsG+iDSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eqrN8Muhhr+98uuGZ+Vm7HVV+F1PSAvmObZnpuu+y/I=; b=KvfVvnDI9rg0MYL6aaPaf4EElLkTCN3z+x/dqc4JJvdtcDhJghCEpsPWMxFdMoSIPhdBB4zPTbK5LY9O2keGa2m5RCsaXhTBofBUSjxiuOLhdUtSSSkipIDwTknnizM5vrfDIVL8F6qqjbJqIWUYi7OqAAqbkATa9rarj2yuTRg5DYL1mzzNWXKZZeyo8qSuZBjoBLzYslkgNnU8FDN4sZivw9APBZkL2WsxrmdWBDtvGnYXHf7bsW2INF4qFkCVah8oRFmDcgwjmY+s6zKN1HYt6i+dwr/YaNhoCC531u7bQmM4PJ4fcuUMKcvNCj1DwxMC9cSqys6Su5f2pL4UQA== Received: from DM4PR12MB5312.namprd12.prod.outlook.com (2603:10b6:5:39d::20) by DM4PR12MB5101.namprd12.prod.outlook.com (2603:10b6:5:390::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Thu, 21 Oct 2021 10:36:02 +0000 Received: from DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::a4bc:7da3:32e5:1665]) by DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::a4bc:7da3:32e5:1665%8]) with mapi id 15.20.4608.018; Thu, 21 Oct 2021 10:36:02 +0000 From: Raslan Darawsheh To: Dmitry Kozlyuk , "dev@dpdk.org" CC: David Marchand , Raslan Darawsheh , Xueming Li , "stable@dpdk.org" , Harman Kalra , NBU-Contact-Thomas Monjalon , Matan Azrad , Viacheslav Ovsiienko Thread-Topic: [dpdk-dev] [PATCH v2] net/mlx5: close tools socket with the last device Thread-Index: AQHXwNlLT3Y8gMJUL0qkIti4N7dpD6vdTQZg Date: Thu, 21 Oct 2021 10:36:01 +0000 Message-ID: References: <20211014085026.2991677-1-dkozlyuk@nvidia.com> <20211014085528.2992805-1-dkozlyuk@nvidia.com> In-Reply-To: <20211014085528.2992805-1-dkozlyuk@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: oss.nvidia.com; dkim=none (message not signed) header.d=none;oss.nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 97411474-e963-483d-8086-08d9947e9442 x-ms-traffictypediagnostic: DM4PR12MB5101: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: O49sCoHTj5DuPo6sqb54eR/po6h8RdykdJruR44utkRmdUkObBqBsg0tf7fE34hfxAFmmY1GQAK0YCAD26QH7AbyBwhVsA7zVu2Hd6OwyHbKZx8cvYSo7SPMwFaigY/mude7BGWQYyPEr6Jona8f2iKUytyJ2WzHkM9hsgbQSq5bVfZVWtNeEwsI2z5f4HkGH6WNr2b3v99dZBJaEqzkuoufovPUDRfDv80Y7CQ7RB9UBlMclMivAC6gaind+Fl+759WmotSCp5THW4LM0twZIQFFoJ3wNVP/a/AH1m9vthVYorT6P1ZCoFAp4obG/ncbvHLBxXJIuj0l0VuJuzHzN7lERNdmsntDuPtYKy4CJ0dkwKuLyiWIW82Zir+ry52PhJ4ALtWqtEJNjarwGlnYYXI75pQN7v1m9wkiCBEW7okmSTZtfBqgRF+69+n6YK0MKGspypIh4uDDlo9qW/RpTtR+FxG6JbOsKKXT0cW/hD13xgn76cCJSP7Ppr/BBiWwJmjSaqe6GobUCyYcgLJMzxA9frhGrupK1mYBtEL7PBG3xQr3k2jgJbXZHjxcxn1k3kZAA4olg4pVNsKQ37ZHkeE0UPZszUafmAl/Jz+XeT1mnDTKBaW5vcxYdqKJcQQ4QQhF/pG2xAxA6slI2c40TKQe1P5TM8BoYELXasiLQT1/sLRx2zNsgw9rJtZPWJrikkI56okqa66a5kYb5MLjg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5312.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(55016002)(76116006)(38070700005)(66476007)(7696005)(64756008)(66946007)(66556008)(71200400001)(52536014)(5660300002)(508600001)(66446008)(33656002)(8936002)(6506007)(9686003)(54906003)(26005)(83380400001)(2906002)(107886003)(38100700002)(4326008)(316002)(110136005)(122000001)(8676002)(53546011)(186003)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZdO7eoMJz3LrG3IFm4winAYp+zegjX0iv3KMhNh3kC4DT2pkiUveNFwuylTO?= =?us-ascii?Q?srw3i6Afo6+WL7YVgFXDFWHcVnT/02cxi5Gz30i5pE4NQJ3fVePngQCSQVsu?= =?us-ascii?Q?QfQ4310UJLHFHgj2vjXZ3zMc1pz/9cF7mD+VHY2cZxp6dx38siwlTIh0ngko?= =?us-ascii?Q?bezbdSZKKJc93mlssUWH7t61FTlaHHM+RXw5ZP4Z1YwOdo674YOylAaJtjdz?= =?us-ascii?Q?hlC0coro8pAYqK7e/GqT6dWPZ9GVDy6DqLvNMY0rOtmEwjXjiOzeES3NWfMf?= =?us-ascii?Q?1Gno5LE8pbPnOsmgNKIldvlo1sWNgnm/UVqKYv79uUsKzuL9yFloV65c9klM?= =?us-ascii?Q?qIziY0L+vtuSvha9lKajq6AHuArlz5drumK8cBWaKKAHkpD1x7R5xcdgzqL8?= =?us-ascii?Q?JDZfoqDJG07wrpN7ZltI6DkysD4COOfEs8U94j43KrYZ9eWzQoI34qr+atsc?= =?us-ascii?Q?WgqKeKP20K8xKE8S/jM4bVj2zBY4gKgwpVP3rjM8KjyP7Yij/JR8nsjCBKd8?= =?us-ascii?Q?05OCQKmeRxO9sOEdY/6nYvjYO0HfstZCX/FSXpmx0LNcTycMsaOtFqt7abYx?= =?us-ascii?Q?5McHUNWvVcr7gaSE2ExwkOGZw9RCSBDwnC32parl4GtikMi3ASziB+okyYL1?= =?us-ascii?Q?PxPnwouWu1QRW2auI7xerA2eQMbvoB7hmYZAlLJ0Mbrt3AcyzYlDNT6R0Alb?= =?us-ascii?Q?rLdl6RXJdQNFL6ef2r7gB/jKU81dTX47NiC3z8j0Xb91oB7vfeNt0QRDDMVg?= =?us-ascii?Q?F9zt0n+XiZnqFtJZMihuzxnxgnyjIDm3DX56bqRWD//uygaQDStzsN2BUHkw?= =?us-ascii?Q?LpzE76EQo1BLi+9TrzQTAs7nSapygRZ/5hY9qDy7bIOJl35YbPbf9yhjDuUd?= =?us-ascii?Q?PzzffgB6MXI+xIhtJq1X8gr44RDDy9Ef6iiqgaVrziV4/cdTGdNg1HtO+pk9?= =?us-ascii?Q?0mUJM7AjCtWZGDeSXqmCRiwtsrg/z3USlQtC5y3zWuH1xQMJHEed2/5xWS2a?= =?us-ascii?Q?dYvKjZgtafWPK567RXDicatpSYr0VYelMIvWpRQk7//Dy7yExPx7XnliyYa4?= =?us-ascii?Q?K8MKmyvYqUrcRqLhQoDTyE3nNtpBn8Y1Ge4xBlBariMMOl1+izwLX4/mAKn0?= =?us-ascii?Q?p/swRUh3mEQjpu46zHSWwTHmORB3voS0S4TZ/0KYNeNzNdYl+c6qYF+HYHXa?= =?us-ascii?Q?tmjdO0kzULho1yqbu1GRZypfWlw0Hf+dBX8TxVTB3BwPGOrqoPjY66CLHuX1?= =?us-ascii?Q?z8XoMvB8l7p82lbs69I6yCUxbPO/g5WfrKOzN6RvfLba1ZbnVOju1mhPFmkc?= =?us-ascii?Q?iERowrhCpbvz3D23mnRiiU0T?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5312.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97411474-e963-483d-8086-08d9947e9442 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2021 10:36:02.2707 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rasland@nvidia.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5101 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: close tools socket with the last device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Dmitry Kozlyuk > Sent: Thursday, October 14, 2021 11:55 AM > To: dev@dpdk.org > Cc: David Marchand ; Raslan Darawsheh > ; Xueming Li ; > stable@dpdk.org; Harman Kalra ; NBU-Contact- > Thomas Monjalon ; Matan Azrad > ; Viacheslav Ovsiienko > > Subject: [dpdk-dev] [PATCH v2] net/mlx5: close tools socket with the last > device >=20 > MLX5 PMD exposes a socket for external tools to dump port state. > Socket events are listened using an interrupt source of EXT type. > The socket was closed and the interrupt callback was unregistered at > program exit, which is incorrect because DPDK could be already shut down = at > this point. Move actions performed at program exit to the moment the last > MLX5 port is closed. The socket will be opened again if later a new MLX5 > device is plugged in and probed. > Also fix comments that were deceisively talking about secondary processes > instead of external tools. >=20 > Fixes: e6cdc54cc0ef ("net/mlx5: add socket server for external tools") > Cc: Xueming Li > Cc: stable@dpdk.org >=20 > Reported-by: Harman Kalra > Signed-off-by: Dmitry Kozlyuk > Acked-by: Thomas Monjalon > --- > v2: add Fixes tag >=20 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh