From: Raslan Darawsheh <rasland@nvidia.com>
To: Bing Zhao <bingz@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Matan Azrad <matan@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix the RSS consistency check of meter policy
Date: Tue, 9 Nov 2021 09:57:16 +0000 [thread overview]
Message-ID: <DM4PR12MB531220A1725889945E216250CF929@DM4PR12MB5312.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20211018144307.148246-1-bingz@nvidia.com>
Hi,
> -----Original Message-----
> From: Bing Zhao <bingz@nvidia.com>
> Sent: Monday, October 18, 2021 5:43 PM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad
> <matan@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>;
> stable@dpdk.org
> Subject: [PATCH v2] net/mlx5: fix the RSS consistency check of meter policy
>
> After yellow color actions in the metering policy were supported, the RSS
> could be used for both green and yellow colors and only the queues attribute
> could be different.
>
> When specifying the attributes of a RSS, some fields can be ignored and
> some default values will be used in PMD. For example, there is a default RSS
> key in the PMD and it will be used to create the TIR if nothing is provided by
> the application.
>
> The default value cases were missed in the current implementation and it
> would cause some false positives or crashes.
>
> The comparison function should be adjusted to take all cases into
> consideration when RSS is used for both green and yellow colors.
>
> Fixes: 4b7bf3ffb473 ("net/mlx5: support yellow in meter policy validation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bing Zhao <bingz@nvidia.com>
> ---
> v2: remove unnecessary parenthesis
> ---
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
next prev parent reply other threads:[~2021-11-09 9:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 13:16 [dpdk-dev] [PATCH] " Bing Zhao
2021-10-18 14:43 ` [dpdk-dev] [PATCH v2] " Bing Zhao
2021-11-04 8:56 ` Matan Azrad
2021-11-09 9:57 ` Raslan Darawsheh [this message]
2021-11-10 16:16 ` Ferruh Yigit
2021-10-20 19:35 ` [dpdk-dev] [PATCH] " Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB531220A1725889945E216250CF929@DM4PR12MB5312.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).