From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 040F1A0C4D; Mon, 8 Nov 2021 13:57:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D71B41122; Mon, 8 Nov 2021 13:57:32 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2048.outbound.protection.outlook.com [40.107.96.48]) by mails.dpdk.org (Postfix) with ESMTP id 7256240E28 for ; Mon, 8 Nov 2021 13:57:31 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=djeH3MmijS+2mIoK5vBMCFLg/WmVMG3iXbdVJ5J+F7bC5drDg72p2XzK3ZoWo2CYrXIBpqwM8CebPv9QstmDOVzZkLy4L68PpM9wtWqTxJu2gkdxcyw4//ISf9OR08HmqKquo/ZD1E6RhCFP083Ag5pJYSW5Tzg76gHn9Anoc5Vw+7o+Ys30KsbrqOQCk5W/pwMCPujmgFYjmYFD8EKUJQ5yqezP4Wy73B9nEyGdQ/v7QisBHNqyzelxiWBqUo+Pf5PWWFG4EH2QNzs3l46xl3X/mmHknFa2QtEW82Zfrw1ZIXQpyHySwVsCD2E0S7w6iGbkuVdc3bIGaFZs4bWOsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=30bKRrlnDKZ/tSzqhtpnxYghY6TdxFQiugbhJ/txb0k=; b=GBH2RysDFIlqe6TrSt2o1tL88lqAA06gDzW4o6Uz/gow/Z+IRug89T88iq7NonSsHi3RldVjM5SY8QTaowoWNMkdzYz4hceTlnRKDFGb0WTZEHPCrYpcISG36uIwmPIYtCBHWR5SlhVWp+SlKywmXxYzGUmadqzNvOkLFIpNXP7626GXpuhajRuG6wQXQFtrX8MtXawYQ6munjt9DylYRrlKqjBL933mckqbtauYGhuO6vat8b1bnNt2RFxrFZWQ6v06mPB9XknI30G+dLnuODiloc1C2SXCsNvAYeOb6kez6dpiJ4B5NgONW0eW+0NfFt5ztcuiweQ06NnzquILWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=30bKRrlnDKZ/tSzqhtpnxYghY6TdxFQiugbhJ/txb0k=; b=omq+0PeJloDY/IzIHvJ5iQxtu+1lVAuA7IIgHm1Gl0z/JShwMwEnapwZTCwUfKo6xtzQxv+wRBdydzIct9uKLj6hDZVDLg2c5uY0EBGS3WcpNKGIr81R3BgEXQvI+fQAM2he0kVMTiQu8EUpTvT4ZpqiLJqbrj/GLV5DnJfe0hpnFieWIdcD8HBqVpYzm1eSwIoZO3780gb9DUB8LC/whcXSDjX8nqCLpX8pn64Zk76+OShRIWcv5zfRaazw6zdLO8teEaowR0qzA0aahGQyGEaQPvdZ9JCN6omEdLFNz90br/I1f4Qm4cRg9igoH86KSjIF4uIydnVDAr04wh7aRw== Received: from DM4PR12MB5312.namprd12.prod.outlook.com (2603:10b6:5:39d::20) by DM4PR12MB5168.namprd12.prod.outlook.com (2603:10b6:5:397::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Mon, 8 Nov 2021 12:57:30 +0000 Received: from DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::7cf5:9d34:fc6b:b4a4]) by DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::7cf5:9d34:fc6b:b4a4%7]) with mapi id 15.20.4669.016; Mon, 8 Nov 2021 12:57:30 +0000 From: Raslan Darawsheh To: Dmitry Kozlyuk , "dev@dpdk.org" CC: Matan Azrad , Slava Ovsiienko Thread-Topic: [PATCH v2] net/mlx5: fix split buffer Rx Thread-Index: AQHX1JI8OkrqtzG9eUm0vJoW7EoVAKv5lyYw Date: Mon, 8 Nov 2021 12:57:29 +0000 Message-ID: References: <20211101095646.840095-1-dkozlyuk@nvidia.com> <20211108111716.1311979-1-dkozlyuk@nvidia.com> In-Reply-To: <20211108111716.1311979-1-dkozlyuk@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f4966afa-e56d-4433-4f12-08d9a2b752b7 x-ms-traffictypediagnostic: DM4PR12MB5168: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ejoohFBCCRa2XoC1vyNE2Z4F8BXlVYD00WldZGWKmyBD+0LSJlZCFa0aNZgvDI1b/j33+e473SHmMm3OuS2FLN9FTR0TStGtBMpt2xcEu+c7eGrZnCqKwaltQBF654ZmWiJ9GTNqgwn+pH8SzzLkWk4jb3pegsDIXT0MHuFrAEj1oJJfA4vSfK0O1DSn3WUVTZscgF4lSq/0kQKxBg0PGXuUheF3cJLC2WiUAk5ZPyITFYqnaLgD0oIb0QZAVOFUrfXAG2XYJf7KJRmEtyzCU+5Y27v8wKbl8pvqaHVSbR2RmUs6GaexiM9Pb5LImNekWGOUA00UQczF8A5rW7gWl4HufWJL/3b+blHXd8Fr2QmvqVzGaxTbMt359nRjPjy2p7nXpCp0CJHbv/VQmES8WT9FxE3bY6Du2YqCGliFGY7AdDFjc0FJO6OEsXJXRja3QzIhXenq9ORy/iofsnJ4UOkTcYbBqUwwqedERxqh5KYkCRI1htwMYfBONV01Bw9m0VU7G8e+/J78XJtx69rdxLLRs23y2PQ8fF0giFVWYj4NtcFm7YcW1hOOz7VYDgeITwic0xXOMJ3faeGjiIzi3NDOGhcZv+Y1xqFxD6DaarJj2p1eN05wt8WUYnvZQMXXZg7YZ/QdKhzUhFLJzfKXehGEVYZp8yJB7AkdXONWdGsFRY+Bd5Qoe0dUkodWPWcvb0qARIJHHXLAAoDlxxPzSJBm2wewsSE98G4Ix2flYhU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5312.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6506007)(26005)(53546011)(7696005)(186003)(33656002)(52536014)(86362001)(110136005)(316002)(2906002)(54906003)(107886003)(5660300002)(4744005)(66556008)(64756008)(8936002)(66446008)(66946007)(71200400001)(4326008)(9686003)(55016002)(38070700005)(83380400001)(8676002)(508600001)(38100700002)(76116006)(66476007)(122000001)(83323001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0n70L+4tiRUQGD1/G5NZkt/pjQiHOUwhEF9MP/hMMTc/9S2XsqAJJQ/SiM9E?= =?us-ascii?Q?4VFwjc9H/yimE5NWzNJAEURhKIf1ro5vFsR8l7xAZE6fpUP9ueEnfo2BZy8z?= =?us-ascii?Q?Ev6QiSuwqfKDCZbyh+haGjqV05zvg9TuYXVfVEalI26vgrvmXoUv193aY+Cn?= =?us-ascii?Q?O5mKewSEu3wbmuL6ghATyzSjXFc+B0lgNXCOUlXLiQl/aJJDZAjSQk7dattn?= =?us-ascii?Q?etcaqUJbgLGcJAY+tCkOCHRoq/LKkcotozYL6XKX6Zsloa6osGQRouB/rTBH?= =?us-ascii?Q?WaoA9Zq//dyLyGtwi6ZFHBM9y/CGmJzuUdjXjKlRrPvCK5+8C2SEXtJawQyT?= =?us-ascii?Q?IT9yOM/25SfZcvywgrG4x+0t5TFlfqNSqH+Of8b3aVCjT0GiIwUr0g3Ncbnd?= =?us-ascii?Q?fMW4I+pmOweNtt8sSGR5gwkFhCzi0VKwRrqcHZhAK+RGPdYddSZcDAxl6+cO?= =?us-ascii?Q?8LlmjFcXnoJUEHsIQzIJ0lwGyGGMkx15uS1Kl8X8Aoe02KEtUdkDBY3CEYBP?= =?us-ascii?Q?bVJCr77Ne1ughGNTmZVfBbGWJqlyGuLvAC+popvhv/ln7RViwS0mZ+PMtlPr?= =?us-ascii?Q?7fRh5ZQ1McL3odwOp4AWxNVA/OSs9dtCgm+ijI/nhA0te3TEyupOhrcGguMD?= =?us-ascii?Q?cpIYNGR+EPbwrplOx7t3uWx0BMAFozrwOOJ87ulucFKP9eq8mIM6riYUED0e?= =?us-ascii?Q?6tTW/wBqeEmceoDk8Mbgeia88i5ZaQ3HdAeEXQSHHwr/PQLlyD/DutCJSdg5?= =?us-ascii?Q?a8UhuUdUnvnW4rYQcHcsSKF2kKrIxZ1fl1EJ/b7W8kXXo7vF/sUoFD2v4wgN?= =?us-ascii?Q?gnsZKrPGuq6eqaV+GRCOv6PtukdGjaFkAKJNxA6MatSDYp2nTXDXllMNgyz3?= =?us-ascii?Q?TEF9viDYZF/19lh0V+/WoY4sxMRzg+abaF0KSq4fJIGucvMy3HhCXGwuRGD7?= =?us-ascii?Q?zVDyhQyQXepNCcAsj39EgLtOsDUQoaPTLlKhuk6RSjw3CIUnSVG3FhnQevI2?= =?us-ascii?Q?tQoYBrsNripnDnkTFabC2NJVZx0HpVfQp6cUkv8o5WuXdRAHTMEOk1jZq9yd?= =?us-ascii?Q?At9zfryLsiii2DYEL3WS9qOeDdQys0YP/Ldm13ded97YKNRVEJ6sHpD4UFGo?= =?us-ascii?Q?KAtBirSRjkjoN1bATTcf58as+mRTqIN/4m5LG0QnbAdnJHK7eVG17lgmmjm0?= =?us-ascii?Q?LPs9cK2s3DnXAYWnqZH8WS1vbzNXXTDJnnXcjQIXUpbpxqmOm0tobRSrzCgX?= =?us-ascii?Q?NnB7jB8WJDEAOiQ77vsqdvcRkNAt7kz5vX0I3CIlnWT/Rk8qIijPI+bGYiyq?= =?us-ascii?Q?1k3JQAr0f5u6mcc4r/5MCP0dgFeqkm1qytszQ9VuvFuAgq51chqtRZMDuhIN?= =?us-ascii?Q?3Fof98tiw2SQ/UydUy2Y6Mc3F18j2zZNLA6lZLuozvqWIvXtL7Gg+BaFW/LH?= =?us-ascii?Q?V5nFBLlc4hdEIwnKCCBrQYfNs4OSV3vLsSRE0Xx1I+q3EKcT4qoBfhuc8KVN?= =?us-ascii?Q?EbyZJAFKJrrX/Q7CeU5Agn/TNpXzSmKni5oTbE8ui+O20nqgf17VemocmrW7?= =?us-ascii?Q?zqTl2TSZRu3SinauKSvP9tuBjAbCJ++118E/2DJj+Mq+kC81n9n2FQXQVPIA?= =?us-ascii?Q?/QydQew92qWoYxeOzQO6h7A=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5312.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4966afa-e56d-4433-4f12-08d9a2b752b7 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2021 12:57:29.9478 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: J5VUbIegXsTjDJrStYI8PCHk15SOqDu24pXR60rCxoAeM5oheiRkGKw1Q8C3xpyWbUBYGJEAwU9ZoH+gFrgSYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5168 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix split buffer Rx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Dmitry Kozlyuk > Sent: Monday, November 8, 2021 1:17 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; Slava Ovsiienko > Subject: [PATCH v2] net/mlx5: fix split buffer Rx >=20 > Routine to lookup LKey on Rx was assuming that the mbuf address always > belongs to a single mempool: the one associated with an RxQ or the MPRQ > mempool. This assumption is false for split buffers case. > A wrong LKey was looked up, resulting in completion errors. > Modify lookup routines to lookup LKey in the mbuf->pool for non-MPRQ > cases both on Rx datapath and on queue initialization. >=20 > Fixes: fec28ca0e3a9 ("net/mlx5: support mempool registration") >=20 > Signed-off-by: Dmitry Kozlyuk > Reviewed-by: Matan Azrad > Reviewed-by: Viacheslav Ovsiienko > --- > v2: rebase on next-net-mlx >=20 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh