From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 59E8EA034F;
Tue, 9 Nov 2021 14:40:14 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 32CB040E03;
Tue, 9 Nov 2021 14:40:14 +0100 (CET)
Received: from NAM12-DM6-obe.outbound.protection.outlook.com
(mail-dm6nam12on2044.outbound.protection.outlook.com [40.107.243.44])
by mails.dpdk.org (Postfix) with ESMTP id CDAF14068B
for <dev@dpdk.org>; Tue, 9 Nov 2021 14:40:12 +0100 (CET)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=SfCzQDs8GwFLxNWdC2ISvaLBp2faGMo/ykKEAECPqq5XVYDRynvJE/UiaT8YCc4JDV0cGGc75Njc/3eVTDOU/4E+uJdRwuejb5ry9zb7k65EUYVljtMK5XPhtRpVk8RPNqq09L0Eb35DvK/L94w+srbHkU+0e8rAEAHDWdEp6uJgN+tnYzemscu68N5741ylmMEp7WnDyA0scNA1Vb5YelNciQ5lG075ztsAA4ulUDroX9GAUirmCs0wtUAIZKAWtwBn5yuezDkeBRFr2Ps0Sd3ydv4KpuVY7m815KSfR4NziT6Qo1Bp4O7kFFeeQrN3gttUwq2lR8c3Nwj5g3dxwg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=yEiY7AWe5QNh6xm/NL6xpCwYvnq97/RjIdXunVE2bM4=;
b=PiNxCV0od1sxFWa0VCpNnGUHzUC5VmZquxUeUdOB5GPX86owT6/c/PDwQqWnB96W3bamkQ9Of3lbivyRQtmxGjwd9+uoIZ3dz8TR9DnRjHLErbvSKwg6ZVJ8RAJ8j9YKoUl4gkhADKjt2bm/8LvCn3naU5HwHfaRB8A7apKIUvDscLN4kDB6MCzdSO92mHzq0uvMKYqr6WdDK7teFJocaKdDn2uTcSGDdh2Q4YETpD3C0gQJC6kceFq+gwsLZJodnr7UYp+OuzA8a1br3tDwa6MTJFNJmV/BUNITV+zksDEKqGunU35sYGd75ysnvCBN//aJgJQbKlvRR7dBvpsMzw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
s=selector2;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=yEiY7AWe5QNh6xm/NL6xpCwYvnq97/RjIdXunVE2bM4=;
b=AO+fbHLQbUB6bu+sY+9M/FSgZHw2IU7WUYyVHgbA9GtlMRI80pa70rkqX+Ff8o8QYtDv1qq+yJxaEAMJivn2beMyKL5iUZuv2IBsvy1yn8jgLUINulw5pMUjW2dHZEXTYwlUyfRFRlvRSrdoMaFv75Uzn+wJCMBXQxzeOAdJjlBo3W4xwymGvWTNC7eqJcE/GnfDo/dJCXLwrLRvgn5xwTsHXl9S36FRMma2eBPpJ42AhpKlv0Ku62HIHKotn6UkxvuNPPluRoGhC4PApnu1PWJWScbzwHwUzGNRAIH/GxWe+L/1JrZRtEi4WPu8YbjJOzhYGQ4GDDXFyJ+6yrBi4w==
Received: from DM4PR12MB5312.namprd12.prod.outlook.com (2603:10b6:5:39d::20)
by DM4PR12MB5199.namprd12.prod.outlook.com (2603:10b6:5:396::14) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.17; Tue, 9 Nov
2021 13:40:11 +0000
Received: from DM4PR12MB5312.namprd12.prod.outlook.com
([fe80::7cf5:9d34:fc6b:b4a4]) by DM4PR12MB5312.namprd12.prod.outlook.com
([fe80::7cf5:9d34:fc6b:b4a4%7]) with mapi id 15.20.4669.016; Tue, 9 Nov 2021
13:40:11 +0000
From: Raslan Darawsheh <rasland@nvidia.com>
To: Dmitry Kozlyuk <dkozlyuk@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: Matan Azrad <matan@nvidia.com>, Slava Ovsiienko <viacheslavo@nvidia.com>
Thread-Topic: [PATCH v2] common/mlx5: fix external memory pool registration
Thread-Index: AQHX1VU4oMWF0upFekCITvneQp2YBqv7M93Q
Date: Tue, 9 Nov 2021 13:40:11 +0000
Message-ID: <DM4PR12MB53125285B982E18CD7DA94F0CF929@DM4PR12MB5312.namprd12.prod.outlook.com>
References: <20211102065917.889267-1-dkozlyuk@nvidia.com>
<20211109103253.1938561-1-dkozlyuk@nvidia.com>
In-Reply-To: <20211109103253.1938561-1-dkozlyuk@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: nvidia.com; dkim=none (message not signed)
header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: dd6b2a0e-dbca-469c-49e9-08d9a38673c0
x-ms-traffictypediagnostic: DM4PR12MB5199:
x-microsoft-antispam-prvs: <DM4PR12MB51991EA5AD87DE3AB8D3AB0ECF929@DM4PR12MB5199.namprd12.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3276;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: wjfR1wgeRkOw06mW18DiULlw/oVF0zl/CBYmA3bK9NmITKxHphx54Wkwon84+g0aQZgZ3+s7Ea0MhAZuEjcIsnZix/qPHJFXqML+9MqKGymngGiR/VxEihtFX2CLuI93BMhOWzY9uJtcwdEtaqdCZ2wGpBZ2KkGaaKZoMsFe0tNyRcqqTTcAwPe/WAhEr6scKxLMtlkUyaPGdCtc3k44FfMASiy+Zcx7GL+xp2gQEJP5ymMlFmd2cFCx45trSTwCoW2RG7RSEkWFad11xZBmBP++hJbGd//XUjdDw2cr82GDtuz6U28W8OqnFslQGNiLgpHpXg06tvB2MF2Wksrs/6Z6akWg9KQydYZjeGID8bFGOMhWRUFyJjoRLm2mTWtHtFoVU4xUvjVOnXArhN7Ri8zN4KCsc8q7rFuwOkCewK2pXpy3Mme1BMh9k+fGYn5qyUF7ogMNQ5UGKUznIBKc+qYfs3Do2VNGX8JMVQ1IDd2p3EDLOh5cYQS/SdYDFgvKQs90uIXpomkf6cVR9iNs79e9oJDG2IfklJUNW5hX8oV07lamL3dhtAUYbQzP3HR0+OpFH6zkuy0Y7+NV8/bR0Y1+3Pz/irLLi9go8j+WZMlusbm0itJ+ayQvyHBWJIPf4UdsYYpRRl9Ecb6qb6tiBpgSnOoAcEvvoWEAG60QxkdQLyP/AdRmT0X4bYeKg46pdi7CC30cVuSiyU8Un8nNhQ==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:DM4PR12MB5312.namprd12.prod.outlook.com; PTR:; CAT:NONE;
SFS:(4636009)(366004)(186003)(76116006)(54906003)(53546011)(508600001)(38070700005)(55016002)(6506007)(66446008)(26005)(66556008)(66946007)(86362001)(83380400001)(316002)(8936002)(52536014)(8676002)(5660300002)(38100700002)(7696005)(64756008)(4326008)(110136005)(9686003)(71200400001)(2906002)(122000001)(107886003)(66476007)(33656002);
DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?68kP/110kcp6a5vGnrkiQOTfrrjiDqGMPUNVs7CTOJ93IDmPYCqmEeifAvaD?=
=?us-ascii?Q?G4twSB1kqADDrSlZY4tJPYak0dcWoHikJNBkHBhB+5irrWKAKhFSV5m/XOe6?=
=?us-ascii?Q?T5QXfGh3f8lMk7j3gS15U2qv/tIRpBoymqxBea0mpvoTkSsO/6hS9n+DuXnJ?=
=?us-ascii?Q?Tz6DMQMlWhsa0CAhT9aNni6QNBTEF6hF2oHeKGm6ju+G1+EBs+PZG4gpr4l3?=
=?us-ascii?Q?1CtOOoD64vrMY8E3kLeRJOwe85vGrqjVjlSu/z6Casb9y1+1ekdYR/6KOnbH?=
=?us-ascii?Q?JFW/syX2uyaoAWj9oZNFMfnvSduOnDnlhcYm9XawJsRA/bpcq+oAysYHxwY5?=
=?us-ascii?Q?pmjumG8VmW2hA+tpz2SgfXOwWbwh7UizUAaJ4YzCTLdOI28QGSrtTMzoR05g?=
=?us-ascii?Q?2cRG1kmFqm4Ce6ZCm9M3xyQ5YIsCBL/6xup5tXqqOJF7R5esnbyfoj9ZmuYz?=
=?us-ascii?Q?Sqr6tNhhzO8H6AL80A8gFikc0fOUZR31RpAxhkCP/XpJ3+gV3IHxM7T+ldQ1?=
=?us-ascii?Q?yiFu1lfd/2l6llJCubeF1+IsBS/kWV71ZWbwgnLd8BxQBs6nBLC8ubSnxuX8?=
=?us-ascii?Q?U8vm5FxR2MQ05/OYQtksVSwPeZhPxAfGchIam3zylXWNReRWmghS9oDupKMC?=
=?us-ascii?Q?/Mnjny9bOVaSqo3MHVA8nZozzn+YURlWUcKK04CFSfVzU2lCI3HMlYuDsYqk?=
=?us-ascii?Q?mP7zQUxEM8+l2TP9HB1z/9eNYwiijtwFPphH5Ig1YRk9JfmLE0KhZ/bGdYJj?=
=?us-ascii?Q?2KfTBwiNp1nPGSGgUsdGt/DV28QKqOBE0Z+D+tgDPxAjg7y1kNyajPZP4twv?=
=?us-ascii?Q?GJeaYAF72JJvCeH7mO2xcV+6CBrAv4GpEEXYj8IY8vKZnjp2kD4pNZSVKBqn?=
=?us-ascii?Q?lXoaup5kHe2ExqSMVp378OIG5niuP2HuHdG1gaGalByQUvwRB3y8ePzXws5l?=
=?us-ascii?Q?oibGV9MKwhC9E8SVQHSFUI+c+v9hy3Mo8QRvawgrkcCTFdudQvUuWi6DZnNu?=
=?us-ascii?Q?Q/gyI8JYESIOsgpoZYGV2fUA8ZZmAyzCg0ZE+KI+s3ZizfjlybC83dSz/w0i?=
=?us-ascii?Q?4Z19IqQQdN4LW96jutQZHJMaI/sNI7PyfvdSNe5r7s4ZOTfT6XVqON+fJ9mQ?=
=?us-ascii?Q?pAjxva7GBZr/9tZOIAiKYf2BOMQ9TY/uu2FZtxdQF4iepnbPeZ+obSHDR3b8?=
=?us-ascii?Q?UYLP9/X+ZWb30+8xD+PLWBJZgF7HhU2UXBxh3anO/lGZL7/CWzrGdwm3H2uX?=
=?us-ascii?Q?ie1q9AnCAjY9LyUTzBA2xInI+4G/hJvjaIc67i+T5/vaawqrCClpi2kyHAoX?=
=?us-ascii?Q?XXUDsJjcmlX2PP2GTzgYKLOLR8HmIu+T9+oPn43wKClvJjU8ZZJBSVlS5qmB?=
=?us-ascii?Q?WM1B9kJUDoPo2uYk3ek/pS4ddycz3xaB7jViG505jeq2oBZt/4OB5SUQY0WX?=
=?us-ascii?Q?b+wd/5nOwxJgwlbnatPujHWnhnDS5BQeLwjFFMqygYukHtQWMPuCIJ/t3zMD?=
=?us-ascii?Q?njAuxDESQEE+xIk3P3gIIbDqkfqzCe6q8A08vhXl4P0Lw89whBKBc1MPLTr7?=
=?us-ascii?Q?ti17ybyvNntSUvMBeOe1bdnvEhU7DqB3dU3oCyWgwNe/6AYM4acgu5NtmoFS?=
=?us-ascii?Q?NK37GJCmKlXAuNu0nuzpsdY=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5312.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dd6b2a0e-dbca-469c-49e9-08d9a38673c0
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2021 13:40:11.1636 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1D6mfPdwSp2u5Ztmeu9oOHn/bjsIhd9xVhYkr+mcR7ePhhDpfAIp8GhxAgCIxo1SLj/Sx51xctU1LH2CPhy/yA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5199
Subject: Re: [dpdk-dev] [PATCH v2] common/mlx5: fix external memory pool
registration
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Hi,
> -----Original Message-----
> From: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Sent: Tuesday, November 9, 2021 12:33 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
> Subject: [PATCH v2] common/mlx5: fix external memory pool registration
>=20
> Registration of packet mempools with
> RTE_PKTMBUF_POOL_PINNED_EXT_MEM
> was performed incorrectly: after population of such mempool chunks
> only contain memory for rte_mbuf structures, while pointers to actual
> external memory are not yet filled. MR LKeys could not be obtained
> for external memory addresses of such mempools. Rx datapath assumes
> all used mempools are registered and does not fallback to dynamic
> MR creation in such case, so no packets could be received.
>=20
> Skip registration of extmem pools on population because it is useless.
> If used for Rx, they are registered at port start.
> During registration, recognize such pools, inspect their mbufs
> and recover the pages they reside in.
>=20
> While MRs for these pages may already be created by rte_dev_dma_map(),
> they are not reused to avoid synchronization on Rx datapath
> in case these MRs are changed in the database.
>=20
> Fixes: 690b2a88c2f7 ("common/mlx5: add mempool registration facilities")
>=20
> Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Reviewed-by: Matan Azrad <matan@nvidia.com>
> Reviewed-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
> v2: rebase on next-net-mlx
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh