From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21A4FA0032; Tue, 16 Nov 2021 17:04:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0EF2740DF5; Tue, 16 Nov 2021 17:04:48 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2068.outbound.protection.outlook.com [40.107.223.68]) by mails.dpdk.org (Postfix) with ESMTP id A9B0B40141 for ; Tue, 16 Nov 2021 17:04:46 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bL+PKRwUHoWdGtpdeEWcf0PpWc1gQxOrcrfBj2ug6gyRkAklwOLMePswZGdYS2GwpMzApVXlyGrctmI9szypUhr9kGUVH6QcuqiLTgVqVfgpZvMCBnkS6dWOPRrY90ea9rPNEVMYHHXKHQxNOGHXZb9UT2BVqktjnIlPjzFPAOoIMGeJRUIKYaeiDKfRFkmh9pYzrjy06on06wDKGmtzPWeNbvITr34GrkW2Cqfgcg83zFKA9pBBf7kWl1JWaeDOO8M3kgYNM6m+YEy+SeLAIPEWJxEky03HhYoAHwNcF+1nZ+l1lXjh1sAgsxSeUKmYO5GN4XTErQGvwz/qbdevtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F3zcSoYfv4kQQkdO7wsVPYh38hxVoeYLdjt7Uq8ucug=; b=jp9dL9F8W+OVVsb+7Ip7GmRPerg7k1DJ+ddLbfHzVsK3eAuWMPvNu/DcALu3iwupPaOQ59Kq6UPstvuVIkUj/kxCPNpV4RkI+n5fG3jcaVE6GAfFRhjZNKZlXuhk9IOW0YritSbpZVYZZk71gCXIY6HjhAd476jMmIyDCEWQtVbaULxb4wqsgK6MfQCq8J2NRgblqn3qyAPuYBUzU6tnzikesmBGtHQZFds4ofF7IKXjaGeC0ic7i20CjAzHaU/she25S/+Yxwv9XiH4iFtnu2nePkz5G3Ad5CEAICj4z/HMq5eVtf1hFm7NIhiru2GtCa4RDWYbEGl8AZU3iOeEWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F3zcSoYfv4kQQkdO7wsVPYh38hxVoeYLdjt7Uq8ucug=; b=LFEr56/1PXSExz79wMWR5HHKaH53gEDrhTx+bOCnl3m29+3JPDiAEKV47BC6rBSM6jZaafJX/pupR6t7ImFY4TgOoMbmiCBA4T9UjgVBae5nLYdyP3/r59fxE7p5gHdDU5id8wKUNIvxDH/yeIfu+nfips6UfYWMl+ZjmEmQdiZ6vO+JKXvE1vkeLki4f6h6/jZJ8Plcvf1EWSIDkcdG918MX9DTFnmV7IdfOBGj5MaK26OxkfPujw4sl5uhxR4iPemKRYcbi5Kfmi9ReK5pW6gAj5p9OZSa7Ql2WXmGaWNwDd/foz1GSyeo3nQFTnB7MYHJcwyuHpazdS9t81B+Ig== Received: from DM4PR12MB5312.namprd12.prod.outlook.com (2603:10b6:5:39d::20) by DM4PR12MB5038.namprd12.prod.outlook.com (2603:10b6:5:389::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.15; Tue, 16 Nov 2021 16:04:45 +0000 Received: from DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::7cf5:9d34:fc6b:b4a4]) by DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::7cf5:9d34:fc6b:b4a4%9]) with mapi id 15.20.4713.019; Tue, 16 Nov 2021 16:04:45 +0000 From: Raslan Darawsheh To: Dmitry Kozlyuk , "dev@dpdk.org" CC: Matan Azrad , Slava Ovsiienko Subject: RE: [PATCH v2] common/mlx5: fix MPRQ mempool registration Thread-Topic: [PATCH v2] common/mlx5: fix MPRQ mempool registration Thread-Index: AQHX2uD1fuHRDvxoNUSzdzENdmN8zKwGUXzQ Date: Tue, 16 Nov 2021 16:04:45 +0000 Message-ID: References: <20211116085752.2419240-1-dkozlyuk@nvidia.com> <20211116115545.2441025-1-dkozlyuk@nvidia.com> In-Reply-To: <20211116115545.2441025-1-dkozlyuk@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d42ad696-5f60-49d7-84d7-08d9a91acebe x-ms-traffictypediagnostic: DM4PR12MB5038: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FFaEXTa9wl2fMZpMbF1NuIEraQcdX4MBEEHZAY8EZW0kLZqSJ2AElQw0PYuJyNFjcw3YrT2dOO7PzejoJRX46w4qzo5du9JnLKWfUGFti6e95HxTiDeAIXCQnjVzvzwcIOvSttf0ouTMtW/E6JN+6VSE4igTr5O4+/VUILt3GakAZY4JdAftlYCC+QjhsCJZx5LsA6rLOKy329Aj/rGwircfuGL+9Cv1x6LhWHfdgO07qLnCOtyNCpDG7UL6AEICbScMf9Ge+57T00WUtpKTopJAf2GOm9RR6sb52LeTTskoxjyF2Rpz07mLc/JPyyWHxWgIJS2CL1Hb7vf4GzUA68QOTadOuszDJon6ScDsQgQ25IrURHO4kom6P5rFzHEgCRlwISfXB7TUmcbu0AHe3r2IgAHpEdMfxadgurqDjrP+GZoiup7cnQPL4jHZdQ7sdqCzFuqCDsIXIjss4SpEsRAd7kWTcWnVwlee0xXu2VJmycDHuhA7LQtwC8IKVkpp1kFcxKcOjsvJ9KhyizKuaZ6PhzQ2jDHLvmvHcUsV/zSrtA767/nTia0jXp74kSZFjt8PZ4zSg6DQ0WfSNu4HrQwIp5SFVN4jW1y8V9i2ixYk90GPEVmfC5Na8a/CKyM6er+DJayssZ3l+nQGvwLNRHDkBVWJtErwxSyvhJ35/jpW/cMc30SzQxncK3lEKo8DskH9ce/xJOrYNUb6Ecvvz5vICWC68i9AgCfNmdkTRh0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5312.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66946007)(8676002)(6506007)(86362001)(52536014)(71200400001)(53546011)(66446008)(76116006)(83380400001)(33656002)(26005)(64756008)(66556008)(7696005)(107886003)(5660300002)(66476007)(122000001)(38100700002)(38070700005)(9686003)(54906003)(55016002)(110136005)(508600001)(316002)(2906002)(4326008)(186003)(8936002)(290074003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lihbuYRUVA1bUKyZ3IiQly5I8/15gaVavRCpG2UyenBkYl7pP2fEEkQsvm6K?= =?us-ascii?Q?i3e0aGa5dDY4uXWcyrQBHHY96P/qZTv6yuWIBkp2Jj667l8gNML8TYqAXe7v?= =?us-ascii?Q?+pD+xhlZTzHvST1tbos3nr5svgi6xtufs3MrGqtK7vJW9paEnHWDesctzVUj?= =?us-ascii?Q?Yb1CTnkzj8UMopnoJ9z2CuZKPaY/5j+vJKYsmNAkny9OIZpd77dXC5UiSxF3?= =?us-ascii?Q?VqQ651lCQ63kBC0IYWcLjJJC/M8NpQuRk+UXq2iVMla7uX9lPEPBlQ2RlvrO?= =?us-ascii?Q?iE85Dd3b564CAIpIgkBqtzmCjxsqxW2DyOndscJbYnpHwdYG6UGR2yHuv8MN?= =?us-ascii?Q?u4n2lYauy31/St2tF8U6s+S4NJb3Xb0UBFGnImhl5+EAGHo1C9364ukITk5B?= =?us-ascii?Q?vxMvvf62A7+GcYY2V9Lg3iIglVPdnaCIKK1zIcuH6YGnW0v5LYO6L2Gt9ybs?= =?us-ascii?Q?d9mlDuz6EHUHPlQnJduRB2CN66gjz6x6HZxnVJJzF0hwwMJYJiQwnm5kIjoj?= =?us-ascii?Q?dP79KKVbcXJb4QQpNO62GkSUoWC2WnJwHR7CZX2TJbHNlxBwXiLkS0srhfuH?= =?us-ascii?Q?E0wKHcYicFLke586ZIG3rd0/hAd9bb/JHQn3bOtKAjjMq0pJNSdPqu4iZ+gt?= =?us-ascii?Q?LgLz0uwHS4QwWXqEHTfhuCIZ5dV0TorP2PlwvOb11ZdLsrZTVYv/VJLWj5+d?= =?us-ascii?Q?xMrdlLAn7WGX79wWdUgVffcdAI1Ig4q5uW6lJ5YXxrWHpy0DRDflVV2mFsgW?= =?us-ascii?Q?t9xtyqyicCwklc9NpstWZJ48gXDnfDVBeNb9bSU9G2EuDwec90v7BeP9mrEq?= =?us-ascii?Q?zU9LbId3aX/cy0xYDzU2Q8FfuwkoyZi/nz1mJsrsySZ4MEvCXFoYFgXkptm5?= =?us-ascii?Q?FjAQXVTvn+sVtYtIxoESqGSwHCvqPYFpQwLJUB56//tB9Mv+C5YipdLBvZso?= =?us-ascii?Q?C9PbnqHCYy0zRraa0HkxMZJTCFlAtfLrZ3lBO+u55e8bdJVZAPMH6CyWxtz/?= =?us-ascii?Q?rXLBhz6MWNgkdlC7nQqAxIeZiTXb5htr+FQ6TywmreB3OxmW/Hf1/hJvuTMr?= =?us-ascii?Q?+5j5b9Ct3xr4QHNpTdgh+/S9Vb2r1UtX8ePjBrOusMwt++wDabbPJt4iivuN?= =?us-ascii?Q?WefAY0b34TcjgB7JleOxd1EcdZjDBU1C1KX4HddfFHp8vUOPoXAiENJK4Z6G?= =?us-ascii?Q?CW82BRmFG9JHGWwi5BfkmpeYVRqzDHP37UgqOBZFr3v0nnGCovU3JHK+kDyl?= =?us-ascii?Q?117LSq8nWzTWK6PiTj/04cBUydPRvM7fTjBaRXKcqlPD30CXSPK91f3Btk/Y?= =?us-ascii?Q?sZaDTYbwCJAEOZ2wTY9hwLRwN/oZVf3D0cY5PYEA3V39hB3q6zGfBz/8cKkp?= =?us-ascii?Q?noLgB+1ar8uptnM2mII9CSPyLvfu4WRrsSxqFCEF+bFj+JBkLiCObtZYQDkE?= =?us-ascii?Q?zoUZ6aHnoGq6wcQ6dBlNs/fXZ95RbRy9jCfb1/D0B96nULpF9uzeDJwaJgxV?= =?us-ascii?Q?XemaFAXGOoGKLOJV7UiPMBi7MtLX5WbP+5Tf/cL0tpIzfwN20twF107iIGT9?= =?us-ascii?Q?sM4R259tkpyX4SRHGQ5lT/AR0PdIERZQDDFgXN9aSfrHkjX8pDfgxJsVuPQs?= =?us-ascii?Q?8uZbVvBq8Smt7Lcps5hgEns=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5312.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d42ad696-5f60-49d7-84d7-08d9a91acebe X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2021 16:04:45.1655 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: n2NkfgzJT1wzcKWn8Ni5NtSkKeHig6PZ4OLQYVRS/k+fu5gTiuVH9jyd1Rr2+oI/XxvidC42L6UNwBVUpTxcFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5038 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Dmitry Kozlyuk > Sent: Tuesday, November 16, 2021 1:56 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko > Subject: [PATCH v2] common/mlx5: fix MPRQ mempool registration >=20 > Mempool registration code had a wrong assumption > that it is always dealing with packet mempools > and always called rte_pktmbuf_priv_flags(), > which returned a random value for different types of mempools. > In particular, it could consider MPRQ mempools > as having externally pinned buffers, which is wrong. > Packet mempools cannot be reliably recognized, > but it is sufficient to check that the mempool is not a packet one, > so it cannot have externally pinned buffers. > Compare mempool private data size to that of packet mempools to check. >=20 > Fixes: 690b2a88c2f7 ("common/mlx5: add mempool registration facilities") > Fixes: fec28ca0e3a9 ("net/mlx5: support mempool registration") >=20 > Signed-off-by: Dmitry Kozlyuk > Acked-by: Viacheslav Ovsiienko > --- > v2: improve logging, add ack. Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh