From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49380A0C43; Wed, 20 Oct 2021 21:35:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A9DF40150; Wed, 20 Oct 2021 21:35:20 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2077.outbound.protection.outlook.com [40.107.95.77]) by mails.dpdk.org (Postfix) with ESMTP id CC9FB40142; Wed, 20 Oct 2021 21:35:18 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WqEugXk5lBuXwjKtxeiGAQwZPNGi0DzkBeQKR3Ptlrcm/0wuAn+qVYm8OdXQ6ZyAezFjLPyymSM0hdTzvqvTZCIL+0kEnymoFwGkRQkYoNLs9ez03zzRMzNwgAWtQSr70RmZvzL0I8FNrcF9dpPEN0y2yccrp2y31iAiPJYNwac65ap7y5M6GpJ6pDL3lqVfypnuSqfVCqhOa7/YiVveIvqwt1uq3bQjEYULzWHD+jKC33u7hJZ4I5QDoEt9rbunSUzGrAkj6pdxxNaRwAar9YUbsavgxwCEhJIoyM5Ncx1+0YH90mBQFj5zNd5iikG9Ha/6pdlu3do1bK17RMhpfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3F0+k0HAmcUt5pqmMHGWFqYSOaKG+qu5Bap/T46e8ws=; b=Xd+snKm6RvMPh3mIpTafAncdtphmyj2RxVA/87Nhn3TH7JvlapcsB88K3lBYJIdYJ0dl+nvH3jgPs3giM+B+etoMM95y7rVAkzATKShNEzLEHQoaRgTxUOvQoP1X+9J67ERjiJN7kf6O4Sn7NFHUFg5L2VpHIC8p2WzWve1SRZLNSCwBh8njlyjqln+8QHwfasq/lWy3uSf+rS3XQnw3HkzuRrMDSNFnaHCikzzBRscaUIuCzjRUJPsiM4KZYU2cQIxiRTGGCrA0zfmhUkuL0KRVN6PGcAnkhTc2xJc2s/vXCDABfR5CrfPI4revPlNJjNhE2vZLv/sh3cR3olWRZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3F0+k0HAmcUt5pqmMHGWFqYSOaKG+qu5Bap/T46e8ws=; b=KF/ke+j3NDChS79WRakmBHmq61cEWMBZIdLPQDHNHgaJuDozKapgtUsGWN4BqpAHbSt9O0MKMumzkj5olN5ysYYqVqQt9foz9dxVOEqzAFVs61IKrgpK/KPzZewe6FWNuQRvlCxbn521sEn1yKDTenr9nOGLEJjfxnEp3ZW0OhScykgFXWHaAmxrU4y2ngkWEbTK3UgsPMMHRPub51Lv+0jhqy+mKGr4rcb2jLmV6USqbefzBDYkv4mkQBqDExmAcK6LhWdwDJlRmucXSJAZ+xLlM69jQLaRPxff8rzpaVek1D5vrJGxP2jMoC4DJGXJDcHw79V7VskVdBIlDTIVOw== Received: from DM4PR12MB5312.namprd12.prod.outlook.com (2603:10b6:5:39d::20) by DM4PR12MB5200.namprd12.prod.outlook.com (2603:10b6:5:397::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Wed, 20 Oct 2021 19:35:17 +0000 Received: from DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::a4bc:7da3:32e5:1665]) by DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::a4bc:7da3:32e5:1665%8]) with mapi id 15.20.4608.018; Wed, 20 Oct 2021 19:35:17 +0000 From: Raslan Darawsheh To: Bing Zhao , Slava Ovsiienko , Matan Azrad CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix the RSS consistency check of meter policy Thread-Index: AQHXxCJlpWZ8+9Vpr0G8EDlOi3FEOqvcStEw Date: Wed, 20 Oct 2021 19:35:17 +0000 Message-ID: References: <20211018131612.145215-1-bingz@nvidia.com> In-Reply-To: <20211018131612.145215-1-bingz@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cc68485e-958a-40b7-79c9-08d99400bf08 x-ms-traffictypediagnostic: DM4PR12MB5200: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NW2OUc5nYKNlXWe+7Bn+bVPIdSJ7fT/3UAUoQscfDxBm84CPf4T0hD9q3YfRtEPUPHThiY/azVUyJPSnwG3HXvJljNRaggqgCUHlEHrAUQxz7BsAqkIdVo0EPV4H0oC8U2BYzEqRKfYz364HaVOkdg18wJkqdMD0UHvigAqa/OltW8Mq7bZ/S5/PFZKtnUxosHyiuEZxR03gL5nR5/LZ7qyuq/aHzYduJQVHGfA94mmNLfXlW0fNtt91fVMM9C1sLbp32Mygh16MDFORi5la9MgwZS6nLD3EyuqcGtTGlP8PtLRaUL4wC+OKQ9h3OHdu+RJWULi9S4ZsWxOBCzCUilwznH9GvWe0sVGqmhc6Zr86rUjBqKpviJzpHM1QfFbaDfo5+wPmNGzgCEdU/kq0P2mK9WjIjSb1fYnf2NHU0RdR1CluT7gFlNT5QQp6ZbvH9UEaRgFIA0aa3y8hDDTYs33jJ1DIaAEBJKgY9HXG9Rn75vsCslQ+hiHmHf1Ig9t2/a1w+Wx2zxvmg9Bf/3O9AeFRKMkC1T0R+IIlpnKoZtUsBuGQrwaBsss0DeNbAbDNLq8pNv2Hej5rZPKZA5XcqQuIdV9aylLD6L2/zXXoeHTnimgp0pu5DlLS4I3TSKVxV1ahF8+cch8mTzr9ymRdmcjBiB6E9Fd79dj9udb+me9hMx71N0ynyIPqYBuzBe7Ycn/s+0MTqqaIqrTebhwHOA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5312.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(53546011)(38070700005)(6506007)(9686003)(54906003)(7696005)(71200400001)(66446008)(508600001)(186003)(8676002)(83380400001)(4326008)(76116006)(64756008)(450100002)(6636002)(38100700002)(110136005)(55016002)(66476007)(66556008)(8936002)(66946007)(122000001)(26005)(52536014)(33656002)(5660300002)(316002)(86362001)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?z9+2dKbQUmHurI1lRmwGoBB60XRtO8TORgNFPJ+uk+OEOWKh6Y8kuIxLeCTY?= =?us-ascii?Q?HRbiRM6FXzK4MtIot7cHHebmpl0CUifMp9SaBfN0nUerB0kqG/x4RMwGxByv?= =?us-ascii?Q?obhRcDkaMr5ujADZJjurfImtUU5xbdxmEy66CGSCuVlw7hxrNUKQ7J/qlEMV?= =?us-ascii?Q?10zryEyr3gfH/N23+EBe6vm/XUK1/OZoLF+Vb3RyAOt50fEyM52jbIOmsGIx?= =?us-ascii?Q?yFNYsXtPV2pIs6qNTkuIkW9x2Ez8be7zJQ1dzbenJB2XVCh/6wDyWAwrrpLP?= =?us-ascii?Q?/yy6FM1NcrYlvpmdYlC5adtRb24QHsFzSkICRKucJZKJz2kLFwZTOImfXAML?= =?us-ascii?Q?NZPSz5qORsHmWJOWZvVAbACpjaV2acuaF3QcHLh4Uv4zWgyctQ7qaJJETsLy?= =?us-ascii?Q?MwB/k36CetFjVnBevUT5VOG5sq/q/cGE4zrPJkFoYa/zi5zFXjgGnrQXdzJe?= =?us-ascii?Q?rmxOZF0oKBCI28Pse+d6mXVg14NPA+NsYxK5G+1cDgZQH3nGyx328NP8FHNE?= =?us-ascii?Q?ySd51mq6hhTv9I+jlYFxIusl7JswklUVdnGMIfxcQuCErcX5d0NXI3JlLl9I?= =?us-ascii?Q?2Ex6ipuR1MEKogJndM6NgNVuhV1oHuKFOHD2Ybi98huXxmEDHuNWY9OteSDn?= =?us-ascii?Q?MIx3xCvkf2h/hHYWH5PKJZXnBFpshC4K6tE+37z5Q8ximOwS0aZOjD/g/nJE?= =?us-ascii?Q?EN1HrADIYQ88fUnO9fmlTPDLsSWVomxHHVSTCMF7zLmvuLTdVLFbUc9cLRyf?= =?us-ascii?Q?ld0Y8byeAS9L/nM82q/9mVQRG0lHwvSPvZ4Sd6CZQyuAji25K25FgmLBMVWc?= =?us-ascii?Q?XF2fzYjL/mymGSPo45uoX6E0ZPbXVulTMgmMhB+vHWZHvICs4YKZGc2ATw5P?= =?us-ascii?Q?9aokOMSDzZYn27aRY6iBpCWO0phnLF4lH333TugSedZ+H33Hx4/MP78ya/xu?= =?us-ascii?Q?Encd/+fElG1Q1juq4jXCMLlKcPK1qalieRLt2JINc5U8K+Jb3NtpY8hmYeb8?= =?us-ascii?Q?fNvv9ZaDomGoonoW4NiRyEe8PotChKk8w+9kqrl86GzMWmatSqGmYHJYvEsu?= =?us-ascii?Q?uJDADiJkO51y/qx6BttrQMUtGaOBWPP/qS+cX++0r8ZfynLTPMQ2eVBOPJBh?= =?us-ascii?Q?sTeVaLo7Pxi80k/ekdCtN7kgdWCh9errnTBsUk1hmKln1siV7pcwGYh5XE77?= =?us-ascii?Q?bq80tBm7pA9GMSkAkJN8cj1jQ/Bb/BNUTMcX2xKhLA0RfPQXsC4+0LFYg1tW?= =?us-ascii?Q?gb+uA+vxk67Yn7XAZ6mQP68VCaFqUjC74eFwDuDhxxhJIGb6D7S38jm5Z5wc?= =?us-ascii?Q?1eRGR3x4QBYay2iR5VrWY2z9?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5312.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc68485e-958a-40b7-79c9-08d99400bf08 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2021 19:35:17.4763 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rasland@nvidia.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5200 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix the RSS consistency check of meter policy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Bing Zhao > Sent: Monday, October 18, 2021 4:16 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh ; > stable@dpdk.org > Subject: [PATCH] net/mlx5: fix the RSS consistency check of meter policy >=20 > After yellow color actions in the metering policy were supported, > the RSS could be used for both green and yellow colors and only the > queues attribute could be different. >=20 > When specifying the attributes of a RSS, some fields can be ignored > and some default values will be used in PMD. For example, there is a > default RSS key in the PMD and it will be used to create the TIR if > nothing is provided by the application. >=20 > The default value cases were missed in the current implementation > and it would cause some false positives or crashes. >=20 > The comparison function should be adjusted to take all cases into > consideration when RSS is used for both green and yellow colors. >=20 > Fixes: 4b7bf3ffb473 ("net/mlx5: support yellow in meter policy validation= ") > Cc: stable@dpdk.org >=20 > Signed-off-by: Bing Zhao Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh