From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 467E0A0032; Tue, 16 Nov 2021 14:06:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 334A740141; Tue, 16 Nov 2021 14:06:28 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2044.outbound.protection.outlook.com [40.107.220.44]) by mails.dpdk.org (Postfix) with ESMTP id 973D940040 for ; Tue, 16 Nov 2021 14:06:26 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CJDceAetup02v7c9Rts4uUYj+H+CcnLnlX8XMaUk+8VguN92qP/OPnXunIEtdiN9sA5F1lh3/MEUsDn5pef3akLzhP40A2Xwgc2MLm3Zb3XtE0VcJDTGSEOzrDCW7v/+6bN3Ap/Q+jZkuBlab1QhvF88abg72UhDbNXT2oLkhHsRDV7n0tVp7atadueV9/ZiQzZjIfw4tOEZunsHNQQ868DuxSl4ElBk4/CCEe8d+/VMQWEb8tSbcRU1L4qs+y3gu+41kyJDFxEtt7h3/jSmZe2JSAjblh692t+5mzB4rNPh4BMCykcI/HH5Xc5luB9piUSDGCaviAXTcGEVEvj5bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aE4gsndtqtS+Lc5XFmQcCAhExxoKzyzWJHbFhqvqGVA=; b=c1JPHjHe/gsFwvf8t9YF/5jU9+LIt97S+WKfhZWKrws7L6jRnSRw1FvYl8MW10MlZTSIrtvsokc6q7TkXUsB3+WTpj/JaB6XdclvwnlOhH5zwTlWXHQBlkTx2AoqrVYoxMxDiuXPxhWwwSj1lS0hRCLVaNGJ+yi+elyYx6VRho1CFTfKou/+HHX+0pkSRRuRKzyGWjVTmc3IjNGj2R3fWtJHgmUqm8pT9Rn+qLLZfhNcWaB4l+kqOnszYMhtDueJ4rMhWyBzmTmPDtCKV6mBG67pvx2F1GUersxNyM2/enT6Dmqf5LkRt3sC+2XSB5aQWFQCRxa4qg2eclkDIvfvSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aE4gsndtqtS+Lc5XFmQcCAhExxoKzyzWJHbFhqvqGVA=; b=cV325hL9uyD0GfMScOuwDCdUHmZFXkRKUxgubcwXYY89ZFwJoVNWsnvZrMa1Xt+4lktz6oKvYDoZ1DiOyGChFe/fJaUrUKGQDK+qZw54zTt25n8GuZM4r7kGVFZHpo9Vn/NB/DordcPVPBJtljidgDcItbz3wWz9IoZl1b4bDwAReC/L6dbI+LSJ6Np5BygHxiC3oYOUvtk4RtxwKR7SW1On+wvVxIeuhxKhmyz3E4UoQpEDKiCJaYPlklgCTnk5EmxPKTgJmPjYdVbFltT66R/cW3vIML9P4Kn0K/XuqhOQMiPUrqjzCqXcxQ1aubNKd81kIsfKpAF69vPFfizmnQ== Received: from DM4PR12MB5312.namprd12.prod.outlook.com (2603:10b6:5:39d::20) by DM4PR12MB5247.namprd12.prod.outlook.com (2603:10b6:5:39b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26; Tue, 16 Nov 2021 13:06:24 +0000 Received: from DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::7cf5:9d34:fc6b:b4a4]) by DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::7cf5:9d34:fc6b:b4a4%9]) with mapi id 15.20.4713.019; Tue, 16 Nov 2021 13:06:24 +0000 From: Raslan Darawsheh To: Dmitry Kozlyuk , "dev@dpdk.org" CC: Matan Azrad , Ori Kam , "Xueming(Steven) Li" , Slava Ovsiienko Subject: RE: [PATCH] net/mlx5: fix keeping indirect RSS non-isolated mode Thread-Topic: [PATCH] net/mlx5: fix keeping indirect RSS non-isolated mode Thread-Index: AQHX2r0G3nTOeHxockOGAai+aIBID6wGH/Mg Date: Tue, 16 Nov 2021 13:06:24 +0000 Message-ID: References: <20211116073834.2413952-1-dkozlyuk@nvidia.com> In-Reply-To: <20211116073834.2413952-1-dkozlyuk@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 33e7673f-023b-4ae6-9576-08d9a901e4ab x-ms-traffictypediagnostic: DM4PR12MB5247: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: r/CfEWoxoDnM2mzv0Mk71QD/m09QEaYxIY7H4yk5y7U8Jb7K8A9MscfRJllrrPUNtFqS/wjrF909kkro3IFDMpC+xR0RcAuEa6mkntOJor3SM6/Ynurlyg9sQJ+dJ7CVOXvMQPJA1m84cRfhyZQYJBns0YdbxiQ6O+SlGOh0+lV+sBhHiYTceE4VnDWrvCD+8belzWOGbLD3GMeGO6XOqhfnyALceqqqelnAaG50za3yAbcGN0XsrTXIhbugRHuAaqkWQ2ow98iA3cUUsYjqGfwnEkvoy6+O5Ij5X7EMGCucdnowJP4Gpe9iHdmJscChLc/MW4YhPGml5R1vMu993l9bnwd9crxwu96sXW5wzfRby5oXUMbmfyZPWu32DaZlCJCcvcs0ui2lGd245cISll+MWQog+30ra2pXyUI2qTJQr8tlT1z0XlkZN+c+p7INNxfLnizeaRSq2D2q9tAoUaJnIueawLhxo3LgVY1OF0BG5pENgPkwZce2NgzrBfsn4s5PYFKbyg2SgAhHc78TcmNCLCgcsf1eHGw+5oePvv0AUMtIDq+aKtH9wb0O33EkZ2/B4PffatVVVHu+X1wxEpY/tbhVkDd6Lfwcm31i3v/sYevi4c3WUiGEcuupJ5wngLixvwyi/KLaNYbzUBSfXij9UhFCnUvC+kRgYMoe5sDWIBZm8bd8o8oPkMeGUG9lBfINhwHnFvFNaS9wElhnVA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5312.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(55016002)(76116006)(26005)(54906003)(38100700002)(38070700005)(4326008)(66446008)(316002)(66476007)(66556008)(66946007)(9686003)(110136005)(122000001)(5660300002)(64756008)(83380400001)(107886003)(86362001)(186003)(8676002)(53546011)(33656002)(6506007)(52536014)(71200400001)(508600001)(7696005)(2906002)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ec9IZSpdQFRklTEqITKYiWwJMTQ/DRh8fnKSe/chvnQZ/D45yCMbCUvRf6cA?= =?us-ascii?Q?BGxJnOeNhUvyQCQJ69Gx5ORhY28xG9ZULPGXN70Xw2+8bugx7q0bdXoaE7Ea?= =?us-ascii?Q?cohztPMu92oqDZxKWV7Ean8150Cd9QX6gdW/dsadZWqtlC0wKUT7ZJlN1FoR?= =?us-ascii?Q?6oybuOmkQQWt+2B4jHIOFrnhRUUcCAxyXQ44QLYMGzxYQjW4gKrd3CqCXQ79?= =?us-ascii?Q?DqqUM3OqPxZGZwFecLhRelOVkZxykXBOCRc4pJxtouo/WxkyBqO028ycYese?= =?us-ascii?Q?TIsBuE0Lw6usJ33S6mhc5paVnxihkI4k/J4vvLghDKrFmBdHigfvJJQCNi7X?= =?us-ascii?Q?mvgx6pGaE9fNGpNvSPVr87L5fIXB+NAYC6qd1GdfTRGt1PH4tyd9Ynot6viD?= =?us-ascii?Q?LkgBMQQzE6ZxCayPJw2gYSwhwoUxEPQcA2nLsa2s7SwNZNUqwPthu5GsKKDS?= =?us-ascii?Q?boAi3uNuQVINDSLwDL/eisWD3pxOeDHeLTxZs4O9G2QEcUviSf4THaJBZGsj?= =?us-ascii?Q?8FVPrcNS/c6fZ5yrpICVFoA9CDIH5Wbpij2BcUnjStJ5Lc1s6T4mrsrJP+PY?= =?us-ascii?Q?Z2SU0yIiLvbg8vfYuBwV61nLVhAk6iqn9yYiP3TKUMYxkMuUZgAl+SZrAI23?= =?us-ascii?Q?6qS1fjV3Y9us7WN7wzSA/NNh6LOS9WJN43imfH8eGv93FPPuZnmZx6ENolmQ?= =?us-ascii?Q?S1Wdo6zNtd5U+c8YPkxE5qoqSApgrtEcUUxf5D0rPIPXOHCjK8FRoxj/N5yU?= =?us-ascii?Q?T1dVpNzbNuNcsvr2oXyWOTFKuAgKx+tjduH+QCwB0bjAcmMVwtGG6cs0f2wB?= =?us-ascii?Q?reAydNpdxlDmU369Gd0xIr2BPZn3t/Hx/v3lNKb8lHRWd4LoURyFNguDJn27?= =?us-ascii?Q?nHzEFX5nvFYJ+g+EJaYeTto7mTSPsV/t55YSKGCYMMzjCu4t9VrU0iVJrQz4?= =?us-ascii?Q?rEXkcV4nS+X8fVOJT4is/sgHWSr/eMimGxBpJJbAkDMb286pTFakNPJkD3UZ?= =?us-ascii?Q?Yv8awHtDe+c+wB/iu8/eVw972UkI36iQ8dkCQe0eUydctACkAemXGjLLs0+f?= =?us-ascii?Q?lrt1yvqZWkOsSs5I+aMkrb35/c5B+lR3FRNrCt69B6ci35k9KbyyM1Owmhut?= =?us-ascii?Q?DB1s9au1PE9YSK6seDz3pl1OGm9PnOp+/Rocmv4xoTbbYzGtKE5TaBCMFvqp?= =?us-ascii?Q?i8uU4n9EQtc9Y8+0pywkkuev2vMK5O58q1fCTIev4UdPnWJEOcj+WFS3e/0d?= =?us-ascii?Q?O7ynLrTUcOn6WVceApRLBPWxR79rLhcqKWznZtCw7qeDy4d1Ti0pNrndkEox?= =?us-ascii?Q?C8ph8DJSVoEyIXIHuF/0nMFCJPkSA/nLlQxetIyQChshpQZ2cpz8lISCO3pG?= =?us-ascii?Q?CyqOQcXYHaQfXhvFjdIREMlYGU72M/4T7UJb90gmvaBiNJzOn0uGXWaPieCV?= =?us-ascii?Q?nyTmCBmrB8/++hgnH82Ut20Y2mt51v366hs2+5e5nza+SOJB5ICDOdPOt+tx?= =?us-ascii?Q?t/s13rFkNDcAN/YAdHEow5yEeV0yMV9xkYbjy0JUQl1QyYneUkoM8fxA7qDj?= =?us-ascii?Q?drEaoyG79VO6GwXgbrBCe6Uy1vn85ZMrTO3LY2hMtWTXRRnkD6DBtv2GWxxE?= =?us-ascii?Q?kjKEFCWXm90A2Aoo4R4hX24=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5312.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33e7673f-023b-4ae6-9576-08d9a901e4ab X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2021 13:06:24.5022 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fE8IfUIHLHVCV9NuKxvh9PuuBIHB68uk+wltEDVZfCOJu8ZLNXmSbw5D3dCKK5BRT91DR7AvXbAS35lbsaDZpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5247 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Dmitry Kozlyuk > Sent: Tuesday, November 16, 2021 9:39 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Ori Kam ; Raslan > Darawsheh ; Xueming(Steven) Li > ; Slava Ovsiienko > Subject: [PATCH] net/mlx5: fix keeping indirect RSS non-isolated mode >=20 > When a port starts in non-isolated mode, > an internal indirect RSS is created that includes all configured queues > and a flow rule is created that references this indirect RSS. > If before switching to non-isolated mode an indirect RSS was created > that includes the same set of queues, it would be reused at this point. > However, because the port had been stopped (or not yet started), > the TIR for this indirect RSS had been destroyed (or not yet created). > The flow rule could not be created and the port start failed. >=20 > Creation of TIRs is moved before configuring non-isolated mode flows, > but it is not enough because of the following issue. >=20 > Commit 0cedf34da78f ("net/mlx5: move Rx queue reference count") > changed mlx5_rxq_get() not to increment RxQ control structure > reference count, mlx5_rxq_ref() was introduced for this purpose. > mlx5_ind_table_obj_attach() was not updated to use the new function, > so when the port was stopped, the control structure reference count > of an RxQ used in RSS reached zero and the structure was destroyed. >=20 > Use mlx5_rxq_ref() to keep RxQ control structure > needed for indirect RSS persistence across port restart. >=20 > Fixes: ec4e11d41d12 ("net/mlx5: preserve indirect actions on restart") > Fixes: 0cedf34da78f ("net/mlx5: move Rx queue reference count") > Cc: xuemingl@nvidia.com >=20 > Signed-off-by: Dmitry Kozlyuk > Acked-by: Viacheslav Ovsiienko Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh