From: Raslan Darawsheh <rasland@nvidia.com>
To: Lior Margalit <lmargalit@nvidia.com>, Matan Azrad <matan@nvidia.com>
Cc: Lior Margalit <lmargalit@nvidia.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] net/mlx5: fix RSS expansion for L2/L3 VXLAN
Date: Sun, 17 Oct 2021 16:17:01 +0000 [thread overview]
Message-ID: <DM4PR12MB5312BC7A5E89970B5E89C295CFBB9@DM4PR12MB5312.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20211014062136.2976961-1-lmargalit@nvidia.com>
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Lior Margalit
> Sent: Thursday, October 14, 2021 9:22 AM
> To: Matan Azrad <matan@nvidia.com>
> Cc: Lior Margalit <lmargalit@nvidia.com>; dev@dpdk.org; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v1] net/mlx5: fix RSS expansion for L2/L3 VXLAN
>
> The RSS expansion algorithm is using a graph to find the possible expansion
> paths. The current implementation does not differentiate between standard
> (L2) VXLAN and L3 VXLAN. As result the flow is expanded with all possible
> paths.
> For example:
> testpmd> flow create... / vxlan / end actions rss level 2 / end
> It is currently expanded to the following paths:
> ETH IPV4 UDP VXLAN END
> ETH IPV4 UDP VXLAN ETH IPV4 END
> ETH IPV4 UDP VXLAN ETH IPV6 END
> ETH IPV4 UDP VXLAN IPV4 END
> ETH IPV4 UDP VXLAN IPV6 END
>
> The fix is to adjust the expansion according to the outer UDP destination
> port. In case flow pattern defines a match on the standard udp port, 4789, or
> does not define a match on the destination port, which also implies setting
> the standard one, the expansion for the above example will be:
> ETH IPV4 UDP VXLAN END
> ETH IPV4 UDP VXLAN ETH IPV4 END
> ETH IPV4 UDP VXLAN ETH IPV6 END
> Otherwise, the expansion will be:
> ETH IPV4 UDP VXLAN END
> ETH IPV4 UDP VXLAN IPV4 END
> ETH IPV4 UDP VXLAN IPV6 END
>
> Fixes: f4f06e361516 ("net/mlx5: add flow VXLAN item")
> Cc: stable@dpdk.org
>
> Signed-off-by: Lior Margalit <lmargalit@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2021-10-17 16:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 6:21 Lior Margalit
2021-10-17 16:17 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB5312BC7A5E89970B5E89C295CFBB9@DM4PR12MB5312.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=lmargalit@nvidia.com \
--cc=matan@nvidia.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).