Re: [dpdk-dev] [PATCH v2] net/mlx5: optimize the device spawn time with representors

[Raslan Darawsheh <rasland@nvidia.com>]

Hi,
> -----Original Message-----
> From: Jiawei(Jonny) Wang <jiaweiw@nvidia.com>
> Sent: Thursday, September 30, 2021 3:01 PM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Ori Kam <orika@nvidia.com>; NBU-Contact-Thomas
> Monjalon <thomas@monjalon.net>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> Subject: [PATCH v2] net/mlx5: optimize the device spawn time with
> representors
> 
> During the device spawn process, mlx5 PMD queried the available flow
> priorities by calling mlx5_flow_discover_priorities, queried
> if the DR drop action was supported on the root table by calling
> the mlx5_flow_discover_dr_action_support routine, and queried the
> availability of metadata register C by calling mlx5_flow_discover_mreg_c.
> 
> These functions created the test flows to get the supported fields, and
> at the end destroyed the test flows. The test flows in the first two
> functions was created on the root table.
> If the device was spawned with multiple representors, these test flows
> were created and destroyed on each representor as well. The above
> operations took a significant amount of init time during the device spawn.
> 
> This patch optimizes the device discover functions, if there is
> the device with multiple representors (VF/SF) being spawned,
> the priority and drop action and metadata register support check can be
> done only ones and check results can be shared for all representors.
> 
> Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
> v2: Fix the CI warning
> 
> ---
>  drivers/net/mlx5/linux/mlx5_os.c   | 33 +++++++++++++++++++++---------
>  drivers/net/mlx5/mlx5.h            | 10 ++++++---
>  drivers/net/mlx5/mlx5_flow.c       | 31 ++++++++++++++--------------
>  drivers/net/mlx5/mlx5_flow_verbs.c |  4 ++--
>  drivers/net/mlx5/windows/mlx5_os.c | 12 ++++++-----
>  5 files changed, 54 insertions(+), 36 deletions(-)
> 

Patch rebased and applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh