From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4CACFA0C43; Tue, 16 Nov 2021 10:25:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2140C40141; Tue, 16 Nov 2021 10:25:05 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2045.outbound.protection.outlook.com [40.107.237.45]) by mails.dpdk.org (Postfix) with ESMTP id CA77640040; Tue, 16 Nov 2021 10:25:03 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XTyaW0lV81M7wjc+AOdxvADcgv7FtQXZYBhh5ZmnkFPT8NkeqEdLUoW7K9rcf62V/XzGunERONJbs7Ciq8U9rzhfCGrkrV1XzgBEI8Q1XP+79e/uEUXUZyTVYvSU3Oa4enLVmy90xu9J54VuixGjdnN6fQtXtuvjEn/ec2C/k+ixwt3R+Gdud30+JySaTv07J8RajNeQPX+Xv2VzO5iMI/Hf60xvcuSIJT0CMXranqs/03JCUc3vRtOvKWTOwIQ/YXuKt9JU/wpyY71TgQHE8Rov9NZq4RzHs7J4wmtpMMacCffEg42w8a/8756K8q5H3lrM6aDSBoaW7i2RMrLyrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mrcBB4EGQjZo0Fk32EtY/+ShS7bjrZPQXyaVczEouEY=; b=N/VfeJz1ldrDawyJyWt8hSXm8uPdgyu923Np0sbMwKwsUR7Gbyg9HrvJM/lZd+mkMTR8jIhwJ6kzJJd4bhS6PvwVDXcwJ2Ijd3ihqsna/8eIybQReI+/xWzaw6aksQrrT3mN8973davmW8mOYBQbr13jS327AZlUtDgRYRCrBAE4cFEBWwghQKcYU96mVho5a+gDqb2/rFWgMR8BUAqwzPjFfugUlBJyS1QLvG3+t1JsQycDwrlmWe2Y/D4Yx1QdoWmg+RxjfFEGpkrZdJVwkV2e9aKyCOqCy33FX41EBwf0WrFLnumxU/uIgOwwTAbzxFaOPOcaoq2SLiRA6fPDZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mrcBB4EGQjZo0Fk32EtY/+ShS7bjrZPQXyaVczEouEY=; b=r69zP5SHCZgFkWB8YAIi/ZF5OswS3tna7ZWWQNqZGtXTZ7iG39Azd/GHtFDchTWp2XgxplF8cnSTI2IVhfzU51fgMRL/xmCue+MgdC23VGA2w+k+kbXbkCJJr7S7sDRo+vyk8UlNbQYrf4SOfU75z9QyM6A3kvtWqZb++UqJvC2ByQyZ5fZWAmX/+9VJtXmT05zP2dS/9cBaxPrXs0MKFNoV0gsYCh/wG/d3E33TnP+BNgTxnJhLjGobCBazWCaquqUwaNB+O5mARy6kOSFR5Sb4/dLbXv+C46YEezJ2B3XBqUmvoUnzCIPH5yQcs+Ij8/yn3GclUXwHjaqhhti7lQ== Received: from DM4PR12MB5312.namprd12.prod.outlook.com (2603:10b6:5:39d::20) by DM4PR12MB5039.namprd12.prod.outlook.com (2603:10b6:5:38a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.15; Tue, 16 Nov 2021 09:25:02 +0000 Received: from DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::7cf5:9d34:fc6b:b4a4]) by DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::7cf5:9d34:fc6b:b4a4%9]) with mapi id 15.20.4713.019; Tue, 16 Nov 2021 09:25:02 +0000 From: Raslan Darawsheh To: Bing Zhao , Slava Ovsiienko , Matan Azrad CC: "dev@dpdk.org" , Li Zhang , "stable@dpdk.org" Subject: RE: [PATCH v2] net/mlx5: fix missing RSS validation with meter policy Thread-Topic: [PATCH v2] net/mlx5: fix missing RSS validation with meter policy Thread-Index: AQHX2jBWhNbsrkpnv0KmaHb0SaNzrqwF4w2A Date: Tue, 16 Nov 2021 09:25:02 +0000 Message-ID: References: <20211115113518.1654183-1-bingz@nvidia.com> <20211115145121.1663173-1-bingz@nvidia.com> In-Reply-To: <20211115145121.1663173-1-bingz@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f0ec04fd-eb42-4c11-02ad-08d9a8e2f806 x-ms-traffictypediagnostic: DM4PR12MB5039: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dvtcrJaqk0hvS3YeiEc64N/2uWjUJGgf1/bVKnYrfEW3aGhZnNedvWLf2v+Whq+RD/zlZOEByxgLBNAv2GF0/HssrV9j9SGLZrFIolY41mdsJGOqR/NV11QIHOl3IF8Ictlx/WQtyLTXaKveS1lcFep74IJh7uhP7eWxJHKsGrKZnaef6Hd/sMxHDjSF5rWaYuvnoqL2ArM5X4oDBVvroiDDxO8joYw5N96YohIxtEiJg7Ms9wkVJzUMLw3WA2G4HcRLUVsB5uvP+imLiGyDfP90Z6eIZtIQeGCIe1+6ptWG+goJAbGmWeyEOxmyuzueDxfjiWTqwfqRiOYcCKTBnH+ZMzBgkXjZw3yClwQW1zK0iQ+Hc9L9VzYcZ+rcUQMNp/1TCjspR25zlRbHE4AX8kOBoEMlZJiVSLPLwG4C/u7KarGLVigUOh7cv3Hb+rR4fsasaCCa1hWk56rkYMSC11RP6cmfkYrFKICU8MNI3hg3ie3ZqwED6xH9Kia2mxK6UbYJ6XYHBJgXxif2h4WPtyRkyqhcdjSFujYOj8nCUPDa3RybMMldiaB2uRxkB3R0YLmI5CXr8ggvGj8ME7n5R0HXAa6H2e58Ks0G0ZwrU/dEgk3PkF1fFD2gFE63ilwBEPEWZ/lDXR5TiUZMUDXt9s9avEieLIESWvICS9aKdoDJ3p5ne98aJ8/c0ZwoF+nR0A03gvFY2gZXsR9QcQmlOw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5312.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(5660300002)(54906003)(38100700002)(122000001)(52536014)(83380400001)(110136005)(8676002)(8936002)(71200400001)(33656002)(508600001)(6636002)(4326008)(66946007)(38070700005)(2906002)(450100002)(7696005)(66446008)(9686003)(66476007)(66556008)(64756008)(76116006)(55016002)(53546011)(6506007)(26005)(186003)(86362001)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lL8lfi8tGC3JWbcXbuuvEDi1DzM6b+6Wzw3yTnRMU2p+CKGgdG0fLb6u2U3W?= =?us-ascii?Q?tW5Lyf0jU0ewhKzJpJY7/IxTrEwX6pyYfx+2U7Z0Kh/ccpQDUiJ9oUPwNS0n?= =?us-ascii?Q?nyu3kbdCmCXtnh+Kmdgh4RJNN9jN5jQn0/yEr4Dg7Jy9PLEnRNw/lvr1Zp0o?= =?us-ascii?Q?gUSu+E5eS/f1oGJQInKzO2NujfALap38cCv4t8mDY5Mad/7F458v5n8gjMIG?= =?us-ascii?Q?qxM7M9sFFnYf+Cy9HLjOVoCAl9K+MqHW7ciLG97Zwq8YjH9HFmlyhPF0M9+O?= =?us-ascii?Q?kFky0FLKFxVgTY6j1apRZCSDaTwBVtnkU/dzcuvkPe+d/pBVSf2vQclXMRHh?= =?us-ascii?Q?q4FWI2whY9nvO/t9NwqTEoKKvs7w0cEzKLiFamouXGSkAdLdUXU76OFZ4bse?= =?us-ascii?Q?1l1Lk91Ni23izCfhrFT9z63zaSAKT59PfnCfwxD1rv76VA+p4D6MftQPoF8d?= =?us-ascii?Q?EatzoIaTzX1OcdS8Ej8MFnuwDl1+x1VKWX6HqnjHImuRlQXBXBBHhzQTbuGd?= =?us-ascii?Q?ZF7WHCwLRKIH71TTDEt+DpwZuGvcrR/wIuwPYvHXX4AgXj07g2whxnGcIzFc?= =?us-ascii?Q?X4O4cZ9SVB90CqYx59Iqk3ZkysXmzwrL51+s8W9cXKqAQeu76bRgP0KD9m4s?= =?us-ascii?Q?KrIFMidPAh3hZd+9LKpo56j883AK4e12Wb+bTDWSMP7zytPR5ZpPY2EGpUtQ?= =?us-ascii?Q?3AQPUTpg9jAZKo19aDtY0LsCVTMunrp7KXRZut2qOscMsfWAw9WPdU5sN//5?= =?us-ascii?Q?U7fFydZZfUE4FEmrmdBMWkqjlRBEIzMBM7PLdB852MLgrxTE8LOpAEyNef+9?= =?us-ascii?Q?Vfs8vvyYBXp+fGWaqzOZgTUJD6gogUUB1FcBdL+6N1eepdMORHREmfYH+6QF?= =?us-ascii?Q?f15Ly5LTHQhU+EvMkEZqILO/VPFgIFNNmwauOMju2vfe+ttotP8nkaZzFvr3?= =?us-ascii?Q?UPHQmnAeUrV36pthOF6d+2OTKB2vHyo2XPGsSnZSOrxw0B+1KfPhY93Epth2?= =?us-ascii?Q?lOAkleV8ZNY8rjKEfnJXJxLBYY6LnSI5LpNNEWA0Ftf7/QBgF3TkzNQMuKym?= =?us-ascii?Q?BtFEG89qXHpCL4K+ANXYGXrUEk3GCU0xDITbuck+IRkihfGsH8yzPJzz+h4J?= =?us-ascii?Q?pp+yG3czZRMxMuz7++FSeNRR00C9JDNDXGlv5YY/viMvKPgmKbU2hCYBxAAz?= =?us-ascii?Q?yp6mDCCf5Vw2zLYjP42gACj0YXSG1JPxawmWozXONinJvEG2RrtKvvtMq5vJ?= =?us-ascii?Q?wEiorbsVIIEWiQr3WkYoMhQ+8X+3NvFgzseo6hWxXZCAvWTScLhdyYp///+k?= =?us-ascii?Q?MBhXN3gnQruAk9JFx/Qo2iVxqcuHADlaxtBTy3uHLKk8MH9Wl7q8O+5CmRPU?= =?us-ascii?Q?mY6WIIC/xdl7Fr3rctUkPXkzYIrouC5M1T28MaEh94o8vwqg6lElZ4ujJPig?= =?us-ascii?Q?snwIfpCT4sbX8a5I6dAU1Y8x80RlVDoAZX6WAzhGc5XlEnTIAe7HX5le3nD7?= =?us-ascii?Q?3aeApzYWFpIJF6DCMjj6sNaY29WRzGTfSey4oCql/sMIBFQN6LG2/QpOs+qR?= =?us-ascii?Q?oAgf8oRG8S9TviuIzQFVvbAwJwp4pyZl+RuAvFyZ7XdBbrEa1918sSzINSQw?= =?us-ascii?Q?ysqQL27RFmslx8rOY/o3R3c=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5312.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0ec04fd-eb42-4c11-02ad-08d9a8e2f806 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2021 09:25:02.6476 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TLVWSuLqZ3hetzO+i6ZVboyYaCfMFb51IaZMoz2XU34IBtVErhm4fUctt1NRWowBJFaO2WJPLKyGjpYb3R1tQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5039 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Bing Zhao > Sent: Monday, November 15, 2021 4:51 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh ; Li Zhang > ; stable@dpdk.org > Subject: [PATCH v2] net/mlx5: fix missing RSS validation with meter polic= y >=20 > The RSS can be one of the fate actions when creating a meter with policy.= In > the previous implementation, the RSS validation was missed when creating = a > flow rule with such meter due to the fact that a policy meter was created > firstly and then used in the rule. In the stage of meter creation, no > rte_flow_item* information was provided. >=20 > A unnecessary RSS expansion might be called since the validation was miss= ed > and would cause an unexpected error of the rule creation. Even though the > rule should be rejected from the very beginning, it would cause confusion= . > There might be some other errors when the validation was missed. >=20 > Adding the RSS validation inside the meter action validation will prevent= the > code from continuing when there is a conflict between the items, other > actions and the policy meter RSS action. >=20 > Fixes: 444320186393 ("net/mlx5: support meter creation with policy") > Cc: lizh@nvidia.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Bing Zhao > Reviewed-by: Li Zhang > Acked-by: Matan Azrad > --- > v2: fix the coding style issue. > --- Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh