DPDK patches and discussions
 help / color / mirror / Atom feed
From: Raslan Darawsheh <rasland@nvidia.com>
To: Jack Min <jackmin@nvidia.com>, Matan Azrad <matan@nvidia.com>,
	Slava Ovsiienko <viacheslavo@nvidia.com>,
	Dekel Peled <dekelp@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH] net/mlx4: fix empty ETH spec with VLAN support
Date: Tue, 23 Nov 2021 13:26:01 +0000	[thread overview]
Message-ID: <DM4PR12MB5312FB36D7C2CA6687F2EBB3CF609@DM4PR12MB5312.namprd12.prod.outlook.com> (raw)
In-Reply-To: <3672e46dd1181429c73952a93cc211ad11769b99.1637589050.git.jackmin@nvidia.com>

Hi,
> -----Original Message-----
> From: Xiaoyu Min <jackmin@nvidia.com>
> Sent: Monday, November 22, 2021 3:53 PM
> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Dekel Peled <dekelp@mellanox.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH] net/mlx4: fix empty ETH spec with VLAN support
> 
> When the ETH spec is empty MLX4 PMD doesn't allow match other criteria,
> which means the flow should be promisc one.
> 
> Currently, PMD validates this by setting flow->promisc bit when ETH spec is
> empty and checking whether there is other rte_flow_item followed when
> flow->promisc is on.
> 
> However, commit [1] adds support to match traffic only on VLAN id, the
> above validation logic should be changed accordingly.
> 
> This patch changes the above validate logic by skipping flow->promisc check
> if this item is VLAN.
> 
> Fixes: c0d239263156 ("net/mlx4: support flow w/o ETH spec and with VLAN")
> Cc: stable@dpdk.org
> 
> [1]:
> commit c0d239263156 ("net/mlx4: support flow w/o ETH spec and with
> VLAN")
> 
> Signed-off-by: Xiaoyu Min <jackmin@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh


      reply	other threads:[~2021-11-23 13:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-22 13:53 Xiaoyu Min
2021-11-23 13:26 ` Raslan Darawsheh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR12MB5312FB36D7C2CA6687F2EBB3CF609@DM4PR12MB5312.namprd12.prod.outlook.com \
    --to=rasland@nvidia.com \
    --cc=dekelp@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=jackmin@nvidia.com \
    --cc=matan@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).