From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F6E8A0C4C; Tue, 23 Nov 2021 14:26:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF3F64113D; Tue, 23 Nov 2021 14:26:03 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2047.outbound.protection.outlook.com [40.107.223.47]) by mails.dpdk.org (Postfix) with ESMTP id DB70D4003C; Tue, 23 Nov 2021 14:26:02 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R8yNwCxoCCaBwa4eb21SnpKRLTEmTYhqw2ENfemw4JedHp/T7woGuRTTrI9F5woF+DPJ/UCARr3l4bum9tm3PaRYxp4WvvunSAyB6UJ8sVPC2jcboXFHjGNXtDpM6lNspAHKCV1S+R2M7LhnvYFscb93G5CCgmFLOogTov1G32paF1d2/Wb3fulHWXQ8lh29C4zKmZzdqN33yd8GNRZhG2L8ksio88X4Y4n0gWRv0CFt/AR4/0WdQS3zz29FAcmKVMvZwX2EeDzGSQ7Gxdsul5TeZcmCVQafARqwzboLBYJVWoNXAC5bvoim/iij90NTiHyBwkfJC5V+383p9jHjuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r/cxQxivldEmcLLvSV4095iTF/BJt3jKD3qhvrGOuhM=; b=cF4BNvNV3BzlB3J5/oKtTKg3f8eXwdW0JvrysMf/Buchdby+RbAIvrOhSEhNYsyU4Dhb0evBG0iP5TVAcSy7P3S8yX5z0tJj5ZugQo1LUarTajBTDCSEXpV/Mubu7G1XvGM3v7MpKLO82P1p7xzrFXVJFBpK+KftiAMjpm1PGsiTLSwS4oxRm45IztyXL1pKu+xZ5UA6lPj2B62wwSJJeLnLXelx72ECy63AfUzACi1SsV0OQHLKxIf7H7BHyHRxd+CCttvo9FcN/pu0YNwThR2J6KPmD2PC0rM5XWaD6x1q2an9QfGcnl5FnpEvyEuOl0hNEuFA2R726QR1b6/WkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r/cxQxivldEmcLLvSV4095iTF/BJt3jKD3qhvrGOuhM=; b=pahHRtltGFekJVRHsuy/GTewxX/Ylk87OSgK//VCE6w5SHizTvhISY0ZVaxB17w5/qKOxLNvj/r+OWZHTmgEGejFEhgUo41kluJJyIUSFxGk3xueBP55qXGv1MXyat5L592mp5ciLGmTDQJqYMp6zdo0tBv1AkzgIUBPNezb6QcwzEr810tzyGnqADUaTDI+t/142E81esxwxCpvXzsrENwMn/phT5RKwO2zd6HGI3f7nJfTywPN+JyEoG3OTrvu0IboPb89YvUy8MuA7rvDDWLyJFw9lqWBE47h+76HE4LLz9wvrbvm15MOalNn1NT+dEDW0098Ver805zuzVsX8A== Received: from DM4PR12MB5312.namprd12.prod.outlook.com (2603:10b6:5:39d::20) by DM6PR12MB5519.namprd12.prod.outlook.com (2603:10b6:5:1b5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.25; Tue, 23 Nov 2021 13:26:01 +0000 Received: from DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::7cf5:9d34:fc6b:b4a4]) by DM4PR12MB5312.namprd12.prod.outlook.com ([fe80::7cf5:9d34:fc6b:b4a4%9]) with mapi id 15.20.4713.019; Tue, 23 Nov 2021 13:26:01 +0000 From: Raslan Darawsheh To: Jack Min , Matan Azrad , Slava Ovsiienko , Dekel Peled CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH] net/mlx4: fix empty ETH spec with VLAN support Thread-Topic: [PATCH] net/mlx4: fix empty ETH spec with VLAN support Thread-Index: AQHX36hlEow7xl2nZkiEOZvtyPjFtawRG+vA Date: Tue, 23 Nov 2021 13:26:01 +0000 Message-ID: References: <3672e46dd1181429c73952a93cc211ad11769b99.1637589050.git.jackmin@nvidia.com> In-Reply-To: <3672e46dd1181429c73952a93cc211ad11769b99.1637589050.git.jackmin@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c8112287-750b-4211-78da-08d9ae84cb13 x-ms-traffictypediagnostic: DM6PR12MB5519: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:304; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6tbFqHLibFI8cyvPu9z0ZN3M8ZIZHUEJwzDpBQAxeNHG8XrvAAcbtULxVqRsfcFq89PhPAXavMYd+u3rczDrZhvrN+/Mmq2KOT00xP6OZCO6+KLXimbLtTyJ3r1s6Jz8TyHmcFyzW0Xd9O3AzK6eCVDgpVWMzgntQIo9DmMi9mjH41DiUdaHnPQZei72a2ynYNyygeVaBQ4O6g4ZYwCu14aQIKMokuc8l7fhQGos7MF1TbkHgxLWg4cnDvblxu988Gx8U/2XhZNexe3yMBw4KTMvNFzd7MarnzfCGBHlDNjH6ohGQK5LbLuj5GB39hxEQ7Wmyubb2aLGRt6IWqj7yaBFIOH1bv7FU7d69JW5fr7P6WP+a14j+LQP07JlineHGFod/2cIiA4zeFGbBHD+U87NQ1aR/Udmp1vnLVdbDDxzJFtZ9nzE8wG6AHtg4Oj0wNa9GbWhLxqk8OEDbPgCQRdXjmpqSnugbHo/7nWZR1ooXE7vX1lTnpVmTL21zoahtVsdJ/Yh1fIOdoOHm+0BfPrbfbeSQzdyDFz5Osysx9MKUQhUmtwYlGwb6C2Q0CwahH8V/a4+4YVFu9CZVvpvZ5f9J9qsO+wux1NXYnNU56liANuiif0SFSbN+HyN/SFmyoXrq6WQ3Lyz2M36IeOiMkgaH0ljRyW52byic5fjo3g4t6hj7ofrbuptSai/QHC4OB1oQKvcaJ9a3Ta/CYYLhA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5312.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(76116006)(33656002)(53546011)(186003)(122000001)(110136005)(54906003)(38070700005)(64756008)(450100002)(9686003)(6506007)(83380400001)(38100700002)(66556008)(26005)(8936002)(66446008)(86362001)(508600001)(71200400001)(66476007)(4326008)(2906002)(8676002)(66946007)(316002)(52536014)(5660300002)(55016003)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?namyesyB8gtq3i8wRATy0LiyYfxpPn4YlO8zfDGU+XcrQWPiPIBsoL+MctdR?= =?us-ascii?Q?ivmIiquWd4wbgRJmZzc4ZTbVM1kZFWhZioHLR5qIkOlmEHCHMeFS112HC6tN?= =?us-ascii?Q?p4yd0c/As4Wvsxw1dp+fiQee+ZAZ/T8/ABvZJ3MD2jRenma3aneIopATFNuj?= =?us-ascii?Q?HW01xraOrWuEgRbhmZv3gZypNOmykx5pLFdUMG6EWZ7zAKhZtuXlq2qoVjWe?= =?us-ascii?Q?O6ovkevEndttI+WO3iqupR04ES/qUn53fIB63pFCY6NYFrg+bqFBfvFlN910?= =?us-ascii?Q?xxL8Lm/LKDG6qfVvqMuahUncHdnnHWqJAGtyeC3h9IQj6iqIkOAWtmbHxYCq?= =?us-ascii?Q?h8Nh7Ism8L8rq4L+gH8YzqaDsGlTdP/qcEfT7I0RBXdjAtYSWncoJi+er2Ow?= =?us-ascii?Q?GPyP3HN8BV0EhoDh4tkeLYdE4nFbFATHnqm8dgGumUhZHssem+lkf6sFMATp?= =?us-ascii?Q?Gwz7evtA7CcTEFSVVqmYoU854E1EF2ZatQIsGXFZBw3dyqFHrrDcq5uB6qzb?= =?us-ascii?Q?LtRH1rjtZgAY9V0U+kJTgx3WiXOqw618RfGOJI7ASLkIKG+6RyX0cK3beaV2?= =?us-ascii?Q?AfzN1pWG28CNvYDJTkJmWjpfZIuvIf2hZR7yq/iZL7JK5PrJFWYGfb+giLco?= =?us-ascii?Q?/fFx55IpkJXTnCCos45JvgxAUB20Vv+Wwpo6dSObVwHGm3Ipu89BMKlJnb/E?= =?us-ascii?Q?hwXNgpCIyOZfSVlWOjz2nJn2Obj2YL3mNpsmLnRpuEOulpPUbQiwkq+sgVE2?= =?us-ascii?Q?RLzQw9hoV6a9/jX46p35MVxjY3/kQONWoLpUHfGwIzSNOvInkFSWzq5TobU3?= =?us-ascii?Q?jBLw4QybzFN6yxIv01UB5itqZBRLbMMzRl46DvXCG7aCb15VMC/ayZagw70o?= =?us-ascii?Q?zyED7KIiWvnRdsCguH0a5hTRSbuB+BdZInVUYEL6yv+zNgGKjlwNbrgRmL2H?= =?us-ascii?Q?/PdQxvIkRNBN7Wvpw1FUApC1Na+5CtkT1QCz+onM73VSzk/+o7cF6v6YrsF3?= =?us-ascii?Q?uSegZDALIjFKDQ44JWa+XSVfqb+vvdebExl+lHE39I90GvsGHGLuM2oZD44U?= =?us-ascii?Q?Va0o6UbAGSfbsyfTJ7w6P2ggQ24GhalPL3spgzKsirdHtwszcRNPlAsHXjGt?= =?us-ascii?Q?DrrZ+0F0de4rT/tY1iKGKT/WYBrD1+iWnZRIc2yzCPGdQV4saO5vkEejcti4?= =?us-ascii?Q?FugWOrApQEiY5JcjOn49CE0nwtb5+kO8F/8FWfyqhSDquyH1Mo0FgRNqUUjr?= =?us-ascii?Q?fOogW+Kp2v/C6lEiBFBVmT22FRx3dSAVTH+pbm3GYNRV+VQWbYFkH1OFh2Sa?= =?us-ascii?Q?w1ogZ10/yhxwgIYAKEhCOFiFH8D6bX4mevEb6YKMv6FVoYRmj9zMg1O3WFL5?= =?us-ascii?Q?GzUFNHyOIHEcCdlEb7qRWzN/8W1USvTBGxU8/0WBrJNLcReQXK+2HwRs9/hu?= =?us-ascii?Q?b8MYK1sGrELz755peXe9EafsY6GQ2yTVaXbxX3hTetLqZ1AZsmaVqT3i7WfC?= =?us-ascii?Q?0gkIrmEB97EzJDVnwCdqR8S9JxYocAWM8iprpmLtTReiaG3Ln+r7xw207JbS?= =?us-ascii?Q?742Vb73/hvQZpWNZcbFAoXI9PnMeLvus7J1Mx7kVvAjE+NhR3w+9OBdz20tz?= =?us-ascii?Q?viQ+sy1cFOzgbMlQNkHp5HE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5312.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8112287-750b-4211-78da-08d9ae84cb13 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2021 13:26:01.4477 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Pi719EHcVIcEsnleq3c3tcDIpAZ9XIaXZL++rGI6UjuEFFvssSlFOPXdlVDy7iVOa+FUejzxDAOyRL7HLDoPyw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5519 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Xiaoyu Min > Sent: Monday, November 22, 2021 3:53 PM > To: Matan Azrad ; Slava Ovsiienko > ; Dekel Peled > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [PATCH] net/mlx4: fix empty ETH spec with VLAN support >=20 > When the ETH spec is empty MLX4 PMD doesn't allow match other criteria, > which means the flow should be promisc one. >=20 > Currently, PMD validates this by setting flow->promisc bit when ETH spec = is > empty and checking whether there is other rte_flow_item followed when > flow->promisc is on. >=20 > However, commit [1] adds support to match traffic only on VLAN id, the > above validation logic should be changed accordingly. >=20 > This patch changes the above validate logic by skipping flow->promisc che= ck > if this item is VLAN. >=20 > Fixes: c0d239263156 ("net/mlx4: support flow w/o ETH spec and with VLAN") > Cc: stable@dpdk.org >=20 > [1]: > commit c0d239263156 ("net/mlx4: support flow w/o ETH spec and with > VLAN") >=20 > Signed-off-by: Xiaoyu Min > Acked-by: Matan Azrad > --- Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh