From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75DB7A0C41; Thu, 2 Dec 2021 06:52:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EA147406FF; Thu, 2 Dec 2021 06:52:07 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2048.outbound.protection.outlook.com [40.107.237.48]) by mails.dpdk.org (Postfix) with ESMTP id 29C7E40692 for ; Thu, 2 Dec 2021 06:52:06 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nopojDOCr1Wl9Cv3EPWTfH9GaKf74ihsycFq3IHqMqPF0GCtgnjvg0npjEgOHBFR2wZ8F649C1b5TbyVbI41TgVONwtOwqNEmfsdgoxNfPOSxGg7RT16shGa2pIkJOZNaPyCaGZfqo3O073ujU58lm6QnkpLqCl8Fsal6RHyu5j2EChpcubQpNFkNHro3Us3guwlO+xct4f3yOhHC5EBCeViOPqpjdqNC6smNIMLw9xfuv12tK9vFHHy4M4px8BkQOHZfkJuoWPiTTXeOTJzXcZPVT5RfzRcZrEW3unf3Tt0/GhCA8keJXBGDRNeVud+s1xAUC33HMwW9EiEToB25w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jmdHOp5bq8revnqw6BKzOpD3WhR30rr415Blt945ynY=; b=KQxip85BBe1fVOYxmMKNEOlXdEIs6y80eErIzcB7bFplv4qkmp7IA6jN8K9HgcReqsWT3AJyxLwPj1/9wN+YeQEeibp/ZoHp+D/b59/2oIbsP19oY53oSS/QY4WN3I2H+c2U8PhDLDTMPu7k8BgzbAEPlX0sSkAYTCBCmOrYknEF2vNcIXZZN+hpvxiUiBjqFLj/l4I5B2Cehu2JyrSOmtiBg+zfic01UDPv12Yp5n9Ejhm6CK5A4F2yPj9osUqjxs4wx8i5dSZlZmwZu9WaUfVkf/F7G63eG9RWp1a6NWCW7vX4l34AOq4tlMS9Y1LdiF3MEYDsvAP4C/qv/r3pRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jmdHOp5bq8revnqw6BKzOpD3WhR30rr415Blt945ynY=; b=KE1X/x6KkBpgKQKnUgH6+GGQmI6ZrfVYrL+/xj3RKI6FE7IWCfYb8cgY+uzNkp8wDHsfnWv+TcjB6hrn3BIXu2ZeQcdMd7qMnCO0jXBpF9Yui+YUjQMwZ9P7kpys4FKnut8KWW9dvR9dRcBYZAdnOUROtvYSCU/Xcef7JReo7vQ= Received: from DM4PR12MB5344.namprd12.prod.outlook.com (2603:10b6:5:39f::11) by DM4PR12MB5136.namprd12.prod.outlook.com (2603:10b6:5:393::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.24; Thu, 2 Dec 2021 05:52:04 +0000 Received: from DM4PR12MB5344.namprd12.prod.outlook.com ([fe80::a003:6e33:8c98:790f]) by DM4PR12MB5344.namprd12.prod.outlook.com ([fe80::a003:6e33:8c98:790f%4]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021 05:52:04 +0000 From: "Namburu, Chandu-babu" To: "Awan, Arsalan" , "dev@dpdk.org" CC: "Somalapuram, Amaranath" , "Sebastian, Selwin" , "Giriyapura, Maheshwaramurthy" Subject: RE: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000 Thread-Topic: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000 Thread-Index: AQHX1iiJV8q+ALSOzEaloXAtM6obMqv/+TdggARt3wCAD5TPAIAAAlmAgAAM9oCAAajGAIAHwCOAgAFg0CA= Date: Thu, 2 Dec 2021 05:52:04 +0000 Message-ID: References: <20211110114519.8216-1-Arsalan_Awan@mentor.com>, , <1636971324930.27524@mentor.com> <1637827914612.88281@mentor.com>, <1637831201071.84716@mentor.com>, <1638348510880.95547@mentor.com> In-Reply-To: <1638348510880.95547@mentor.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2021-12-02T05:51:22Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=1c1cf0c7-977a-4434-8234-ac1c7f4930bc; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=1 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_enabled: true msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_setdate: 2021-12-02T05:52:03Z msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_method: Privileged msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_name: Public-AIP 2.0 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_actionid: a03b8dbd-671a-4b3e-9386-e17172d16ab4 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_contentbits: 0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d8fbf0d1-8792-467f-7c2d-08d9b557de5a x-ms-traffictypediagnostic: DM4PR12MB5136: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HqX9h/iemeI40ROjmvrSaIJdgQ0SYaAVjC0D2qdElUrwheB6vYI+uvX0TNO6JpyNiSDnhcZUt+KZQo2h1d9yxmYTEWcnHZ/G6jeyofdvJ1/wJ8QjfVJdHeihbnrqkAWJUPPosKrIo5cyPJ7TSCX+9xlMeeBvuSaDtTwE1bxtSlDYwag6G3lXRjNYm7acXe2SyddPz86wHXo9btuQVPWKinfQQFft4b3OInBkFXcQ2yw8Uf8YjGOKyERNgAYwt3DlbQx3aMp7xL5syNXPEx9hPqWRgyQ7TGhW/eghhsS+yxuWdR/jUEaTnXA3QhUBeOme4Rb0XneFOk0RbfayqZ1fIOpSxlZRgHJoWfzV4uezciRLKdanL6T7Pqjk6rCB+jVNOYNFzgnkSxx2oR6NcanrCEiBfIDugh0RlzcQdR2H4S9ENWTSCV29XdE0gfZTZGOTlqpcb7Yp6E24j+SnpPiRKR27JDT9kzOLros8kG86I1Dp/iQl9sEOs15m/crK/+w08khQoF3/erWNvR1ef+tSETGGv3T7J7URVtA6ljG8MSoj/IGhiRwakfak0+FWrvhIjWD5Nx+aPXt3EmG/CvP7YSO8o4z7CE/dulTyJ6RlGX+DByXuX+Wbjjw0/WaghHkl3elfQHCbW4hZbVD6JptRpy0Zm16gylIO/vPQEWNsIrrnjB0Y9Gc/QUuDHpCGGcc1FoNs6xE6aPcVydflTdxBkw5JDe5j3POd7YFsAvFEjNfi1e1jq6K70rQtcLexxa57mZs1Nho1ksIoGiYeVglZyCKYhVGu6nslczJUYcnHzGM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5344.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(76116006)(8676002)(66556008)(122000001)(38100700002)(2906002)(316002)(66946007)(7696005)(8936002)(186003)(508600001)(86362001)(83380400001)(9686003)(45080400002)(6506007)(26005)(53546011)(54906003)(52536014)(38070700005)(66446008)(55016003)(64756008)(71200400001)(966005)(110136005)(4326008)(66476007)(33656002)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hdE1vIAYD/4SogkON+aCDY6bgGhrnguWZzPINUBWg3CAAmmTDAeqLjnCGdbu?= =?us-ascii?Q?QWCNuclzvhJInhPhpsJx2kaIWTVH/rE7KCfM6YyPWbB2ysnw+e7Xk79vGXGz?= =?us-ascii?Q?FwkdisKWQuYDZ/ekSbc+UREgQ/DqqUpbi9F47zuKAamzQBhbA8LN+xLdXt/d?= =?us-ascii?Q?Ha6FnJJEVkI9Tu2GW8o8clM/m9o8V77dsZUBVYHOakmTzlYtgj92rEQbIbNL?= =?us-ascii?Q?jBJUsKSJ8mPzOwvwcbwXPz+aWtRK/K5RWmPFIVcddTIQ59dKt+/V/nxm/4hw?= =?us-ascii?Q?YHgv/OFtE+JiswsX5rsarHoau1yvN+rieN85Fzt8PqvWWF8lPk1whoR1TV2N?= =?us-ascii?Q?TzdKFJkmgy1BPzMaVXa/SaSIgy4/mX222OVMf7svniQmdgVho19GgIFmADEE?= =?us-ascii?Q?h0ZaNefs4HIp4IfQvYImps30rCP2M+kLymBNA4hSjU5GA0QjZ0Q2Jztr7deD?= =?us-ascii?Q?vu1IuLS3p0A+XYXsc0NwPrFTQXNbWbnELQiFgkgTRgkjIYGXYHfAeRcmxZwB?= =?us-ascii?Q?/tIgrrP+DZqCL9A2kSXXszf0CGJDyeJzEqe3QMBR5hZD+lnRA60K4p9n2ewp?= =?us-ascii?Q?HFUDz5becsAVghZhAhb5jhXEB9a+fEjLqkrPdPu91LgR7CmMWdgLqZNEJVFc?= =?us-ascii?Q?QNKKxJlT3ezEP1WIl/qglaI+sbpMdARv85Tvm8fvMgxcaON1wF1tNvm6X8/I?= =?us-ascii?Q?KK4sWMwtilmEje9thyYrlCicJDMlnsvK2hTOMoc4aplcbEb0TIKhPAenR2Xu?= =?us-ascii?Q?rd7Nfm7GFm8pzRcgHCGsKGf7r1r6I24dQU8YWddeKzAmlufjBkL7N0Piq+G6?= =?us-ascii?Q?BaSuQEAE4CW7y3Mdj2R1XJ9p9xxoxzKtopID6+Oozm47ajgkwdrhJSJehsjC?= =?us-ascii?Q?P08K1zWl2LKJ5LRmuLjUhNARRv1uE/iZSZxP55xBPfk03JI4cartNc3WInqD?= =?us-ascii?Q?/8DshYD34SQ2Kwk713XMQpF6yHIKTZAX3kYnNMWejmLDqBp3MZ6NgB+FDe4a?= =?us-ascii?Q?wXDZVAlHj+uiqOxm2QNoF1jREBV3ukH28tCwm/NTS4k/gYKyBug15cxbLoAE?= =?us-ascii?Q?oVWmFLaP/Z1QX6j57SdFAZ9n5U1VxpLtv/TV3sEOxg+//vQcdJHSmyj53xwO?= =?us-ascii?Q?86gujcvDgG4A35qPZdWSqZAWMa9T+/00fPLKyM8T1rPrqbdqQHxE4kUWnyjF?= =?us-ascii?Q?lgcMNxcUr3/DyjH01/mpDDAZRNNzRY0iZXyJpp8JobhXTTY9e/EZco8mlS6k?= =?us-ascii?Q?/bkzGIfaVuc1ZDs64llVupv6UI9JHGvi1J0SCA8mnwqjLWmG8vTDAZCTasiU?= =?us-ascii?Q?dU+WjBa1RyPTsEocq+iPgdwd2eDwBcYOyrCT6LZKMTvZkBdk8V8zosViGg8T?= =?us-ascii?Q?2/pJqao0mQl6ggvaxekezbYPga4GP/srLSkFdinVqiLsCGPsJ7Sejq4KYyCu?= =?us-ascii?Q?d4LkCmY5D37IsabTP2KJMB+4bJUjXUnMniHbAuWYgPtgiV7JTTac7ajCPDxi?= =?us-ascii?Q?XpA2QiQTyMYFl3BWqj8kYA0zwgJ6yoZef88xaCrJmNlYuAoLZ6PE0yOgS/b3?= =?us-ascii?Q?SyW7Q8+nhTj7thBaIduNUne8RJ3b243ibG4PACy1LceoW7mhcssdWpjDVMH+?= =?us-ascii?Q?mQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5344.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8fbf0d1-8792-467f-7c2d-08d9b557de5a X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2021 05:52:04.5675 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MSwJnne94IQWKUSBtGDij3XqKrXPM8gDyVer1bjhNN8nkq35v/bjvbZW+bNNdWIXFgV6uHtNaVUFj9F5T9vzvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5136 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org [Public] Hi Arsalan, Thank you for your comments.=20 Regards, Chandu -----Original Message----- From: Awan, Arsalan =20 Sent: Wednesday, December 1, 2021 2:19 PM To: Namburu, Chandu-babu ; dev@dpdk.org Cc: Somalapuram, Amaranath ; Sebastian, Selw= in ; Giriyapura, Maheshwaramurthy Subject: Re: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000 Hi Chandu, I have provided my comments on your patch acknowledging your solution as a = better approach than this one. Thanks and regards, Arsalan ________________________________________ From: Namburu, Chandu-babu Sent: Friday, November 26, 2021 3:35 PM To: Awan, Arsalan; dev@dpdk.org Cc: Somalapuram, Amaranath; Sebastian, Selwin; Giriyapura, Maheshwaramurthy Subject: RE: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000 [Public] Hi Arsalan, I have submitted new patch to community review and looped you in. Please sh= are your comments. https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fpatches= .dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D20788&data=3D04%7C01%7C= chandu%40amd.com%7C6355ab7462c44e390bcc08d9b4a75e16%7C3dd8961fe4884e608e11a= 82d994e183d%7C0%7C0%7C637739453199074315%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC= 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata= =3DI9m0teM9abhf21%2BHn90dJCLNKS28D%2BY%2BCya%2FADdS5nI%3D&reserved=3D0 Regards, Chandu -----Original Message----- From: Awan, Arsalan Sent: Thursday, November 25, 2021 2:37 PM To: Namburu, Chandu-babu ; dev@dpdk.org Cc: Somalapuram, Amaranath ; Sebastian, Selw= in ; Giriyapura, Maheshwaramurthy Subject: Re: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000 Thanks, Chandu! This will help a lot! Regards, Arsalan ________________________________________ From: Namburu, Chandu-babu Sent: Thursday, November 25, 2021 1:23 PM To: Awan, Arsalan; dev@dpdk.org Cc: Somalapuram, Amaranath; Sebastian, Selwin; Giriyapura, Maheshwaramurthy Subject: RE: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000 [Public] Hi Arsalan, We have identified fix for this issue and will submit the patch for communi= ty review asap. Thanks, Chandu -----Original Message----- From: Awan, Arsalan Sent: Thursday, November 25, 2021 1:42 PM To: Namburu, Chandu-babu ; dev@dpdk.org Cc: Somalapuram, Amaranath ; Sebastian, Selw= in ; Giriyapura, Maheshwaramurthy Subject: Re: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000 Hi Chandu, Do we have an update on this? Can we go ahead with this patch for now as it does not break anything else,= but fixes the problem. DPDK will be working fine as is on the e3000. This patch only adjusts the code for the v1000 and it works fine and there = isn't a difference in the approach of fixing the problem compared to that b= eing done currently to distinguish between the two platforms i.e. e3000 & v= 1000. Hoping to hear from you soon. Thanks, Arsalan ________________________________________ From: Awan, Arsalan Sent: Monday, November 15, 2021 3:15 PM To: Namburu, Chandu-babu; dev@dpdk.org Cc: Somalapuram, Amaranath; Sebastian, Selwin; Giriyapura, Maheshwaramurthy Subject: Re: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000 Thanks, Chandu! Appreciate you guys looking into this! Looking forward to hear from you soon. Thanks and regards, Arsalan ________________________________________ From: Namburu, Chandu-babu Sent: Friday, November 12, 2021 7:48 PM To: Awan, Arsalan; dev@dpdk.org Cc: Somalapuram, Amaranath; Sebastian, Selwin; Giriyapura, Maheshwaramurthy Subject: RE: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000 [AMD Official Use Only] Hi Arsalan Awan, Thank you for sharing the patch. DPDK not working on V1000 is regression du= e to "bus/pci: optimize bus scan" patch. As RV Root Complex device does not= have any Linux kernel driver assigned, this device is removed from PCI sca= n list and not found using pcie_search_device() routine. Patch submitted is potential fix for the issue, but we are checking if this= is the best way to fix regression. Will update you soon on the fix shared. Regards, Chandu -----Original Message----- From: Arsalan H. Awan Sent: Wednesday, November 10, 2021 5:15 PM To: dev@dpdk.org Cc: Namburu, Chandu-babu ; Somalapuram, Amaranath ; Sebastian, Selwin ; Giriy= apura, Maheshwaramurthy ; Arsalan H. A= wan Subject: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000 The RV PCI Root Complex Device is not visible to DPDK on the PCI bus via pc= i_search_device on some OSs including Ubuntu and Yocto. This makes it impos= sible to determine which machine DPDK/axgbe is running on. As a result, DPD= K/axgbe does not work on v1000. Let's use the Raven Internal PCIe GPP Bridge ID that DPDK can see on the PC= I bus that exists on the v1000 to differentiate between RV AXGBE and SNOWY = AXGBE, and set the registers accordingly. This fixes DPDK not working on v1= 000 platform. Signed-off-by: Arsalan H. Awan --- drivers/net/axgbe/axgbe_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_eth= dev.c index 7d40c18a86..7b1b46990f 100644 --- a/drivers/net/axgbe/axgbe_ethdev.c +++ b/drivers/net/axgbe/axgbe_ethdev.c @@ -170,7 +170,7 @@ static const struct axgbe_xstats axgbe_xstats_strings[]= =3D { /* The set of PCI devices this driver supports */ #define AMD_PCI_VENDOR_ID 0x1022 -#define AMD_PCI_RV_ROOT_COMPLEX_ID 0x15d0 +#define AMD_PCI_RV_INTERNAL_PCIE_GPP_BRIDGE_ID 0x15db #define AMD_PCI_AXGBE_DEVICE_V2A 0x1458 #define AMD_PCI_AXGBE_DEVICE_V2B = 0x1459 @@ -2178,9 +2178,9 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev) pdata->pci_dev =3D pci_dev; /* - * Use root complex device ID to differentiate RV AXGBE vs SNOWY AX= GBE + * Use Raven Internal PCIe GPP Bridge device ID to differentiate=20 +RV AXGBE vs SNOWY AXGBE */ - if (pci_search_device(AMD_PCI_RV_ROOT_COMPLEX_ID)) { + if (pci_search_device(AMD_PCI_RV_INTERNAL_PCIE_GPP_BRIDGE_ID)) { pdata->xpcs_window_def_reg =3D PCS_V2_RV_WINDOW_DEF; pdata->xpcs_window_sel_reg =3D PCS_V2_RV_WINDOW_SELECT; } else { -- 2.17.1