From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BE86A0C47; Tue, 15 Jun 2021 13:08:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 282DD41140; Tue, 15 Jun 2021 13:08:05 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2083.outbound.protection.outlook.com [40.107.220.83]) by mails.dpdk.org (Postfix) with ESMTP id 9DF3A4113E; Tue, 15 Jun 2021 13:08:03 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UkNTxo53xDyfcZyZe/HiL4CuNqZ0SCImP9dELkN9tlmanE9onL0nCaovA6oQ4z0WFPHVUxsL3JVRzxnqGqzJ14PZLFpGxPmxrup+oQoNGvvwJgV2gVtMB9ISVZIQ6F1Uh0YW4bE7PztezzhgoEaO/Jo7igIfqJTXnAjdLhGY46LcWEtbY4idvYjUH1Bpa34Stnxi18nj85OlEPpXYJLDoDT8GbnZca3nrsrDN6SNHH/AQPBqkZ5wkPLgbfxtAZ9splzniEN8MdO56/Oq2csw7gYtaDKaEuykLpAU3SKZlavXs2gm7Gd3bMTqrJBVpk5itCZk6jUPVAv8arIQhpulGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LOxMZWRRlocIvxh5Rx73F3wdtqo3nIkGVvsKbZA/LHw=; b=GMH/XSqkog45u1RCulr5cGWRyhrlpQ+FpYdlgNcwDktdX4yw/BhwzKdA0xfOiflOZIhrjltX2pVJc7pXpcWy+qdeOStgfp/4Eo+JRIDZPGCQtLIgYQBtaz3x+aeoOo2y8cE+W5muPIsY8fRFetBpGx+y65YYhTA7HLANwvlZ9mb9WHUQhbZ3FzNMeq+R2KPgy+LYCwjnTXXtOj0V+diDBXz8G20pRURKBUn2Qwx4Uf7mju6cvpCqk1MnsPfb71j0HxM+ZZHZi+lbsf+hmdLZ6kU4rtRDfNcaN2ffaZnoE4zbd1S9ccyVN7nuGlZSDxO9mV2q07WEhvX4WKNFq0+O9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LOxMZWRRlocIvxh5Rx73F3wdtqo3nIkGVvsKbZA/LHw=; b=nMtGzXIt0s7wwjg6nyrcSkfGpENir8qWtZfyI35buoZCFSAEAddUAcEAw5ExZO087wrluJQUqpYZdKpEndA61KDrux0oWp/5ugwEXnDOz700TO/l9hXNx8/0gg21IfyqiURspiIUDj669T31A140mKWOI4WoOkmXJ6WH/+7vnGuu8mbHUC9vJaMI39fsYpBsu/Dwa3QKUthZeuCnCxTBCBrF4xhGNS1ZbWGklhOdd8Xm6qbirrx6fo6x88P8plmr/7GoxTxOkh0n73oFMMx4+oErfL0z1M2PzFY2Vwq2Jrn8AWlsKLi3j0LBx5GRH6FDvwcEcWRiQEhRwqOdMzxCMQ== Received: from DM4PR12MB5373.namprd12.prod.outlook.com (2603:10b6:5:39a::17) by DM8PR12MB5477.namprd12.prod.outlook.com (2603:10b6:8:35::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.24; Tue, 15 Jun 2021 11:08:02 +0000 Received: from DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::ac75:9b9a:a03f:1676]) by DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::ac75:9b9a:a03f:1676%3]) with mapi id 15.20.4219.025; Tue, 15 Jun 2021 11:08:02 +0000 From: "Xueming(Steven) Li" To: Dmitry Kozlyuk , "dev@dpdk.org" CC: "stable@dpdk.org" , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Stephen Hemminger , NBU-Contact-longli , Sergio Gonzalez Monroy Thread-Topic: [PATCH] bus: clarify log for non-NUMA-aware devices Thread-Index: AQHXYdNwKRXjnEVL1UeAjxOJDur6C6sU6Y8Q Date: Tue, 15 Jun 2021 11:08:02 +0000 Message-ID: References: <20210615104409.759899-1-dkozlyuk@nvidia.com> In-Reply-To: <20210615104409.759899-1-dkozlyuk@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [240e:46c:ac00:505:5dce:8f60:941b:baab] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a792ec2b-e133-4d9e-7ec2-08d92fedd7c3 x-ms-traffictypediagnostic: DM8PR12MB5477: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wm0rEBtTorQH+b07ycc6pts14ywtdeiBAhJF2+Hbz46acoWgDq4C4hghHsqde15AdfNq12Mi+pICforw/nv/44Xo/ZemehgfesdzOV+m09JDrvZyVXRQEGojrSUxt9xvQVvRMQQ4/D0w1pCnCL/qy3Uc+dALlppi8q8cJu86+tTLJi6X8JhlWFDcs49TvFD0rRVCUucD2vMd7jNWJlfBDpdeWgd7pozAQw/16+KGq6j4tvhah1VfQpl6ATKrueGNef872MiHr0jy75PmnzEihJcXR8aMzPHdDdTbT/qtTYk+BQvrokPZ7GuqQ6YdUxdzr8jFfbaNM/xNqpv9Hnqj6XU9sViwh1xwWVtDHggLrpc0OD+t4VNgteUbk5DOLT1/vXv/L0xOXK64R3sGgxzVfA4nOptuVQEtoqIySgId1o0bJd8Sp0EL0YQ2kThtfYi726IGSq9yB98VWfI/U2OWLT+N0BibHlDHsPONljxbWQ0UyAY2PCuVlJkINU0yOdnULiQzmZpvWgZaED1NQmKXoGEfBsl4HrMidHEqk5zOcWmJ6Zh041Y8YAlNVI7+PitCqZ4/63Q9MbT7z2wLIi2Mrkbv1AfFKoTggx/0NH9RUqY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5373.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(396003)(39860400002)(366004)(346002)(71200400001)(478600001)(86362001)(33656002)(8936002)(9686003)(66446008)(64756008)(186003)(52536014)(5660300002)(4326008)(53546011)(6506007)(76116006)(66476007)(316002)(122000001)(55016002)(83380400001)(7696005)(54906003)(110136005)(7416002)(2906002)(66946007)(38100700002)(66556008)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dtAmR13dJP4Z+QPpV5XeXLpSvIw8PLtU9Fi3p8BqA8n/msqWykYlQaW2XS6S?= =?us-ascii?Q?5mads/RYZjLlDqzKwS2ebN4ouHBGFyHC89AYQAqjH650PBa1Ogdras9SlkOD?= =?us-ascii?Q?IkW+yyEmp5VER2euBfxe5dHMs9JABXuP3/cSY5eG1+a6/DMP0eQGVjZezTT2?= =?us-ascii?Q?AhmsODapnYufpbI+CvSJ36faWv8VucIHRclup+0osxD5idMKqeaaHA1Z1+ts?= =?us-ascii?Q?krV/pRl4kfk0bSr73PMgHaMPRz8X9C6RrXwR2XGAR5+it/H139S5IYs0BMPT?= =?us-ascii?Q?QmxwStKDxxihMA6b1t2hh+2KjqfIF/0l8qRNe1tOWEpi1ARwZvfP9naiLskz?= =?us-ascii?Q?OlaUIAf8voBvzbHEIuGkILPaeMMbdw0VqMITZg4UcX8eRQArhUHRZAB3EsqZ?= =?us-ascii?Q?xtIzD9FBFqDrV6sy6WDGvRsVGF1a7XaDQxqIOoAPtVwWWOgUgbHbGAzeaGTH?= =?us-ascii?Q?+pjmsolTw0n0utLZxU+HvM8SEW9tBs0LHr1sj3m9GqjMFGLbKfpfl1EslrEv?= =?us-ascii?Q?y86zuwQZPfvCZG7GDKUawiYjYfsLWAbL+VfYJYCFqSx4hxwOYytLJY5jwuX4?= =?us-ascii?Q?Bc61xRAt3keSltIPg601oFPisqaj6r5tGd9Z+sUnFqlUrcDE1//sNsvT4oQo?= =?us-ascii?Q?Q+3ANfjLpOK+Rv17uGUdlvA1xt35/kxRfUvI7XrmPZVa6NNt8u1Uo49LtPvY?= =?us-ascii?Q?jiwchCvCfRAW2ns1nkalp7zcvQ+knt8G1jtn+DqmvEwKrG1DCaeFLxF6zUas?= =?us-ascii?Q?PNGM0gwiH2aeGaD7N3NPTPn2p3pW+OViaAOuamJz31lOaTsCOhydkkxUCtLP?= =?us-ascii?Q?lZuzjnlZ0VNwzTnFXavyRPPDReP7OdA8fmLhqSBIBq0Gi2FCNxXDaAeYGBjI?= =?us-ascii?Q?UdOC6qItaA1QoT7UyOLFWin39XvFIr4KBpBclWBo+icwEneBmvmaMsbTqhdK?= =?us-ascii?Q?Ul415iT8sf8QYAVt1h7Ulez75DAu61MDbLw1NJIlDB+CPdVk+0hYy6wBQtlF?= =?us-ascii?Q?Cu4qMwbA1d65zM0jdNECO2CCztvl2R5yLSzDSnTmphQKhWao1F/bsNZ1W1ah?= =?us-ascii?Q?UacEPtab3rvslq7GNvSXtY3n9xKYyj4zOVQrhVqupslOcFpyEIE7KTYFmNPu?= =?us-ascii?Q?oXomxYBRndghwiMYYs/uZFKM1f2H746kid+ASxGDRzfGjbJj32uZKAEnU2NY?= =?us-ascii?Q?Y6J3J6nETYHRfQkJBJBb4OAGpZ0LxUrgy2z9nozqING9Pc1FxY+NH+/5pVUM?= =?us-ascii?Q?brUcwbX2l1+QEw5WBoiGGJQJAOVMTADpNKEBWmHNH1Chuf1Dpr6HU5Fsq9/m?= =?us-ascii?Q?kYS+NWPJBaaLzV+c4M1AnavYwqvfl9dKIVQTLUjcIKVFz3ZlYlKOVo0PSkWZ?= =?us-ascii?Q?Dv8FyPpUkFgi/SITbWyCeJwOxztD?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5373.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a792ec2b-e133-4d9e-7ec2-08d92fedd7c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2021 11:08:02.2895 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Hahp5TrOvhCOpfB/ORE3k3KWXNoUNNa5Ko02x6hIJu7vxbKPcNz5ty+271hxj8PvqgOchtTE3XVqLvExlpa/eg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5477 Subject: Re: [dpdk-dev] [PATCH] bus: clarify log for non-NUMA-aware devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dmitry Kozlyuk > Sent: Tuesday, June 15, 2021 6:44 PM > To: dev@dpdk.org > Cc: Xueming(Steven) Li ; stable@dpdk.org; Marcin Woj= tas ; Michal Krawczyk > ; Guy Tzalik ; Evgeny Schemeilin ; Igor Chauskin > ; Stephen Hemminger ; NBU-Cont= act-longli ; Sergio > Gonzalez Monroy > Subject: [PATCH] bus: clarify log for non-NUMA-aware devices >=20 > PCI and vmbus drivers printed a warning > when NUMA node had beed reported as (-1) or not reported by OS: >=20 > EAL: Invalid NUMA socket, default to 0 >=20 > This message and its level might confuse users, because configuration is = valid and nothing happens that requires attention or > intervention. >=20 > Reduce level to INFO and reword the message. >=20 > Fixes: f0e0e86aa35d ("pci: move NUMA node check from scan to probe") > Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dmitry Kozlyuk > Reviewed-by: Slava Ovsiienko > --- > Hi Xueming, > Please align logging in the pending bus/auxiliary patch. LGTM, updated. >=20 > doc/guides/nics/ena.rst | 2 +- > drivers/bus/pci/pci_common.c | 2 +- > drivers/bus/vmbus/vmbus_common.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/doc/guides/nics/ena.rst b/doc/guides/nics/ena.rst index 0f1f= 63f722..694ce1da74 100644 > --- a/doc/guides/nics/ena.rst > +++ b/doc/guides/nics/ena.rst > @@ -234,7 +234,7 @@ Example output: >=20 > [...] > EAL: PCI device 0000:00:06.0 on NUMA socket -1 > - EAL: Invalid NUMA socket, default to 0 > + EAL: Device is not NUMA-aware, defaulting socket to 0 > EAL: probe driver: 1d0f:ec20 net_ena >=20 > Interactive-mode selected > diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c = index 35d7d092d1..bf06f81229 100644 > --- a/drivers/bus/pci/pci_common.c > +++ b/drivers/bus/pci/pci_common.c > @@ -190,7 +190,7 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr, > } >=20 > if (dev->device.numa_node < 0) { > - RTE_LOG(WARNING, EAL, " Invalid NUMA socket, default to 0\n"); > + RTE_LOG(INFO, EAL, " Device is not NUMA-aware, defaulting socket to > +0\n"); > dev->device.numa_node =3D 0; > } >=20 > diff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_c= ommon.c > index d25fd14ef5..ef23af90ec 100644 > --- a/drivers/bus/vmbus/vmbus_common.c > +++ b/drivers/bus/vmbus/vmbus_common.c > @@ -112,7 +112,7 @@ vmbus_probe_one_driver(struct rte_vmbus_driver *dr, > dev->driver =3D dr; >=20 > if (dev->device.numa_node < 0) { > - VMBUS_LOG(WARNING, " Invalid NUMA socket, default to 0"); > + VMBUS_LOG(INFO, " Device is not NUMA-aware, defaulting socket to > +0\n"); > dev->device.numa_node =3D 0; > } >=20 > -- > 2.18.2 Reviewed-by: Xueming(Steven) Li