From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF858A0C4F; Mon, 9 Aug 2021 05:32:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A50A4069D; Mon, 9 Aug 2021 05:32:56 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2053.outbound.protection.outlook.com [40.107.243.53]) by mails.dpdk.org (Postfix) with ESMTP id 4DDD74068A; Mon, 9 Aug 2021 05:32:54 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kSbdj0lFDWJYi+G4hTvVtWFBQyg+pQ8GGVA/LtyNknbuqDhfAGxvlFD3dKq2dM2XjvV0Ux+ZrFBdpo3wLfHMJjBA3RCs+VW1ozYB3YteTBdeqjR6WebQcAgl0D7FRAhCQhZ+gKb319hkqZiksZLUgtW5tKJ3dLEACOn3/qOlwKrxb0rLx7XZfBfW1ci+gxRkmTQHlw5CExyfL/YBzhTg67zPTqUg8LaR+x8yBiQUJjAdQ8947ERO5jB7jcEI9/NZTpk0i8XSHHd/q+lOPUgM0e6dQIy5uUN23kt8jDBrT+fj9Khr0VdHxRv0IE9o41YkAkc6UHbAq+B6jqz8OqEmdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sx+z3qSgVaK1gjklv5Oj8rocFVm6sNSbE9jgfDmW4iU=; b=Q6PUysO6aqyhBhqx84yjeDmt1Z53ZtN+Aco3/MjtMxkEEt2AKa2DNmHtgGUEHN9eGehRRSfKMHfgVwDiI0OoR549RqA03reAuc9BsfszSg+5ZYliWF3yrlGlXlqhjPjA5k3lYNQQlrV2Zs0odxjOtqow3+GSxE9U/MUmEM+hILVfETzkxkNUMCgYV8ZDf17U17LpeFQwHupKUFzFg9Eb3WT1KRiF1tDHe2rRh0AJsqdCH5Qf9ECUOdA7mTJyZDpjzXaPK4woi5zcEOhd/GI2GRjFbnW5ezUdqpTZ2lOee0fM2OClnUuqeqHjhvAU8lpGBRRuqzjfb/gpArcy0yhQTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sx+z3qSgVaK1gjklv5Oj8rocFVm6sNSbE9jgfDmW4iU=; b=XvSmygEUGlc6NKuSQYCsWBS7Ik+ERjXZc2UaYStMocfDAU0qRShGPkZXoAsQrUwyudNsucmmL5J+awhNSBdbQqoUPqgogPtrNoqLypkYVDvrOk6+cIm2LfJsSSq9fJXvTorSOUFnsTxjupkQRu6nz3ZM1ESx30IbCMeXa82ZDCdHBWQKHIaN4A6RLd7uf3GRRvBjv9cMZ8YHnsqkGgy1GL40VvCmGaBOSs/Hn4affocaX88L4BqHTX+RfwgIONiunZEPezmSqg+7ovlnPk8O/JJ9N+10r5kyiCRmLajSLeGUzTktvda9vuki1H+RnhfRjyWidPV4wbbR/Y1hRcoIxw== Received: from DM4PR12MB5373.namprd12.prod.outlook.com (2603:10b6:5:39a::17) by DM4PR12MB5088.namprd12.prod.outlook.com (2603:10b6:5:38b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15; Mon, 9 Aug 2021 03:32:52 +0000 Received: from DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::20f5:dbdd:64b1:617b]) by DM4PR12MB5373.namprd12.prod.outlook.com ([fe80::20f5:dbdd:64b1:617b%9]) with mapi id 15.20.4394.022; Mon, 9 Aug 2021 03:32:52 +0000 From: "Xueming(Steven) Li" To: NBU-Contact-Thomas Monjalon CC: "dev@dpdk.org" , "stable@dpdk.org" , Christian Ehrhardt , "david.marchand@redhat.com" , Luca Boccassi Thread-Topic: [dpdk-stable] [PATCH v2 1/2] devtools: fix version pattern for fix search Thread-Index: AQHXjEaR+YM0moaNpUiJydJzY3VOhKtqhAFA Date: Mon, 9 Aug 2021 03:32:51 +0000 Message-ID: References: <20210616040324.311461-1-xuemingl@nvidia.com> <20210630063416.9550-1-xuemingl@nvidia.com> <6438723.YY6MpAsgIJ@thomas> In-Reply-To: <6438723.YY6MpAsgIJ@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cae26294-475f-4fbb-dd18-08d95ae65e5b x-ms-traffictypediagnostic: DM4PR12MB5088: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Rk73eoZpz76Ch+dvzTF4amJXx1kpL8zzK4PYxsd4OREVPlSMurvX+Ao7aWhtmW2hEb9yVchD8m81B8m2Sylu8/jS7Er8ddRS48Mv1OhRwF5Iai0DSzEgNgZn/k1wUBiqWEJMqB2Avu7p+I4KO8X4vvAydCU7+20QdLQieHybrDIIJTDl66YA6WowgBF3MtqkF+WKf/3309Xzlod5T1o2fmZ7EiurZqrKW0lVzQjOdJBuwyPGMu97nVSKF2U+/66k+UdK2i2wDSFL1i8nv1w6YEIxpaxuQn+X6A9fLWicOILA2bEmMhHPa+ojngENbR3B5U0WYQdaynHz3xT/ZSo1LifhV7VsfPgt8hQ9HPJ31vmnp1mwzFM2YgqQW7xTYSXVLot2qE7nuPXLtURjXb1tTPfFYPzzVphCrgZHzRcYUWWIuoxwgVnob3Z/8N7zKU30iv0Tvqm9I2i1+MhUBL5Db8ODY5nPngY9qH4ie3HIrY8eKAi2fZ3bKKKB/wCXxyml8hz6Mxy2cMENbz9RSTpR+OzyMagPpeR9m3eTaLkTUxoKXkf7G+vnVa434WPO3UjLQN9Mm1piUOc8E1zIGkVXpw7xns+08dYUeLe0uHqhsNJHmGWTFZ7F8FzESdHVIjuay9+bmEjDrfIZKSr/HW5uBg+INltu9xjM5O1R0PurdPkPIqySBJx7Tl2oAqcKli+kY+4Fp78DZwaO5iInVE/L2Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5373.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(376002)(39860400002)(136003)(346002)(54906003)(38100700002)(316002)(76116006)(122000001)(6506007)(53546011)(66446008)(5660300002)(86362001)(26005)(66476007)(64756008)(66556008)(66946007)(8936002)(52536014)(478600001)(71200400001)(83380400001)(33656002)(6916009)(55016002)(4326008)(2906002)(8676002)(38070700005)(186003)(9686003)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wcNKU5d//2KOtLBRyN0X4PzvBy1l2ix1SfZxXXymERzBBllR5PUiJ0jmmuMw?= =?us-ascii?Q?vIK1VTf67cVipaLGkr+wooY7Q9jzZcj4KOiyVRdX8FsUrigNi3xw8XiGOjdU?= =?us-ascii?Q?yxR0zomy7N0y/npwA00hGeu26cUQq884nvLnd73Qos3sVEAuxpYYTzh0M0Ro?= =?us-ascii?Q?AZwVVu8f7nGVki7aoR/YRPNMHqPpkvJBxm+b5v06UgNx4V00E9bvjFRyVrcv?= =?us-ascii?Q?tdvJw0ZCsQX/TO2gnR/rTA/9luTqTuY0bzyerLjOuf0kgAkxfnh18p/MKq9+?= =?us-ascii?Q?CiH7kPVMduD1yxQ6XfMtkrbfABb8eOySTJXrYti6hj/yr5SJ58l7PZKf3ZWP?= =?us-ascii?Q?uXqBfULMzmJPRjOcr+2S/0OrSMlmCAjqIatSZ/vJZuyiLnT/mmV/yYKmhoif?= =?us-ascii?Q?KTDWqxseGTJMhwcxjDr30zWMatbQt5124kV67iToiT8ahTdI92lmHYDN+Lib?= =?us-ascii?Q?Usm+eFLhv2pjdgIX7LHQ8E5IOFDpa8vCB1LP8uJAeR2LOND+YecyUHJGypvU?= =?us-ascii?Q?VUxJjUo891I5n4+euyQYA7gb6Zv4a/jy4zJxUIn3TOYwU1j9DfxK0DzL3msT?= =?us-ascii?Q?YkkQ2qEK29CXsBQGcd33UUKpyNVUDt1t5at6gYi4fOImccN0ZpAn/owioE7B?= =?us-ascii?Q?dsBGV53ryYOO1tzYl1lO7Byxh1gYc15BArIP1JNyDwifN1hNamdnI50Z4fLJ?= =?us-ascii?Q?CLrPRoTS6+SUB4o7KHPiPdpG1z6uxFYTnM/azVYa5983h9iQLpEkvDUql8ll?= =?us-ascii?Q?PkLPChVLVplTC7rSPwkSjuyynJMaG8PRgK6zNNneZEqR3Iv6smS5l4MBWmSo?= =?us-ascii?Q?zTenG68jWzGy9oGo96HP5u7xTh8+X3zitVqUp+No0go5iG8yojdXj+0rt3og?= =?us-ascii?Q?j6/bCnGLpw4D4Yk4EmTQP+BCJg220Kr1GkIxIRRrJUlPnSzSd4ZpeFN01oGc?= =?us-ascii?Q?nmtmbL4rGQIXmg0OKuf5NBxqNU/MJKO9TGl91PZPWFg9XLuddwoDce+kdTe7?= =?us-ascii?Q?LmN0Sg5SWN6mLVbeoBLDwKsDlDi2fVNPVxm+p2A23VbXeP7ivqn2nLqnwYJW?= =?us-ascii?Q?cgbbKh1P04X3jpbaCcN4fpIQ6EByhYiusPEpVQhiGef4aXgDwxaGvpQjrpQS?= =?us-ascii?Q?ReOnSQ+8I77Gf3FU9F+0pLVgzAmTFJlLsE0QsazmNLuC++tvfhSW1gyRm5lL?= =?us-ascii?Q?HujRrQhWSUt9xPRUuXrc9Fvo6QdeH3+SvpVi07tfN6UlSBaW//MldgBP1XAz?= =?us-ascii?Q?HwzyA5/iuhxkH2vSqRCzT+7OgX+PZUE+2qb4EGKXeBGO4MXwEmEhO3NxQKMM?= =?us-ascii?Q?XvGOsjhnG9KzkG23UxJhVT43?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5373.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cae26294-475f-4fbb-dd18-08d95ae65e5b X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2021 03:32:52.0298 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: o84RBcHO2b5rEojreAoAEJK0rw7e/aOUI83K4XmjxXHQkiMVounNSny9K6+vhdVBbKqY6aRKeKmfDfTWIsh07Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5088 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/2] devtools: fix version pattern for fix search X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Thomas Monjalon > Sent: Sunday, August 8, 2021 7:15 PM > To: Xueming(Steven) Li > Cc: dev@dpdk.org; stable@dpdk.org; Christian Ehrhardt ; david.marchand@redhat.com; Luca > Boccassi > Subject: Re: [dpdk-stable] [PATCH v2 1/2] devtools: fix version pattern f= or fix search >=20 > 30/06/2021 08:34, Xueming Li: > > When scanning fixes from current(HEAD) branch, local tags were > > included and reported as version. For example: > > $ git tag --contains --merged > > 20.11_backport_202010506 // user tag > > v20.11 > > v20.11.1 > > > > This patch matches DPDK officail version pattern in search, selects > > the most early tag. Official tag pattern: "v." > > > > Fixes: 752d8e097ec1 ("scripts: show fixes with release version of > > bug") > > Cc: Thomas Monjalon > > Cc: stable@dpdk.org > > > > Signed-off-by: Xueming Li > > Reviewed-by: Christian Ehrhardt > > --- > > devtools/git-log-fixes.sh | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh > > index 210c8dcf25..153ba5b438 100755 > > --- a/devtools/git-log-fixes.sh > > +++ b/devtools/git-log-fixes.sh > > @@ -38,12 +38,13 @@ range=3D"$*" > > # get major release version of a commit commit_version () # > > { > > + local VER=3D"v*.*" >=20 > Which tag is it supposed to match? What would not be matched? > What about something like v19.11.8 ? > What about the above example 20.11_backport_202010506? It matches any tag version like started with "v" and a "." in the middle. So v19.11.8 matches as at least one "." in the middle. 20.11_backport_202010506 can't match since it not started with "v" >=20 > > # use current branch as history reference > > local refbranch=3D$(git rev-parse --abbrev-ref HEAD) > > - local tag=3D$( (git tag -l --contains $1 --merged $refbranch 2>&- || > > + local tag=3D$( (git tag -l "$VER" --contains $1 --sort=3Dcreatordate = --merged $refbranch 2>&- || >=20 > Why adding "--sort=3Dcreatordate" ? > It is not mentioned in the commit log. Mentioned a little bit: "select the most early tag" By default git output tag in alpha order, this makes v19.11 appears earlier= than v2.x, that's wrong. >=20 > > # tag --merged option has been introduced in git 2.7.0 > > # below is a fallback in case of old git version > > - for t in $(git tag -l --contains $1) ; do > > + for t in $(git tag -l "$VER" --contains $1) ; do > > git branch $refbranch --contains $t | > > sed "s,.\+,$t," > > done) | >=20 >=20 >=20 >=20 >=20