DPDK patches and discussions
 help / color / mirror / Atom feed
From: Matan Azrad <matan@nvidia.com>
To: "Geoffrey Le Gourriérec" <geoffrey.le_gourrierec@6wind.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: Didier Pallard <didier.pallard@6wind.com>,
	Slava Ovsiienko <viacheslavo@nvidia.com>
Subject: RE: [PATCH] net/mlx5: fix linux stats gathering function
Date: Thu, 2 Jun 2022 09:01:24 +0000	[thread overview]
Message-ID: <DM4PR12MB53891700717733ACC6ABEA2DDFDE9@DM4PR12MB5389.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20220317132348.30240-1-geoffrey.le_gourrierec@6wind.com>



From: Geoffrey Le Gourriérec
> This patch encompasses a few fixes carried by a previous patch that aimed to
> support bonding device stats counting.
> 
> - If mlx5_os_read_dev_stat fails, it returns 1 instead of a
>   negative value, causing mlx5_xstats_get to return an invalid
>   number of counters. Since this error is not blocking, do not
>   mess ret value with mlx5_os_read_dev_stat returned value.
> 
>   This allows avoiding the very annoying log:
>   "n_xstats != n_xstats_names => skipping"
> 
> - Invert the check for mlx5_os_read_dev_stat(), currently leading
>   us to store the result if the function failed, and use a
>   backup value if it succeeded, which is the opposite of what we
>   actually want. Revert to the original (correct) test.
> 
> - Add missing test on _mlx5_os_read_dev_counters() to prevent
>   using trash stats values.
> 
> Fixes: 7ed15acdcd69 ("net/mlx5: improve xstats of bonding port")
> Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
> Signed-off-by: Geoffrey Le Gourriérec
> <geoffrey.le_gourrierec@6wind.com>
Acked-by: Matan Azrad <matan@nvidia.com>

  parent reply	other threads:[~2022-06-02  9:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-17 13:23 Geoffrey Le Gourriérec
2022-05-08 14:21 ` Bassam Zaid AlKilani
2022-06-02  9:01 ` Matan Azrad [this message]
2022-06-05 15:05 ` Raslan Darawsheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR12MB53891700717733ACC6ABEA2DDFDE9@DM4PR12MB5389.namprd12.prod.outlook.com \
    --to=matan@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=didier.pallard@6wind.com \
    --cc=geoffrey.le_gourrierec@6wind.com \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).