From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A716CA0548; Sun, 9 May 2021 09:46:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1EF0F406FF; Sun, 9 May 2021 09:46:44 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2060.outbound.protection.outlook.com [40.107.236.60]) by mails.dpdk.org (Postfix) with ESMTP id E39DE40140 for ; Sun, 9 May 2021 09:46:42 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f2dza6JyS64b84A6uKkET6ir4Og7PjTYfSe0Av6WkpyOvs2vxv5LlsAV8QJZcQCH7zVLoLJjbnQJEdBCiEAdDdVATwgdBm1JMR4v0lwnM0EGWtc3PdRL+YEuB6OG3RmgOngBkixGfTQM+WKvRcP8QQcwrs+p0KBJtymQ7fxjXLQ4QbD8FJmju2wLIxTL0Cla/0qpAc8cCFnLOuu+dU78i66oeEiLomPYS9qPm3FXwL1Nhf4vPcLIVeyBVxk9TI+EBSMTnZ0AmrztPbGVVwHr9yNFJSL1ecpNfdCrpgjtnhW9oplVoE2y84k6kXclpQqdyIbl+5jlPA4GzkX3pxwgjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+UtmTZ6J6bcJAamSs9Pq3ReCmanMlqHeeJ/2Apfb8xE=; b=R23jVyTSyjRLuhyHGoK49UTQ12ZytBLF9mn3DHb09LUklzzFszTc0S0j8ct04PXXTt9FzUB9jZ8E49Tgo770HgBISJ9AT3ZkqBVDrJqCrhhIoz1Wl1kpfQ5bogx5ElWgl/ZOX8s14/xoqgNnyjr5ObY3FdswlUI9vXNcidbmZUXgew3n7dh5etbw8J5OmNXzcbMoj8JJPJj/ll4yAE6f2rWImWOcydJtIc57Ty0jXJaLardhxeHoz3maj8HQ5+V8VEehcjIYoIfvYrmGLrD6Njlbn7Wr8NAPu4JojFzgAEQwmX+5ppg4z7FAa8SR4rulWAXxIQGrDz7WE3/Ykw39RQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+UtmTZ6J6bcJAamSs9Pq3ReCmanMlqHeeJ/2Apfb8xE=; b=Fl9qpFSNjL0AMcNE416OUtbi/Wg7NVgKxRajYVImAmbMfy+wROCFgqoJRcaTguLgP7GV4bVWGcLO7fUIu/f2jSQQdmgGlmRQETEHUHqLx8bKnhO1mDyFFkGW89ZFYAgsd8mKJPN1wqVG5mgT5Q8hSRMepD9EspP2FTOUmAZyvZ9B7mD8cJqHr8bsty0ZMLSMHjOV/upI87nmjEamER0pPoM50L1r5nve38N631FJSBJlA6zxDdMSOMmBQArsnmIBSucMWx5Eor3CZCmcJo+LlA8YEg2uSq5SHLwNe3PvqMUNa/1NBCMk/v0h505G7l29BfcZDimrcKmT8jLTYLJ05A== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM4PR12MB5119.namprd12.prod.outlook.com (2603:10b6:5:392::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Sun, 9 May 2021 07:46:41 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4%6]) with mapi id 15.20.4108.031; Sun, 9 May 2021 07:46:41 +0000 From: Matan Azrad To: Akhil Goyal , "dev@dpdk.org" CC: Suanming Mou , NBU-Contact-Thomas Monjalon , Shiri Kuzin Thread-Topic: [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD Thread-Index: AQHXQSnD6vYVcRj7jUOdKtk8oGg08KrZdOsAgAFWbCA= Date: Sun, 9 May 2021 07:46:41 +0000 Message-ID: References: <20210429154712.2820159-1-matan@nvidia.com> <20210504210857.3398397-1-matan@nvidia.com> <20210504210857.3398397-2-matan@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [79.179.26.253] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b557a550-2070-4037-1f35-08d912be95a6 x-ms-traffictypediagnostic: DM4PR12MB5119: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3TLrQHXfrkBBhGN3SVxEYxdmB49JhfWdMcs4CCbbG4sYwvw7dmkcukoTV9yf4nBM7NmrLbCpa38rJyoTrqyBCZlhv2qCu+lo0zqwwORaOs01nPSTTAmjcmacEM/fBbt1wIfc2HeGp00bMuSFbZDXmG1VTuEma7cLYBCoeOR1bxddKW24O//DUpQ+vywCZk4Hcb2gl5Yf+eXP6A+PhVUg9ajOII+nPEYtxPmDRrJKObYce8HiFLlO24EUe5pa3qkl5ehsc4H22F12iJTOT0D46fuux3XByXW8RxYzYaj2JNeznxDSNL4xx6dgw0FAddwz5wNCSfbvRYFsAN2VvkMC4sJcgh+UFlMb4HCz7HIYchvWieidzPYiMRDGWhYjlQR1t1VlA8ObPBOfUDUmtxjMp4tqpW2gCqmN7kW1vQACvkts8wlOpiU5TwYwxuSlFEYGhVTzMy2bMXukg6YHqijIVGHMnfPu11KE8YlYFtFQztwz5QNPCCS3uCd37APoaTAoFixqIfbkFSZCX7axN3e128uKKQidpD8lIyS196OZF+hRdyrktNGWRKMFm0EIHQW7c75+IPg7vL3msH07mOxnY0r1lNJ8cfrEgUv9dEo9lAY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(376002)(366004)(136003)(39860400002)(64756008)(110136005)(26005)(2906002)(52536014)(66556008)(76116006)(55016002)(8676002)(478600001)(71200400001)(8936002)(86362001)(6506007)(54906003)(33656002)(5660300002)(107886003)(66446008)(316002)(4326008)(7696005)(186003)(66946007)(66476007)(122000001)(38100700002)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?wPZPEJyC2Dm/rfmz9iccbYUe2fo56bpYkaGLGKNKUVNyIBFBZO0wGDO/OdSq?= =?us-ascii?Q?HJZbjuGzWdj87tB19wMi78XrWq22Tg1nKMbB+kS216nm/rRzbGuBTlbsXwnG?= =?us-ascii?Q?H0M10o8TYfsbIFrfc1h66Za6WrPnSAhK1dC9YMh9lRB/shyN0GP4d3q4QL8S?= =?us-ascii?Q?ilGi4hWSOHr7vaGosWpcLkRr/NrcjXpUgoB10Jqz2VGk6Yc+bw99yANQ4k5x?= =?us-ascii?Q?V6ZLuoNF7AgxghtXqkPUh4HSIwLkbH3Shke4rDsJ03rIXSyJ/2xDVV81GYQj?= =?us-ascii?Q?0xEhj46VjhioNgUxnmbqrIEbX7gSGtiYIn1H5AHN450tdXuAYz5u4DB19Jrb?= =?us-ascii?Q?6vyjCIYqBjADpxg60jo4VAYW0SVsqatY6Pow1hP9cq5z2rnn80e1EHArMUeK?= =?us-ascii?Q?xvl1XizYV8piSt5fgbphzcBvNYjpPsTpuHyfTPwhmaq9jySx7oi6VfHs0PUN?= =?us-ascii?Q?5ILwz85FsMx5plqT/A3H+pnYvrADjK/8vewFyFmAAr/nweaE9ImrXOR7ZkHd?= =?us-ascii?Q?mh4u1nUzxbnT0Hef3huZnjeOP1Xrn4qKYuKjQF3/n3XewJgYwhPXknBWz8S/?= =?us-ascii?Q?zPH18bMNRBO10vMjz0t4w0walidcmGT0MwZLS4LTDb76wolZalZXrAVDoiyh?= =?us-ascii?Q?KR//Y2kkFTIzBnDXfvWsFIlpultO1p4EtqG5it3NDwoN9pZduGH7Pg0XmMyS?= =?us-ascii?Q?ddG5JH6BTkPaUv+D7z0iKiuCYEEvl3G41py7ZrwVa2MQL/PZyrYx/oh3f9L4?= =?us-ascii?Q?XwPDY+exk9gY2BSroDPnsIr/1M2DovWVWERVbq9BrebOQa8qplx8TMgNxRk+?= =?us-ascii?Q?k7krN+EGoyMH9P2c89MRa3vpGtltZ9nB4lHO2GUmovIEBI9JxG4rciBbxst9?= =?us-ascii?Q?EHzy72Cc2pRI+oV4XehwrPqHC0Gn8s+0CUMvb4JT6oe0d5OcmWY9Qguw6AKv?= =?us-ascii?Q?wJ5Q4J+DzGEcH5/HlRFKc0ohhKdqyC7YmFj6OtFYlQZfIRqPISAjWeLSVmS9?= =?us-ascii?Q?mGE74cyjiFiJHplB2c83vXTalsk4ijWxC1LAoyk5zjMo14OjApyImD6IHq2C?= =?us-ascii?Q?KR52qo4v5BVeYMdA61vgxJb/5dd6djsNwyf/667JWRgotczeaMUcS/Eo168q?= =?us-ascii?Q?vReAOlL7QZ+1h5VvKtTmZveOU8neCy4jcU5QOwo5qZ0oIcHHW27tVBYJ28fs?= =?us-ascii?Q?EsZzGsvjyneN5YFm1cXtIAalr7jzQXTlRJSEhIBKu78xBTYq9ZNW4mmX+ZA0?= =?us-ascii?Q?QvRZH5tT0cvXV3WorqhcO0WzVrGZYrrTDrAS5SlrFp9V9zIZPntC2DgZWuRS?= =?us-ascii?Q?91BPtIupbNc/inBeOpwX95ut?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b557a550-2070-4037-1f35-08d912be95a6 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2021 07:46:41.1044 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: y5T0CVm9RYJt2CdumS2yEDcctDRoglVlAzyYZ638oSHmljGfqkh6GIzb8OyFW4cI7r54HBgnrgy8JbAEghL+sA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5119 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil Thanks for the review, I know it was too tied for you to review, so, I real= ly appreciate.. From: Akhil Goyal > > diff --git a/drivers/crypto/mlx5/meson.build > > b/drivers/crypto/mlx5/meson.build new file mode 100644 index > > 0000000000..fd00283665 > > --- /dev/null > > +++ b/drivers/crypto/mlx5/meson.build > > @@ -0,0 +1,26 @@ > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright 2021 Mellanox > > +Technologies, Ltd > > + > > +if not is_linux > > + build =3D false > > + reason =3D 'only supported on Linux' > > + subdir_done() > > +endif > > + > > +fmt_name =3D 'mlx5_crypto' > > +deps +=3D ['common_mlx5', 'eal', 'cryptodev'] >=20 > I don't see a reason for eal dependency. Do you really need it? See RTE_LOG_REGISTER. > > +sources =3D files( > > + 'mlx5_crypto.c', > > +) > > +cflags_options =3D [ > > + '-std=3Dc11', > > + '-Wno-strict-prototypes', > > + '-D_BSD_SOURCE', > > + '-D_DEFAULT_SOURCE', > > + '-D_XOPEN_SOURCE=3D600', > > +] >=20 > Any specific reason to use '-Wno-strict-prototypes' > Compilation works without this as well. We use it in Mellanox driver usually. This is internal mlx5 code convention. =20 > > +foreach option:cflags_options > > + if cc.has_argument(option) > > + cflags +=3D option > > + endif > > +endforeach