From: Matan Azrad <matan@nvidia.com>
To: Bing Zhao <bingz@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Raslan Darawsheh <rasland@nvidia.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v3] net/mlx5: fix the sysfs port name translation
Date: Mon, 27 Mar 2023 15:00:08 +0000 [thread overview]
Message-ID: <DM4PR12MB5389647A8308C03685B003B6DF8B9@DM4PR12MB5389.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230323105414.724908-1-bingz@nvidia.com>
From: Bing Zhao
> With some OFED or upstream kernel of mlx5, the port name fetched from
> "/sys/class/net/[DEV]/phys_port_name" may have a tailing "\n" as the EOL.
> The sscanf() will return the scanned items number with this EOL.
>
> In such case, the "equal to" condition is considered as false and the function
> mlx5_translate_port_name() will recognize the port type wrongly with
> UNKNOWN result.
>
> The tailing carriage return character should be removed before calling the
> mlx5_translate_port_name(), this was already done in the NL message
> handling. In the meanwhile, the possible incorrect line feed character is also
> taken into consideration.
>
> Fixes: 654810b56828 ("common/mlx5: share Netlink commands")
> Fixes: 420bbdae89f2 ("net/mlx5: fix host physical function representor
> naming")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bing Zhao <bingz@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
next prev parent reply other threads:[~2023-03-27 15:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 15:57 [PATCH] common/mlx5: " Bing Zhao
2022-11-10 16:21 ` Stephen Hemminger
2022-11-11 5:41 ` Bing Zhao
2022-11-11 17:38 ` Stephen Hemminger
2023-03-22 11:34 ` [PATCH v2] " Bing Zhao
2023-03-22 14:58 ` Stephen Hemminger
2023-03-23 8:20 ` Bing Zhao
2023-03-22 14:59 ` Stephen Hemminger
2023-03-23 8:23 ` Bing Zhao
2023-03-23 10:54 ` [PATCH v3] net/mlx5: " Bing Zhao
2023-03-27 15:00 ` Matan Azrad [this message]
2023-03-28 8:39 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB5389647A8308C03685B003B6DF8B9@DM4PR12MB5389.namprd12.prod.outlook.com \
--to=matan@nvidia.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).