From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EFE81A0548; Wed, 15 Jun 2022 09:47:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF2D640221; Wed, 15 Jun 2022 09:47:04 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2083.outbound.protection.outlook.com [40.107.244.83]) by mails.dpdk.org (Postfix) with ESMTP id 95B0440220 for ; Wed, 15 Jun 2022 09:47:02 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IPV2KetXjUTDani8rOfHmHcNxUkLqhlmQk4YgAWiaRdNM6AdPV0lVNNN+fOLPJ8oZmPIhSqcM6AvfiidnlhZ8l5IWO/ekOg/ZEJX09NTmHqtPSmkY0Fpl7T0zuSdG5FQogSzUXbNvpR0PdbB+F7WRpzu4hIEqLcSIXsRD8gzkMKEuDRxiKq5U0rRxrGRk5WJf63OP2mUAxGidjM1fwPGkzt5qe4fCp8uETPBd/gDyLDjUmNggVHFtLrS8xyZ84GkQaHPdxUdntAyBZvmUrbATPA0CX19JISjYWMDxg8U6G27u8jKJHla7sXWfigDwl4QeZ7vBV784aRHy6UyD0vNAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7xXguVo9Dm1sqg4Z1bdvjxgkIq8pvSJGxu39wuhikKg=; b=GKYBB0+7nCxyKwQ/WcEbCzJ6RHyAo3uVZehLhahLI5rPTOBGniYIJdqJW8jGUxsijhApsW4wJIkjhIRUItqzCoprUq4eFMhydIaWtacuoYYS20jDOgB9iy1DqROdwG+Qqm68ml/HAjXov9so6U7d2bL9bXeJ3pYztJkgMEu+u8v2Cm+Apinimf9NvMnEpJ4DMxRHPx4bNLhHkN9QZ3D0vPoXLptaRCl6Zr1WOz+97knuXb1tpknWsXUGO4h5dcUWCKfr1ZkRXJysia4CfWgK0CfWe1MtMXx0jV9KeHZ57N6U50SIlsNACRwcsGrqDtpmBCO2lHFVusKwTh79Gm0Tuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7xXguVo9Dm1sqg4Z1bdvjxgkIq8pvSJGxu39wuhikKg=; b=AnSpzVN7Deubnq0vV/f8YetEHG/pFEccIfh86j8HklZndpcqHOL7jQ2YShhdD4cTqXtN10r7Ur7SPILH8SQxNc6e84xWWH+h2hvKPca0kcyJ5UB17oa1mnuk+PP5fEbOfTIBCnefy1kzqnLJY1tp7dH/BmXQ2iHFvZWJ3Mooixm+/1gSWk5nhO0tSlK8fuUDEiIlSxTNthMcLsiJ/uIpv3vCdw9XYjQULPwUTydA2dw2cA3pltikxhicpzsUCzKc3z3dD689po3QvvkuLQr2gtThzDzU+wW2YHdttNjPUe/t1cG1isbySGarrrxgIS4gPxNb9oV0YF8YynTxsQ1Cwg== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39e::8) by CY4PR1201MB0088.namprd12.prod.outlook.com (2603:10b6:910:1e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.16; Wed, 15 Jun 2022 07:47:00 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::202f:4817:3698:ea4]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::202f:4817:3698:ea4%4]) with mapi id 15.20.5332.022; Wed, 15 Jun 2022 07:47:00 +0000 From: Matan Azrad To: "835703180@qq.com" <835703180@qq.com>, "dev@dpdk.org" CC: "maxime.coquelin@redhat.com" Subject: RE: [PATCH V2] vdpa/mlx5: return correct error code after rte_intr_instance_alloc failed Thread-Topic: [PATCH V2] vdpa/mlx5: return correct error code after rte_intr_instance_alloc failed Thread-Index: AQHYf/WRvMMZs2LtEkWbu0APDmv/0q1QFsaA Date: Wed, 15 Jun 2022 07:47:00 +0000 Message-ID: References: <640b6f87-fa5f-4a94-3228-a2c880861a53@redhat.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 67a9300e-b8d5-4e7e-8d15-08da4ea33aff x-ms-traffictypediagnostic: CY4PR1201MB0088:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GzcB6iq50qjESVlENDyvMY7MYngMl06Uj2tSsWHFnB+PVFdk2aSWR+4tzKnVVeuFZedAsOJWwGF1JnjpWVGNku2rSj+iA3QSaEZPcBN+wqIfAVMXCtnjalh7MFA/eCXhh+SQtTCTfEoqHQANKexcCRcqmtWQH7XbQuhFT1VwXtxgSfG5k7yr0Av8m53xEaV2xKAPFDaDEWkhzkFi3JoK6+dIxFvkp1I6IBE1a+I1d+6ZCXwS20ZxrdLs43Hgrn6dBv3EmT781thEjDsA/I1jIxNI2xncLXRvMtYud7BsXHMUbArkwA9yMH0Puy8Z6HyEgeJu/JxDNA4SNMFnImwKKC3n8xnEoBMRDVcnRKXSI1LxqykUP8AlW4pPagb4cmrmhUqMSkn+rLEf2n2qm2AgRTfuVX6pz/S6XYzGF+XgargBazY3jV8NOXBWPF7NsBGzwhWqYtmNtq2S8SuslYQz4S4pN/kgchuNjLLS+tudQrLgVPG4ZnVnN9sbNJbcw9mHB//0znmV7XBi2QlT3I24JtfsI8XCDiKay2Aw8iruXM6GEuLWT4YWxVrhNTurkpnhKQaGo/YmEP3X++f/WJNjF3wk/0YjeUTKzQclceKWx2yiIFFa4KbLC7Q3Z5ChkhVZi5USqzaEvVNKQgvlrsJyVJe+C+qKexDkqMyGsvVERxRwl/4QdKUwzXUpdMx+nawC1YJBM9Rr8QGbS9oQGmG49w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(64756008)(8676002)(33656002)(86362001)(55016003)(4744005)(5660300002)(26005)(110136005)(122000001)(71200400001)(66446008)(66556008)(66476007)(316002)(4326008)(52536014)(2906002)(8936002)(66946007)(508600001)(7696005)(186003)(76116006)(38100700002)(6506007)(9686003)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1xUYBQxm+SfYBvFTS2HlraQ7rGXymwl0i/ACLHRugA2Decj1emFvsjQDiUdg?= =?us-ascii?Q?TNteakSb7OwcH+fuDJQoxAyqZPPz7avACYAo6PEEm6OkmRWf68XXcmkAX9Kf?= =?us-ascii?Q?/glfkQA4rS+xGLF09j8RjKWp5F4K0T/uKDDalHdT8KPsSSmUapwZ9GSIkwB6?= =?us-ascii?Q?L8jn6ox5vnIGLYq7wwQ0iqD1q0a83mnkp3bTCEvtKFCreLThWVuMHoZ10uO1?= =?us-ascii?Q?g9ccQOsAONhEmGVuHcVU5iomkS1b23UskwFJ/tskbm3yz/ZpW/N003K2bzRJ?= =?us-ascii?Q?T/nUyWqmV3tFPGPocH0Ck4ffp1szTCD1uj1gbNjn9AMyYf016ZzeyzbhKMeY?= =?us-ascii?Q?m5WtWyXsOmWrv6U/PGl32ptwI49kNcYr1nBUnSWoGjrSGdJNvrut9qJqVBXZ?= =?us-ascii?Q?rHzq6XUqFhN7D/zt4lqhCj22pYLAugDnhrBboBkUI+3NE5+f5NmepGCVQURz?= =?us-ascii?Q?cb4DsrF3nVr/c+7ZwXJ2P8iugniZepZGBb2thQz6/X+SNCPXDSb/2Hu6EVBJ?= =?us-ascii?Q?zFB582yupI0O9VTTQD2inqhmmtQ6J4x5QN8aTeNS+s6wEM7tdBCcfRJaHY83?= =?us-ascii?Q?KUmW7faFP5Mji2KC5ysZDZxsZhGyb+jxAuO2d6ve4PHxW6xK8JM1ravDhDNQ?= =?us-ascii?Q?vua7V5iubbEsLYQK45gupZFzUvcJXvsmcFLV4qoagVwiojesIei+TOWKakah?= =?us-ascii?Q?4kGv8//jT6In1YqCcZzE9GXJqG9LBESdaC+IU6Jhc0N+oQ2Mq6VM5hSy0RjT?= =?us-ascii?Q?fgLoJ0AzA8FyB7+yzVTHVt2YNzZ+2DzxVLuOGqJAGYrVsyz6dQk6XCMt/fP2?= =?us-ascii?Q?uCFaOSEEOm7GJFPSuqjrXb1nrs716v/3szaqwJDhzjWerEShiv5nw/o/+sH2?= =?us-ascii?Q?UU9p+3kBmZBQt66YN57spyoxJ24nz7KpUrhyYvNpRSiq5sfL6dfFY6HmPiG/?= =?us-ascii?Q?Nbjh+JG8zV1LRRRGaGzNgBK9n+Pld2z/HimNOXdBtdY225fmLXAkSOkRDZWj?= =?us-ascii?Q?JPKknko8gbsJ5T2BxNnWFVnSyRioaBv2Ig1n7jelTlT7LZ2cClQsItiT/lHV?= =?us-ascii?Q?4I+C82k1Tyb1D6hsMu7fVzI3pg+n4HvLLJLUdF6jvLQySIlQ5IuCj3aMC6jH?= =?us-ascii?Q?AkT57kXKz7682dTSwi5fiF8N3/Dk/9B28d2Ar2gJVLanJKeMxPFH7NFk1j4B?= =?us-ascii?Q?KZThs64kW1aBkDno7gHbLHMv4HBpOPsgQ+iLWcjf10PPhriwT5syuf4VPa4f?= =?us-ascii?Q?yCMNyWs1JKTSxqNogJMAymOerJDahGtfTKVFkUGYO0MK13mjVI1/v5sf2jKe?= =?us-ascii?Q?9ZL8j3l7lTVJC7teGNFn4f0JO59odrk07yDV+89lCkfld1DF7YuSdFnQzDKy?= =?us-ascii?Q?sU3fZn+8icisfK2SPiMte/1+5xJyaGXy9CbOkESPmYi9qM3zieogf74Nv9Sa?= =?us-ascii?Q?6BxwM04WTUxdcrm7W8/q5V13h75vGTVTIYD8hVJu6w9+/jHd4sEMV7Q6OXYl?= =?us-ascii?Q?RTrceiokNqCHMe6x4FcInHmqFykfYP5Zdz+UxVquCyQ94uDKTTu0sgSNLbLM?= =?us-ascii?Q?Wc13B7k66krxiGsv4OSJlBaJY7Fk0N/51R7Hnf3q2VbOWUflSICef/K9gszE?= =?us-ascii?Q?bpKhvmZHWQXeCcnP5GjhSWH1EjhpyR+M9Fn1hHjx4ufQPlibLrcJuRI0+d8u?= =?us-ascii?Q?Kst5RkIj/mAJm0lYEHH/9y2HbYUEwFOyM5T3ZQyQFLEFOEUF?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67a9300e-b8d5-4e7e-8d15-08da4ea33aff X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2022 07:47:00.2653 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6Frzb98dX89pObH4WD0m0t9N+xIDDS1rLSxW6ZlKHqF73HDvxQzxqKsBXEXRc11s2VFgHU0idYQeeqg37a32vA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB0088 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Shiqi From: 835703180@qq.com <835703180@qq.com> > From: Shiqi Liu <835703180@qq.com> >=20 > To Maxime, > I am so sorry too late to reply your comment.My name is Shiqi Liu. > I got stuck in how to reply the comment before.Now, it seenms to be > ok!Maybe there will be some mistakes I have taken , when I reply,please t= ell > me how to do it correctly! > Thanks, > Shiqi Liu >=20 > diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_event.c > b/drivers/vdpa/mlx5/mlx5_vdpa_event.c > index 7167a98db0..6223afaae8 100644 > --- a/drivers/vdpa/mlx5/mlx5_vdpa_event.c > +++ b/drivers/vdpa/mlx5/mlx5_vdpa_event.c > @@ -395,6 +395,7 @@ mlx5_vdpa_err_event_setup(struct mlx5_vdpa_priv > *priv) > rte_intr_instance_alloc(RTE_INTR_INSTANCE_F_SHARED); > if (priv->err_intr_handle =3D=3D NULL) { > DRV_LOG(ERR, "Fail to allocate intr_handle"); > + rte_errno =3D ENOMEM; Shouldn't rte_intr_instance_alloc set it? > goto error; > } > if (rte_intr_fd_set(priv->err_intr_handle, priv->err_chnl->fd)) > --