From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2914FA0548; Sun, 9 May 2021 16:19:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 074DF406FF; Sun, 9 May 2021 16:19:36 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2084.outbound.protection.outlook.com [40.107.236.84]) by mails.dpdk.org (Postfix) with ESMTP id 1DAB840140 for ; Sun, 9 May 2021 16:19:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C0liQwHBewOkNiS6rjtb+i3h99vPVZ8H5NgGXz86m146/ueUoZGhibIy2VLXKlJcr28fc6RueOZtYebuEdrTSojTWFK4hY2iZvJmt/Xh6zfoyvAPvZkaMF1avSsXwclRZGgUkRKjmsliFxRZTT7e+c60344wfR0xhWqwMOab+5R4gWnKPJhipo9LqDSmsQqYFAeYroQJ4ZX2FBjf795IarUfl6Nghzj8X4mq4XdBEQI5dtyYJn4cJdGyTvSt9QZ409M9M+4d1vHhphTORw1jrd5EYuhaM0zjyn/P8YKrE6pRCZu8TOuXfDVSiNDS7Paz/sdbuy20OvOqCeseCON6lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OsMrKSCtMd/epK8UEv9CJyCqxlr8c4jxy6Gt+Y6sYFQ=; b=PCRMlYVPiv3fs1e2MGKc7uYWBiRDSJjJaUzgbT5bC77ReG6o03JsuE6Jy6emnvskcJ2RiIMJrFaIt8XpyR2w7A1KOko50fnm5CmWRHH6r6xxzvqVobI6v6ohx8iGHcV3fYt63qQD2aAI/BvngIKzGL9zd3yj/vWcPvteXDwI4Fx0NuOCcEcFXbh/ATV/D0eEv3Oc4RCbKY7MfxGlHd0H0VhKbW/RMigj/D+5+3yOfH3WpNTRp+ED37h79lOQwZ6762EySOvC/SrqzL4Zke4hB2jdupgujt/z0uFID/tnii2dZwlKwdmE0PqsqzZTo1qn2rYgPAszWoGB+XuQMdgT3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OsMrKSCtMd/epK8UEv9CJyCqxlr8c4jxy6Gt+Y6sYFQ=; b=gOO6jVRRFCrTASMc9GdxM0xV+Z1WNaNWwkJoiOBOXmONBuThqSn15fRpzB+ENxvUU2hwsZ2e/2prsDFPOQQXHyKXf+vRSlugpgNK7nYK5SNjUp6yIur08azQzUPaXAvOc1r0qVNk8cwWjHp8nus0y7uJSxMraOGOOdgP0Yjj4oyPYlD9qdx1vL4ezigPmJ9FW8+nFG4g5e15tooCvAdxRs1fwDukGz2gy8b7/F+ZCdye1uscOddiHQuHLNL5NNVTRwM7BPvLZfwx3mKVi3Bd+0ARYlcGmolRzxdrD56ePHdgbPwfH3YyE3J6EUQId8iyKsHom6NA1jofviwvurSdqQ== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM6PR12MB5535.namprd12.prod.outlook.com (2603:10b6:5:20a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.31; Sun, 9 May 2021 14:19:30 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4%6]) with mapi id 15.20.4108.031; Sun, 9 May 2021 14:19:29 +0000 From: Matan Azrad To: Akhil Goyal , "dev@dpdk.org" CC: Suanming Mou , NBU-Contact-Thomas Monjalon , Shiri Kuzin Thread-Topic: [EXT] [PATCH v3 15/15] crypto/mlx5: set feature flags and capabilities Thread-Index: AQHXQSnWSi9lLLdzVUyIjb1J25XG7arZhMOAgAFWmUCAAAnXAIAAUc5Q Date: Sun, 9 May 2021 14:19:29 +0000 Message-ID: References: <20210429154712.2820159-1-matan@nvidia.com> <20210504210857.3398397-1-matan@nvidia.com> <20210504210857.3398397-16-matan@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [79.179.26.253] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: eed71f02-1c72-4a4b-292e-08d912f575a8 x-ms-traffictypediagnostic: DM6PR12MB5535: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hQrDkXpiCbFkyEzoulwfBSPZP4tj84rIH7TemJya8BoWkgKG8pI2CwtUgwWRwzRkq8P2VelHf3d1wwl08Tt3dgh5fRkMKdii9HAQfTfiI3hJUezVX4SBQomcxEqsMb3H2E+2+1x3/3om3U2B/4n8vk8IhBCNUs7qfqSloBteP6oFaBuM2XOouKyJiyfaQoOMT2PwZFKOZzIZt9tD8WYCQqC/LtdWGwYVPlXo1kt9wBX4K2gTJMrH7752l2Q9JLvPeluqEPEIHrqCjH2lR0Se+s2pna70gEPL1l//p8v4qheqbdJhl7HNvSaQNJfSO3IiHwM3rctzmW4aT0wG/AzCXinP8NgEJxdl6K5HoAiAHpoakAvlKVPe7YfWcCQbWDIxcwaopw3Acy764R1P611JJbwjB6qKGeSKKLQTiqkbXy50kAmjlCRzuTA9MzQzUKf8CZ0THq+tYQW/Y0DM/VjT7xE+5ShfzvJdvgPdPGSbJLDcJ+BOGhMoUf8KdpE2RXt4vel0yzILoEKFclrNaL1+GyCqNNbMZ9yw/dOb5WZ9TvtOfkB9hJURZ4W5MN51hHrpz6SNIvMDUvC8kzOwqNAnkOQIP3L0ARcBU4MAoc/2sQA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(346002)(376002)(39860400002)(136003)(52536014)(316002)(54906003)(5660300002)(2906002)(110136005)(478600001)(186003)(4326008)(8936002)(33656002)(9686003)(55016002)(122000001)(83380400001)(38100700002)(107886003)(8676002)(66946007)(66556008)(66476007)(64756008)(76116006)(66446008)(71200400001)(6506007)(26005)(86362001)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?yXiyIdpJjSwyoifIQctnqYSyO1XGgSDSXlRwQkEVsS9BKe+xK8LlNHOFpggM?= =?us-ascii?Q?+kkkqXrziLmNuA/a4F2ZD4KPOteawJ1qcT/DYry0+7PanaOXmWKSoiYLAl8P?= =?us-ascii?Q?fWhhFggxvEqiD60ZTg1UIzdjAdM7IJ8SdqjFHBnrZ/EaybNUxNDlQF1FCfbY?= =?us-ascii?Q?Kw+kuu66JWvgIAqS3Wrj6WPSA8ORVHUfs0tpc8G4cQlPaYy/n8Dt09B6SWMQ?= =?us-ascii?Q?wZbI5l1kBS6lltrtrUF2j8rwz+JjBXUYB+WBDgpVS/zx9eDKG3R06T/0jEo/?= =?us-ascii?Q?qgeW3NpmxxovRKi/CHbZeqAPNy3nzKfL4Z7xwyDdE2MRlFS5qvDybYPKUsVP?= =?us-ascii?Q?4OGNuoA3Z9rxyLHXut/UF0Od8TODXx66sBZxLQxxg8Uq5C14BpgC2oWtXSs9?= =?us-ascii?Q?zUMM3xzcHX7XkMoaq3KUAI9j8nqZzfBB6f59BNgAqnlDpmFd0Xf2zuwlLkWO?= =?us-ascii?Q?so0M+g4yTLwRuyJiJ/hLjA8nmS+JviJjuPAiyF2W349CNg1+JlM3fLjeKVZW?= =?us-ascii?Q?2JwKEkf5wy7OypKd4c71/Xg1Qyr7YupzAulvsH4KqBYutlx8ykFb2gu94LJ1?= =?us-ascii?Q?ZM0N/OL23nsdxfwO9cOo7jCrlxYTdSyxZPECVS7VC3rQsqZcRsJ5VsuQAo4e?= =?us-ascii?Q?NnqBWBzVpcpkNYHhcOJt/DtZIBoXyyH8D1CGxWVEu4iew5ggJrOseGmNsrOk?= =?us-ascii?Q?Rg/WiaV/MRREvsty/4hD4XsY8V+HIXsv9ZkKt68BrkqkRWpODroupSZpVHeZ?= =?us-ascii?Q?9JtznDgUaTzhxuVT5zygaki/ECE8Tg2FAjoOZXd9FakEpNM+Ay9b4WMQfRPi?= =?us-ascii?Q?pO712Gr1aZfeC53TmSYhUy71v2KGjmhGFM7lMtZXO4N65m22XiK2SP2CotV6?= =?us-ascii?Q?6fFDx0HnmEBqvOuGxW8aN+RD6UJrgdGFYIQhyVeyI3+BuGFpCfJxD/bySagT?= =?us-ascii?Q?s2uH35WE0Z3s5AxDFZ03hvYuPYjS0yKUNY9IjQ0NK9LVL7vl2EBMH7G4HDK3?= =?us-ascii?Q?nqXlJjvXN7bh8bhPN1XXb1iDTD1wBcQA6pcfzJ41a94brWO6Dzjkeogv4lBn?= =?us-ascii?Q?D+PZbkCVWZQCF4Ksv25MWRZEt3up6N52BvJNul0TMiU2PXl8dqLu8eltVCgH?= =?us-ascii?Q?xvkM6WcelhBmhcNwEB6zBSWMjVCnkuHRZmkVwqLS2b+SaUKXts8c42szZlG+?= =?us-ascii?Q?BfHEIcuKmBSe/MoArxVl0XNj31VaESu4vknrqG6jPgobkjJFgRXvjYIr0bJt?= =?us-ascii?Q?0A1Ci8FVrh72WkbSkr5GWMxydGfMpbTVHieluo+WweAlZLeoRVhrbaVGKJOy?= =?us-ascii?Q?UL+P/L9NCSyGZyuG7XWP57N4?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eed71f02-1c72-4a4b-292e-08d912f575a8 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2021 14:19:29.8593 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dk52+zx+JiQp+dw3Py7+g7vmaVFesABTA07HRyYIv6mK1+uAcD/QagnmfGDJ1nGhmUiyRBK3Wcp/8dNcAHLwRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5535 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 15/15] crypto/mlx5: set feature flags and capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Akhil Goyal > > > > +Supported NICs > > > > +-------------- > > > > + > > > > +* Mellanox\ |reg| ConnectX\ |reg|-6 200G MCX654106A-HCAT > (2x200G) > > > > + > > > > +Prerequisites > > > > +------------- > > > > + > > > > +- Mellanox OFED version: **5.3** > > > > + see :doc:`../../nics/mlx5` guide for more Mellanox OFED details. > > > > > > Since the driver is by default compiled off due to the dependency on > > > external Libraries, I would recommend to add few lines here as well > > > for compilation. > > > Like to compile rdma-core and set PKG_CONFIG_LIBDIR. > > > > Why? all Mellanox drivers has the same external dependencies. > > I added here link for the doc explains it well. >=20 > This is a crypto PMD, not a NIC PMD. Somebody working on crypto PMDs, do > not really care about the NIC PMDs. > Hence it would be convenient to have compilation information here as well= . > You can refer to other document for details, but basic info should be add= ed > here as well. The link explains how to install OFED, this is only what the user need to t= ake from the link. The basic is to install OFED. I don't see a reason to duplicate doc section which are exactly the same.=20 > > > > > And I do not see any updates to the test application for testing this= driver. > > > > You can see update to l2fwd_crypto, we tested with this example for > > the first stage. > > Everything looks ok there. >=20 > L2fwd-crypto is an app which only test data path with no packet validatio= n. > It does not tell if your encryption is correctly done as per standards or= not. > Did you test interoperability with l2fwd-crypto? > All basic configuration tests are also not done, like cleanup etc of the = PMD. > I haven't seen a driver getting merge without the unit test application r= un. > Test app helps you comply with the way dpdk drivers are meant to be > written. We adjusted the l2fwd-crypto to the dataunit feature and wrapped keys. We validated data integrity from the packet returns back from the crypto ne= t port. As I said, encryption\decryption with AES-XTS is working well. Now, is too late to update the test application to the above features, the = driver code is here for a long time, no one ask about the test adjustment u= ntil now. We can add the adjustment to increase validity for the next release to all = the remaining crypto apps (test\test-crypto-perf). For now, we have one validation with l2fwd-crypto And any user can run it a= nd see how to use mlx5 driver. > > > Is this driver really tested or is it work in progress? If it is > > > work in progress, > > We > > > should defer this PMD to next release. > > > > We can continue test this driver for a long time. > > The basics were tested in the above crypto example what proofs that > > driver works well. > > If we will find issues in other tests, we will send fixes. > > > > I'll send v4 with your comments adjustment soon. > >