From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 010CDA0C47; Thu, 16 Sep 2021 20:40:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C2AF407FF; Thu, 16 Sep 2021 20:40:15 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2063.outbound.protection.outlook.com [40.107.236.63]) by mails.dpdk.org (Postfix) with ESMTP id 9E1B34069E for ; Thu, 16 Sep 2021 20:40:14 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fSEgZUxVuRHS2il3eLHgpHGC8mgN6mVknrIA8y4oJqJbSZn4mFYJN4QMF+Gglj52vWasZ/2scHdjxtEhqwpi5yFGwvBFh2kqka+XIoaG0mzCriUkjwHTz8t1lmjWDVZuw8IcEB11yNu5EOWTI/PyygWSSVjiRWenHn1MHz0MmlNq+Qu71yqNiHojdzaSM6wWZGH7PLiw+xwm+TvdD5jFV/Ugiop0mOeVnDALfgjeZ2LzTj2328jMGNAD/G6kUOMCoXXANlAc7ExeG4aFiPt9WrFVes1X+mayd5EKxd3uRZgq+/3aLr02RWDJpKvm2aZj1CoG4T5z6KhP+OxqF2SRkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=BpzGUe/+qZv47PbqjJZjECZyo1Sd3Cb2Q7u0PPNFizI=; b=N2cxYCtJ3wr0JSJeYbvGX+Xt/Tv7lEY57yvGqL8lfaLFPaZZifePSmwHY+u5esCZrr09gG9z7FBw5qBatQ2+4P4kdZyhLqJAJl4JA7bZFXxyt3vmneOfWmOgVq3w8RpHCzevJopi9i/U3pHci2Mo9ONRKf8cRMyC756rkf8YH712Yu1OIhyb85GXSdEUn+Oikg0Oqz8xtnCLX2WsWw3XQdMnDL3SStjL3il6cF7C30AoQDCiTJdN//CzoTVgzJD2GkX/A2G9OOxni48Voy5kZGdGLgfam/tFOKdIVXCUsAtsYdaekFX3sQQZ/iZG7tnShHZgfU8N/KBfXe12tfE1rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BpzGUe/+qZv47PbqjJZjECZyo1Sd3Cb2Q7u0PPNFizI=; b=XEPz5nlaPAj2xr1H5Nrw56aCkL81oeWUvRyu/zwuLDI4WNfaC794V1z90Uj5zayLB+y93du/HOZZPXgWmw6TzM/9Sk6rDct48J4W3O/6pe7Xc3yo/sZw04hwYSrQZtHJKWA1hjl1FBHHhrT85nmRjcO9PVQm1bbIWToIXCcO7pbdwv3spQFXL3yq120jrK73x8++8lFwNnFVPZBm3wHg4vwKNEhFJy+9ktpzn7JzL7nR+6EnCp61ZmlyeK0bmb2c0m5ardW4E37YpHw8+cKQ8y3X16qMMB4FE+TXyr0I4ZN9Wuv1oUQDNazy7zahRBlHww7w47bbTIac5WuhUJdeSg== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM4PR12MB5056.namprd12.prod.outlook.com (2603:10b6:5:38b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.16; Thu, 16 Sep 2021 18:40:13 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::45be:2914:19ef:f4bb]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::45be:2914:19ef:f4bb%3]) with mapi id 15.20.4500.018; Thu, 16 Sep 2021 18:40:13 +0000 From: Tal Shnaiderman To: Akhil Goyal , "dev@dpdk.org" CC: NBU-Contact-Thomas Monjalon , "pallavi.kadam@intel.com" , "dmitry.kozliuk@gmail.com" , "navasile@linux.microsoft.com" , "dmitrym@microsoft.com" , "declan.doherty@intel.com" Thread-Topic: [EXT] [PATCH 1/2] security: use the net library for IP structs Thread-Index: AQHXql+NiXx2aTgXf0eMJFHSXcjVDqum/IOw Date: Thu, 16 Sep 2021 18:40:13 +0000 Message-ID: References: <20210915162603.16652-1-talshn@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9504986c-ce48-4f1d-d41d-08d979416b82 x-ms-traffictypediagnostic: DM4PR12MB5056: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JbH5Apuxt/i/pqT3kER5qce7wPFw319ZfYoydjinOOhCRoDAXg1xxiX3+316rGt5WuumcEQi89HnzBCpIjK04sTfIP4l7GhzGiPz3B+yUOu4CXUp3uCZOR4dOz783Z7tyiFSNZFKlNWG/G9lYJnFg1sbbYOBe0tGgsC5+OmuSg/Rd9AkoUhuXslvvjse8MnXiN1LX4qZEArfXubojzAAQnd3fIWyAijKbIRbkvnsHPCwureWSSe6fXLC0FQeeTeySDo+BpkvH/2nukAVFV6WT1m9G5/4tgbvBmJff+td06CZvjGXUEm3OXFtEJBKlIkBM0ddhEar9xmMr7m2VucvXuBbmDGd7uQDUmKKAmazQx2zFVfcwh5QDkGBSTxBJQ3ZbZpQIVcrYNUWMS0MM3IcSTs2yTGDh/udK7EIYy7n8V3gxOcjBIlL3A9EdaeTPNkUU67243up6Q21fTUlmZRqR+PZoVSu3eJyH7GzC7c6FsMXcLdtx6UKx3sFlXMXNTPffqX1CCdyT/1hB72o0+0PtYYpB1WUmIDgi2qa0Fq8w85gdbEtN8UjnMGj9AE6tYv4Bzyq5tUDkLF+UxxgAz/SHCOUR6FzV3GrRR0/gtNmiZVyLuDmxOtK8e2ve7lGPifyDj9DPVDuSoMMPB6WyMgzj5TQ9cALzVSi7emAc/5WS0MoQ+dlpwMfZ0JcntsZCJFlF8H4Z0lXPWF27R/mwYHjIA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(38100700002)(110136005)(66556008)(66446008)(54906003)(316002)(122000001)(86362001)(38070700005)(508600001)(52536014)(55016002)(9686003)(15650500001)(8936002)(71200400001)(8676002)(26005)(6506007)(5660300002)(7696005)(186003)(83380400001)(2906002)(76116006)(4326008)(66476007)(64756008)(66946007)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZqYsPJxueuoRGyxhq+jhSPmAlySszeL2U6G1ZWPS45eOE5j8lFaj3Kkl6Dkv?= =?us-ascii?Q?/pbsaAXBKEf7FJguX0YMCrGGK62GBzApbjuTWVeBfoFK+Xb368T+HRlG6h26?= =?us-ascii?Q?1DwL+g8mQIEFDLZedraLo030+6LMchnA6DwVixJB9YcvoDZf+ZbssHEMZnKN?= =?us-ascii?Q?zN5qKVpNRxezzGpXxBdQF8130pfsNlbzHlD9iun7lLV5eRhSiI8YogemRWfi?= =?us-ascii?Q?hEvhb4bzAOLOfnoFaiRSeTqU3Eaa+GMaj/v8ZfX4OrH05szc3KLDrHYAyCPO?= =?us-ascii?Q?KWgDMGo4WoE2nEIm0NdkYHb1jbgjjXm1kPuc1s/er4iteYJ5nX+LXStQKO1B?= =?us-ascii?Q?a5Cnpvfg6oP18NNJYxWbuT+eKPqOjag6is1E7JvWWnW75ZZ1MFTcIP9AtVmL?= =?us-ascii?Q?XLwjD0BkvPI6nsVrnTjY8Nu0kKEHJ2QGy0hwtN2bhR4qaqWcjxtPlSa7VCC7?= =?us-ascii?Q?uMg4ZW/0r1vfS9DmjP7MjPa7IInJIDIEqvKmQrbMiKfGNFROUVXsNk9bGcKz?= =?us-ascii?Q?hNpCEabhinVJfHFeqxKQZeyeiRxhN9wQQ/3+zN9k+rif26FCke5pc2gykC8n?= =?us-ascii?Q?DHr9DTR5+xQPosaF6hG4h48F7H7KmPIQJt5RKPf8zFiNVTuXCNeYHPBA39PY?= =?us-ascii?Q?chTvqewq/iyW/MmfSB3YpVB4I8axh/zaKtQZYMSKTRBGsvumf78Fh4yBimMN?= =?us-ascii?Q?2qSh/Xs2Mdrxtq/mQfZuHPf5mfI122+mKIIpn3MlM4ZsLL8XnKbqbBl2g0wA?= =?us-ascii?Q?1O73F9Ak4HpVmPQC93JPuqAWZ5hZq2nyqS8us6BFrNlDmybnkHfhxpsfEg35?= =?us-ascii?Q?6JfQ9ZO527VnMLEZwJqHPdScQHrVmr9tVHwlWbj7Qd4aKF4eDDkLXskpV7L6?= =?us-ascii?Q?ZlW2+x0ejznp2pdMAkMQDXhdpVE/5uZK1sk6v8RQTPPM8y9Z4nYEItfE0PaL?= =?us-ascii?Q?hoz/4SF3WI0bG9tVhyIookSCic6z8uIUeTiTQdO3BgNoMx04t4l0aqtJguwQ?= =?us-ascii?Q?t576XS20QQKvvze98yye3QwHvTGo+T8DbUOWFLaIT3s5VC5eqmohmOwepEGr?= =?us-ascii?Q?XyajHHHggzoNO6zH9HAD+0YAEAHvwgr6vRpV6ERt5X6kt+/Dc0Y0CiHTtu9b?= =?us-ascii?Q?2G9/tCs8vymrKQwxBiOTSalte/XS6ReZXA1KjeRzihEZ3PH828qiZ0p0oZEL?= =?us-ascii?Q?WisVANHARP/+eTuIh2RoCYDXAULJHw7YyW+H4AEa5d2OoKb4xh9OUIwa4bYJ?= =?us-ascii?Q?mJl4j9fwSkx+Dw+fWVgbVqUpHqjtsODx3wsnHO6KF9FcGJxn3bkoAlU7Z+2q?= =?us-ascii?Q?WZQ=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9504986c-ce48-4f1d-d41d-08d979416b82 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2021 18:40:13.1853 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZtIVLO+996+q86m0DZIG1W6i1rq1RZ5Y8OHxQJ/dDqePnClMg7RJ2Fe+RftgGl9W0QNDyf83Xnz0ANbDof9o4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5056 Subject: Re: [dpdk-dev] [EXT] [PATCH 1/2] security: use the net library for IP structs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: RE: [EXT] [PATCH 1/2] security: use the net library for IP struc= ts >=20 > External email: Use caution opening links or attachments >=20 >=20 > > Remove the netinet includes and replaces them with rte_ip.h to support > > the in_addr/in6_addr structs on all operating systems. > > > > Signed-off-by: Tal Shnaiderman > > --- > > lib/net/rte_ip.h | 1 + > > lib/security/meson.build | 2 +- > > lib/security/rte_security.h | 5 +---- > > 3 files changed, 3 insertions(+), 5 deletions(-) > > > > diff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h index > > 05948b69b7..bbd8650962 100644 > > --- a/lib/net/rte_ip.h > > +++ b/lib/net/rte_ip.h > > @@ -25,6 +25,7 @@ > > #include > > #include > > #include > > +#include > > #endif > > > > #include > > diff --git a/lib/security/meson.build b/lib/security/meson.build index > > 5679c8b5c2..1034a7a299 100644 > > --- a/lib/security/meson.build > > +++ b/lib/security/meson.build > > @@ -3,4 +3,4 @@ > > > > sources =3D files('rte_security.c') > > headers =3D files('rte_security.h', 'rte_security_driver.h') -deps += =3D > > ['mempool', 'cryptodev'] > > +deps +=3D ['mempool', 'cryptodev', 'net'] >=20 > It is just a header file inclusion, will it really need to add dependency= on 'net'? >=20 Without it I'm getting an error of missing file on the new include, I can r= eplace it with an ifdef similar to what rte_ip.h has and loose the dependen= cy: #ifdef RTE_EXEC_ENV_WINDOWS #include #else #include #include #include #endif however I think it's better to remove OS includes, unless there is an issue= with adding 'net' as dependency. > > diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h > > index 2e136d7929..0c1adcee21 100644 > > --- a/lib/security/rte_security.h > > +++ b/lib/security/rte_security.h > > @@ -19,13 +19,10 @@ extern "C" { > > > > #include > > > > -#include > > -#include > > -#include > > - > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > -- > > 2.16.1.windows.4