From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7499FA034F; Mon, 7 Jun 2021 09:29:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6471D410E9; Mon, 7 Jun 2021 09:29:30 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2076.outbound.protection.outlook.com [40.107.237.76]) by mails.dpdk.org (Postfix) with ESMTP id E7F5D40041; Mon, 7 Jun 2021 09:29:28 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l1yC6srgpT4M62NPJP4mY6VxqmCxkDgFKlfT44lFvk3wzLfGrOYyVP9O2n8BCzOmiBpHv+KqlH1H2Nvbu4DCNoZ1sRpWIp5BwnjePrdEop/hJhoNF6VNb0OEeTZt59w0wOSvez6qQXV7/c/h/60Fy9jZKkLiZf2KS4SLyZ0AP6z7c3UKgHuqBXQ25abbLuLQnRstKVn29K0TaDM/QTOYf5rouQ6U5YIfnaALwRqix3SbW2AYm7nDJo4VwdBEhVtQba7ghdmL1A2HjKoNQD53qTDLlAMs1LNs4+O5WTtBy+kK4tbVuQeP3xgeg67whx5HD/5NTn1OLMq+LTtEUpahXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ciJVB2+nBoxZWvLy6VmRi93A0H3IanNiH3cllUeXkJU=; b=fSMPJ1D49xTxWf8sAm/nNgoOpIpN6xq9tExe1SgPLr0XZP0/FbAExkeEWWhkRNFufIc3xyEnayZkG3yI+75s/jnkdhy2sxXC4N08gr7gkcYjR8jvke1Rv+W6XgSGwRdX6UeAIzDMP3NsffimFiRm5LcmYhkcrdcYN88dyK9lgOlbM3VpTtRw+vtwkxeLTX+THziAsHpfqcy5S6Utw7M7eTuTXrC0tlDWfi6WePrvM1SFve8yIWZRDcnURLJ9LHDDBjt8o1pJcRRNHPxc5XiEqEQGNr9ZeDb4CZEAU0S+w1NN0TzJFM/c7PkyGcgQquXb0K4++vMYLthfH7EIJgo5FA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ciJVB2+nBoxZWvLy6VmRi93A0H3IanNiH3cllUeXkJU=; b=qkIGsYpV0JmR+eEyS8c1sVbHlddzKvLba+fv0/At/judIHl/mLGw0dLxvlBGqqRuE/aeqrReAJfUYIMHo+7jseKw5yZZ1+NfvMFuvdku2fnI59TGpIf62oC6BMZ8J3KMmHq6Fa/nwwCMVS6INf7RJjl/ADNL9BDiqJSubvefIdlVj147rOoOqUu0mM82bRh5Leg38VTOyziqKRvfFo9eDW/JAiuUs9/8dZc28n/Pj8FWBPgkipKaWSqCEU4woFPoB32rN8M/zUqYUqUP4flLncchxgtutYXojYIDONjSkE5ZTOgwm8r7SeCdrk7bRx97KZxFCHuRA7Rfyfu/p5Yt+g== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM4PR12MB5293.namprd12.prod.outlook.com (2603:10b6:5:39d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.20; Mon, 7 Jun 2021 07:29:28 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4%6]) with mapi id 15.20.4195.029; Mon, 7 Jun 2021 07:29:28 +0000 From: Matan Azrad To: Michael Baum , "dev@dpdk.org" CC: Raslan Darawsheh , Slava Ovsiienko , "stable@dpdk.org" Thread-Topic: [PATCH 4/4] net/mlx5: fix constant type in MP allocation Thread-Index: AQHXVrVrzIg8Y+AVL02EBWSQCVwj6qsIMDMw Date: Mon, 7 Jun 2021 07:29:28 +0000 Message-ID: References: <20210601071122.1612432-1-michaelba@nvidia.com> <20210601071122.1612432-4-michaelba@nvidia.com> In-Reply-To: <20210601071122.1612432-4-michaelba@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 721569bd-3661-40b2-6883-08d92985fbd4 x-ms-traffictypediagnostic: DM4PR12MB5293: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OLYhlnq9yUO/pka4NsDj5923O+QxOnu68AVhYMJ9Ow36evQq3sjE/l6fEWvgZKz1HOOIdnUgqhx/5wxURvv8U3ksL41xQvfN4XiqWmiNn4O9ujdLhw54eiTqTM1M+pNELavjwS1H7yOqWpEg5EPPzNklvjFnlsdxhujqYWN6lyyJ29DhSclwRio0gCn/fT9JGb8/TbDjgOpGqptef7q7Eafo1icJ4lw68BGeVCS1GC0QiQyufP48xaYxiAizJfXLXW8mXiTwXfDoy8IirHSCNMYJvmpw2mfuuzC3DmMdCkO/CB8MvjFKjJeq7RyizIRDSl/g7yd9S+5ApnFS7rsN7l6lMKnbyAbfPVEGfJZ1348n4hCMrhE0NQKyspY64sUTKowCapvAlnVRZosauAgZXHTLI8jv51j9QKhmHwU3VkOWUjYRmCNPoHW7W9azmAg1HfnyzJdHeLti9R6HV4M5weSWCvPaiJRsFQm10rp1KWp6sAop+bJ67qJ8SZpYi9T8k7ZKs8Xn1aAOP8+VDLP8jbC8sEgBkuCbyAI1jKtjM0MEIYDs15HkCaZFsx24xFRyaQc+unzksMflZXpWrcwCKPsqlTDM0nBZD4Y/AxuufB8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(136003)(366004)(39860400002)(396003)(9686003)(4744005)(8936002)(110136005)(316002)(26005)(5660300002)(2906002)(66556008)(66446008)(38100700002)(52536014)(66476007)(186003)(4326008)(86362001)(66946007)(55016002)(54906003)(450100002)(7696005)(76116006)(478600001)(33656002)(122000001)(71200400001)(8676002)(64756008)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?8JIAvop2UUrEpvr3sTuxBnmLbo3JoHPeEDLUc4yds4d1lp0GmiZRTjAk6rAV?= =?us-ascii?Q?pSal75PuOpdqZrpNx4cfgfCe9p7fwXQVA7HSsajw7nhRz5yRc8nepcIENB1O?= =?us-ascii?Q?yZx7DJ1v6VaEBofBKmCl+ZzGTGxOHJ7NRY371u/F26T5oFiVnlTQvST459RW?= =?us-ascii?Q?liidsa2P259+vx247aQRW8wLpmuo0FkTrf1It5w0FKRk7cFziBI0G0giVsDD?= =?us-ascii?Q?4l7DPGHEl5Uvw23A8cEa3uLP6JQsN2jwXkcS2hVd6JWLzdeX7xAsc7NdF+ij?= =?us-ascii?Q?0jbdEmpNY3Tl5TDLO9P+6EtREtSRjsfSbx1yPg/8vdANVKdcIWEDf6htiw36?= =?us-ascii?Q?WRCQhnJ7u9acPa7xZ8nvRjBxh3HcEmEJxTuinm5ST/LuamPltmgmfo1DWJML?= =?us-ascii?Q?yL45iZ0fhqN3RZ4K2uY6jnVFHK/eJHBnrQa8Gw2tepEGHekf00ID7brOft+G?= =?us-ascii?Q?+UUs2bxOjeoiLTH6WTG0dAZYkFsQ/d8niW35rssRAOk7mvZYxvIRa+RUipp3?= =?us-ascii?Q?diUKT75sOpUaEWpFBwvW5JspFm2qckELJcWdaLL/TKA/a9uMWDLwpVPA3c7H?= =?us-ascii?Q?JRHmml9KpHoOumT/pZgCN6rap+EWGY3QEscq2FeSFbh4krtEtnem6CA4WEG+?= =?us-ascii?Q?9IVHdJkZEKPyfmK1gc1ig2U683U7A0yqE7pF8DIFCccHcK4cx8XTtEsSWBvp?= =?us-ascii?Q?NvZbhb/0FxPNqVV2CTnPwGY50YB3yR2qTlEreKdTtvJbFzDbRlAOCFm0nxcw?= =?us-ascii?Q?TJICMZIHf/OPKcpxb0Si5Ax2c02NmKH1k2Dfq24unPYeEUpc7uSOuMkiO5fS?= =?us-ascii?Q?Q9d80N0IGacPdXrvbMB/45eS6v0XJj2mBb81ZROmYCrJvqQbZcHMW8qz9xhg?= =?us-ascii?Q?mQh56nBrDrxZeIiXHpzz7knF2zbU9WCNmha/g8rPoiLjYNy/sOCO/s2YjTJh?= =?us-ascii?Q?Td6NbstfooJpMdusmbUr3jGFocFW2DdT8mWBZTwNVCFg6zdIWZSM67Sk9cQA?= =?us-ascii?Q?cbvQpWr+HWXjQKuT+2Ga0qifSgWc3HhPVvZ5YXZRWL1MWPUUGveHDStg24qT?= =?us-ascii?Q?BIguRgx/lSjUco6whOXeh4HBLCEGNdERal3GDSbkbAPUwhh+r2fessb7nj4F?= =?us-ascii?Q?wNLvxO/VNmmgdD0L3zi0lM9GdFWysjEWyqGBF233QhVC0V1B96k2mA+lIQar?= =?us-ascii?Q?4b6AEhjg3uteal4FftZbFkuqfxWvfZ1DJOpMKWV9TFu8COVWkrZLcoQC2PA5?= =?us-ascii?Q?5VfPmoYJT1c8gk3YVSbz28dL5+jldwEHJi7dxnPyd/I9+/lB6sGDXDg1pKJ/?= =?us-ascii?Q?axuH072qtzQTZsb/r9sL8NJn?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 721569bd-3661-40b2-6883-08d92985fbd4 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2021 07:29:28.0214 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dyTbEqYjs42v/0QSZSNliQTXSliv850t2mzaovJXsNR6RF6LgWrOFjEQQAEi/F+Dkb/jh00zi7OEVllUINL/jw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5293 Subject: Re: [dpdk-dev] [PATCH 4/4] net/mlx5: fix constant type in MP allocation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Michael Baum: > The mlx5_mprq_alloc_mp function makes shifting to the numeric constant 1, > for sending it as a parameter to rte_mempool_create function. >=20 > The rte_mempool_create function expects to get void pointer (64 bits, > uintptr_t) and instead gets a 32-bit variable, because the numeric consta= nt > size is a 32-bit. > In case the shift is greater than 32 the variable will lose its value eve= n though > the function can get 64-bit argument. >=20 > Change the size of the numeric constant 1 to 64-bit. >=20 > Fixes: 3a22f3877c9d ("net/mlx5: replace external mbuf shared memory") > Cc: stable@dpdk.org >=20 > Signed-off-by: Michael Baum Acked-by: Matan Azrad