From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6225AA0C43; Thu, 23 Sep 2021 17:44:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E113F41260; Thu, 23 Sep 2021 17:44:21 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2046.outbound.protection.outlook.com [40.107.93.46]) by mails.dpdk.org (Postfix) with ESMTP id C5C0241257; Thu, 23 Sep 2021 17:44:20 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I0UgiG6aPP3En/z8cgufV4Uw8nues7a3Z13VT4nVtXBa9TRP+T7yuUtOME4o7iDEAHgpYtCeFdB0v8AVfn8Cf1D+5lIwlIf2nxadkz6GZJXKVF0oZa+Jt8JfAWdE0IEGp8dcIcZaTO6vlzsW2ke5ZT4h4I1IaHq9OhGGmn3RSs/E+2czW5aRbsCXTw7YZXoOAaTVRnZNljW/Bb5EqxIOWV+QFhA2qyx3mTCL6vAi0CC4G3oB9+ggIGsjvMmdxwAgcurwljR1GSAUALQsL24oezBhDYAMpkE6co4ACbHWYYcmZy4rSzjlmRuw2R/TFJS4cUhRBXjleWKZ7tYdHZHf6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=sbye1+hkB9+ZGHR27ZQCVTd414KZSImkLPbKd5bdh2Y=; b=cfRPq++iPOtIC2+3Q+JfpqS9/sjzHOff1RZeHD/2qLCJQ1q9ysCRqyTnykGwoaN2z4DQw5wQZ8AjJz7rvZLtwMECCGv1BPPAjvSsh/h4j2d3h1+rwz6hGnf0UTI0kMS1cgg7MIzx/5MT39DXP8mkqAI6toZEWnYGklHTIt6MmJjxp2qgkdfwX8qo9uERZ7c6cXxSBiYUiD7MLYIDMnTcwEixh9icpsDEV/QjYLbkSEOAySTsqu6vPnnS1vUm8CeiApEzjpaz6bsZCcYjvsHpo2CnaTDlX3GMPkV+knwc1sVKWRReCPd77SiZwZHLH7+V1x33JK9e3M1RH9gQEH/VDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sbye1+hkB9+ZGHR27ZQCVTd414KZSImkLPbKd5bdh2Y=; b=O1Has0ehssvUi7izlFit0BS1J/UnboCDeMCE5LFdH1woPCeByHrdzpYu/6RXeT1KwLcOVIVTxGEQR6uGLGvo880ksDExp5Zc7iHIf/yJeTdQEsj/AmqlcWQOAYtNX71PRbkJmPHTku0tCK0C1D1G/PxFJC1KPIxyCwSStsPjbpmUtho/k7Ap2C3BVXtxchLzhsGYw7zZOaDtNeXuNx1xEhtvMkMNTnGDcmNlFP5CNCFk7elvXJBIBKVqwqFzt0aW3BiQzCmpxj1SKWTHTqDAhu6sU6R2ACfeVxkwgQq2jOCPntkEMzrVLOlu9rb1H/ZoDDWl8db2EXr0EyblGSlH5A== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM4PR12MB5309.namprd12.prod.outlook.com (2603:10b6:5:39d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15; Thu, 23 Sep 2021 15:44:19 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::45be:2914:19ef:f4bb]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::45be:2914:19ef:f4bb%3]) with mapi id 15.20.4544.015; Thu, 23 Sep 2021 15:44:19 +0000 From: Tal Shnaiderman To: Pallavi Kadam , "dev@dpdk.org" CC: "stable@dpdk.org" , NBU-Contact-Thomas Monjalon , "ranjit.menon@intel.com" , "dmitry.kozliuk@gmail.com" , "Narcisa.Vasile@microsoft.com" , "Vipin.Varghese@intel.com" Thread-Topic: [PATCH] bus/pci: fix numa node return value Thread-Index: AQHXr/OaKMsrIvkv6E2mowhZzMbif6uxwmDA Date: Thu, 23 Sep 2021 15:44:19 +0000 Message-ID: References: <20210922211906.2135-1-pallavi.kadam@intel.com> In-Reply-To: <20210922211906.2135-1-pallavi.kadam@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2e5bc2bd-5b4f-4a73-0846-08d97ea901dc x-ms-traffictypediagnostic: DM4PR12MB5309: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: g4tRl4M/7hKneQ5kX8W7NMVavSf116/yuX7H+zCpNfUydMH9oviHW9zWWmxQNW0w/M6VQMzfKThT7Wqzuqj8YqxeWnxlaqSBPJNaB2MI3/9D+WMT5SJnCKGAFqoibdAUZ2g4Ex4vKI62zbZf/HGuXhMWJ2af9qGGfJ7/vd3kxq8WebfPXeQl3uDUTx2MzweTCTlFCqsvvo+G4AZ19Qyv/QhC7afixihetRXvd5n89MbuHZtuYWgrB9rbGEp3EqJ+GZItMuaVPkVb/AqXidndA+w9+SMQIhOMHDIWglzNZTZBd7N5bvPPquHvRFy68ZUx1qMW0AttZf8fzzTF0PaHHF9wugY1ZHsQBiOeARK4NccKQVEOyKAaUnfvsAb0K7EVfX+Y7jZyDncRL0HgShUdf/CX0QP406gBSAqijzaCHq898WmHvc/Fx4/92/3syILAS3pcnUIDHcp+uIUkdCS9FAhRFlxQclSuXq/fpUoqRzgw/hfuhm3aWFrYyySHQuS+xjp6BT/4qmiz7PbD8I25oMWSCsihlT6UjcwbDUQZFy080hOLS+ELBOFZBBKRPUyj1hwneu+JNmVopTfsRt8o+iiganDY8W/4AXh9Sieuoo5Y9OQ9+l46hwzKIb1e3csaDEFcAWhQpdm9/Mc0bpLHVBh0EG4Qxm33eBInQDgcEjzT2CFNd6zy1eQu2ZAX0WoUv9msvoTNHHvZQyIXeqPtyw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(7696005)(26005)(186003)(86362001)(6506007)(38070700005)(33656002)(508600001)(8936002)(66946007)(9686003)(122000001)(4326008)(66476007)(83380400001)(55016002)(54906003)(110136005)(76116006)(2906002)(316002)(52536014)(66446008)(66556008)(5660300002)(8676002)(64756008)(38100700002)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?51g+kuFXVp4G146QWZ0h0CXA88r6rsScs6dGwMpVPS4+NqD6qCzdYoSMS/Zx?= =?us-ascii?Q?7bAb+ly4uFgsQGxCdqQdSjztX2fKJUY+vgiH0R+blhkQ7BT/GG8ANhxrbrhk?= =?us-ascii?Q?VscHq8zNbNZTyvFpM8t6+XY3URtYNtBhMpC6HdOhTgESX9OJvsPH2RT9cYph?= =?us-ascii?Q?s/hlyTvxjkza5CxK65mK3xkUVQjLzhyq9QBU/iBpES33UqQUmSGRFSrcAShb?= =?us-ascii?Q?jS/HnwgYpBmqvvZ3U6Gf4jh3JShZfZIOlBv0cXBKXr8Iozt6mKhlPhtS50mC?= =?us-ascii?Q?taGCGhP6dnl2qlMN4FR72WH3yW1VhXTN9Uv4ys4NEK+jM0/eUo/ERoJaiEkv?= =?us-ascii?Q?RhTojllWhXQWLJrA1oQMnCK7Ot2YoNCADS142KxXYCgB7ELr6cMt8W5NT41p?= =?us-ascii?Q?AiLtfJ3PlqDdps/dc8hqPYsC+OpN1HUVm4TEa6QuLKucXl0Un14+KJJZmvyZ?= =?us-ascii?Q?8ODOeQSkD4pYDx34huXOq7Lo3MgoP4vo04a7ZVFQPsEQ7MvAZqN7LN2bruec?= =?us-ascii?Q?du8y406nKKyas7nhFOINzCwr422e1G2/dQn2IRR2JlYolqZdQ5nvKY3ZTsUU?= =?us-ascii?Q?ky2O/mt5chQkqnfQkK/Iayxzik/LEAANqCalDBdvL/LopXwXbMMlSae3NNvR?= =?us-ascii?Q?YK66ooHXyYLkNSey/oQDhMVnhn1tUaFYMC4JT5TyuJRfafM68fdVfLHtO1ok?= =?us-ascii?Q?UiOJYTRneo7nKLFN7OjiXqWeLGYo89X8QOmglNWl5tLipjjfJ+5UF6I/p6tx?= =?us-ascii?Q?kRjg8JKEieMlG3SH9DawevzIFBsG0NHmE8D1oIrDGRQKntKlOq48zAhAIFJo?= =?us-ascii?Q?PemM76ldi/ZiSDlZ16WOU4j4Fm6kY0ZpnFMgkVolDcrKua5U8XSRDkh2CaoG?= =?us-ascii?Q?XZB5ncY1ln3BcPSOaEJcb5klURcaejq3M4h8o0ZoMTG/ir1lsUrnom2NxE+o?= =?us-ascii?Q?5Fi1DjXCxjZAaXolHiEtG21U71/lL6Q+5eUvrqDTkGQ9NIj0ItjeW4LJqbNo?= =?us-ascii?Q?k7HnJ9F7mFFYHyexdn+6GjrnvrAn/Z+r2suAlYp7HcT2FFHRSXZiJmBNkZ/4?= =?us-ascii?Q?SqW8VzACyM3EDtPM2zZTE+XHU4CeCb5fnrn3sabG08K41F4SKnHm+2gxSDzB?= =?us-ascii?Q?T1AAd/+0uc7sJJE7H9DeL5zTMFNFjMshS4r8VHDRdyMBk7FuHNyBiGgLP8bt?= =?us-ascii?Q?wIH7J+dSyqS6k8LncRO/VKN8aMBgIYbYPe8/3jQ599PTd+OLrwoKuNdyDeh0?= =?us-ascii?Q?c8FuSePiecBaU0LGlwetlIEHhl+db/uCwibmz+GAKE27l9rkYm+cfsLRJ5fy?= =?us-ascii?Q?wEQ=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e5bc2bd-5b4f-4a73-0846-08d97ea901dc X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2021 15:44:19.4918 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7D4lSXVHSneGbVNUQRmQuPBFmnAgJj/eWp772tK7+pIZhOKowAtZK6R3mDL0TJ4Qs8grASvlAqLEsz1LoHcIUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5309 Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix numa node return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: [PATCH] bus/pci: fix numa node return value >=20 > External email: Use caution opening links or attachments >=20 >=20 > On older CPUs, currently numa_node returns value only for socket 0. > Instead, application should be able to make correct decision and also to = keep > consistent with the Linux code, replace the return value to -1. >=20 > Fixes: ac7c98d04f2c ("bus/pci: ignore missing NUMA node on Windows") > Cc: talshn@nvidia.com > Cc: stable@dpdk.org >=20 > Reported-by: Vipin Varghese > Signed-off-by: Pallavi Kadam > --- > drivers/bus/pci/windows/pci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.= c > index d39a7748b8..343ef6f33b 100644 > --- a/drivers/bus/pci/windows/pci.c > +++ b/drivers/bus/pci/windows/pci.c > @@ -5,6 +5,7 @@ > #include > #include > #include > +#include >=20 > #include "private.h" > #include "pci_netuio.h" > @@ -243,7 +244,7 @@ get_device_resource_info(HDEVINFO dev_info, > DWORD error =3D GetLastError(); > if (error =3D=3D ERROR_NOT_FOUND) { > /* On older CPUs, NUMA is not bound to PCIe local= ity. */ > - dev->device.numa_node =3D 0; > + dev->device.numa_node =3D SOCKET_ID_ANY; > return ERROR_SUCCESS; > } > RTE_LOG_WIN32_ERR("SetupDiGetDevicePropertyW" > -- > 2.31.1.windows.1 You should add "on Windows" to the end of the patch name to clarity it's a = Windows issue. Aside from that LGTM. Acked-by: Tal Shnaiderman