From: Matan Azrad <matan@nvidia.com>
To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
Raslan Darawsheh <rasland@nvidia.com>,
Michael Baum <michaelba@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Lior Margalit <lmargalit@nvidia.com>,
Asaf Penso <asafp@nvidia.com>
Subject: RE: [PATCH] net/mlx5: fix devargs validation for multiclass probe
Date: Thu, 25 Nov 2021 10:38:44 +0000 [thread overview]
Message-ID: <DM4PR12MB538976CCED397EF7C72F6EFBDF629@DM4PR12MB5389.namprd12.prod.outlook.com> (raw)
In-Reply-To: <2510169.dztEg1IeGT@thomas>
From: Thomas Monjalon
> 25/11/2021 07:16, michaelba@nvidia.com:
> > From: Michael Baum <michaelba@nvidia.com>
> >
> > The mlx5_args function reads the devargs and checks if they are valid
> > for this driver and if not it returns an error.
> >
> > This was normal behavior as long as all the devargs come to this
> > driver, but since it is possible to run several drivers together, the
> > function may return an error for another driver's devarg even though
> > it is completely valid.
> > In addition the function does not allow the user to know which of the
> > devargs he sent is incorrect, but returns an error without printing
> > the unknown devarg.
> >
> > This patch eliminates the error return in the case of an unknown
> > devarg, and prints a warning for each such devarg specifically.
> >
> > Fixes: 7b4f1e6bd367 ("common/mlx5: introduce common library")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Michael Baum <michaelba@nvidia.com>
> > Acked-by: Matan Azrad <matan@nvidia.com>
> > ---
> > drivers/net/mlx5/mlx5.c | 68
> > ++++++-----------------------------------
> > 1 file changed, 9 insertions(+), 59 deletions(-)
>
> It is quite a big patch.
> How well it has been tested?
It was tested carefully to see that devargs affect the actual configuration and also to allow running !net classes devargs with the net class.
> How critical it is to have in 21.11?
CRYPTO class cannot run with NET\ETH on the same device.
No significant risk here; I suggest taking.
next prev parent reply other threads:[~2021-11-25 10:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 6:16 michaelba
2021-11-25 9:29 ` Thomas Monjalon
2021-11-25 10:38 ` Matan Azrad [this message]
2021-11-26 12:39 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB538976CCED397EF7C72F6EFBDF629@DM4PR12MB5389.namprd12.prod.outlook.com \
--to=matan@nvidia.com \
--cc=asafp@nvidia.com \
--cc=dev@dpdk.org \
--cc=lmargalit@nvidia.com \
--cc=michaelba@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).