From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E99D4A0C47; Wed, 27 Oct 2021 15:33:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B854D40DDA; Wed, 27 Oct 2021 15:33:25 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2050.outbound.protection.outlook.com [40.107.236.50]) by mails.dpdk.org (Postfix) with ESMTP id 3A106407FF for ; Wed, 27 Oct 2021 15:33:24 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QZA2QRsCUQJbu1YIUUaZ7BwRrJf8sT4j6jIsu2MeNctR+irUPvUj021dZ5iXPYMm8MRPfg6534xinAqUQY9qYCSvPU2s4dvI9/ndSlGNPbviUieC9yW+3ld6KZhmVOlxL22nhhXtswAawnTTaP63q3wBz9+SgaftOlM84F307e5vU0WDcmVC6YVaI81IUL638RXSYio9496R1Zl8x87PlIbOMCGhs/WDLGWbWv0TW1cRAYglmlvB+kLOhyn66GK/MMCxwrKthXR3zBhlLA2Q4Bg+a7aFrOHTHNpClw0F2XSS10uLR8eiH4SYmSl+i0Kfrcv/G4bxK+4vfNJUNiSn/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p+O35XhzRKyVGP9w5eL8/ouX/+iPdBF+YYQTsBy9hq4=; b=fO+vGo3BHzaJtCtkik2zFt4TxayjkEHEfUbTZIEfw4phwPVIEQVJTNP6CKo9uEzSLV40fTfWZwZKh16gfWULMkmHL5DdXRPhmyFi/T70wNnqlV+a7t5Oa2izQn+a4/wWsRilI9O4fzndc8qmUkRpyt7M6MqF4Wzr6khsDmhG36UVCF1WEmGP9ZwVT4tar0EE8td/h5CtWSOOQ+MhZkzZev+ubfkL5+YwiMoCQbBtVK7wkGjwAAAyA6ux8uUHNYyJUECS7p5pKmgiY1+X9/03Sa7RMvtVapEl67bfWQpYu2XsWMY1EeAI+C8t8+NfDzeBaBZpJtC0NDuw2EkP1frN0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p+O35XhzRKyVGP9w5eL8/ouX/+iPdBF+YYQTsBy9hq4=; b=uIlMBOOZPsFE8zGXN/TbpXujJnFY8kHtjpp5EWHvOKCHecZ/UO6W3BzwaP93Pdg6XQ+ardfyVcZumsLPOEYj73GvMW0S86+/z6KUdCQiLfWGcOz9J3BFQrhhKZbCCkjpUIcauY3ob3hCJ5uyMEkF5ZQAk9dmxXYWZkeCPo6VueJld876c+2WjfxiIG4kvoHFPPbhIyPYiZOn4/gYzxC3sQng0O0mpfGW630KGl1jsEFycu+PdPQDE9RQlKiIYYIiqioXFqekckEq8yKO3iVloiazOb5z4U7pp5c/U5W7j4WG2AT5PnKEKdBG8QLLsiWPX9kGJMTLMlrUp8tDHK8UpA== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM4PR12MB5214.namprd12.prod.outlook.com (2603:10b6:5:395::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Wed, 27 Oct 2021 13:33:21 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::45be:2914:19ef:f4bb]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::45be:2914:19ef:f4bb%3]) with mapi id 15.20.4628.020; Wed, 27 Oct 2021 13:33:21 +0000 From: Tal Shnaiderman To: Akhil Goyal , "dev@dpdk.org" , NBU-Contact-Thomas Monjalon , "bruce.richardson@intel.com" , "Yigit, Ferruh" CC: Matan Azrad , Raslan Darawsheh , Asaf Penso , "declan.doherty@intel.com" , Slava Ovsiienko , Eilon Greenstein Thread-Topic: [EXT] [PATCH v3 5/5] crypto/mlx5: support on Windows Thread-Index: AQHXyyrPxM5GzGn+g0e6Q3Nh1GOzeKvm0Wqg Date: Wed, 27 Oct 2021 13:33:21 +0000 Message-ID: References: <20211017094133.18988-2-talshn@nvidia.com> <20211025084617.4952-1-talshn@nvidia.com> <20211025084617.4952-6-talshn@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7fe2aa50-800d-45d7-6ee2-08d9994e584f x-ms-traffictypediagnostic: DM4PR12MB5214: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Svt9KlyRXdlLvRiTijlfE2lYesnlJTZ7fy1/Ukyh/CfclQSegCVgv8Hg490ZfvT7vrJFJKTLl94A3ceaOcoyyRKoH+Ux7POmcHd1rWp+E/J2kjYqp/HIBxaJKuDRo7HC7akVdBaMdo705TJ0vQSY8rG0+iCpULqMLbI6oyR/7EOZpRFV9U6kcUWofD1pfaNWz0b3tlb2Bo+YFftc3dPQ2qIhyQsNxHr+yUW+B9faDSOFgM/PlFzLLVll0H2WIOFGjdMaGoKsXHvVHxL3GtzardCIYLsmtIYy/HFJiTzYFGVhY08VHSodwRXd9Ph+cZLkJ/tyqh7Vik8LQdXO+ENLlNnWwmzsaXhooZ6P3Cifv42o1h/LtWKBcmfrqyXPkxoy6l7fq5/a1KI7MxuDFbLdDHv9jk3Kq91/O03k/NFvvIe3aOZ6RfZV82PERHmE8szuPIKwQoVgBY3yVu1YrzkPLiZCQhQJniSEPa5pyrJbsruOAhPQMU9eG0ocGJpipzZUA0tMWU6qUURMZoPmA0NhMQUa2OUeIf3NxdF9g2eXt/vzSjyRhTfR20yBw6xMIkUHJXYtZer8BZXd9R0NPuWFU+MIR0sKgbQiQG2ke+E/629GPuTgrtpEnhcLTQVNata2wKiJjEUS5sn8YfrHUWBBmUMngRrj4zrMRM7B/K6SrDlsy+1VPakBAkbb2Dn3fYlyzWFW+1Ljc/lhEkVKOIZ2sAPQsreec76t/eYGQRKUYHxzsLdUgzKQoR9UGY84+DBZrrULf3Ai7L5pkwkKyMiVmiV8SAfHOkWOGiLdw9jctLo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(38100700002)(2906002)(38070700005)(186003)(55016002)(64756008)(71200400001)(66556008)(52536014)(66446008)(6506007)(26005)(33656002)(66946007)(66476007)(86362001)(54906003)(122000001)(8676002)(5660300002)(4326008)(76116006)(316002)(83380400001)(9686003)(110136005)(508600001)(966005)(107886003)(8936002)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RtcW32gNLEaQ9nyNUhUyBUazktlNMOHX6JueYhpAC16ekAp8sfZ4vyCUFEPM?= =?us-ascii?Q?e4QwNg5WZjdRPXfKKuzWTah4h5LAGnwzS/ruZ1Fr5evz6gzelSixUrTdgiOn?= =?us-ascii?Q?t3OwKD+RLCPBzuC06z/pWV5vP7/AZeGkZeNvd3Deg0k8aRrXg1/5D/1BGZAm?= =?us-ascii?Q?ZqkGjtp03A+7G9Gr9ujT0jkkoyOHLP4zRWAV6XeVJ4ZJxEcVq8F2cos0mol6?= =?us-ascii?Q?vPD6hLH2Hb3y4uXvEmRRinCvkpLK5Z09PKPzgZODvdCP9MMSw7OFczweW+15?= =?us-ascii?Q?kOtTMfmQejgDVBsKqGb1sj3ixNr5L7JINnN5sgW8p9X9M6740Oos4IRMw1mP?= =?us-ascii?Q?2HPZJ94Co/FOXzxP4//yGmYYDoNdGfpwbDRJDqRJrPt92q1yLAJKm+Du/Ebs?= =?us-ascii?Q?oUB0LCAnSi3gwdyhoRui6td8L2FWGPscN5GjuxbsqmqD3k9y+Y+vpozi2l1D?= =?us-ascii?Q?Guy2TrYWIwMc1+pR2IRmmNeWtHbXxWSOD4eK8xCWhD3l/waY1RxqhM+z0jkE?= =?us-ascii?Q?Ne/wB/bIK0ehQr3I2L8NJDx4MgQ869dnAo1WguQ6MKpahsEiypLpGt0Oq7e7?= =?us-ascii?Q?3y8+DrPIwKXPliCJ55Mg7qBjQu8E33rZVWuFIwJHmB4B4/QErGKoI2pTBiwK?= =?us-ascii?Q?9Q7OlVq/LitcHoiD9ne3dgh+JvdbJA4xm8m5hbsm4LHIWDSvKuh53a2aFZR8?= =?us-ascii?Q?iWdm6CM/IntW4ckBXKruYwFqGlASaQsS6yH893rzUl6q4VkuF+3I3x7y7qrb?= =?us-ascii?Q?4695hxtgU49jHHigI8xiCzVSBkmR8rhCu3eZzFijO2bGKBoH0BSmLc87U5tR?= =?us-ascii?Q?DyrKBRBZ2wWUb4NgwguhiRxNq7irOUEi6DJJ8IdTvSxIF2pZSEN3vyJBevk0?= =?us-ascii?Q?e6KBMQLeoLfjrbxQXx/oYtQClGGO+tCf/BrNVHG4JubTqvo/gzisL28LWAoI?= =?us-ascii?Q?XdU+srh1tTok1qGxmOPB/wXddLBx1tW+ax1ggUk+R18IvzHdqkEsQ4QXnEVL?= =?us-ascii?Q?0uKtXlk1EM9M/fT9cTsWc7psA5aCytVepd2kenP5iCBXxrBMBplypFTyzFNG?= =?us-ascii?Q?nMKjsJqWM/FjmG+HKFVOC+oT+mn7hXr4gNL4YzqcxCDymR1/enRrtKYlgAKW?= =?us-ascii?Q?+haPvvcvNc4aDHCuXD7UybjK6NrT84tRwvW1N1z0WqSs1pTvV74X8MGMlo3I?= =?us-ascii?Q?df+F0ibzsQxZnVjLDLb4gBKtvRdiGdBdEoB56NO8IGdyWiaLYs6qinfwU+EQ?= =?us-ascii?Q?qikRjM+A0E0h8KcfVRBk4R3lLNStrOzhyTLpR4BEx+uGwzJmw64CO9jZznQo?= =?us-ascii?Q?aCWGtouCO11kBI5lLl9HnQgGzMBN8xTLrONI3XXfRBal4l31vQmf9UTKd+5x?= =?us-ascii?Q?5i/Y0qwf1Ti5TYSbkL5Ny+k0egrrJtr9JvblJWL7GSBcFKBL7lp9csi7DIJK?= =?us-ascii?Q?llux6r78bVNC+wfObFfPhI4RCwEYE7gTlUrfJV//OrIjKIRA/jtsoi/vyXND?= =?us-ascii?Q?FQpABLLA/ODPDjeSw9OsMCE2n9rUIowcNFlFR8OW685tHLg2G9H+jjGyFurT?= =?us-ascii?Q?2CED0BnvG1QePDGmrO7Kdb8Zgx5hINHP5dUAS0Ym3//MLRABmczrIaEjrm+v?= =?us-ascii?Q?zA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7fe2aa50-800d-45d7-6ee2-08d9994e584f X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2021 13:33:21.6545 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MFQHE84DgIX0muJGyz3UIhfS0n7m3WL1LXsZAhXOaV9gEwVq8qGBqQtwGjgxd9Y4F4KIFg5HPFRhLoLaaqO4og== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5214 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 5/5] crypto/mlx5: support on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: RE: [EXT] [PATCH v3 5/5] crypto/mlx5: support on Windows >=20 > External email: Use caution opening links or attachments >=20 >=20 > > Add support for mlx5 crypto pmd on Windows OS. > > Add changes to release note and pmd guide. > > > > Signed-off-by: Tal Shnaiderman > > Acked-by: Matan Azrad > > --- > > doc/guides/cryptodevs/mlx5.rst | 15 ++++++++++++--- > > doc/guides/rel_notes/release_21_11.rst | 1 + > > drivers/common/mlx5/version.map | 2 +- > > drivers/common/mlx5/windows/mlx5_common_os.c | 2 +- > > drivers/crypto/mlx5/meson.build | 4 ++-- > > 5 files changed, 17 insertions(+), 7 deletions(-) > > > > diff --git a/doc/guides/cryptodevs/mlx5.rst > > b/doc/guides/cryptodevs/mlx5.rst index 68bfdf3a83..7338c0c493 100644 > > --- a/doc/guides/cryptodevs/mlx5.rst > > +++ b/doc/guides/cryptodevs/mlx5.rst > > @@ -39,12 +39,12 @@ or to access the hardware components directly. > > There are different levels of objects and bypassing abilities. > > To get the best performances: > > > > -- Verbs is a complete high-level generic API. > > -- Direct Verbs is a device-specific API. > > +- Verbs is a complete high-level generic API (Linux only). > > +- Direct Verbs is a device-specific API (Linux only). > > - DevX allows to access firmware objects. > > > > Enabling ``librte_crypto_mlx5`` causes DPDK applications -to be > > linked against libibverbs. > > +to be linked against libibverbs on Linux OS. > > > > In order to move the device to crypto operational mode, credential > > and KEK (Key Encrypting Key) should be set as the first step. > > @@ -155,8 +155,17 @@ Limitations > > Prerequisites > > ------------- > > > > +Linux Prerequisites > > +~~~~~~~~~~~~~~~~~~~ > > + > > - Mellanox OFED version: **5.3** > > see :doc:`../../nics/mlx5` guide for more Mellanox OFED details. > > > > - Compilation can be done also with rdma-core v15+. > > see :doc:`../../nics/mlx5` guide for more rdma-core details. > > + > > +Windows Prerequisites > > +~~~~~~~~~~~~~~~~~~~~~ > > + > > +- Mellanox WINOF-2 version: **2.60** or higher. > > + see :doc:`../../nics/mlx5` guide for more Mellanox WINOF-2 details. >=20 > I do not see a way to cross compile this driver with MinGW. How are we > expected to Test compilation for such cases? Do we need to build it over > Windows? I personally don't Think it is a good idea. >=20 > Others please suggest. Yes, this driver can be built only using clang on Windows, net/mlx5 behaves= the same way. DPDK CI has a compilation test for Windows [1], it will fail if a patch is = introduced that caused compilation to fail on Windows. [1] https://lab.dpdk.org/results/dashboard/patchsets/19686/