From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23145A0548; Sun, 9 May 2021 10:32:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0BA36406FF; Sun, 9 May 2021 10:32:38 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2065.outbound.protection.outlook.com [40.107.94.65]) by mails.dpdk.org (Postfix) with ESMTP id AB61A40140 for ; Sun, 9 May 2021 10:32:36 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uu1e6WQ3pcJjSrafh8HWLtZyC4hx12LyoiZ7ntW5wHB2/pkA0qm/LHlvoyn46vceZ3ioyN8bNFqtZm9rOY3pGioPP7vyB9t5TmeoniflbmNOR0sBZdB9PCklEGs9qW1nsx/zkYIAI6/OTc4loiYwH6mIe1a/7keqOUAixH+UTLpgszFT/mGO5zsXuIkHIoI3WOx35RGFh2LBf4bexWK5qPlQD6dvjKTirMKysYn+V3vLdtmIMg86S3TkkasEErajqyqit7uQ38mT5Xp9psnD17rN/aQSbYvZMnJM56M0CmEUPViVIGeRrHpa6JKamnCx5HWYuJ0IDIHVbA8r0nSC4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pj0nMY0Py2uPTEMUoXBRP4OurseAZMr7d276xPeS0RY=; b=S3aQLFgFF74Y9raf8lp+jbMrQomZ3dU1O9mq6XZPSfWF4I4tP/iCwrP+QEO+2cze4TqRmeGAqnp7wMDFCDiKEX5D4OcxmIoxKvJT+9NyauU1JntRV6d4NWpvad3lClVHbvZ79Op8fE0tHuD4Foa/wgzKbZkjri1OeHwaQKWQM2Kr9qn4VPzPFxrnoSEAnm3C1IKAdtU9DM2aC2xocUm7ZzqCTVwWP2Zz+XhG+4i40wzr9M15VhWjWOlPKAfs515OiBLNRBBmffaYRvV9vmlSNBQEZCsswMd6RPiS37lGP7kPGBfsEmi0DkfYudqdQTueOpmgVbv5rvoLaJRlNNTBZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pj0nMY0Py2uPTEMUoXBRP4OurseAZMr7d276xPeS0RY=; b=sEuIIoFHED3aGn+LSGf3voNg1dXDNFmzEkjLgomOwqXh+Ip3jWFMs8HQ6n70aQo4+y/be4S8BZF2CAPA8aqlNTkEkDEsAbxMR4CQ6yu+vWhJaXIEdeNTmbpyvR6NrXtzYcVeAz9G+e5jjjjMe0ujyvadLaGdW1f3FsXLg/UbXSxarI/94kbIHxOBbIh6BIMmg/W0jJRbGLu+dz66VgWBGyKt7BLntaEC3OORrC/z2OUMEGYhCfQFvurMrA34O9qLVZb1oOOXMFSgPkuHqdyhp7vmpiA8pDtRgPewK6XbmaWv6QVoxHmLHwbjdEvuZEQ7ZeJ1L8fDr7WnHSoVyqFKqA== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM4PR12MB5391.namprd12.prod.outlook.com (2603:10b6:5:39a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24; Sun, 9 May 2021 08:32:35 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4%6]) with mapi id 15.20.4108.031; Sun, 9 May 2021 08:32:35 +0000 From: Matan Azrad To: Akhil Goyal , "dev@dpdk.org" CC: Suanming Mou , NBU-Contact-Thomas Monjalon Thread-Topic: [EXT] [PATCH v3 13/15] crypto/mlx5: add enqueue and dequeue operations Thread-Index: AQHXQSnV0r7BWmAvPU6+pDUoLbSSharZhigAgAFTFMA= Date: Sun, 9 May 2021 08:32:34 +0000 Message-ID: References: <20210429154712.2820159-1-matan@nvidia.com> <20210504210857.3398397-1-matan@nvidia.com> <20210504210857.3398397-14-matan@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [79.179.26.253] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9153b584-82b9-48c3-0e74-08d912c4ff0c x-ms-traffictypediagnostic: DM4PR12MB5391: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xOswpOwRw9fLGbL0Rz4H9VZOIdeaiSXGIG7oZ6h8hfzg4g+69gHcJk6XoiN13VmaDwpI1v6A0qR2s3NLJ4TQBoy537D/fx0yEH0EXjkbIHN95c3S9adhfs+4StPlDdkJW7uQ2QeS5xK1x1HcGg0JFMXfhipZIAfLhGP9vWHAr214Rn4Jpx4F4bUvpjfFcyerbcneOxXbHGsVZ0USHBmVbEJIeirlLG3BQTiRFpNbclCvIQHetlAbn6vr8XFbOTmmz3SFQjeXsMcPwqvWfx9FyBberSV8Gnu6fMPPqiqjQl0lgbboUJOX6SnO2r7nk+aMhbj6a6HbVwn414/96AoATcyVvWUA7+tiuYbePf6nbt8ql+do4rEZmbzcQacB/Vc3cd45qf0DC5PrPc77XXGR42ZG/rFtKP657D70ddNmnL633+Q/kYpfRyVQsz1u/nqHcsZ81mg+bVdRGNERe+8//GfiXe7s5RNRJOEq+8LSI2FY2PEU2tyCPvQbOdSzdl+XaJUN27wdE8Xb83N5eEiezBSzTkMJF6q/hK7IbLiy0fsYyaXw+1G3SsA1vGiAAEq89mf7TIf7z38wN3jy9t0iJh5H8tqCI8kdWsha42MYUyg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(376002)(136003)(366004)(396003)(71200400001)(33656002)(5660300002)(26005)(8676002)(86362001)(6506007)(83380400001)(122000001)(66476007)(66556008)(478600001)(64756008)(9686003)(55016002)(186003)(38100700002)(76116006)(316002)(52536014)(2906002)(7696005)(54906003)(66446008)(110136005)(66946007)(4326008)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?HdI69bJx6LkmCitpgd+T6tDT7pLZmQ+XLW1RxmJtmy3m/yLcLN3gkFy5j5ju?= =?us-ascii?Q?jSUrhHaWQlwcz1khJ+RRvo8+YpM2PxAqNN1jPmP20Lcuw9/9tvt6bJ1bdH5b?= =?us-ascii?Q?0uP8BNeujmLYPbZHzzQKRe3H+qrA0v/87xGXrqHev6dSi3Suo+HUXJI3clsF?= =?us-ascii?Q?jkhtmzHicCpIl4Xg7r/3dIIlTF4L3r5ZIQ+9K09mW70yL119NJo91Jfm+a+x?= =?us-ascii?Q?26bJQXORDVqeuEWj7H6c7DfKbpYwDAJM3C9Wix5j7FJNYi23RBxW3VC9RZgV?= =?us-ascii?Q?5sqR8KNtnNqgkijCXXUlZz0wPpEfm/Be7yzHZe3G+zYX/x2Nrb/kaIB65w04?= =?us-ascii?Q?Cn7b+QyQzJQjTevcOQVmWnWFVdiWst1bImDPjGxBeObp6qEGD58L3vdzqvWM?= =?us-ascii?Q?LVnUVVh1m0cT32EPtI3HXt7da9RPJ4jJ3/I4R7fC7o/BLDYQ1WkOTekbgoRf?= =?us-ascii?Q?8sE6tEGeG4iTO0aDs9DGUCILpSDc2omp4F+uSS427UqFMfXx4ST25Jt3TyZI?= =?us-ascii?Q?/8iHgoUyG45WDT3BI81nFpOZZFs3xcwZ1Yzbw+SDUvngHU4m5f15XTNYb3Ip?= =?us-ascii?Q?O9C2lJ3gZYGtFmTThILEkmcKwIdkbHGtc7mdrBkiJA4MWPBkBN2kBBrqVqxv?= =?us-ascii?Q?qvcPX/MzZD3YPt9M+Et6+wGK8U8QIeJJMQFwGWxqBQLW1cvNp7+g07uYTZ0h?= =?us-ascii?Q?uDOwoGqYc5+76Ab1AmZGe28akMA8bq15KvGCRwE5aEC9ATdbxH1f7oNBC6qG?= =?us-ascii?Q?g9nUhz8c6OieYK+YZZ6AgeCqhCdbUBhUv7rMnGnM2a7wARq/0drXT+sNANRm?= =?us-ascii?Q?CoQk25jw7kYv96fWKdKDtVfQf9DzgFCwH5Y6G3FOcvE8jCUaxQC6Vg4W6Cxp?= =?us-ascii?Q?XGVbqaWr9sryouIadjuEiFcLqiQhx2Ya7Mi9KON7qXPRawNrJcoa/9mb1pRe?= =?us-ascii?Q?OkRP90dQJpbbZKbzqmAiPi9CpQ/i5Tye93iHF2OneQrDaQT7uyJmXSD3bKmZ?= =?us-ascii?Q?s16M59oZxJRXNlyYT6Awf9GTyoofIkb3IM2gjphc60bAKAVN4XqVMZLTR19M?= =?us-ascii?Q?8pmzjs1HhhTeZ4SS6upng2UKzVDd/liUi+dfNav4aiC2vDsoOCzCpxlXVp8n?= =?us-ascii?Q?hFWcjv312b1pT8/cCoKQ718iTjK2fowAXz6YfhqiYWdR9OAWUMsysCrPb9o6?= =?us-ascii?Q?miyaGgRAxi0cKRAqZ7yh/066UgB4eDg7Nr0p7jhCCxaYfsXHBSsNbp7hoHxi?= =?us-ascii?Q?d0Oau9lsfCuuWDXQ7vmwXFKrjTZS+2k2Zl0lqFGDc19NppRYnEFDept2VMy+?= =?us-ascii?Q?d7zm/nEfdpIMbVExs5iXLagu?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9153b584-82b9-48c3-0e74-08d912c4ff0c X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2021 08:32:34.9813 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tEosJhEpMFxouvLLAgNc6nE1Y3NTBSViYJNtDzdBDQ/QKPH/zc+J65XpJHUMxJKkdg6l72zD6Rg/gOCU7hcfxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5391 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 13/15] crypto/mlx5: add enqueue and dequeue operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Akhil Goyal > > @@ -685,9 +919,8 @@ mlx5_crypto_pci_probe(struct rte_pci_driver > > *pci_drv, > > DRV_LOG(INFO, > > "Crypto device %s was created successfully.", ibv->name); > > crypto_dev->dev_ops =3D &mlx5_crypto_ops; > > - crypto_dev->dequeue_burst =3D NULL; > > - crypto_dev->enqueue_burst =3D NULL; > > - crypto_dev->feature_flags =3D > > RTE_CRYPTODEV_FF_HW_ACCELERATED; > It should be set once in the patchset. > I see this getting set in 1/15 and removed here and again set in 15/15. > And whenever you are setting it, it should be added in the .ini file as w= ell. Moved it to last patch too > > + crypto_dev->dequeue_burst =3D mlx5_crypto_dequeue_burst; > > + crypto_dev->enqueue_burst =3D mlx5_crypto_enqueue_burst; > > crypto_dev->driver_id =3D mlx5_crypto_driver_id; > > priv =3D crypto_dev->data->dev_private; > > priv->ctx =3D ctx; > > diff --git a/drivers/crypto/mlx5/mlx5_crypto.h > > b/drivers/crypto/mlx5/mlx5_crypto.h > > index 52fcf5217f..ac4ad1834f 100644 > > --- a/drivers/crypto/mlx5/mlx5_crypto.h > > +++ b/drivers/crypto/mlx5/mlx5_crypto.h > > @@ -37,6 +37,9 @@ struct mlx5_crypto_priv { > > uint16_t rdmw_wqe_size; > > uint16_t wqe_stride; > > uint16_t max_rdmaw_klm_n; > > +#ifndef RTE_ARCH_64 > > + rte_spinlock_t uar32_sl; > > +#endif /* RTE_ARCH_64 */ > > }; > > > > struct mlx5_crypto_qp { > > -- > > 2.25.1