From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7842A0C43; Sun, 1 Aug 2021 08:13:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73ED640143; Sun, 1 Aug 2021 08:13:18 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2053.outbound.protection.outlook.com [40.107.92.53]) by mails.dpdk.org (Postfix) with ESMTP id 5F5F140140; Sun, 1 Aug 2021 08:13:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gLd9gt1Zglb6kYOZjJKYv14Ps2uhnK9gDlTcdFHD4YccrCcuUI+mZ/RBRf0ioGhY6wppSgkDOMTJk1eyFuOWjlT8S2rHe7QDNG5Xk/QjHU6ht2G5mOynjrY16BDutAAnVHXil5UjU3OE87d1mRVrfyuoLoZWPaiMyqN0ZDC2UeQkUAJ5uV94fimx/U+LjOHWg6BAmOroIZbNrN02YJn4HnMr9DoDXHw26oAw1fIfKBLEUUhK9MYt8UDPy/DgfcFmYFnEFZ+JKEu1B1iVrobEGDHcYIAAiMvl4qCjl7VrSEtKjUtskYY4sB70vcSBfftckBN3mNf9A+lB2m3vss6KOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RHXwwAXSv2RjegYtTg+4XupTJeWmefIsL6LCGe+kqY4=; b=mDr3SaqosrVkpri4GFgei9Xm8eaVkBhq5FCX6lwBwtNnR0djU6oxF7fZbvVga9Nf4nwnZsOiM3D2GJlnYZkKzQNAVi8yPCaMWe3VSYVU3C1O+6oEz3rlOWC3nmaQZCJeBja6Taw0KXEZlaDcdsIU39IlIZgdFdjYh1ohGiV2DipwKvemMGXKJD7RKj0aE1d6hj+wzP9ofRJvSuh8hmkaWE8KEhxj2Fycy99vj7KhNQH6RFIgNsd1M/AOXv8eSRFfHHO4fCx5N9E/LOjQlrN3FEL5El+976nEtNOXJmxR8p+FSEtSKhgAwTQTgwfeoEPM2dbjkXxtW7EZjBii6UphxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RHXwwAXSv2RjegYtTg+4XupTJeWmefIsL6LCGe+kqY4=; b=sbDLfXBC8WJ6v7xWb+e9ALLwXMYcupnDKnaWhDPnXKKagvh5j2HvxYB/OJxaP0mujPanaKKwCVMTTSaN2Zt7RDQJM4E5OQ9OHSTOCqOWQhHsphq2G1fTXHYoObuBtF+L6E5yoJg1YXknDjUI50LENFKI+bcF9v8dLClJip5k4JvGfwOJgtac/WL6a9erhKBxrZOfYEkUAt1O0mwZYFsEj7dMtixId9rrVcFjw8riN8FAiikKhzPWl3YxfJoD149qj2E7juYhjBEJteT4itgYvaFLWnG/m1hL/h6Pu5G6hJKmgAFJ25rsv2Yk58usUY4TfU3wnAgm9GzYgEsQbWdnog== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM4PR12MB5071.namprd12.prod.outlook.com (2603:10b6:5:38a::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18; Sun, 1 Aug 2021 06:13:15 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::6823:63cc:f7d6:dd00]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::6823:63cc:f7d6:dd00%8]) with mapi id 15.20.4373.026; Sun, 1 Aug 2021 06:13:15 +0000 From: Matan Azrad To: Raja Zidane , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH] compress/mlx5: fix level translation in xform API Thread-Index: AQHXhIOvHAbrFsezqEGcEOgKdua3xateLvDA Date: Sun, 1 Aug 2021 06:13:14 +0000 Message-ID: References: <20210729141108.20908-1-rzidane@nvidia.com> In-Reply-To: <20210729141108.20908-1-rzidane@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aa99c746-0415-46f2-a819-08d954b372d1 x-ms-traffictypediagnostic: DM4PR12MB5071: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2512; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hVIiahs169KxFuhXFheJiKDtUPZMUvqhS00AoLgO71POTg6F/FG/lEwj4SQzOv//I7MqNrIcEqhUhXPXqbmx9YlEnXkX2sEIadGw1b74uRzM1DJ6TWWRcJdF5wmclmMnGZ5NZFCY2hCWD1pwO1wel9iEogGZI3sUE7Ido+G8t91h5E/7hvfR8P66adTOowOq0Xnfr4Jn24a3CJ1Rolz4p7ev7zF7/BpyhNU/tVsU8pgX1Cownv0f0OAIMxRdnSFm/GRbMfmTbaURJXrZmi/XlfIcivFBv1/ybtomGTjrVE88oswacUkYjMlnkc7ILLedyvuQBWxk6EifgmAveHA6VaPw87WtvroyFzDS4nGNVukdY1i8caeNdZzTwtHUmSY93wjoRyHMx7julh6ufUALddzJniu3mhj31BotCeJbZ4f4QZcqOwEwWTe0hbBgPPUXyEPM3uNpGstRqmtaNNxKsCK0h0FWRPHyF6L0byxKw+txszxMoRrzRYoH356vQkgPcmN5rooe+uPAb33yMu4CbWBOARrW58MIDSHr+5njVWdgLoQkDupI/sxuBSxoM7trpWVhuHD8jO6yZRp7jl1hTQG+D8VvKUkgVWktDHJdZBRhm2AjSPqI716NEQfj/n4+IWIpxYXp/xL9/+WMFfpWam4xu7G7mNMY7Kx/TYUUAaS37zhkDiJcdWk8hHWXiMAC0uRlcDjXILkPnPK24uZ9fA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(376002)(136003)(346002)(39860400002)(4744005)(8676002)(8936002)(26005)(6506007)(38070700005)(7696005)(186003)(122000001)(38100700002)(55016002)(64756008)(83380400001)(9686003)(110136005)(33656002)(52536014)(4326008)(316002)(450100002)(5660300002)(478600001)(66556008)(71200400001)(66476007)(2906002)(66446008)(86362001)(66946007)(76116006); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?42yaf21kHjt4X9XdTDbEqGcju0NUM4BS7RAQuXjiFjk6Pb/r9DW8JxrGwHu0?= =?us-ascii?Q?HKuOy8+VSwWq0cEZWJ9ugcnkjZQcbgsbDaP1bdgnx8+hfn65l5WWcXEnuM/p?= =?us-ascii?Q?p4BKrkVTjvb6NNGX9dS48TOxy2WLmK7J78HpZyBPVzNWBp/AfUd229le2d9A?= =?us-ascii?Q?9H43zsrIF9Ua/t+5YdcYDrQuwKvuZScuS8m/NaSN/jbZu127EJHsazhaOvey?= =?us-ascii?Q?xyprqMUw04iG5sb6l/PUB4Ro2h0d+E0ayzXftSMl+bT1R2XWMPIxR2pHthOC?= =?us-ascii?Q?rUl6MM/FqoxtZ7Pa3szWRxqw3Ncp5ODBuXnEE22kjIL+tzzojePq8CZPpcMe?= =?us-ascii?Q?L3rY8SdgtRhzMiJZO/dNSAeyxv+YJukzjIoR8zeAlur1RtyDxKPPCayy9KLy?= =?us-ascii?Q?XBLMm0sdbHa4P5DftLXYACWNs76QFHGCJc8o7WlIzIu/eZkAMgOwpGt5A84a?= =?us-ascii?Q?p922LvaQ8IGdVWQfeMptHuE19VxVF+Phi3pzsvvTwZVgmcA3VQobf6O0ayV3?= =?us-ascii?Q?hq/oyC8dFBtK+D7eERvxAuUQO2CMyJvCDu1G63n0X+VnaFCKLg1XV9Kr47k7?= =?us-ascii?Q?68E3egugktvzvkeAhO1EqAM8bx9Y0Ww9oWASER/HkXLvVXNcVsUnqP7LW+Wy?= =?us-ascii?Q?Gv+OhZ4VJDWw3SApiWXPqiBjcICdfZDFfGf+9J9fO16ORV9c93Om3TAiFkHO?= =?us-ascii?Q?LLaPgE8DprgMDo2cJgznhfVJdB1a86uy2+OWxyKKJij8SMVIGnyP7EDEvrKM?= =?us-ascii?Q?8E/Y13F6Oo8Pg7XnUt/1OgidT1sxLije2UeLp23JkqVX9OIv7y/ypGmZXtV4?= =?us-ascii?Q?LZeI8Ozf+MdhSMgxMGxbfKqFylg/xqaCNPjYkVcCuAWUy+HIWSMDVWiidrBr?= =?us-ascii?Q?xDoEK+IIc6JH1YlJfl1EoFT5eBScFBRQA3Hj0Kes38pLIU0wALmGwPAj8yfU?= =?us-ascii?Q?tioT4HtEEjo2vCzEb1+lR6kxzfI2HKohmfcYzXe7GM261u5jd2nR20EzhrxF?= =?us-ascii?Q?+ek0gyijGl8bSjpRtCgePmoJkT2E6epr4ecffOiLoVt1skQbXDw369z5sLlc?= =?us-ascii?Q?XPQGAWXYvH3oDTuelROFX+kMNhapHUHmganG5BBHZiPc9Bah4ZMg2ztn2/bW?= =?us-ascii?Q?u4jw/TEpVRkzzccJKPCGA8HmWC9S72+7yndMUW+Rc2b/Po+28khkwaYY+4ZV?= =?us-ascii?Q?gElwXFaY5xZWzVwuSDMT5Ub+WBjhMfgFvvfjQP9AWGhvcvpfOMwujjnXR4ga?= =?us-ascii?Q?FbZzXA2g3RTXcd7OlF8ACsI8lIRDDNsPBHO71PRIVTRsDNRvNK1BdMlEUUwG?= =?us-ascii?Q?27s=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa99c746-0415-46f2-a819-08d954b372d1 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Aug 2021 06:13:15.0035 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: n3ZQZSOnIZYXILoaA9Z2tst2Yzi0Fl0gg49U49E2uemlsVc4GzwyErZgG6KBkWOux0O9j4kR3qVqNfVZ9Zflvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5071 Subject: Re: [dpdk-dev] [PATCH] compress/mlx5: fix level translation in xform API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Raja Zidane > Compression Level is interpreted by each PMD differently. > However, lower numbers give faster compression at the expense of > compression ratio, while higher numbers may give better compression ratio= s > but are likely slower. > The level affects the block size, which affects performance, the bigger t= he > block, the faster the compression is. >=20 > The problem was that higher levels caused bigger blocks: > size =3D min_block_size - 1 + level. >=20 > the solution is to reverse the above: > size =3D max_block_size + 1 - level. >=20 > Fixes: 39a2c8715f8f ("compress/mlx5: add transformation operations") > Cc: matan@nvidia.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Raja Zidane Congrats on your first patch, Raja! Acked-by: Matan Azrad