From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1041A0C53; Wed, 1 Sep 2021 09:47:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D571D40686; Wed, 1 Sep 2021 09:47:49 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2064.outbound.protection.outlook.com [40.107.243.64]) by mails.dpdk.org (Postfix) with ESMTP id C8C6140142; Wed, 1 Sep 2021 09:47:47 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CDSA+tFxKGER1pupP54dwqUyzzc2VxlU9bq+KZe2FNvM0JX/EG/mT46sPKHA8Z1qC5jrdb6F2AqIjHju7ZqJMjCE0kBv4OVvu0E7ADVN5tVfp59EM9uJNb6Sz2rRf6FZxeL3g2N6gMzuNBzYsQql+9kbICAZohNAfGNs/NlR6KuYlPYhwHJEWhoUeFP3N3/BrcWwMA3eY2ewepeVGJg7Oy6n9jiYgIfc68qWHVxOsh5zZKQh8ZrrJKOsCUqoqWF+dA0JhRyfvvDYUbLWjXWJfo1mbVCe4obxSykCnGM+eVIARB6ZLsOnXsP4eHRcNruBLAiZqpuQzmq+W6IdBg+ixQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=AqcNZGmGgvIEVeqKUEL0MWzvGzlCibtugZVCy9VQK8k=; b=IX4nctoBpNG6L876ITTKWvXqSZYS393Xn1zpa/TCbXaBa9MBrfLIUFR1UJeS1cVwrGgyFVVmemEQ6aNBg+Iq4eBY8AmI0vxHxIb4IhiAt/3z24FVXxGcTktQa75lIv7JUgprDXF838GPk6moB1WjJZ8+YlSrAV2Bz9gWecZ0X918KnDBJmBdLXCzJy1ERsmJWkLR4hAwJ/c3fqmFLQn/JCVmG7JDYf30lJ7Kvn96bBk+XHwpieTo1kebldN+7i4FbB7kUkorc+Wq8EEfXt1CiVjmVUYDiwFbI//L6hJxbm5RG27/aPSXir3b5eSboKe+HgEA+YKgtyTzGO2WOQYgUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AqcNZGmGgvIEVeqKUEL0MWzvGzlCibtugZVCy9VQK8k=; b=Owj80AiMDN0wVLfFPK32q/JLdBSBI3GD8OM4OwpOYZEhGmwVVe3Uw/mlBmOaV90pifBlcX5mBNEDYtomwHxbQo60pVrlySY5056YqpC3Udf42VZVnPeNJvh25CqZfnJ9CXA3BMk+PRE7BD+spO3GR7CqJLxQsZTVqsMQsyDis2zY4ErV26e2H7IoxBzA+NrubLXbNtuTbQdWvMLyPakBkmsR1jKMAVYJt6fC5wZFGFa07EtvQBzQ2TKu04rxaQDAinxl9HqvULkXl9Xqda4CsdN/UisrKNgIKesLzEVoQXs+XIqdG6myAqD7d1V8OBoGfLgNe1rvAbtypkDYITzbiA== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM6PR12MB5566.namprd12.prod.outlook.com (2603:10b6:5:20d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Wed, 1 Sep 2021 07:47:46 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::6823:63cc:f7d6:dd00]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::6823:63cc:f7d6:dd00%8]) with mapi id 15.20.4415.028; Wed, 1 Sep 2021 07:47:46 +0000 From: Matan Azrad To: Michael Baum , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH] compress/mlx5: fix QP setup error flow Thread-Index: AQHXnqhh8wqsdN8lHUiHHjWoSUx4RKuOzeDQ Date: Wed, 1 Sep 2021 07:47:46 +0000 Message-ID: References: <20210831203941.3411351-1-michaelba@nvidia.com> In-Reply-To: <20210831203941.3411351-1-michaelba@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d1c055af-454a-4405-749f-08d96d1cca37 x-ms-traffictypediagnostic: DM6PR12MB5566: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:608; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6ZgkOgk2gfbP+7MsvBzItnVctY7lTOYqP7qa2bv5Zmw6n/UIcCQa50yyNBnk0bDh3nvcNtrI6d1ox1bJjOGymf+nBuyP2q9na384cG6eKda9xkCiDVM9TZJ8ty5rWK0biUfDYfaok8Zof/OB6FMToz/GDcrIv1/Qyyw5hJGJjZSqKYBkHsWqsLKSKgYoIllatRMkgqeuTG+ORUfo9/BlO/d+/Ir0xUWgr7S+IL7gWgjJ0qV2aknVr971DTilDxM3/G6gz4g6Pz22EBeD5xR1ufBu6zwYpBlGjAWEuxjMN33eJmytw9uMNliOWQTG52xZuOE8VGCbYyZeXPB9z34KrJomSe5Yx2cv80UId8AlWZ2xt0BRTp+uVN8mPDhHFsrzFkXibczjikRNhwKyAAnyF7AwKBX9c7zeP5i/KsvHdhy26nZj6EV1IrjSlS7067d/pVLFHswlMSU/k9OGSfBUQcC32CdsLdyDzOGVAmjkXNANuDFy3xFdgM+c+0HfspmORsioVS1tLSAQqzL6S17dou1p30Rvpfo9T69nS4WRDIfQufgY19Kj/0B34qbW4pYpVG50F+xomed0fCpYuVBbS7BctZ1EU2w3XXvnTf9XELRP02t1mkbmdwgdDAX65+1am1IVTI88UAR/Zqwa1wzVlqRLydLjb0JnCl7jTOmxRFGSXXEhuv4SF4QFIJ8s171esdiL2rX2FUqFRzfBVOEzzg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(366004)(136003)(376002)(396003)(8676002)(316002)(66476007)(66446008)(66556008)(478600001)(71200400001)(64756008)(186003)(26005)(66946007)(53546011)(38070700005)(7696005)(76116006)(2906002)(5660300002)(33656002)(9686003)(110136005)(4326008)(52536014)(4744005)(6506007)(38100700002)(55016002)(122000001)(8936002)(450100002)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jk85JClXHMcIpC/e/WQYlu6Rp4ogKOUtuj2FZWt1K3szjM1n65YICfOh988r?= =?us-ascii?Q?fP4ez0sjVQwOPlBm5mIYw5pCICi6H9A1IrgARcOnJh8YZUE0+sEAZyVau4pz?= =?us-ascii?Q?0r0nzG9ukpbqpcxTibE0T26afXeL9cdPn8cdHj7nJaKXg68tNCIkHbelBaRW?= =?us-ascii?Q?Tdv3TCZ6UvFOQpM1MNlUrDLufmv+koMFqmo53/P9/lJTzbQ3yIbnOO4Vnjef?= =?us-ascii?Q?1RocSizevDuUL+aeZYL6oc2ED5RUGVApXaX4AP4xyd1UCbqIYNou2gksm/pH?= =?us-ascii?Q?OwWOd+0fK11WQ4haqIHjXe0ZNjjb/9cSq4Maa3aGWb9IWR09fqwzyyHP3OHd?= =?us-ascii?Q?lMEFLIzfxfJM/kRDldkiKkWDovVeO5h8XvDqy6pMrOlLpL5Na5uz3OIPR2on?= =?us-ascii?Q?W/c1cekyiEHUIuKn7PbZFUEr4aIVfqXbL+85xiKtjSjJL8k9O/Sm5SIKfXTw?= =?us-ascii?Q?gnmB1AmqFLjTs+q+31Cag6HFIrQk9z1vNxwqw3J6Njfj7xCSsoRVy0MK+YiT?= =?us-ascii?Q?07MtNmlSinikGDTUupuG+7itOy3YsZ8Qf356culzAW5z2Zl/wzQsUgHqoLvc?= =?us-ascii?Q?BaKsp7pgRYrgGZYxjYbOC7CQbo5+gtFTp4bDSrEiAlBvs5MnRecwwfzLeFpx?= =?us-ascii?Q?8t6ntB/SvknUi5LX5o4dNjInC261SeFQeudIz+9NKyjQ7Ct1pHYdQzl/B1jf?= =?us-ascii?Q?ImwsB2vKfjm9OCkMmmUEg2VF2QcRhskjPHawN5rs+XQKbaMhf3CCsXBXgS23?= =?us-ascii?Q?5BN9JGvbwkgYX8K83Ry5eznWCHQUBoRdgYAnitB5m97iR1HWe01wgcDdb/Jr?= =?us-ascii?Q?6tvo6+ACYPFvC8Kb3ZvwlTnfzS/zqLkbHfXgw2arn55SPo9QzOurntKA11wb?= =?us-ascii?Q?oLY+GQuZMna5qe4EJnjjM8GEBP3VKQpRvQpkqjN4QNw6mXCBVWqReOcSBij8?= =?us-ascii?Q?4ydusHLeaEek2hfJKtTWsH+HUTrDMzfTtarHJam1DdC40CDLY4HZ0EF+AUrD?= =?us-ascii?Q?8eYDnRqqbZJXCnLn4DOWVJ4k6lw0zd4m2FnLiVOibhiJ5NhFUFsn8hrR9Rvx?= =?us-ascii?Q?x3sB7veCLBVt1sCFOiMFaxDLgw8ox0j21gM/PWKIiWxlMY0m0jSJFQJ5zP2f?= =?us-ascii?Q?Uusw/OpOBrJbr1iz1vzBX3ffCHRFKRlukySHgdat5THA7hOqZ5k9wfPtwswK?= =?us-ascii?Q?ADkYZ1uNpDNCDO5aeYfYYb616n/w9EfL2DeeXpx41/Ves+hJAU7APoDaYVTA?= =?us-ascii?Q?neUQxkxMu9SQVUGt3xw8TfEljK7j6vhXsMODz4TzXYGXmPSd78+m6u1noTbL?= =?us-ascii?Q?y+o=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1c055af-454a-4405-749f-08d96d1cca37 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2021 07:47:46.8132 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NPUVE5LeDxc8A77QALOlWtK2fsPEn3iXyixhgD1r+Pc45L+dgEbDH3lDNI5PeJ1SqGUkwVWgDAziIkxYy+da/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5566 Subject: Re: [dpdk-dev] [PATCH] compress/mlx5: fix QP setup error flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Michael Baum > Sent: Tuesday, August 31, 2021 11:40 PM > To: dev@dpdk.org > Cc: Matan Azrad ; stable@dpdk.org > Subject: [PATCH] compress/mlx5: fix QP setup error flow >=20 > The QP setup function allocates buffer for its opaque MR and register it = into > MR structure. >=20 > After buffer alloction and before MR registration, it tries allocate MR B= tree. > When the MR Btree allocation fails, the buffer was not freed what caused = a > memory leak. >=20 > Allocate the MR Btree before buffer alloction. >=20 > Fixes: 0165bccdb45f ("compress/mlx5: add memory region management") > Cc: stable@dpdk.org >=20 > Signed-off-by: Michael Baum Acked-by: Matan Azrad