From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C9364607E; Sun, 19 Jan 2025 14:09:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 16C5F402CC; Sun, 19 Jan 2025 14:09:27 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2085.outbound.protection.outlook.com [40.107.212.85]) by mails.dpdk.org (Postfix) with ESMTP id B1FD1402A3; Sun, 19 Jan 2025 14:09:25 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nIqBDrBAO0DJ1mMg5tDc+qIjqYpcLt2wKCOqqPDgECZNSLAVD/BQ/2kyDHJ6T/BsYWwzdbnPFJWnLvVNxdA0V3UTAndMUEN6rgXQpjzH8gXi9E3Fih6+PsqIGTFUjUyUkeKAKxAVxz4BgF5BJeXpOWmB6VxnUoLS4L4CD0xHNQqwsjAhWiAIPwEbzX/jTRIXIf/VCXLDS6fQ3RBEfXVCJwXnHMlGFV9EnQRrLVrfCcylh+504EYYTglL6j+Vxi0oxMCyNqzTnpLlMjjyQF9dYcTWVMnAp/QWAEtmiFng7geWijSb/kX8svmHUeYfmAGIxDXf3V20V4w+Qh4PvR8O/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y9nYni8Zl1ZlaQjTS/GC2LF3e8o8qJFU6tw1XbrjC+8=; b=UXWlxgBweefgBArrP8bmYERTVFshI3eIT+5FIhUWc/iwMKSFaUVzSTwsTFgbOH+94J/tafA+wl5udlBKup0EkSdJZB+59xrIj1aLVWpJjBICXMW/crHxzOfpQiZV6QcaDoGeGsWflF74JyZzuAkUyZ0drGbnEWdyvCDXCXWILUSAfsLcd0TCOnLRlG1L4aMnimBwYxc3TILXCskagLW113wpbhJNBRqKmCc0D6Fto24n3DedcGwBLqs4xA+HRqf6x/UFkL5KqYd/Ql4MJsPSAtkgUCjDMUhxLu/MmnVcFHXsUALbnLtm2u7N4nPXHpCr0llPtuWUaVPxbbuX8LI4Qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y9nYni8Zl1ZlaQjTS/GC2LF3e8o8qJFU6tw1XbrjC+8=; b=hPAnXJrlYjPdu8vhv4zNFOGhfps28z0soGGib9OXFBmFm67coknvLYPiqcIRRjWzF7Z+EGvn2HM7Hsr2JJanoBSPBmtpyPoS9V0oeeBvd40uNaSaEcyWjl1THo2QulKK9zK3ffoMFOVX0KXcpUMqWHxZf/SSITe0aGw/Ai9GbOMwPHFe6VsZeDqYPMixhGQmnRdoyFeYaRfXHpwPbQM5zoI/J6bbdhe/JqvxK98xuD8gXRCTXc4YH23m8bH8eBIBTHkDjJ7xzFvGB9WpE2lRKYNtGq/CMi3xntdhsxWUi2uhIGI6K4XMaVwAQa4C8s8OWNWlhpP+O684WuEufLaXEA== Received: from DM4PR12MB7501.namprd12.prod.outlook.com (2603:10b6:8:113::14) by MW4PR12MB7167.namprd12.prod.outlook.com (2603:10b6:303:225::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.17; Sun, 19 Jan 2025 13:09:23 +0000 Received: from DM4PR12MB7501.namprd12.prod.outlook.com ([fe80::70dc:609d:fad1:379c]) by DM4PR12MB7501.namprd12.prod.outlook.com ([fe80::70dc:609d:fad1:379c%5]) with mapi id 15.20.8356.014; Sun, 19 Jan 2025 13:09:23 +0000 From: Alexander Kozyrev To: Raslan Darawsheh , "dev@dpdk.org" CC: "stable@dpdk.org" , Slava Ovsiienko , Matan Azrad , Dariusz Sosnowski , Bing Zhao , Suanming Mou Subject: Re: [PATCH v3] net/mlx5: fix RSS hash for non-RSS CQE zipping Thread-Topic: [PATCH v3] net/mlx5: fix RSS hash for non-RSS CQE zipping Thread-Index: AQHbQsBmDWjupScNGkSFuUPcZb2fbLMeSmgAgAAWW3U= Date: Sun, 19 Jan 2025 13:09:23 +0000 Message-ID: References: <20241129204540.2159168-1-akozyrev@nvidia.com> <20241130003925.2228586-1-akozyrev@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-reactions: allow authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB7501:EE_|MW4PR12MB7167:EE_ x-ms-office365-filtering-correlation-id: 7df5f7ca-0ae0-4070-8d0e-08dd388a7e67 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|1800799024|38070700018|7053199007|8096899003; x-microsoft-antispam-message-info: =?us-ascii?Q?H3xXDJcZo5ZnJ6itYnurdiwqfHxvp0S05oyD0LkQ1tfABOL4xu69/3B4XNF/?= =?us-ascii?Q?1IbHf30YHx2clvcIqZGgsKI5Fu7t+pMGS0FrAGOIWIWUDP1hwtgqB7xi6d2+?= =?us-ascii?Q?zRCbn55WOLcRLR1/8CQvj9ErnSd76LMsPVErlfErzF9Z+vOKtZHFjRkKTISy?= =?us-ascii?Q?TD5KBAPyn6CZz4O2EFn78A+4FY1TGpkcnZJ+u9ow9SAjd7GJbKxQ+VdDhe5W?= =?us-ascii?Q?41zM6vNNPdKlKj1FcqVUXsyLR/k99+MlexCdTmBJZ71fb8PnJaP1chslePWD?= =?us-ascii?Q?jQ69661ZgYYzzOflJettw/rIZmO1wsvVvG5XaNQQtB13IzhhZ6wrq35HH6tC?= =?us-ascii?Q?NF0w/qGRXVe6wvMcGJvQ7iDGx1jcgh8x9AAiy9PUV4IeEi+/XvpgMKwGZ52Y?= =?us-ascii?Q?t8HpwTk6SVa2/yzYDHoGpHa+KN1h06YSxgNiXQEf4oms2mtL7SLyNsSGLE5Q?= =?us-ascii?Q?OQSxbkfGHalxAl7EZzESI2D6Fi320ESjm+sAL8pxc78Z4AsMOzgf2TfcWQe7?= =?us-ascii?Q?X212n+XQ4f3FvCZcGHh3Bnbqz0yHUxv3iRgxKrnTSe/CTryHZR8ed+rqIwZf?= =?us-ascii?Q?VNHNyBp+B5rHTeUwRrp1TcIQAH4PSpXAgocXFBEevin0QvbHkshfWz16jGrM?= =?us-ascii?Q?kifkyqwZx+tZBeQEAoYBn1cYEYXKO9oRK49sm7yYvW5MMyI+mZ3mPFTLuj2r?= =?us-ascii?Q?Uf7scTM0IwVN0afPP7X5i+Q+jBED8npw4QE0xR33Io3ViduW8lbDk7Cl2Ovp?= =?us-ascii?Q?KH3ThmhOTBrsGL9L2i/Ut3/7M7k+3DLjgaVeFZIBxwQcAEEXZiF+p/JKHPam?= =?us-ascii?Q?Z3+iNysvbk3b1MTgmmlUoDwqsdS/vsuVwkk0hD1pirJI7pJkHA3eW/L044hM?= =?us-ascii?Q?CBUtPL/hUbmQ7H3yx5E0lt8jG9iZ/8x2XMDbGPl7VqjhWE98ilzqXcZjC1tQ?= =?us-ascii?Q?aC2Hxd/FoYZBy9VHPr/MwtMIV0Lf6YBxKuQsOgcRyUFnwL3lXWDpb98qwdVG?= =?us-ascii?Q?3dNhtLVeTUKcjW+L/q4SmBC0ihudI8nwKicVek9TUg9Ez9iTAh/lXzjTUy6i?= =?us-ascii?Q?46Kmr/BAdFBvu0/lK6HtVdSN+QDfRyeijkUY3kRjfqgSDq1faQS7xO0AlsBh?= =?us-ascii?Q?oDkkIc8XztLyjSa1zYyfNO99A1SIorIXx2MEiqMWjsWQ7Y9NtIwkrIZkNfli?= =?us-ascii?Q?+aidpJfjAuL0xCJ/l4L8YvyC6R5sGUvSECUhiRJrBEJAQ4FccFnZ923bJVr/?= =?us-ascii?Q?2V9RYDHitiP35yp4vDTtOGcOR66aahGERNPs9TkcQMlo7ABiAeDOx+AnV5R1?= =?us-ascii?Q?dE9R+SLbRD40m8M1/tKzZsxvlcaijeMYJHuzjavTmJJb0FhpbORJDt5xLmbQ?= =?us-ascii?Q?TxfvWucrfYqPw1NGawZM9q0eNkj/L8AY9RAU3Nxr2/41RqY1lEJKUmk2upw9?= =?us-ascii?Q?U2Gm+NKbCpffU9BOVbbhkNQ6+kBfXP4s?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB7501.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(38070700018)(7053199007)(8096899003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oJbTwzmPFr2Yt/HnUuh2jBBA383xzz8NnWWAb7mwf9C5nHYHS6MB/JKr+GEi?= =?us-ascii?Q?zDHRru1lq5V9aGNQ9JM5YoBB0vwUbeI2mRJjR483WVrlQBukSQuMnw6f0XfI?= =?us-ascii?Q?iBqZxRCarLZpZEVclpq59jW+Qcorr44blGGUcWXSKPdIJEgigM4uZC6TmJdn?= =?us-ascii?Q?5svZSBsSGhHVFCfkxaT2gYM1pGyiydgOmot6DeSyhMTxx0RrcGzlehOC/uZ8?= =?us-ascii?Q?4wDwBdvoVe4BCEUVP06VyAXiY03ieC4bRm5GdUT8tl/0nZHrHFoDunz+nRpH?= =?us-ascii?Q?/C72e8Zfdg22CJw6fOBQoK5U2DcFGu6/HIUbcEIWMk83h0vj093LO1M1bTo7?= =?us-ascii?Q?VYyiuoRbtP4I7fZVDGrqmK+TOCorDRNbTo1GZjvh4jWVODDMrYEDDwkTkl2g?= =?us-ascii?Q?fcCze42o4rxaC2hRjWA00/+RfxnbyHFfxyo17ldv2NeW/YnegDpdAG4XLHzK?= =?us-ascii?Q?5A5YBRi97tvTeE0l9uMqsKBu1LM3CNK4zXTmnO1dJDGbga9v8T1XJlj1p3GO?= =?us-ascii?Q?leYN/22AESNFb1MeouWESjfDvzt5zuwzBgpdXSfhrgx0GQZ5HEDGGDrM6kLi?= =?us-ascii?Q?+L+UCVSmJFuUXIUV20QJAak4PbTGOvbOS5C+IHm7EkyWxOyLy1/STsphvji5?= =?us-ascii?Q?OBRjPnX3/9tGMahp9sKPsIoNRqo8PeHa5W6w4JkINjkEcrVnfbY0JIbnsOzf?= =?us-ascii?Q?1czKEiIcniWVhxTJyJDyYLlIg7NxDOuzJpRNaRh/vXnon3OJJ8a895DQe1vx?= =?us-ascii?Q?tk2Ot4OhjwgUZYABvE/HNt9OI6WNBW4BcvdnLuycPF4NkEdB3nIYFXMH2qK/?= =?us-ascii?Q?onWYRudnmboyYp49VHOXoKuXTsrpR7neafdHhjNb2YxsdDHMB+FiJImywM+B?= =?us-ascii?Q?kd4ldeMEVzTkdAC8REgBrbOJ457MLa15ecxqO9/BQqAaOhGjU1+zGqE92e19?= =?us-ascii?Q?Ik7QDccshBjyYVQ5eiqU+nnlgpNziKmrEqQilucC61/QzSEQzVUle6XG4mKc?= =?us-ascii?Q?lbdpVxbXlzJjIpEAmXFr4E3Y97P3nkrlyLOxpBsTpwYYYH1rAG9IjRY/K3qe?= =?us-ascii?Q?5QsaTn6uG0ZPfIf4hh4XwCoHGHb64UGNnosllVl8Rlf/kn7j0z7J2UzOOxAF?= =?us-ascii?Q?lDHSjgZCHyO6jjXQCtmC0Im7TQkyCs7CL0St+bmshPN2ypJVc/v5c99jidNF?= =?us-ascii?Q?wF1D1654A4wmHJnV9fU1/gik0C7VGZRNsTyTQ+Lb4hOmZCWyAEIiP46lSCJm?= =?us-ascii?Q?fA/zkdlzR8vbfiG0QK+2mlXAaDEdN50EN5bjFUkNk/4cIYKcNfWIio/jS3Kz?= =?us-ascii?Q?LXGPg8SaZ+hfRmqm0/ivYWDB/V2Jn9ZaeHgD8nTchK0Ow0DkMwoKlrJeoBxz?= =?us-ascii?Q?XKwyAzrcc/zuoO6LbDoVs5h7XcCLCBfu4qVRtnGoA7KlCd378C+Q7S5pWsgA?= =?us-ascii?Q?aDw+HqhcVP+yOeOjsflKPfUxKmpN9zDbshRTFOr8MEMJcz5KHe/ZUgw2mpWw?= =?us-ascii?Q?akTy1UwXm0neI28Juoh1N9ZZoRRc5pXEiciWk92BqVXkvY7Wca11lAeYFWAf?= =?us-ascii?Q?KlD3UBLekeAuLVcL8xW7QfDnIilsA7Fe+6s9mNpcUJfs4P3CsZorRjd7/Dc/?= =?us-ascii?Q?xQ=3D=3D?= Content-Type: multipart/alternative; boundary="_000_DM4PR12MB750150EA6D0C1454818A3B99AFE42DM4PR12MB7501namp_" MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB7501.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7df5f7ca-0ae0-4070-8d0e-08dd388a7e67 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jan 2025 13:09:23.3788 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sRRNi4Iv/E61IzD0RNovsJTkk6+2CMF0ZWoeDhyYm6dnScCwVicKs0JFUgfuoZufHWqKQ/fMDs89xscHyRfnMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7167 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_DM4PR12MB750150EA6D0C1454818A3B99AFE42DM4PR12MB7501namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Raslan, please revert this patch. I rejected it last week. This fix is inco= rrect without the FW changes. Regards, Alex ________________________________ From: Raslan Darawsheh Sent: Sunday, January 19, 2025 6:47:48 a.m. To: Alexander Kozyrev ; dev@dpdk.org Cc: stable@dpdk.org ; Slava Ovsiienko ; Matan Azrad ; Dariusz Sosnowski ; Bing Zhao ; Suanming Mou Subject: Re: [PATCH v3] net/mlx5: fix RSS hash for non-RSS CQE zipping Hi, From: Alexander Kozyrev Sent: Saturday, November 30, 2024 2:39 AM To: dev@dpdk.org Cc: stable@dpdk.org; Raslan Darawsheh; Slava Ovsiienko; Matan Azrad; Darius= z Sosnowski; Bing Zhao; Suanming Mou Subject: [PATCH v3] net/mlx5: fix RSS hash for non-RSS CQE zipping Take the RSS hash value from the title packet before it gets overwritten by the decompression routine. Set the RSS hash flag in the packet mbuf if RSS is enabled in case of non-RSS CQE zipping format. Fixes: 54c2d46 ("net/mlx5: support flow tag and packet header miniCQEs") Cc: stable@dpdk.org Signed-off-by: Alexander Kozyrev Sending reply to the correct Patch version, Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh --_000_DM4PR12MB750150EA6D0C1454818A3B99AFE42DM4PR12MB7501namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Raslan, please revert this patch. I rejected it last week= . This fix is incorrect without the FW changes.

Regards,
Alex

From:= Raslan Darawsheh <rasland@nvidia.com>
Sent: Sunday, January 19, 2025 6:47:48 a.m.
To: Alexander Kozyrev <akozyrev@nvidia.com>; dev@dpd= k.org <dev@dpdk.org>
Cc: stable@dpdk.org <stable@dpdk.org>; Slava Ovsiien= ko <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Da= riusz Sosnowski <dsosnowski@nvidia.com>; Bing Zhao <bingz@nvidia.c= om>; Suanming Mou <suanmingm@nvidia.com>
Subject: Re: [PATCH v3] net/mlx5: fix RSS hash for non-RSS= CQE zipping

Hi,


From: Alexander Kozyrev <akozyrev@nvidia.com>
Sent: Saturday, November 30, 2024 2:39 AM
To: dev@dpdk.org
Cc: stable@dpdk.org; Raslan Darawsheh; Slava Ovsiienko; Matan Azrad; Darius= z Sosnowski; Bing Zhao; Suanming Mou
Subject: [PATCH v3] net/mlx5: fix RSS hash for non-RSS CQE zipping

Take the RSS hash value from the title packet
before it gets overwritten by the decompression routine.
Set the RSS hash flag in the packet mbuf if RSS is enabled
in case of non-RSS CQE zipping format.

Fixes: 54c2d46 ("net/mlx5: support flow tag and packet header miniCQEs= ")
Cc: stable@dpdk.org

Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>


Sending reply to the correct Patch version,

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh


--_000_DM4PR12MB750150EA6D0C1454818A3B99AFE42DM4PR12MB7501namp_--