From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: Igor Gutorov <igootorov@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH v3 2/2] common/mlx5: reduce HCA attribute type sizes
Date: Mon, 28 Oct 2024 15:48:08 +0000 [thread overview]
Message-ID: <DM4PR12MB7549A04B5425AB6DCA710E5CDF4A2@DM4PR12MB7549.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20240807204406.700332-3-igootorov@gmail.com>
Thank you for the patch.
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> -----Original Message-----
> From: Igor Gutorov <igootorov@gmail.com>
> Sent: Wednesday, August 7, 2024 11:44 PM
> To: dev@dpdk.org
> Cc: Igor Gutorov <igootorov@gmail.com>
> Subject: [PATCH v3 2/2] common/mlx5: reduce HCA attribute type sizes
>
> A number of `log_max_*` fields' types are unnecessarily large, and can be
> reduced to `uint8_t`.
>
> Signed-off-by: Igor Gutorov <igootorov@gmail.com>
> ---
> drivers/common/mlx5/mlx5_devx_cmds.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/common/mlx5/mlx5_devx_cmds.h
> b/drivers/common/mlx5/mlx5_devx_cmds.h
> index 2ad9e5414f..f523bf8529 100644
> --- a/drivers/common/mlx5/mlx5_devx_cmds.h
> +++ b/drivers/common/mlx5/mlx5_devx_cmds.h
> @@ -268,10 +268,10 @@ struct mlx5_hca_attr {
> struct mlx5_hca_flex_attr flex;
> struct mlx5_hca_crypto_mmo_attr crypto_mmo;
> uint8_t log_max_wq_sz;
> - int log_max_qp_sz;
> - int log_max_cq_sz;
> - int log_max_qp;
> - int log_max_cq;
> + uint8_t log_max_qp_sz;
> + uint8_t log_max_cq_sz;
> + uint8_t log_max_qp;
> + uint8_t log_max_cq;
> uint32_t log_max_pd;
> uint32_t log_max_mrw_sz;
> uint32_t log_max_srq;
> --
> 2.45.2
next prev parent reply other threads:[~2024-10-28 15:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-16 17:38 [PATCH 0/1] net/mlx5: show rx/tx descriptor ring limitations in rte_eth_dev_info Igor Gutorov
2024-06-16 17:38 ` [PATCH 1/1] " Igor Gutorov
2024-06-17 7:18 ` Slava Ovsiienko
2024-06-18 22:56 ` [PATCH v2 0/1] net/mlx5: fix incorrect rx/tx descriptor " Igor Gutorov
2024-06-18 22:56 ` [PATCH v2] " Igor Gutorov
2024-10-07 20:37 ` Stephen Hemminger
2024-06-23 11:34 ` [PATCH v2 0/1] " Slava Ovsiienko
2024-08-07 20:44 ` [PATCH v3 0/2] net/mlx5: fix reported Rx/Tx desc limits Igor Gutorov
2024-08-07 20:44 ` [PATCH v3 1/2] " Igor Gutorov
2024-10-28 15:47 ` Slava Ovsiienko
2024-08-07 20:44 ` [PATCH v3 2/2] common/mlx5: reduce HCA attribute type sizes Igor Gutorov
2024-10-28 15:48 ` Slava Ovsiienko [this message]
2024-08-07 20:58 ` [PATCH v3 0/2] net/mlx5: fix reported Rx/Tx desc limits Igor Gutorov
2024-09-19 19:42 ` Igor Gutorov
2024-10-10 0:18 ` [PATCH 1/1] net/mlx5: show rx/tx descriptor ring limitations in rte_eth_dev_info Stephen Hemminger
2024-10-10 9:06 ` Igor Gutorov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB7549A04B5425AB6DCA710E5CDF4A2@DM4PR12MB7549.namprd12.prod.outlook.com \
--to=viacheslavo@nvidia.com \
--cc=dev@dpdk.org \
--cc=igootorov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).