From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE1D345BFE; Mon, 28 Oct 2024 16:48:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2A6140E0B; Mon, 28 Oct 2024 16:48:13 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2056.outbound.protection.outlook.com [40.107.243.56]) by mails.dpdk.org (Postfix) with ESMTP id 05129400D7 for ; Mon, 28 Oct 2024 16:48:12 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=h868yUl1/I73/sMY+QIpRqPtVZNdnhD04w647vd/9vhl7MucN04L+BkLvGG8qHV4FhX382j3ZjK9O3zZqyx57sBMWzaEPKH1vOEPEyLdplhoMuk1V10Bt0SRCDNZ+RVSnkbHJ7OeMCnghGYs2O7mqCaRWKqDD+yd/TtBcVgH7b0Mnonq4bkZ2r8dR8MqojKYaAh3DPyyrEtS0c8UuV57xX3oLi0lMSLtWZFuHXhDV3w6D6FVOOTAi8+7eJrF8fh+//E8rHx/RrxnbO5fHVdQuoy+yubznY5njBJpSBUaXO1eXE7JPRa/DXWwN1E9kjnLTsc4SVX2yYEs45DiRxSUeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xuD9TFT7sK7WiGRPK9gMDrKLxGgUVoueL+JBiVkyBr0=; b=gLui4NcrjLXE2ryttDclUIjBwe+qkaKJJmakJqQqcYex3MhzowEkc29BlIX8z1NTd93ZPXUaSfuVb4Zf0GemnM8FETYCvMpnfx7MvbMXGBto+5KkvWhQy5xSm36ANR5RuR9tEQkOOn7Y4gjESHIb9m7Vv+b6Y6+szMhdRfHTo3SI3ztnDlDGv5mufZEAcfMoOz634Yef60WbZyt2lu8eT/aEP+JBSMDcEnm3sv4pDdr/dER9AgEZDydk3QUwtzAAPUYfpy2TYVrUB/C6z17qxDYL1b4wyDaCBCfwZCMktrWGLqk5NzrxIi07JPLLTIFWmxD1Sqy5J0q79YQ2KLPlxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xuD9TFT7sK7WiGRPK9gMDrKLxGgUVoueL+JBiVkyBr0=; b=Bsvjbi7lPKz3NFQeozxjdqtnusfYUCyLxLTFlNrQtwF2P0Kvh3shQnhfvsBXFsyBwlFLNu2kAPpThCCNPqEjGZwe3abXJovqkXN6hDVo4O0mRWtymib8o0eI5Hp54+S2mMEYwFDbRjrTYMVHHWNephikXm0mxd+AQhLpHTAecFVzKmonGOWU+VWvxQ+8No7AhiMy5JmHkGR9BZzwgf3WV8QHhuEmReB2AX13+vRLkLWpQUyTmvIHQ5lFRQOxmj8ugWI03K2dBJYH3XSNB47Np9nAcrh1rZNig6jUZVWZdKclZH5EIT4Sa4zYI8pXxIJ7ibOgiwLbME8LS9Liv/X3MQ== Received: from DM4PR12MB7549.namprd12.prod.outlook.com (2603:10b6:8:10f::14) by SJ2PR12MB8941.namprd12.prod.outlook.com (2603:10b6:a03:542::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.25; Mon, 28 Oct 2024 15:48:08 +0000 Received: from DM4PR12MB7549.namprd12.prod.outlook.com ([fe80::36a0:7d17:4418:7c62]) by DM4PR12MB7549.namprd12.prod.outlook.com ([fe80::36a0:7d17:4418:7c62%4]) with mapi id 15.20.8093.024; Mon, 28 Oct 2024 15:48:08 +0000 From: Slava Ovsiienko To: Igor Gutorov , "dev@dpdk.org" Subject: RE: [PATCH v3 2/2] common/mlx5: reduce HCA attribute type sizes Thread-Topic: [PATCH v3 2/2] common/mlx5: reduce HCA attribute type sizes Thread-Index: AQHa6QqtbkNv2e6wWEWvO3fT4kR7hbKcz13w Date: Mon, 28 Oct 2024 15:48:08 +0000 Message-ID: References: <20240807204406.700332-1-igootorov@gmail.com> <20240807204406.700332-3-igootorov@gmail.com> In-Reply-To: <20240807204406.700332-3-igootorov@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB7549:EE_|SJ2PR12MB8941:EE_ x-ms-office365-filtering-correlation-id: 2539419f-b203-4da4-f9e5-08dcf767eb51 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|1800799024|366016|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?XC6u1Eh1CoKfLxIR+lr1/XEBG4+PaCb3Fllw7HyR1xF31369khKeBtWzLkjp?= =?us-ascii?Q?Kd7y68EfN8OczpAI/yg87Vt0eMrjTHNFHYDJi6OuJ0l3vVnQjC4YfHiLP8AD?= =?us-ascii?Q?0k+/yJe3k0wUcfPotYOmj/hx3AeNhbh0yRJXXg7dvUgo1Oj1lX0VDEO0P/QL?= =?us-ascii?Q?qKDZo71JgqQGnC02DidQ7UDH3zZP0vF2IKve2Hwy0kXfP+udG4MkqQQAWzXl?= =?us-ascii?Q?sfJ3jKuzrHWQ6ZZxHgcLIpSaNGPfbMAVeR4UPunIfKG1YbxERsVpz7fHN9Gs?= =?us-ascii?Q?XBRS+WcDs/x+bn5neZKZyoAKSfKpIY8zSYGVOVMQWQBBdTq635fEZCKyyzRt?= =?us-ascii?Q?H98NhyUlDId48PdhWTqcDFS1e62jb02oaMoK8VbTD8lgsOa4CZZj6YEQ9kle?= =?us-ascii?Q?XCkZPB3+5dsUjvjVvdEvgTenJQ1uK+nfpkASO5WTQEhowIHNmFahcQ4ZAhVy?= =?us-ascii?Q?O4o76kZ2KCu3BoLPTVpet6O3a/uNgaM57VhKpWrwKmCVqS12127SwN4j685i?= =?us-ascii?Q?VsJzJ8U7KRmY9iPCDV8TGUs9i7xM+APGpGJ0EkRtVF6yRo3R/ag7329GZfgs?= =?us-ascii?Q?GGso0ltyVHP+QFVYcG/MN4w5kLa7hllzykNTHltakuC30aS67Rrr2wnvW1um?= =?us-ascii?Q?ehSsRceimF5QhVf6Xw/jdp9CbVoe/yAZK7pOzWyngEbABT8z7CHG/Vz44UWa?= =?us-ascii?Q?+J0wuIp9TaqY/okNQW7N578VUPR36vyu2Oh0hWOsdUkq6Vp04mLxhNjtP25e?= =?us-ascii?Q?omJ0bZtCyXfIW9VM0nVtG2dYVjj/4dERitwHY4gWfqO5gkifepexhQD5sbjv?= =?us-ascii?Q?qKjbooiPe4uz/iHXdurXf5LgF1KNLAV0T7SZpajqzMaS7tJl7lKfBlwqua/2?= =?us-ascii?Q?+SNAcMVQs7pE+yjV3OOJnW9KAIagf6mvZb7JlG81b6kR0uStSiM0++H3p3/7?= =?us-ascii?Q?BC+C0XlvBWLb4ocC0aNTF8itamkU0G6Zw2pmnpWh+OznN4UzuMVe1xELdtwd?= =?us-ascii?Q?gFWh8Pf5zdDj1XjoS+stMMK+YDfxSgVj8q5/biQJOVnYY8n+RxkvxhiReYsE?= =?us-ascii?Q?jpSZahPGtsUXT13hiFzSN6X6DmOfRO+/wyLd1tVg7zx2N8xZBMEl8iwFFIJ3?= =?us-ascii?Q?CZ5mnirEpdl3W/MFjyChpCw8uN8Ocd3BuFOx4Gx6MIEceZ7Dia2ZWaHKRLN1?= =?us-ascii?Q?Y7ZczFYX4dl8QcPY/HjLJ51+UN1aO1iSWrviMoH83z8gLS8ng5Vjg06WW+24?= =?us-ascii?Q?sX15c+pWm5jT1dAcpn85mO2rLBz6pFOH8KhEpBZAi4oNgtrmaOeebubGWf3w?= =?us-ascii?Q?W1bAkW15p70yR6E8iwvpgidiU/wujJxri2SFjf0yN3lXgM8uD9DoFc2emaf3?= =?us-ascii?Q?6T1BYQ8=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB7549.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FfkZzPaNKpqMENrIcKsLIMyaD9892NXUPEBjP2XxHlC/8xmDh/yAyy5RDZjN?= =?us-ascii?Q?/Tg0rUBkBPbHiDAR8tpi5Bo1sX14Vn4Tac3RIgsRa9L2A7V+x5jH1MjuLkwA?= =?us-ascii?Q?pyLiEPux7Go62PvoyjBYh0BKQRqL8xArIYmfous//NU1toQSIzSecgaIFhRY?= =?us-ascii?Q?Xsfghp2z+S7l36WY60lvCZ5lGlZ0tsMxXYu/3vQU4CLyBu42eQXFm1H9YTwg?= =?us-ascii?Q?0vY2Vw3+E2XJWaJ1XrckTyi/vMf5e15FqLQJ+aCo0qKRMCItnzmZtSvLp7ut?= =?us-ascii?Q?G6MVoYJyKw8eoS8lcQ3MiSay3s+b6b//VyEwGzafefPoj5jZQChWZv28+b0b?= =?us-ascii?Q?fjq/Ndw3wEEqHEzMxF8SvK4yMXti8Qjz56NXMWuCMgSslWn178gEpfq6p1a0?= =?us-ascii?Q?cQSEvhG3oNK/d8J4NueVVuUi9NuElrO9eINpY+COhZwOA2DYbD4UfKlUw04D?= =?us-ascii?Q?8baug1tjOnUUVh4zqXq6JMZOyDAMbSUL+qmk/MKqI1nuXqGe7tMghkTNy6Vk?= =?us-ascii?Q?RXpxswj1/mAPI85LtgVC9y2hHTQUdLcFQcWBxlYBuilVbkrQhCtBdwV5cS4u?= =?us-ascii?Q?T25q4Tx2nVBuqmm5i7q8VHBns06N1wKKdh8l2E5W+vcfnn1zoPR7Kkbro7oU?= =?us-ascii?Q?KowDXwNN888R8FB0IBXnuW55X8bNhpom6fyDGCUrEMkZnY4mkUPrOHuPKb/v?= =?us-ascii?Q?VWAICkxW4qpUjyCMeKB6Vlt84BgBhn7C4SVEnNgnJ/3zJdwGNfQaLWvwNaHd?= =?us-ascii?Q?VpO85i5qWk8rknMFgGC6AhNwOp3K79mJIHUeXcamtFHfec/Wnug3dC/cwynw?= =?us-ascii?Q?33FlDT1mw23y+JtRYBvoIuvIm6MLirbovGNAtBzGwVNuKQt6BDTmjobvKtQJ?= =?us-ascii?Q?mla6c49Z8Y/1h7X3A9pXE0YVxnKNI8URhs+D3E0OFVtPm6CsdfCSk6NYPop2?= =?us-ascii?Q?orWvDC0ZfyAj1WPmRZKBJl9Yu4mmobcxBvUBe+rluUWurmVD9X7GozAKR+o7?= =?us-ascii?Q?k+NxgDdd989nRkkRMfD5FqWMSxic1JFv2whHgsGJCmyPfPc3WMWdy8yiMzUo?= =?us-ascii?Q?2/ojkjqW3jlo4rfKKcyuajlERvfN3nlciOHoh2g6CE/VrtfcAYhnQ5rEDVqH?= =?us-ascii?Q?kCIG3exel5Ca7WP2arj3um8FIXi+WJ+VFbHc/fzX7Ia5CzUQasVG7zBi1bXY?= =?us-ascii?Q?diQYVGxJCgrn8T3LfP7ZL68pQaFqBlvNOZx9F2l1k6FeytvMMYkRFejY/KkF?= =?us-ascii?Q?7MO6mdpADzCf/uEfmPUCv5eMDciY5adxHN3wdQs2Yy72iBNTqwQKBwoba3O/?= =?us-ascii?Q?tGIYu0wHZVmjs7pFz8YfGUgYGumSvPjWaKWBJ4X6xpWaYv7kKZItGstTghqD?= =?us-ascii?Q?Ui4Q8HSH830fE7Ywq8Offbu52L/thmuqXobHu0iU2252h+5IpAWFedxDqQXQ?= =?us-ascii?Q?25zpenAZMBdEDBW4lOoqgOxgVt+iisFqXziqFKxrMRRa7P21mVJiDumxXrac?= =?us-ascii?Q?gOp0db4F7UVFw4gOYIzqgmfVc+dl+50WAHawybIXUAqKedplYTo9XDoXMC9G?= =?us-ascii?Q?JcvOMpL1hrKAAEtKCHaA4aX8CrFvDgpJ5lW7KIds?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB7549.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2539419f-b203-4da4-f9e5-08dcf767eb51 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2024 15:48:08.1083 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1MDghOcnkcKuPMVpNNF9Ei49tBm28Zd1K0sLKdemvMFjld3n2Wns78ctOuU7ABqi6drJ54tH07rhwRSLRrL/bw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8941 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Thank you for the patch. Acked-by: Viacheslav Ovsiienko > -----Original Message----- > From: Igor Gutorov > Sent: Wednesday, August 7, 2024 11:44 PM > To: dev@dpdk.org > Cc: Igor Gutorov > Subject: [PATCH v3 2/2] common/mlx5: reduce HCA attribute type sizes >=20 > A number of `log_max_*` fields' types are unnecessarily large, and can be > reduced to `uint8_t`. >=20 > Signed-off-by: Igor Gutorov > --- > drivers/common/mlx5/mlx5_devx_cmds.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/common/mlx5/mlx5_devx_cmds.h > b/drivers/common/mlx5/mlx5_devx_cmds.h > index 2ad9e5414f..f523bf8529 100644 > --- a/drivers/common/mlx5/mlx5_devx_cmds.h > +++ b/drivers/common/mlx5/mlx5_devx_cmds.h > @@ -268,10 +268,10 @@ struct mlx5_hca_attr { > struct mlx5_hca_flex_attr flex; > struct mlx5_hca_crypto_mmo_attr crypto_mmo; > uint8_t log_max_wq_sz; > - int log_max_qp_sz; > - int log_max_cq_sz; > - int log_max_qp; > - int log_max_cq; > + uint8_t log_max_qp_sz; > + uint8_t log_max_cq_sz; > + uint8_t log_max_qp; > + uint8_t log_max_cq; > uint32_t log_max_pd; > uint32_t log_max_mrw_sz; > uint32_t log_max_srq; > -- > 2.45.2