From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: Jun Wang <junwang01@cestc.cn>, "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH v1] net/mlx5: error cqe handle Tx queue need assert
Date: Mon, 28 Oct 2024 15:11:49 +0000 [thread overview]
Message-ID: <DM4PR12MB7549D08C40DE491CD7E47CEDDF4A2@DM4PR12MB7549.namprd12.prod.outlook.com> (raw)
In-Reply-To: <1718175943-3586-1-git-send-email-junwang01@cestc.cn>
Hi,
I have some notes regarding the patch:
- patch does not fix the root cause of SQ state setting FW call failure
(https://bugs.dpdk.org/show_bug.cgi?id=1449 )
- MLX5_ASSERT is engaged only in debug mode and should not be used in release
- removing "return " prevents the tx_burst from retrying other errors recovery
What we should do - check if issue still exists and fix the root cause instead of
crippling the handling code.
With best regards,
Slava
> -----Original Message-----
> From: Jun Wang <junwang01@cestc.cn>
> Sent: Wednesday, June 12, 2024 10:06 AM
> To: dev@dpdk.org
> Subject: [PATCH v1] net/mlx5: error cqe handle Tx queue need assert
>
> When encountering errors in handling some queues, we should assert here;
> otherwise, some queues will fail to send packets continuously, leading to
> traffic forwarding issues.
>
> Bugzilla ID: 1449
>
> Signed-off-by: Jun Wang <junwang01@cestc.cn>
> ---
> drivers/net/mlx5/mlx5_tx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_tx.c b/drivers/net/mlx5/mlx5_tx.c index
> 1fe9521..e149f38 100644
> --- a/drivers/net/mlx5/mlx5_tx.c
> +++ b/drivers/net/mlx5/mlx5_tx.c
> @@ -213,7 +213,7 @@
> * handling, we do not advance the index
> * here, allowing to retry on next call.
> */
> - return;
> + MLX5_ASSERT(ret < 0);
> }
> /*
> * We are going to fetch all entries with
> --
> 1.8.3.1
>
>
prev parent reply other threads:[~2024-10-28 15:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 7:05 Jun Wang
2024-10-28 15:11 ` Slava Ovsiienko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB7549D08C40DE491CD7E47CEDDF4A2@DM4PR12MB7549.namprd12.prod.outlook.com \
--to=viacheslavo@nvidia.com \
--cc=dev@dpdk.org \
--cc=junwang01@cestc.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).