From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4DFC045BFE; Mon, 28 Oct 2024 16:11:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D624740E0B; Mon, 28 Oct 2024 16:11:56 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2055.outbound.protection.outlook.com [40.107.220.55]) by mails.dpdk.org (Postfix) with ESMTP id F3DD2410E6 for ; Mon, 28 Oct 2024 16:11:54 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TpTDZASJbZvfFcRoideS3t4mZOSF4UFs+wXpFidpj8Hj9hPOSoDKedzv3T1zGIIHaPLElHLmKq9FkUTLrvAkxGauJn12hTSOI1ypuLnkYPd7XKAWeH5QLK+I4SuQiDXJxSBt3QE4s+qjdZuXRo+uLw+ZwN8ZKgqrFHUO3w4UCa04tCqSfJz5YrHzalc58w6eShGMOBUVZ6d/WICSQI3l4Hmk0s62Obw8EWYR4HHN+Yv6ihDA/n0DMLHGXJgmpSqMa0Ze9mRZXdMeNnht3thaUg6Cql7QO4jRl/0QoGTLaNYYkcp1Ei+szKDLAjT8zum4uI4DQGLtXZ+p5pCJ5roQPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=45MF+cV5jeUObkt15j9l0U5QQJBFoIKCHUaJgM+bhCc=; b=wTDuCYMD/y1s9aoe6nxEyT7rHDK01V/Sho+pr9HckPCmX+0FcJXMPa7AAjUN+naV30zpfcwdbCHtWCusv/o6UItMS7Za2q0uYDVF71It1j0swJyoAaBKZMUAtCxMxCj04zv8BjrfZSaYf/Q42gVMS90BDtNHxFXHDjHnhC0ESqCOCzDjpKBln5R6Ga7P9iMyXYbmy5XY17rtUZw3p8UNVY1XN5RCHvcmD2/n5oT0wnKNjXQYggO9gjAl8BdIWncPhrbllTGs+P907fUh3oeawS7QTS7i0C+Ge2XnQl9YE0utojYLv/vRLT9uQ6IvV2+mlU03/+dHGDbClzcW6IS/Ig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=45MF+cV5jeUObkt15j9l0U5QQJBFoIKCHUaJgM+bhCc=; b=Q0Ld27xQOmeydwIpWoRoq1fJO7OC5iu4MBg7HQ2rIk5+/6YmM1TdRJHbNwygqxngt7mQYtGS8M9ZtzSGDchDlIFDrNQZO3JSPzSinUJyT+tHPMwpS+jWpF9RNKBJ5ufVZFMZa7/WS0Cf7LslWeOR5lZCrNQVwzD9UYC6teOsTI4ZUZa/N0hcc5AmXQdp/RYTwevkjoDoBUJmduT4zVP4p9ITacOqblpK0f1ZuBxf0NivOewUFZNTuD7MJOGpDQn/Om/wfE7Z4HA5ip31o0Zb8XesgU1E09z66my2+wswkbKmakut4TWNxr57qT5AkIaMjV+sHQQV4fU59srjsBjywA== Received: from DM4PR12MB7549.namprd12.prod.outlook.com (2603:10b6:8:10f::14) by SN7PR12MB7855.namprd12.prod.outlook.com (2603:10b6:806:343::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.24; Mon, 28 Oct 2024 15:11:50 +0000 Received: from DM4PR12MB7549.namprd12.prod.outlook.com ([fe80::36a0:7d17:4418:7c62]) by DM4PR12MB7549.namprd12.prod.outlook.com ([fe80::36a0:7d17:4418:7c62%4]) with mapi id 15.20.8093.024; Mon, 28 Oct 2024 15:11:49 +0000 From: Slava Ovsiienko To: Jun Wang , "dev@dpdk.org" Subject: RE: [PATCH v1] net/mlx5: error cqe handle Tx queue need assert Thread-Topic: [PATCH v1] net/mlx5: error cqe handle Tx queue need assert Thread-Index: AQHavJb79FKnIfDf3EWqsgSqUpC5/LKdHPOw Date: Mon, 28 Oct 2024 15:11:49 +0000 Message-ID: References: <1718175943-3586-1-git-send-email-junwang01@cestc.cn> In-Reply-To: <1718175943-3586-1-git-send-email-junwang01@cestc.cn> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB7549:EE_|SN7PR12MB7855:EE_ x-ms-office365-filtering-correlation-id: 4dcb7d8a-9083-4da4-45a5-08dcf762d8a8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|1800799024|366016|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?R3AtP1RByVKm/0h+o/DjS50y7BMmdHKQkLoV2wcKG6wsp2etxBz3vdMqr3+6?= =?us-ascii?Q?pCyZVHEBsOVAaq+QzeoLT7iLYWghEPzYiZ+7u96V6RSKb6NRGceJjVsDW2tF?= =?us-ascii?Q?obYlECKdHnpKzEoHr8niWe9Ax4VGEZNsECj1/nzjAn/14WbERbVd30ljoIdq?= =?us-ascii?Q?VQfbC0AeNFOsrG8/Up8OiZtmDOiMLux9GBptyeqvVImr782z5rqguaiRzjNk?= =?us-ascii?Q?aQMB1FPxkjKIgTCVpUcvMKtLddPXOYEBx5zFKoDPpCXia4Bwp4evHz6Xn7Iw?= =?us-ascii?Q?R2N4EPkQGoG1O02aKncc+4iPSjDa9biqPgQ8zyQlK6dPEoIa2ioQReZxlE3L?= =?us-ascii?Q?Dw1qKu1IZu7cF79eD+YqXoGXsbbRW+AxVyawoys2S2eeqyhXlHU8XEJ0n5Cg?= =?us-ascii?Q?rw4jslmvCA7eDI175a98jWUuNWsmNYg1uZBDiQwu86iaTFrKBJjeETvtoqoR?= =?us-ascii?Q?nk7IvlcQvEfCzHfKIg8lx64x2qnn2xaZxANrrBZ6VEMzpW3z9zlkE5VVD0GX?= =?us-ascii?Q?Glvw75HDc60dfF+iW10yWVWYLqpYZZlKg1bhW1X9ft8DYEVGD/wYVvyHGFll?= =?us-ascii?Q?WEzQoSMBcbAeTfz3C6OEAEdB/YW0hpEk0WjXOeUmOavQdgpXAL9OD6aXnRdh?= =?us-ascii?Q?wxWZGrE7mXl/fxkGfDrGageqqzM00TwyXFFzkCqhKUaXVP3zZI8JK/Z1GyJL?= =?us-ascii?Q?FEkK9VBldANkEp3Xsstc6IAUOeyNL2eZ8Fy7uVRFstpVVAZ6V/nrX2aD1EPP?= =?us-ascii?Q?dxrokEfRy9x/+gREjEe+Opf09+B4RUQXgnp70l+W2Z85qi690GK5cVlqRFlx?= =?us-ascii?Q?jZw8exZuILfhS6AGwlKby+ijD9zNc5XaqBRc/cP1iB41517nIuwGftUEbny0?= =?us-ascii?Q?iLxnVhns3qyscmvyoeYwlUp7laoR89/u5q6UC2NtjFCxc37RlbijW3YunTNY?= =?us-ascii?Q?IhkJYZHIwpR8kd9rv/P6bGDiLilJcE12NHmTFSzenLVb5up6FZnP2AfaXyPP?= =?us-ascii?Q?1lOlQWFhWInmZXrCx+ST6xLa6R0qO7qgqIZpPdSuOUJtOLZPVWvYMonYwIKi?= =?us-ascii?Q?E/QekMi446vuOl0eVmcbW+pEh/fLltJEl6DD9ccyeeeG3Cm6VOBeuC46Ue7K?= =?us-ascii?Q?QifY+DuM09KKzSHZXqrVehgzuVNVLqz0cF9rOiAZVah2hmVjW+36OBiBES/3?= =?us-ascii?Q?rJWG/0eBEpstcvAb6ee/X6oOnYEszDh3l1zId/Kfs8KHMjM8R/aow/n+imhd?= =?us-ascii?Q?jCVy15IVNsF7Mootd1e5ehVob4+d0IT35ldRfF/APbXuMf3BJGNlVscOsiPt?= =?us-ascii?Q?AjH0XbRKGe7daWjDzx3Gbq3tN9IoVxKQwfOPWOfJDYJDpiK3KjArxecLOPz6?= =?us-ascii?Q?3ethJR0=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB7549.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?angxycIiobyQC1jVqVMzir2BtOO6aUFRlVBZSoRfIzcEjNHt0PYfXpWwKhsS?= =?us-ascii?Q?Q+QiQ2OKFqIcMaVp9gPj95mVf/HSVF9iL9XNT5M6GRCnL7hnGhKb/9KqUt7S?= =?us-ascii?Q?U811JnMo+MCYxiAXt1pomYrtOqwxNL2Gms28/KubafTuPvu0icbX3ld0ZuNf?= =?us-ascii?Q?GxYQCF0w4K7vdSxarp8LQiP12bDrnzuzgrh1W191gKjrcY7iIMLYQ5tv8NgB?= =?us-ascii?Q?AA8D4nXlf3sLWMne+y8JXFwTQUutFdjuNRrwizHHcSapXGhtt8l48XBP8Kmf?= =?us-ascii?Q?xcBqBzyLfP/LwLX1QES970c/nriBfK7AACiflJ1dFPMUD4/nE/3J+7otLhCv?= =?us-ascii?Q?MG6KuZ/aS3zKTjRIv0yVpiRkBAfJpY1+yJC4KY9Fc64A1vhkOCq/wkzdSC5H?= =?us-ascii?Q?PHaU2RU86LI5w8YTJ40YfGyHeU9fgNIQvBKMKN6L4tlEMgKT27dvB+ERhg8U?= =?us-ascii?Q?xUwAUsToc7lvBK7WNVSgLJxRwzLDwRQLjWGwqBqiBFMaQR2rQJr/e5REZ97C?= =?us-ascii?Q?awUX/Ygu9V3Sd7sGdRT2+p8gCl0uHCYxc8c5LP65Wy+jbG8XS0Wqo0INrA83?= =?us-ascii?Q?7WOxaC82XEUMTK7WzrKvB0XD3p5C3U/uQxvxpumucXY+I4d5kTwnzjUSe90l?= =?us-ascii?Q?K+QOnRwm/VmKQTLGXhEz+txYY5z9B8sIbT+UDI7ZfxbsPEF1HFyTYMMqQ7Zf?= =?us-ascii?Q?NRuCnn263AtVGMC66ltS7SLJh8U3BI0AxLqaI8Ti//O+k78hFQuvD6dkZKeq?= =?us-ascii?Q?zGAgC7l/a4wlyzbMJJ+Zl1Uff/MiMKs7vhAsBRvXB3imC/geIUdRh+yWxmzb?= =?us-ascii?Q?krV3NKJzQPeKk2uYDlcHeUoouDSWtiWbNhA5kjcKYwY4C1hiqHlWqA7OoeOy?= =?us-ascii?Q?aDhJGbvdYaXPSMjA8s2FxY/Kr25278zdp7dTpGCX/HV3cwlU0G0uEUrsZlXH?= =?us-ascii?Q?kdpadrmpD2AM/J+qfuJyz2oRTjzFz585c6xEALgpglT0QTzfCx1L/TR3TonJ?= =?us-ascii?Q?t41xpvEEEAWweWdcwYNrBQ9fRofumz51HfBZLLVCpQ7mVm6Fzt9kxUW2msOh?= =?us-ascii?Q?1mzUWqAub6zjQ3gyfaE9dN+b2OafghGlbWukrctvpsLs4qcqEnsNlkgWPk8+?= =?us-ascii?Q?uonTql+Do3bribzxSIkNJ4tMIiZ1aKXTA/M9sMI+b/voOdxWoDP6leVUMvbz?= =?us-ascii?Q?vgyU9Xgogz+NWO3ocW5xeM3/9JgZXTh0F2KCo8Tzs6f4ZG2Yx5/Y2qLN2/lQ?= =?us-ascii?Q?GyKTVFgdMeUseAWhC8XVfIzPGmD2lyxlhj+KsVUHIlU8W4F7I1+Mt6nW1NtT?= =?us-ascii?Q?t8mEWoix0zCt4KLTgXg55iTnmeJo3Uwr/JHXVu16afrHaknQ0CWDWwSsgbXs?= =?us-ascii?Q?hpYeaHLtgYSRP18BUbXlZg0M10d6/WR0tlb3wJQhU/RIPvyR6AoaDUwl3pRl?= =?us-ascii?Q?wdP7eitGUwUPRygQCXn6R6oG8w/DZSah/7VrbY10nnmorXrbFNhXbuGIAqTS?= =?us-ascii?Q?8fO7PGpFBZWxHqJU8M+xl5DsVN80lj9mymU4zmJySGgMgrFxdAItNG3Qs5Ir?= =?us-ascii?Q?VGfFMG6slkJP6Nxhu5ARVxRuDivl0dElDdBxg65F?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB7549.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4dcb7d8a-9083-4da4-45a5-08dcf762d8a8 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2024 15:11:49.3147 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4+JYEuvJ5I5gVZhGthyNLd5089Qob/GPT8fb4TRmad81A/mlc/AxsX8IzIC1z03yUTN4XOLZjQEukdwX53T8Og== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7855 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, I have some notes regarding the patch: - patch does not fix the root cause of SQ state setting FW call failure (https://bugs.dpdk.org/show_bug.cgi?id=3D1449 ) - MLX5_ASSERT is engaged only in debug mode and should not be used in relea= se - removing "return " prevents the tx_burst from retrying other errors recov= ery What we should do - check if issue still exists and fix the root cause inst= ead of crippling the handling code. With best regards, Slava > -----Original Message----- > From: Jun Wang > Sent: Wednesday, June 12, 2024 10:06 AM > To: dev@dpdk.org > Subject: [PATCH v1] net/mlx5: error cqe handle Tx queue need assert >=20 > When encountering errors in handling some queues, we should assert here; > otherwise, some queues will fail to send packets continuously, leading to > traffic forwarding issues. >=20 > Bugzilla ID: 1449 >=20 > Signed-off-by: Jun Wang > --- > drivers/net/mlx5/mlx5_tx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_tx.c b/drivers/net/mlx5/mlx5_tx.c inde= x > 1fe9521..e149f38 100644 > --- a/drivers/net/mlx5/mlx5_tx.c > +++ b/drivers/net/mlx5/mlx5_tx.c > @@ -213,7 +213,7 @@ > * handling, we do not advance the index > * here, allowing to retry on next call. > */ > - return; > + MLX5_ASSERT(ret < 0); > } > /* > * We are going to fetch all entries with > -- > 1.8.3.1 >=20 >=20