* [PATCH] net/mlx5: fix PMD compilation in non-HWS setup
@ 2024-10-29 13:34 Gregory Etelson
2024-10-30 7:07 ` Raslan Darawsheh
0 siblings, 1 reply; 2+ messages in thread
From: Gregory Etelson @ 2024-10-29 13:34 UTC (permalink / raw)
To: dev
Cc: getelson, ,
rasland, Dariusz Sosnowski, Viacheslav Ovsiienko, Bing Zhao,
Ori Kam, Suanming Mou, Matan Azrad
The PMD calls `mlx5_hw_ctx_validate()` function to differentiate
between HWS and SWS run-time setups.
The function was not defined if HWS functionality was not enabled
during meson code configuration.
The patch creates default weak mlx5_hw_ctx_validate symbol.
Fixes: d3144c59ac98 ("net/mlx5: validate HWS context in meter operations")
Signed-off-by: Gregory Etelson <getelson@nvidia.com>
---
drivers/net/mlx5/mlx5_flow.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 9c43201e05..bfe757ec26 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -12321,3 +12321,10 @@ mlx5_ctrl_flow_uc_dmac_vlan_exists(struct rte_eth_dev *dev,
}
return exists;
}
+
+__rte_weak bool
+mlx5_hw_ctx_validate(__rte_unused const struct rte_eth_dev *dev,
+ __rte_unused struct rte_flow_error *error)
+{
+ return false;
+}
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net/mlx5: fix PMD compilation in non-HWS setup
2024-10-29 13:34 [PATCH] net/mlx5: fix PMD compilation in non-HWS setup Gregory Etelson
@ 2024-10-30 7:07 ` Raslan Darawsheh
0 siblings, 0 replies; 2+ messages in thread
From: Raslan Darawsheh @ 2024-10-30 7:07 UTC (permalink / raw)
To: Gregory Etelson, dev
Cc: Maayan Kashani, Dariusz Sosnowski, Slava Ovsiienko, Bing Zhao,
Ori Kam, Suanming Mou, Matan Azrad
Hi,
From: Gregory Etelson <getelson@nvidia.com>
Sent: Tuesday, October 29, 2024 3:34 PM
To: dev@dpdk.org
Cc: Gregory Etelson; Maayan Kashani; Raslan Darawsheh; Dariusz Sosnowski; Slava Ovsiienko; Bing Zhao; Ori Kam; Suanming Mou; Matan Azrad
Subject: [PATCH] net/mlx5: fix PMD compilation in non-HWS setup
The PMD calls `mlx5_hw_ctx_validate()` function to differentiate
between HWS and SWS run-time setups.
The function was not defined if HWS functionality was not enabled
during meson code configuration.
The patch creates default weak mlx5_hw_ctx_validate symbol.
Fixes: d3144c59ac98 ("net/mlx5: validate HWS context in meter operations")
Signed-off-by: Gregory Etelson <getelson@nvidia.com>
Patch squashed into relevant commit in next-net-mlx,
Kindest regards,
Raslan Darawsheh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-30 7:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-29 13:34 [PATCH] net/mlx5: fix PMD compilation in non-HWS setup Gregory Etelson
2024-10-30 7:07 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).