From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4062145CF7; Wed, 13 Nov 2024 14:40:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 30AD840A7D; Wed, 13 Nov 2024 14:40:47 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2067.outbound.protection.outlook.com [40.107.237.67]) by mails.dpdk.org (Postfix) with ESMTP id 014204066C; Wed, 13 Nov 2024 14:40:46 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YrBl8rmwoLUpi4Yv5lh+5q15M98KqKPPQF7lA/DSWJBdG6wlgvwA99AVU1oN5KMZwjwBltZ50M5kyS7v8TtYn07L1HbR+Hpc/0mP2WnFxb+mllYlvWsTO3Vh1TYF26jYiZ6sIwKl/Eg2FZyXrSlrbL8eqK4ttE33a96G4/12hI66W5I8v1x/eVpYBhS0YUhve4EYpJgvZNaNViXkmM8vOqfX1cTHIpZpQ2qu1XvWOPwjYr/90fIleKvLKWS9vChr2ny14XDxIxroPqPHwgkaUg+czQqzj8yfUck4Ikr72YNepa41Di1VzkUepmThJO2BWLduPLhbB8OM1O+UpXATMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KLoq/CjGZyct8TZ6tRI2HWCFR7HjcOoMYl0a9XxSbMM=; b=TEITO2kHDuHLx4GztGh9bEA1w1B726mzQ3e2ytjNgaEThLBxxPWniiBtvrhg4UQavUv6mYMKbKCeEXmfScGrVEpLx4/OyM1GMU6nUKyKTDIC4F6rxoZlbHcyYD9GColtplywBaQITwAvSYaAHdZbx12svmCmJRf4+Frx8Rto2SrcP7C0/sj8vzoXdwhJlfb5UxDJ6uhj/27KeM/jFqtqadF+N+HlKtqrPJmtn4WCQkT4twZO7iSnEro5iOlq3+azH/nzyYH3/8lXS8I51jsnehE7/zbav6ZdB8QhHchokJl8TdjBs1qTDOLWF8Wk48IrOkbQ6RDj7ARt6POut9LcyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KLoq/CjGZyct8TZ6tRI2HWCFR7HjcOoMYl0a9XxSbMM=; b=JGp2eq5QbXCg+CFyhU07CkxHkKK0Raye82aHoDbwHlZ7WjKo7wXXmWTLMAdyNwdFxKHG5J9tqZj7rluSKOwiriYfwq7g/ZNe0SaUXH9eM2aUNK2ocA0qKFIA9HNH+uC0y1gkc/Kp6/M8GU1SyT3+9QR2YXtMPOkCEalN36QnEW3yvpqCuhIIUZpNwNPXMSqy21KcJIJlhASUtej0uZhxIINRfTz+FP2LwFK92SNqA4pXmm0RecnfPZ/njaJlCWDVRv/AHSSe6ryZCuN2gqUcJBqYkMIDCDAJYCLnkutmzdL4X3xZczxqXo4Dj5ce/RmxcBmt45VksmCvV4bKNY9rtQ== Received: from DM4PR12MB8452.namprd12.prod.outlook.com (2603:10b6:8:184::18) by MN0PR12MB6200.namprd12.prod.outlook.com (2603:10b6:208:3c3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.28; Wed, 13 Nov 2024 13:40:42 +0000 Received: from DM4PR12MB8452.namprd12.prod.outlook.com ([fe80::b341:6309:cb1f:5b6a]) by DM4PR12MB8452.namprd12.prod.outlook.com ([fe80::b341:6309:cb1f:5b6a%4]) with mapi id 15.20.8137.027; Wed, 13 Nov 2024 13:40:42 +0000 From: Raslan Darawsheh To: Bing Zhao , Dariusz Sosnowski , Slava Ovsiienko , "dev@dpdk.org" CC: Ori Kam , Suanming Mou , Matan Azrad , "stable@dpdk.org" Subject: Re: [PATCH] net/mlx5: fix Rx queue ref count in flushing user flows Thread-Topic: [PATCH] net/mlx5: fix Rx queue ref count in flushing user flows Thread-Index: AQHbNZzyJieo6EtYNUisuXU0YCawX7K1N/WE Date: Wed, 13 Nov 2024 13:40:42 +0000 Message-ID: References: <20241113072244.7627-1-bingz@nvidia.com> In-Reply-To: <20241113072244.7627-1-bingz@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB8452:EE_|MN0PR12MB6200:EE_ x-ms-office365-filtering-correlation-id: e4eb04da-4c52-4b7c-2735-08dd03e8c4d0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|1800799024|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?Q?UtQbv21UGnIU7CZbyL1xnRHFvBkZ5AlEF3Zhg2zWqZucDdqTWrBm0xnPGL?= =?iso-8859-1?Q?5GNqI/tQ6Ha6VXpR1w8wWijZ2qvzJlLxsOay3lMprF54St/Xj2JSJH0u2L?= =?iso-8859-1?Q?S9IV3mLrXIqxCDRwemy/7IMEoWDEAybuLlfxxZkPU848OMN1UlPdB/TZrR?= =?iso-8859-1?Q?52o1Tfc1WlRW0dlA7Xs0dQYbiyNzbAKryj5FnEehCKUWsjGIrXJTlya7B2?= =?iso-8859-1?Q?ezWYVjRqjm36Io08nAkC2FQC7i9uekiFTsVRDJc2n8mZ3DcWV2YWPgWUtg?= =?iso-8859-1?Q?917iduLSpPomdg61GNQcXQ9OW6/m4NjTMsnqEr6tuFqRb+aeXsTJuTPAVv?= =?iso-8859-1?Q?21lh4WxOypYqpy35Pjo+c/CyTgL0jAYsbQ9h0G/zLO6t1xRfmbcQvSkeHs?= =?iso-8859-1?Q?fUB1wqfuqRk9rDUES3fs2jw0gjPwMuCDeSK0EtvsJyaY5H/PEBGv14EsOk?= =?iso-8859-1?Q?XejDRtfD9+l+ZuQj1R1WT50yjQauWeHG09CDxYWXmRZtsyM/s90Hfz+lLs?= =?iso-8859-1?Q?R/yq53zre7H3t6kH4LHrIsH48BpPdufICyjlfvUG9LUqsX/vt7x9jrihAT?= =?iso-8859-1?Q?p1X/mQsYQSTdAkl2x0nq5oymkX7y07Eq9wEZEd9L08sHKSc0YsSRsMfp3d?= =?iso-8859-1?Q?dE9RQPSyOj4s8OW+v529bVBwsedVWe+234zw5YkwN1zzwZl5zLnz34jUyZ?= =?iso-8859-1?Q?bRfiJmzZ1PGRIECTTukILIGBcQ7Lt/AxnOJXMmeht9ZSmEcAFkRXND4YvZ?= =?iso-8859-1?Q?fAgHIbfxcP0ih4hHeoqIJ87gupS4ZkZ8LRSh82YSjkEsr1KqWDHMX8yE0h?= =?iso-8859-1?Q?mLRsbv/LrAlmLa7REC2sP7bBtJFB0mR7Mm0QfurQ48fBkOmghixlnw6OXe?= =?iso-8859-1?Q?OM5z8HE+z32yx8mmhh696NxN9ypuAvvOcnc8D28HJ3DOsBii0BkP23ZwRv?= =?iso-8859-1?Q?Y4nn/kWObg4rZWAyyYGgzh7XUCjsnzMDtccsWi6mxMafiZB2iugp3CAZeH?= =?iso-8859-1?Q?g3bAU1m3RLk8sNhSWJrWehWks0vmB0A5dypLECbOYC3kv3IjjZB3CH2wPr?= =?iso-8859-1?Q?qRWKJ6ygw0kLW8fDkr1bEmAJjX/N8UUPx1SCrITfKLbwV4v4XpiZx7+KSJ?= =?iso-8859-1?Q?DywATcHnFI+QTUxepblirScSaDuKfk6Je8G4yG3QUBX079Iyd8hbZdXjox?= =?iso-8859-1?Q?2x61X3RdTiFz8XdoWVziCRacxcnbP3Yto8FZPA4KzhhbBQ1RYOs3g/9ceR?= =?iso-8859-1?Q?PIjh2zpodB3uxfZjAwMJEoIGoD+60h74QonsQj83UL7ZCMS8IIQM0hrsKN?= =?iso-8859-1?Q?quOBdlAsOcvuhlzL3aiYfnbIvZV8hqQRHJM8qEqQFNk5tvvEQVANPZnETr?= =?iso-8859-1?Q?wgHQd4Nh4/bU4fI8mbhU5YheMhAUunW7OfWcaMlMSw3L8qpBruWNA=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB8452.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ypWSi+W1Njv7HpH6WfraZCNg0fSWRvCPRnuhC+6H53SfIQbMGesNLu9dG3?= =?iso-8859-1?Q?oBOIUAmQ6e4fTuhUvKi9uBvHNZ9mdThzwzOu32QJdwJFf7rLr010HVYdyD?= =?iso-8859-1?Q?agq3tGq5x09pl+9SZxj81wyQQ0WQ89hmGg9q4hEWE/NVKDyX3JXWnlZunM?= =?iso-8859-1?Q?pG2ZO/qNKW4g78/vQdFF/2EFqBOkE00MdH7+EYj1MV47z0ZY73w2QvbCAB?= =?iso-8859-1?Q?u8WJAY+oN3qfv3/Y3w5iLBAA6hLvX47+9djw7y6F5g+/a7xzuKyAKTO2rK?= =?iso-8859-1?Q?2wVdx6ULlZsuJu40DHV0713OycTv+EEsduYcYWaECtkPoY3ipyiCWqkKB+?= =?iso-8859-1?Q?BFSkz/5aGYiMPO/AcS6B5673vlFHMRtOjahPtCLSmbpuOxfhE1GiP8UHzh?= =?iso-8859-1?Q?e/SMFE0ghzGWnnlihF1OAPYrnfcuninpc4K98LngZvPrr3YSvn7Lu/+lB0?= =?iso-8859-1?Q?ml0oZaGY0sI8Sx8iIunRqF8KcAp4mZ0S+uC6870p3l67xEWkAWvF3nW6k/?= =?iso-8859-1?Q?MVmwirm3DdNfZPklsfyQdBg6xIUd93GO1iS60SCbVPT+ZzDqmaCJwzR9TY?= =?iso-8859-1?Q?N0IqiUHVps7Xa/14ysKH9XQzf+WRgaNvvHBEPgOSGv0C15J+IOG0gZsBQk?= =?iso-8859-1?Q?V/MvRKwps85VYE2SZsaUCfOQa27Y9x/Ac9+8FpLHbQ/Xxuvc//CLkpgzlP?= =?iso-8859-1?Q?oUbYHz7aGFQ7gBj+6UGf90SfEubvjIlbrsKTXf1MsnJrGwfvDIn9XRxXSn?= =?iso-8859-1?Q?JaOxD1s0aflaNx2Sa1nZf+lMC4bt/y4wvzeaIK4P6BpiPHnLvaoNrFBlUt?= =?iso-8859-1?Q?st7F8jYW34cCUA80XlzN+k1nSZR7kIbNPdHXT4CAf/oq5ndskvqNgxp+SJ?= =?iso-8859-1?Q?QJSN52RtiU4bY15d8z3PAui4ZTOFO/dkVFBOy9RfS9PegZv/f8auNmnaAE?= =?iso-8859-1?Q?y1GFCBzhQbeppwi9fH5L5FZQxmIQD0213SaGx96E4ATTn9v5gcWn6za3qb?= =?iso-8859-1?Q?LrFyNEminfQpb6SgGgkvSZ5PZFcdnzARVo8rqRf6oCHeIaH+5HSsPqhtNm?= =?iso-8859-1?Q?YCvN555H5DQjK45JG+F9vFf64WugRLEbOLnm6xOsG9Pi/oldLgu1OHRsu8?= =?iso-8859-1?Q?/iJb/HrBk+9AW6NpUGfQIo2+fUMGcsIDhCFgRkVp0JHZsUiSa4gnVbqZB8?= =?iso-8859-1?Q?05+gtBNqOtzfPDk16NkgMDXUV+JlYg5RF2tn3EaeQc0ogpchTqsxiNu5xk?= =?iso-8859-1?Q?ELeHkjAs3kwFSljjIme8r8AhHK1qAwgIGMfq4xBpIswGqa3scnW7I3XdzL?= =?iso-8859-1?Q?xU3o62JE4RDx7oddJ2I+s3k8Qr5/AYCApQg8SXU7iSE6J6jAeGNSIOp8Ii?= =?iso-8859-1?Q?1GyXB1HuMFC7wgbXHDeLt4KU/5bTXKRTWwwZHe2kkpG4xBcP95IRIWDgKN?= =?iso-8859-1?Q?zSecIN3KhlFNo/lm746k1rQ3GPSghW0svY6+I8IPUuXjo5AA9wSsS10o5F?= =?iso-8859-1?Q?4Z3UDOZzYCZ83e5ikJbWAscSLI2f3lqjxLXWbCDEOT3gaToQoVw9HxF6q+?= =?iso-8859-1?Q?7qciX/V7Do2v+DpEdYqgA0DBC6uQEvUG2nSVZUfcdQRf5DEKVrSmEkT76Z?= =?iso-8859-1?Q?q1W0QiZgMjuJ1J9s8dPT0Ywa+tGaQY1Wi+?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB8452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4eb04da-4c52-4b7c-2735-08dd03e8c4d0 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2024 13:40:42.5225 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LuZEGmEo5QXL09YuVV0q/MKKzfN1Rr9uVM1mzq1w3/1csEKoMZrc4sbXayVDMFaBDFoR7LeCbMwDRFHnhuf5pA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6200 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi,=0A= =0A= From: Bing Zhao =0A= Sent: Wednesday, November 13, 2024 9:22 AM=0A= To: Dariusz Sosnowski; Slava Ovsiienko; dev@dpdk.org; Raslan Darawsheh=0A= Cc: Ori Kam; Suanming Mou; Matan Azrad; stable@dpdk.org=0A= Subject: [PATCH] net/mlx5: fix Rx queue ref count in flushing user flows=0A= =0A= Some indirect table and hrxq is created in the rule creation with=0A= QUEUE or RSS action. When stopping a port, the 'dev_started' is set=0A= to 0 in the beginning. The mlx5_ind_table_obj_release() should still=0A= do the dereference of the queue(s) when it is called in the polling=0A= of flow rule deletion, due to the fact that a flow with Q/RSS action=0A= is always referring to the active Rx queues.=0A= =0A= The callback now can only pass one input parameter. Using a global=0A= flag per device to indicate that the user flows flushing is in=0A= progress. Then the reference count of the queue(s) should be=0A= decreased.=0A= =0A= Fixes: 3a2f674b6aa8 ("net/mlx5: add queue and RSS HW steering action")=0A= Cc: stable@dpdk.org=0A= =0A= Signed-off-by: Bing Zhao =0A= Acked-by: Dariusz Sosnowski =0A= =0A= Patch applied to next-net-mlx,=0A= =0A= Kindest regards,=0A= Raslan Darawsheh=0A= =0A=