From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A12CE45797; Sun, 11 Aug 2024 18:01:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 88128400D7; Sun, 11 Aug 2024 18:01:05 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 97BDA400D5; Sun, 11 Aug 2024 18:01:03 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 47BCJTaB024295; Sun, 11 Aug 2024 09:01:01 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2169.outbound.protection.outlook.com [104.47.56.169]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 40xqkyruaw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 11 Aug 2024 09:01:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hwVjuVbUaSnt9hOsaP5oASAgDP9bDN3AwGuQ4V6AT1o+T/4fy4R3NMiksy0Z0cPqI813KZNcmIsoyW+P2XV4IC84/ye5Z2z1C2krno+gjtPFshYeqnEcr4eMiod/aIqiGGCbNSi6V3e+yc7lxsPn/qST7Z7Lvv27EQb3Iryq7LamjpGpkO8jZemepPNryTcbLQwV78oKbkpWUjKLT4hQ4v5EVlxsqdAhzJ/hYw0Y2vBJJ+I+JRn5CTpChHkKBEyCpyiBxn7qPlko+V6rPmx5XmSp+PKIzxkmjBcnvbqc+390qF8xX/YvXxBzf0inM+PS3h5T8JmiK6KOX85oQ+AVXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QAnoTu/E7dCIdAQye6mBsRSkAyEzx/2GBHTw9eT9rbg=; b=i8gB7BVbaO5TThW0NiSRv0HtxdNQozbSvXeJv9XKC7DAI7p2aLmVk6EOckId1mNNAXIZwzSNcSPkAvFVcQ0TwScpjx/3igrCM/4A5nu9q77ds4GobfD1tcQtUPrITVsbm23K38Vvc9374l5B+JW1acefNXgxoKCrJ8UFkHLr7u1JE5EOoOSfzwhPyuuOh0uSjZKi9M9XlY1zspyIipX+qyu7e+BI4SK843cXWjvphAE2HpyhkynnLivbFWUDOL7/GkCU2vdq+FuUkgItBJ+uKcZwT4F7sZ2e8pXc+FSE2g5N/rBvKePzD3cFmh/yHQuhvIViWkLtXIdNb5u0TOqU9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QAnoTu/E7dCIdAQye6mBsRSkAyEzx/2GBHTw9eT9rbg=; b=murj2K2X1s+zeahz9UnvTVuGsfaZYqMaYUtREJMJCjJc1bFRwXs8lWgwVXfOjul6xbmhs0qHklJLgDCE9no39qEdN+eA3bS4fNfcs4XWEMGbM9UFB/PsEEMBD3nOFO6xCOSyq11bY/28HB1fL+VO6LWHr53aq44TxvaigKdKtSk= Received: from DM4PR18MB4255.namprd18.prod.outlook.com (2603:10b6:5:396::17) by MN2PR18MB3606.namprd18.prod.outlook.com (2603:10b6:208:26d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.20; Sun, 11 Aug 2024 16:00:57 +0000 Received: from DM4PR18MB4255.namprd18.prod.outlook.com ([fe80::9060:7014:db69:ca1c]) by DM4PR18MB4255.namprd18.prod.outlook.com ([fe80::9060:7014:db69:ca1c%4]) with mapi id 15.20.7849.019; Sun, 11 Aug 2024 16:00:57 +0000 From: Rakesh Kudurumalla To: Thomas Monjalon CC: "ferruh.yigit@amd.com" , "andrew.rybchenko@oktetlabs.ru" , "orika@nvidia.com" , "dev@dpdk.org" , Jerin Jacob , Nithin Kumar Dabilpuram , "stable@dpdk.org" Subject: RE: [EXTERNAL] Re: [PATCH v3 1/1] examples/l2fwd-jobstats: fix lock availability Thread-Topic: [EXTERNAL] Re: [PATCH v3 1/1] examples/l2fwd-jobstats: fix lock availability Thread-Index: AQHa4mfE8KjoH2CUikuMCBo4ubmnxLIPcbIAgA3VwICAAA8CAIAE8maQ Date: Sun, 11 Aug 2024 16:00:57 +0000 Message-ID: References: <20240729061026.3729690-1-rkudurumalla@marvell.com> <2648204.9Mp67QZiUf@thomas> <16895939.geO5KgaWL5@thomas> In-Reply-To: <16895939.geO5KgaWL5@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR18MB4255:EE_|MN2PR18MB3606:EE_ x-ms-office365-filtering-correlation-id: 5537ec4b-f4a6-4cb7-7757-08dcba1ec9bf x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700018; x-microsoft-antispam-message-info: =?utf-8?B?UWF2UlNJalBIZWR3aVA4aElpdTFQSHIxZERDRGRwMUlQaGxiSm5ROHZiNEF2?= =?utf-8?B?YWdCWGdtMjY0ZGFpTW1oTUV6RVE4U2VNMUlYWGV4OVBIL3pCOGJIc1hFTFI1?= =?utf-8?B?TFNIUmkrRmsyd0NQbEJVWEF1cm5hWjZ3WVN3Z1lNNFVsdGx3c3cySytTR0w5?= =?utf-8?B?M3V3MUR3b3hJVDNRUFBRUE1KY3NqMElJWHFOUzJheGVKVzNhbmlMcDJyVnRP?= =?utf-8?B?bjlBU3kxVGxBUnFnMmd3c0FTbDl4QVBiWlduTjlZODNUbml3VzBXdjU4aEVN?= =?utf-8?B?a3p0VXRoWC9md3BvOVEwY2dyakdxWU5tZytyMnhsMVYzaEx5YVRZdU9od3Qw?= =?utf-8?B?cjlLdDBsOTBLeDVXeVVBRG9DNHJ2a0paeXNibGZQSDJXckd4RmdvS1JpVXJi?= =?utf-8?B?SHpCOHVHbXFRbXpmVytmbmlPTlNDTEZKZ2lSNWpmanljdkRTR0U4MnZEakhY?= =?utf-8?B?b2xxeXJ3cm1sbkVXRFYrVE00NDlUU01sMW1zMDhmU3I0OGhTNHZEaXJPbHB0?= =?utf-8?B?bVZqWWtYT1U0N3lJSnVvNzNtTEZadG9GdGsrdU5UeUtUeE0vYWIrNHlZWDVm?= =?utf-8?B?akcrR0tjWktGdGN6akI3VTZPa25TSnVtMUdFV3RjUWtFR1piMGZmZCtCRUZo?= =?utf-8?B?OHE0R1dpcFJnNDl1MCtwMmszVXk5L2FYOGNUc2p6RmNoUFVGTlF5aHlLcnV1?= =?utf-8?B?SDViVmV1ai9ad0tlWGhMT0NLNXYxRG9Va0RMbE8zQloxdnFKcUlUYytFSFcy?= =?utf-8?B?blJ4ak5WRnRLTmVZdWM2WWVQNFcwb3lYcG83THFxR0hiU25XRVZqSlF0TXN3?= =?utf-8?B?Rk01Nzltb0diV0xoSzZ2cmdwRTY1OHZrMXNUNm1VUmYvZTVUZkZTaUNYS2ZM?= =?utf-8?B?Mmdvenoxekxiaks0cytDQktEN1VVcmUwNmplZ0NtOHFqTmhtL3dIdmZvQUlk?= =?utf-8?B?NnY5YTVseEhMVWw0ZFBLQXZoRlhpYkxuR2ZVamR4RVJqMkN5a09Ya0lObEVq?= =?utf-8?B?L0RoYjdzTnl6MGJER2VObzJxd0txWWtYc1p4ZWRURCsxR2I3VmVnSXJSWkZz?= =?utf-8?B?YXlvSmdNZ0lPWWgrQVZNU2VRdnRIQlVhTjFUOVovVEh1UTJJTDJYbVBFYzRu?= =?utf-8?B?K3lMQzZsTlhucEFTWGs2TzJaNGtlVnNIZFdaRWR2WDR1QlIxVEVMWWRlSmdN?= =?utf-8?B?Zk12RXFNT0h1VHJXSVcvTlQ2cVdaRDljQk1TNTRYNHZZV2RkcTN2QkhDdm1T?= =?utf-8?B?bEMwME1IZkhIZzZPeE9vQzRmaGFUdGJaWStQejRZT2U3cXRlVDFhZi93TUJz?= =?utf-8?B?TW1qbkIwb1JmT09MWUZpdnBUNncyTW5uUHNYK0RMWUN4UUdSeFVaWEpwREY5?= =?utf-8?B?QnQyZ3F1cHRHeVBlZXRnQmVvclNob1hFT0dhUXpQTldWbEtwa3ZibnBxRFVh?= =?utf-8?B?R2hCTnpwc3RlYjdKNWtuU2gyMTVKbGE3Q09BNjFiNXdIVlc1L082d3Rzb2hC?= =?utf-8?B?L2wzaE1xZmxucFJXSVZjbjVTa2h2aW5LMDR2b2RZU2hNLzhrWUNYOXhCOUF1?= =?utf-8?B?c1VMYWxjZGtxQ016eGhSU2VCUG9oRUw5L2tKZXBSTkh6amw5cjExQzlTYUlP?= =?utf-8?B?cko5ZXdVa2FvTDdIU2JkQUtaZ3lxNEZrc3VPbXBNTkZzVUNPdWZoUzdSaDdt?= =?utf-8?B?OEJYY0RCN0ZwUkNLanlNWXJzZGJKQWdDOFl1SDd3em5xOVRxMnIwZzhXQWdW?= =?utf-8?B?ZmJxeTZXdmtoSG01aFdyTEs2SUc2ZW1COXpDd1ZRcURZci9DZEJ6ZmdnRWlB?= =?utf-8?Q?k+10h89kJDt75N0Vey2rbQZvSqcM6KRKSjK98=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR18MB4255.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?T0dNOGpKVlRGaDdrNjNmNE1UeWRlMHdOT0lPTGZrVTFhemFLTjRHazcxTGcx?= =?utf-8?B?ZGNlMHNmWTFRZ0w3Q1VPclE3K3RuNTRCcTNvblk1amJpeHBlS1NlU2tYZGEw?= =?utf-8?B?NTBXL0xFU1p1a1AraVVQVU1WS2VSaEpwTVdzeFVjclJqa2lYL3l4b1ZwUFFk?= =?utf-8?B?Y2pld2ZER1BOUkxwbTFOaWd6aUcwdnpVMDZvV2pzaFF4UjV1bWtIdlFSM2g0?= =?utf-8?B?ejFQb3o2WGpYcmtKbzJhQ1NHQkQrZHB0MUZacDZpWUpNaVg5dk1DaTFITCtz?= =?utf-8?B?R0xiMXR0T1dqcE4vRkhJMzAyN3lyUXFhbUFxVnk2dytOTDlYUTNEbkNsUzZx?= =?utf-8?B?NlF3Y0thcytkTWdoYVV5SzhBWHFtcGtXOVpOam9FZ3ZnRTQ2NS9adEsrNnh1?= =?utf-8?B?Nk4rRDM0NzIrZSsvOHlDaGdNT2NFUjlQMkJpZGxmUUEyRFVPYUNWcFU1M1dn?= =?utf-8?B?eWFKT1ovSnk0T21ZME8vaDJNZ3JhemhWQ2NVZzRjbnYyNjlyMCtGN0RNU3Jm?= =?utf-8?B?eU9pd3N1SmZacmNCK2c1TlltVjBSSGlUWmNPMkZXVDYxZjd6dlJlNjNNTXdq?= =?utf-8?B?cVdHL3FEaUNDYTVjQ1Y2aHdkNUNyWVhiZUtuenlxZzNBdG84aE42UDQzeEs3?= =?utf-8?B?TFNVWTFpZThBQWJTamU2TzBTblJSTU5oSFpWV1RXMlVUaDdtQXROdE5QaEh5?= =?utf-8?B?dGFvNzN4OHNjbDRINzRjMGMwV040SHlCQUFmUzVyTGR0TVh2TjdTMEg1NUFu?= =?utf-8?B?OW4wVnRCOThnT1I5TnZBNTdneGpCVTVVMndoakRIZUtUenh3Y1F0WloxU2oy?= =?utf-8?B?aTlLd2RlUnhBTzk4RVZNQnpvQU4xcFpjbG1MaHJ3Ymt2Nk5nT25IZ1hLOUUy?= =?utf-8?B?QmVnb0szQjM2b2U1UVJkUk5WUWlobVZPQnpGcnJTZjVSeGZUMlEvZHZZVktt?= =?utf-8?B?MzYycjVzVGNDLzJQbzdteEtWMHBRQlAxdHUwS3ZQT1RYTGZHRXVEUmdvQy82?= =?utf-8?B?RTFEcm85dEsxM3pQZTVoTEtYYWUya2s5TkNNTXdkWjB0SGZETUI3QWFoUmFk?= =?utf-8?B?alFVZ0MxaVhkL0ZDRFVIOUUwQ2dCSWJjcW9hWW91RDNvODJLVDdWRTZZSzBC?= =?utf-8?B?VG1WNitoaTJqYmM4dnhpajBocHdGQ2VoeWlkZDIxeDk0ck9BeWYxak1TY1lB?= =?utf-8?B?Sjh6UDJyY0ZaeWcvZVpMNnd4RE5WKzN6YjRzYzJ3elBZSVBXT21JdFhudjJE?= =?utf-8?B?N0tmWkRqa2p6MGxwQlF5QnE3SVJYdG9WRmxSR2xjcjc2bm41RnByUmZxbkdt?= =?utf-8?B?ZytSbDhEQmN0bTd2bG9xUEZDcDNIa0lwZUlVQWFLRU5QRkxWTlZ1d3ppZDVP?= =?utf-8?B?RWJTUHNLZDdyQythUjR6Z2VCcTN3anFKVDIxMEh3SGQzT2x5RWRpYjFVMjlh?= =?utf-8?B?R1g5c3VtOThpNW9VNWxsdE4yT0d2dUMrZWMwSnRkVWNmek92RngyRHZERmF2?= =?utf-8?B?RWZiRzEydEtYVnU2V2J1U0xMeUxGakNidzhSUnBnbWs3TTFkT1BUQ3VkMU1R?= =?utf-8?B?UXBDUzZSbHphSnJrL3lraHZyeklNV1F0QTI1RXgwK1ZJaUtiZ0tCai9VaHJ1?= =?utf-8?B?dUgvNk9aTWJGYkl1L1ZiUGNEYkJrVTZ6cUpvWWorMG1aeW5ZOFRIMmthZGly?= =?utf-8?B?cjNtUTFCN3hSRjUvRGVETnBKUjdkbjJMNFIvaEdtOGxiYVpmNkRQcXkyd1ZR?= =?utf-8?B?Z1p2TW9HYlBoL3pwVlA0RHk1dWU4VlUxbndRLzliczlDTmZsVG5waHFYSGVL?= =?utf-8?B?R3dwWGhtbHZWWjloSkxJR1V6NWlYOFJ0ZStqSk0yYlQ3QjE4bzRRRHZoamdz?= =?utf-8?B?Q3Nha0JuYlpOWmFwUGJuck1RdjNLanJid3ZxcnIvMXpxNHFpelVYT2kxUi9G?= =?utf-8?B?Tk1vRWo1ejMzR093NHZ1elhFT1Y3UEVrMFdEWXVSVkdCNHdrLzljdXF0eWZF?= =?utf-8?B?bGt0NlhyblBuUFh0V0x4NGFQbXNidjE5dTNGZGlpMGVIM0hlMjlhSmFzK09z?= =?utf-8?B?bWFydTY3NGpMenl3QzB5bDZKTVRhTXQwUit3UnYyWVkyUUU2bVl2K0dYZTBj?= =?utf-8?Q?2zfHfZoNAZN+JQq5XiulHUnjT?= MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR18MB4255.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5537ec4b-f4a6-4cb7-7757-08dcba1ec9bf X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2024 16:00:57.5879 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gzbe2zqcIlZC1Vt7SGxoUvSXcRUEWceA4QOMA27QfovWnNvQh6xT9Mj5K+Ekcb5WsNC8LorGzbqrsqatlgKEUXj/xzAMXwUxyG7n7YODm2Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3606 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: 75NbW49N3SnEPUhQ5XIH3fpSrmsMlucC X-Proofpoint-GUID: 75NbW49N3SnEPUhQ5XIH3fpSrmsMlucC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-11_14,2024-08-07_01,2024-05-17_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, August 8, 2024 5:52 PM > To: Rakesh Kudurumalla > Cc: ferruh.yigit@amd.com; andrew.rybchenko@oktetlabs.ru; > orika@nvidia.com; dev@dpdk.org; Jerin Jacob ; Nithin > Kumar Dabilpuram ; stable@dpdk.org > Subject: Re: [EXTERNAL] Re: [PATCH v3 1/1] examples/l2fwd-jobstats: fix l= ock > availability >=20 > 08/08/2024 13:=E2=80=8A41, Rakesh Kudurumalla: > > From: Thomas Monjalon > > Sent: Tuesday, July 30, 2024 9:= =E2=80=8A42 PM > To: > Rakesh Kudurumalla > Cc: > ferruh.=E2=80=8Ayigit@=E2=80=8Aamd.=E2=80=8Acom; andrew.=E2=80=8Arybchenk= o@=E2=80=8Aoktetlabs.=E2=80=8Aru; >=20 > 08/08/2024 13:41, Rakesh Kudurumalla: > > > > From: Thomas Monjalon > > Sent: Tuesday, July 30, 2024 9:42 PM > > To: Rakesh Kudurumalla > > Cc: ferruh.yigit@amd.com; andrew.rybchenko@oktetlabs.ru; > > orika@nvidia.com; dev@dpdk.org; Jerin Jacob ; > > Nithin Kumar Dabilpuram ; stable@dpdk.org > > Subject: [EXTERNAL] Re: [PATCH v3 1/1] examples/l2fwd-jobstats: fix > > lock availability > > > > Hello, 30/07/2024 12:=E2=80=8A03, Rakesh Kudurumalla: > This patch addr= esses > > the issue by introducing a delay Please start with describing the > > issue. > before acquiring the lock in the loop. This delay allows for > > better > availability of the > > > > > > Hello, > > > > > > > > 30/07/2024 12:03, Rakesh Kudurumalla: > > > > > This patch addresses the issue by introducing a delay > > > > > > > > Please start with describing the issue. >=20 > You should explain the race is managed with a spinlock, and where the > threads are running (one is a timer). > Updated commit message in V5 >=20 > > > before acquiring the lock in the loop. This delay allows for better > > > availability of the lock, ensuring that show_lcore_stats() can > > > periodically update the statistics even when forwarding jobs are runn= ing. > > > > > > Why a delay is better than a pause? > > > > > > due to high frequency of polling in l2fwd_main_loop() rte_pause() is > > not yieding the processor to display stats relating to fwd and flush > execution time so added a delay achieve the same. >=20 > Which CPU did you try? > arm