DPDK patches and discussions
 help / color / mirror / Atom feed
From: Shiva Shankar Kommula <kshankar@marvell.com>
To: Shiva Shankar Kommula <kshankar@marvell.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
	"chenbox@nvidia.com" <chenbox@nvidia.com>
Cc: "david.marchand@redhat.com" <david.marchand@redhat.com>,
	Jerin Jacob <jerinj@marvell.com>,
	Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
	Srujana Challa <schalla@marvell.com>
Subject: RE: [EXTERNAL] [PATCH] net/virtio-user: reset used index counter in dev reset
Date: Fri, 6 Sep 2024 10:14:40 +0000	[thread overview]
Message-ID: <DM4PR18MB4269B16AEDCB219875072653DF9E2@DM4PR18MB4269.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20240805100841.276796-1-kshankar@marvell.com>

Hello Maxime, 
could you please review the following change ? 

Thanks

> Subject: [EXTERNAL] [PATCH] net/virtio-user: reset used index counter in dev
> reset
> 
> When the virtio device is reinitialized during ethdev reconfiguration, all the
> virtio rings are recreated and repopulated on the device. Accordingly, reset the
> used index counter value back to zero. Signed-off-by: Kommula Shiva Shankar
> <kshankar@ marvell. com> 
> When the virtio device is reinitialized during ethdev reconfiguration, all the
> virtio rings are recreated and repopulated on the device.
> Accordingly, reset the used index counter value back to zero.
> 
> Signed-off-by: Kommula Shiva Shankar <kshankar@marvell.com>
> ---
>  drivers/net/virtio/virtio_user_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/virtio/virtio_user_ethdev.c
> b/drivers/net/virtio/virtio_user_ethdev.c
> index ae6593ba0b..d60c7e188c 100644
> --- a/drivers/net/virtio/virtio_user_ethdev.c
> +++ b/drivers/net/virtio/virtio_user_ethdev.c
> @@ -204,6 +204,7 @@ virtio_user_setup_queue_packed(struct virtqueue
> *vq,
>  	vring->device = (void *)(uintptr_t)used_addr;
>  	dev->packed_queues[queue_idx].avail_wrap_counter = true;
>  	dev->packed_queues[queue_idx].used_wrap_counter = true;
> +	dev->packed_queues[queue_idx].used_idx = 0;
> 
>  	for (i = 0; i < vring->num; i++)
>  		vring->desc[i].flags = 0;
> --
> 2.43.0

  reply	other threads:[~2024-09-06 10:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-05 10:08 Kommula Shiva Shankar
2024-09-06 10:14 ` Shiva Shankar Kommula [this message]
2024-09-19 10:54   ` [EXTERNAL] " Maxime Coquelin
2024-09-19 11:17     ` Maxime Coquelin
2024-09-19 12:06 ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR18MB4269B16AEDCB219875072653DF9E2@DM4PR18MB4269.namprd18.prod.outlook.com \
    --to=kshankar@marvell.com \
    --cc=chenbox@nvidia.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=ndabilpuram@marvell.com \
    --cc=schalla@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).