From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17E05423C0; Fri, 13 Jan 2023 08:45:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF648410EF; Fri, 13 Jan 2023 08:45:07 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 704FF410D4 for ; Fri, 13 Jan 2023 08:45:06 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30CNQjtB015416; Thu, 12 Jan 2023 23:45:02 -0800 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2047.outbound.protection.outlook.com [104.47.66.47]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3n1k573ym7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Jan 2023 23:45:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xq4SZjFT6Ic6wSHEU5eCRO8VtqdMUuDFmEHjWo8jNNya+vM+sDjttZIovsgDe1xHzGLSUbCh64rZkOXwxf9V6RL3ovM1ne7uFxHlf9UNi2xyyztftzDOtxwj5/IuCnKoyb1KIq69SC9kba/6KEK9HBiJHLpWqyEEsaNQh0xPR/mJHER8wE/LT4HQ1p8c/gcDNSv38vx/2fxfnA5KaVIxbBI0DBIcPugYofuppI3FVuAgGyC6P56bGzwqfyxGuckeLRWnTS9DAfxHDEwMfdaop2aUa3tC04ygBtkC59ewz8cIyODF2Y0N+/btEkPjd/fuFPmUJJ1BeK7UmHImK5qKOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XyOPgNAowWms0ga70vLjDgUIQa0zseGeY+8os2uaefc=; b=iA8P+boJDNy+ZEj+wArVQhW8vrqxUb8psv/higOLlPPO5QTtB3ARwrYiB3AR23LeQAXda2yusNI+9t7/lvrPPRPawgNnuWslgqBprlR8M0dWsMGYHpdbWrR67wXgeLQ3v4z7XB73lhegbheYqJK+OQ1e3CitnYleY/Rtt1CXse2Tur8OFIHnp5f0467LRrxEbWY8b5wkCN7O/Bh6/jFDAwFVb9jKLSEOAGNyknyat7Kiw2645KsZXELMnXhm3dJkz/SHMSJ2TBqcaRcqn7738hfL9Qy7C/atfcYga6L+dT/Sb3cw4LLE3eHIp3A3XfMJ4xGhSOwE6T22tT+umx7F/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XyOPgNAowWms0ga70vLjDgUIQa0zseGeY+8os2uaefc=; b=umQFvezhGa/QK9XRn3zkYBjDOx3LpizROakGGNnHaVJWA+tYC0aQyY8FY0qFnAUGNiXPUUfuLrGBGAnlZOR/JzjHdMhO21vhp27ieh6z14iM+72gc8iWzoroHxXyOySSUZxM5SOAOek60+HeS6joZlTitstjqh8xRma47WiqeYM= Received: from DM4PR18MB4368.namprd18.prod.outlook.com (2603:10b6:5:39d::6) by SA1PR18MB4632.namprd18.prod.outlook.com (2603:10b6:806:1d3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Fri, 13 Jan 2023 07:44:58 +0000 Received: from DM4PR18MB4368.namprd18.prod.outlook.com ([fe80::3117:f51c:37c2:fa05]) by DM4PR18MB4368.namprd18.prod.outlook.com ([fe80::3117:f51c:37c2:fa05%9]) with mapi id 15.20.6002.013; Fri, 13 Jan 2023 07:44:57 +0000 From: Tomasz Duszynski To: Tyler Retzlaff CC: "bruce.richardson@intel.com" , "mb@smartsharesystems.com" , "dev@dpdk.org" , "thomas@monjalon.net" , Jerin Jacob Kollanukkaran , "Ruifeng.Wang@arm.com" , "mattias.ronnblom@ericsson.com" , "zhoumin@loongson.cn" Subject: RE: [EXT] Re: [PATCH v5 0/4] add support for self monitoring Thread-Topic: [EXT] Re: [PATCH v5 0/4] add support for self monitoring Thread-Index: AQHZJU3PoaXFeNya/UGj1gI3nUnCHa6YXbsAgACP+SCAAMikgIACRGMg Date: Fri, 13 Jan 2023 07:44:57 +0000 Message-ID: References: <20221213104350.3218167-1-tduszynski@marvell.com> <20230110234642.1188550-1-tduszynski@marvell.com> <20230111003222.GA24460@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20230111210547.GA2134@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20230111210547.GA2134@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR18MB4368:EE_|SA1PR18MB4632:EE_ x-ms-office365-filtering-correlation-id: a2b9a343-4ddd-413d-5e71-08daf53a1167 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DEXQTKhlhKRlXGZfWGtlHnLmfwaLA1SyHio8Q661R2/lO33orcQSVVA8YnA2gdzhCQkfXCHOM7JmlbnwHvU5Sl6focRHRNS0EDen0j+AWzspuMbzbpNp4d2ZOafSXGhrdmxAEEnSIH7RjfDilK0mvi6w+vA4OW0M2OP/yYNe/4twVS2geGj8M6IttHw/Vp2PHiwNNx/5UcU36/BEUSAjeMVZGHiGg/yRN4ZYcyCv0nL1oA3XxbeDC7SMiZ7JFciNfLMj2KUglld73dpmwJ1KuYnjQ5NH4bXbbjK7a2ACLseF5u+P2F9DLcSWf0vWOoSdoHFEQGFezv8vcvRm5p/JjI5DKaRNiXI9ZYCN5AwermcVhD7dK8rv78Imy6VuAZoG3xAOAEN1H8WPdOI+VNM27pAgV9tic+JPDb7pwJEkO4fgbXiea01w7TqZzV10qYLoH0VZBSm4QASf11JiD9TbKKRW33C5xDkpj2i6Wqm7+LCc+H4f9Ik1M+4UVANZe8Xdh8ZKYjrOcJxn3Ydz+39q5zVF+suXpRLMotGJD99gPFLYJiCxz8+ELgQAlmhfZot8aK3oNLxv9zd6C3G4JeX8f7PGuPLte8fnt7g8ent5ZoIGYM1q3ed3ytSLxeDVDn/sgOE0OejC0m6XNow0qpSf0yTc3nHZGD90/uCbF0lOBaZ7HNnIKKNed8/Do1yM+SAQMD4xPfgkfcaMf/SiSJGnwg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR18MB4368.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(346002)(366004)(376002)(136003)(396003)(451199015)(8936002)(26005)(71200400001)(2906002)(5660300002)(41300700001)(66446008)(7696005)(66556008)(4326008)(64756008)(8676002)(76116006)(316002)(66476007)(6916009)(66946007)(54906003)(38070700005)(55016003)(38100700002)(122000001)(86362001)(9686003)(186003)(33656002)(83380400001)(52536014)(6506007)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Z1Wv3+V5Q//W0Ncz5ggQwk2RwAzne06oJHRPvJW7Yrt/VbBilEHdEDZuYZM8?= =?us-ascii?Q?JcyPtffhGXB7T4YCC489N6vQOx+1e0qVs9J8dnJrv5S4HaB7ea4IROpQ68oz?= =?us-ascii?Q?pMquqD+kF2kqqojfTg97O0JApnqXJbq32oDu1BqaYPwJZ/WgYNqjpp58oOp7?= =?us-ascii?Q?TOiVVzIVhOx130kl1pA7lCZKKc0vh0wbgf5g0GJNP5VKLxswPjqS5rBw3Nk8?= =?us-ascii?Q?kbZwVQnxiqvY4Lu7fEvfVqKguT7ktMj/Jry85hDG+xk+S8IAQHfm1A85nzz6?= =?us-ascii?Q?hhn8Y6NxUm6g9GS8FMCQkfD2BL6Ja3iFWWwo0Rj7tgKG7PRbPlPFOsfDkkeF?= =?us-ascii?Q?6IwMgConJ7KHAhJ1vqp6ofh0er+3+lq4Vp6f+IczbDgw/YAt7p5XaH9qOgHD?= =?us-ascii?Q?kDDG8VUbiqRzU/cy11lk6a6ETK/0gT5jel0gAsUNdb0Q6Sppjs0k3vxhf4Rq?= =?us-ascii?Q?mOMmBC7sQxZHXdv3xZAc/jUsIxEcBgmHPPtiu3XMxDO1NcG6AXug+4ClaRrX?= =?us-ascii?Q?GX1bXLA9HmMVRcPQ/9NM6PL4se/inyYihU39jOAQKsANH4XPQR2arG+wCfuK?= =?us-ascii?Q?ETop8LfiOHNPWxMEZMZ8WWPMefYmz0ZPGFV0jq2NOC5qVUBZ0b28+PTjjA4D?= =?us-ascii?Q?G+L6/S9kzJ8U/OPJ38uWY28VaJJ3j9QCVNO0jnQmdQzzlvexi1q1EZ+ypHu+?= =?us-ascii?Q?V6zwGtZVSgsvkrtg4KEHtETpqyXAYPEVEIWa/L/J70QxyXZUfsoCPP0YhXCp?= =?us-ascii?Q?S6j91q8f7GZNaoE4TNtzW6GUT6dbxANiYyikSCF0QrtwsPXm3AGtfdwcsXzy?= =?us-ascii?Q?wNNslk2uofLjlIVSmOO/qZf1grwR17uVaQ9ab5kuO5GyB+CVjiCRU3kwqBlN?= =?us-ascii?Q?cQeydt2RDb5eYUvMOjdAtWgMazHbS9/mWM7Qf/P/VqNs7CQf4BjqpWMR26pe?= =?us-ascii?Q?RHhw+0jwFxv3+J5ZQFwPMgwMscHbKymQ1rytk81InwZB7GSQfyoF4Vm822bE?= =?us-ascii?Q?78pLVZ1NNfeF7YXKmx0Nz9vE4ebryteb853nZ3YyKTwH9R3HVbQ5FqDRWkkm?= =?us-ascii?Q?bf3jTI+wIhbXtCbsKZPAcg7yVRkiRViBe41yp85EExSnvd6cb8xvbapyjTJX?= =?us-ascii?Q?kVo8JI4ZggWY+mSBX/475W+R3xc5xLBkOYUZc7jxNq2VaP8gyxl2XkDcNZnV?= =?us-ascii?Q?5bbvyowWAgf66oN6xedHA+uGaGZAaWb0GmouN9CJXjAocCv6qCJOscwUhvbG?= =?us-ascii?Q?m8/kVivqnGmmjeYqrwH9jqNDOIjlOPGwSmjQSuSp4CQKu74ZXMo7ew/88QDT?= =?us-ascii?Q?6h2EIFlrSsGl9sOQDmupUBedc6yLE/0BOhLxM/zT2weK6EJuAnK8EQELRVAy?= =?us-ascii?Q?wMZzhT2F0nJCFWb8JmgLkRItdA7SpAHvZMLJvfJpPJ7k/u9KJGTNO79tHmCg?= =?us-ascii?Q?QEmJ39AhwyM941CaxN4sllojU/orzQkRMlJX/UYmXqi8mPO/DmrCWMPVXRfP?= =?us-ascii?Q?bApHMTVBWGYU83GnXZbFhNZPOd2ax8GzV/qUA+onSjaWYCGdfEQ3fYJSXz0F?= =?us-ascii?Q?R/h8tOFMmgboV9B1xq7ffgX7Lq0GuNBp2YsD5YWE?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR18MB4368.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2b9a343-4ddd-413d-5e71-08daf53a1167 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2023 07:44:57.4773 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6m7J4vVV3Cvwh8jElDAmfbNV83as2XPE8VvVDTzZTpAkv+cH2ggxZ7ETLfFxaqe42FOFfycaTemeQzIpIMCt0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR18MB4632 X-Proofpoint-ORIG-GUID: RNCKEOYdqLdMrLV_QgF1j0xzpoD4lX6N X-Proofpoint-GUID: RNCKEOYdqLdMrLV_QgF1j0xzpoD4lX6N X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-13_03,2023-01-12_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >-----Original Message----- >From: Tyler Retzlaff >Sent: Wednesday, January 11, 2023 10:06 PM >To: Tomasz Duszynski >Cc: bruce.richardson@intel.com; mb@smartsharesystems.com; dev@dpdk.org; th= omas@monjalon.net; Jerin >Jacob Kollanukkaran ; Ruifeng.Wang@arm.com; mattias.ro= nnblom@ericsson.com; >zhoumin@loongson.cn >Subject: Re: [EXT] Re: [PATCH v5 0/4] add support for self monitoring > >On Wed, Jan 11, 2023 at 09:39:35AM +0000, Tomasz Duszynski wrote: >> Hi Tyler, >> >> >-----Original Message----- >> >From: Tyler Retzlaff >> >Sent: Wednesday, January 11, 2023 1:32 AM >> >To: Tomasz Duszynski ; >> >bruce.richardson@intel.com; mb@smartsharesystems.com >> >Cc: dev@dpdk.org; thomas@monjalon.net; Jerin Jacob Kollanukkaran >> >; mb@smartsharesystems.com; Ruifeng.Wang@arm.com; >> >mattias.ronnblom@ericsson.com; zhoumin@loongson.cn >> >Subject: [EXT] Re: [PATCH v5 0/4] add support for self monitoring >> > >> >External Email >> > >> >--------------------------------------------------------------------- >> >- >> >hi, >> > >> >don't interpret this as an objection to the functionality but this >> >looks like a clear example of something that doesn't belong in the >> >EAL. has there been a discussion as to whether or not this should be in= a separate library? >> >> No, I don't recall anybody having any concerns about the code >> placement. Rationale behind making this part of eal was based on the >> fact that tracing itself is a part of eal and since this was meant to be= extension to tracing, >code placement decision came out naturally. >> >> During development phase idea evolved a bit and what initially was >> supposed to be solely yet another tracepoint become generic API to >> read pmu and tracepoint based on that. Which means both can be used inde= pendently. >> >> That said, since this code has both platform agnostic and platform speci= fic parts this can either >be split into: >> 1. library + eal platform code >> 2. all under eal >> >> Either approach seems legit. Thoughts? >> >> > >> >a basic test is whether or not an implementation exists or can be >> >reasonably provided for all platforms and that isn't strictly evident >> >here. red flag is to see yet more code being added conditionally compil= ed for a single platform. >> >> Even libs are not entirely pristine and have platform specific ifdefs >> lurking so not sure where this red flag is coming from. > >i think red flag was probably the wrong term to use sorry for that. >rather i should say it is an indicator that the api probably doesn't belon= g in the eal. > >fundamentally the purpose of the abstraction library is to relieve the app= lication from having to >do conditional compilation and/or execution for the subject apis coming fr= om eal. including and >exporting apis that work for only one platform is in direct contradiction. > >please explore adding this as a separate library, it is understood that th= ere are tradeoffs >involved. > >thanks! Any ideas how to name the library?