From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 807A84246D; Thu, 26 Jan 2023 09:35:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3345840697; Thu, 26 Jan 2023 09:35:40 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id C5E32400D7 for ; Thu, 26 Jan 2023 09:35:38 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30Q7W9qp015604; Thu, 26 Jan 2023 00:35:38 -0800 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2171.outbound.protection.outlook.com [104.47.56.171]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3nbn720b89-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 Jan 2023 00:35:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ierdi6d4Q8Z04l4+h5AgGdDFXQKxiaS5zjNor10dLxdVv6pUjPIRIeqaoR6qf9PM6y/TYL6Hbny874l4urloea1W2nKriozU8QXdL5xBmwuS/drpS3A7jnPQvV9+zsHWdAvc2pvoRuB1lC0NYsC60z/glekf0RLUuzIFlMTm0IIizX6+47NuuNaxCxyiFhgWtD1JNIkX2otY10VrTPNVYzPfcdoX09tl1l5CldhpQqy7Y+NEGMac5eacheU3SgInDizeCAv7MrZTzbbFb7Vx2UKhp4e5NLMioCuolDT4aevR//RgM/sxHmCDiSDn/qLPJuet06WWwmZKFBVbgdhqsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SAW0jhsSVA5dJjSXj4w+5p9Vkjlw78s5Ta+6Uo2O6U0=; b=PICyyxYCoYvIMayZRulqRBkFRhBXRzJt8b4kqtLxPyToYfluatwOyN3dugD5TRgrid0RVZi1XEN9mTSf1VTcid978GUYtlBN2Y4oKrGIqmkZGnGbBPVe9xDxAYoLQh3l0XL0oF3qLaGfaHaZXL9dVk0+9jv1ZwJGOZ8iSZ/zRKBWvGyYGnrIUvKVDEMn/iNT4ekNJxRpgQvgHwQx2OmvJGU8QP4mHC4fTgBqhktuiLKctD84PvgBWyfdE3avrY0VhYUxva8/XM+mo1etmd+MrjMwDgVORE3xQNVxHrKbBrgt5KIXjhcyXACkGkK3j5TwFOlUMjooxIiFVMMmv899Og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SAW0jhsSVA5dJjSXj4w+5p9Vkjlw78s5Ta+6Uo2O6U0=; b=GnKPvwLW/UEmMfgr7odw9bQuf8hUi32bHyLJKfKwbEnEZDfun1hP1tDCEecVHfUlQUCo3MAW8GFyAu12EJOT3sngc7fguzw5YNXIFQl9RMAlkYu9I4AMG+gFHO2JeT7UgqxNEMZtylecolYTX9uVdqwW2jSHXPU39OP/DuDmoR0= Received: from DM4PR18MB4368.namprd18.prod.outlook.com (2603:10b6:5:39d::6) by PH0PR18MB5116.namprd18.prod.outlook.com (2603:10b6:510:16d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Thu, 26 Jan 2023 08:35:35 +0000 Received: from DM4PR18MB4368.namprd18.prod.outlook.com ([fe80::3117:f51c:37c2:fa05]) by DM4PR18MB4368.namprd18.prod.outlook.com ([fe80::3117:f51c:37c2:fa05%9]) with mapi id 15.20.6043.021; Thu, 26 Jan 2023 08:35:35 +0000 From: Tomasz Duszynski To: Thomas Monjalon CC: "dev@dpdk.org" , Jerin Jacob Kollanukkaran , "stephen@networkplumber.org" , "chenbo.xia@intel.com" , "david.marchand@redhat.com" , "bruce.richardson@intel.com" Subject: RE: [EXT] Re: [PATCH 1/2] lib: add helper to read strings from sysfs files Thread-Topic: [EXT] Re: [PATCH 1/2] lib: add helper to read strings from sysfs files Thread-Index: AQHZMKh3Sk3R3bTHMEOe9a9tMB63m66u8UsAgAFuLyA= Date: Thu, 26 Jan 2023 08:35:35 +0000 Message-ID: References: <20230110234642.1188550-1-tduszynski@marvell.com> <20230125103311.1249988-1-tduszynski@marvell.com> <20230125103311.1249988-2-tduszynski@marvell.com> <73101748.RN2Pgac3cq@thomas> In-Reply-To: <73101748.RN2Pgac3cq@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR18MB4368:EE_|PH0PR18MB5116:EE_ x-ms-office365-filtering-correlation-id: fc53257d-fcdb-44d6-5e9c-08daff784b55 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 49kSwBKauFuTHtLDI1tpB2uwVjDY8EOy4o8G4Hf4/J/KbzrsVyBVH2sYTBbw76r/hml8M7a0DnAJO1s5rfKBsr/mW6eul/zi+hAPXxh0JUt/IsgrdmpmmxycXIQk13+wBNklrEXqWqVktv3iB46Uw9ZaDbHHM9aBNywgVulXlSn6ZJfCjjKoTgST8Mz7z2d4Me3KNFshZTDK88wgH37qPhgh3HmGVmpHcSQ6+e8OqBReGJolV5OAmNQw8Bv7o8lGUHMnhCiooVMdav20u+bVwquqFyuJBkITgi+O4Odhrj2WebAmmcuVEB8K6sAPL03ZU2MthC59C0ZDt78gJc1ciw2DSp1jsNXTaBLvLytGL9uArQOdUiwatC088TLDCIGoX1qnm/Mu01tKyeLiicv9TLX1KF9Zye9tNVieoQNbSYwB9vP7oFpTuxSHU9XgiSXcqF2Ixu7+1uxhmUBQsZNGiv1BMycfPCUKioD2yW8x04++YGkoG4GX7ApywTShJRV+adBszApp9L6NOfBssxpsMusyXbHanQKxxc/ZePygQdZqS/yvT5K0wlRXwp7yGkvccR7HEuNv7hZ20+sX+uObxlEhOP3+4VWuBeJzWJRoapXYRGu4lI+d6eQf6+bVxFCZVyKcfvrhYtkPpAmAs5KSfhNaF8OU7YMZdZqFHJ3Nx0FXiJYWSsrtNRBCfW0ZHzsiOeLsbiaDEK9zeTdzb0/qEQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR18MB4368.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(396003)(346002)(136003)(366004)(39860400002)(376002)(451199018)(86362001)(122000001)(52536014)(38100700002)(4744005)(5660300002)(4326008)(2906002)(6506007)(26005)(83380400001)(71200400001)(33656002)(7696005)(38070700005)(54906003)(8936002)(316002)(41300700001)(9686003)(55016003)(186003)(478600001)(66446008)(76116006)(66946007)(6916009)(64756008)(8676002)(66556008)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?K9/hSpp6ZHXOixljIL5aSzEPqKsDyVQjBd0lffOu4UA2gGU3ExUau3o5H/QS?= =?us-ascii?Q?/gNXHixMI6CXbS0UKyGoRfWzBCNr8eGDE+3x4cEjL6qO+9J/L2TROmIf5ysb?= =?us-ascii?Q?iTATO6t+Exi8bfJ2UpQX0ayoCDnDDuwS3DL+xZy04WmHpbQJFD46JJ38hYW1?= =?us-ascii?Q?a5XmiVqPDp3VKBE8irJ8TRtFGCyyKjNTgkK2hhWKOBIsjODlRsVHQdtYRccs?= =?us-ascii?Q?sqxsZfapGps7g4cEv2Grv8d8ZwxyX30A27dwto0cuIr3z2JPqVpipoiJrOjJ?= =?us-ascii?Q?uqCBBJcV1lgNg/Q7vDFNjpAyrGJ5VeP7QCknmnf//SiX2xiuS+zlBBwanxzr?= =?us-ascii?Q?k+Hqac5C9a3HqmGc7jWZFuD0DnhhCEMMcbGGXp9+YaLamzKOebsXOSi0eROT?= =?us-ascii?Q?IHPgOhdFnXAo02YUe2OnXjezFNsacExJ0PMmUl0rtGxwTHc/YT3VHauCvalh?= =?us-ascii?Q?81hlBdBBWMVTXq7fWfQsJ8wANm9PZbCgOPCHL61VJ7PXcKnI29xr6uz0LfAx?= =?us-ascii?Q?Py7hmP0NUAjRJEi7Adjn7UrpzA48HqP/glf32g2Dca9kxkehIoHdZ3nNO6Mm?= =?us-ascii?Q?chQLhrpXQ4MTDPnK+D+MqATxVnOzkfVOU7/yXkuVkASFHFwvG7/0BHW0S/nS?= =?us-ascii?Q?Agf9fvno6LEx9Yojx/Q/VCHHqy8LjZEdm9g61jQiFf0jW/XkNsQVwnJdNDj/?= =?us-ascii?Q?MZPRKAYOPcyPUoSdRUdUweLzpnOuMqqaG9iwrK6bp4jGIHuZ9iLQphy1oCx2?= =?us-ascii?Q?EhiAxjP5j1uvXclpAdxb2AlqdKE81QovXYCTJcZHtmotX3tzZHEZFJFjDmx9?= =?us-ascii?Q?bqOoAKTQ//+Md3Thm5Wwm7c5ZWYQdrcCLCUH+3CIrjJ4vCBjF3UixkpqDbEO?= =?us-ascii?Q?/zwsJTnfMmWJ+97HtHes+Zp2AmxzSYHcQ3aNOOFF2nXtvYY/Gj7J3xF/jRYS?= =?us-ascii?Q?gF07BeucC8+HjmgTpn3TmSdIEYSeouTQDdAIH7QxQhcPiYS8LAnbLuTxO0pS?= =?us-ascii?Q?EMPg3IfFpvMxbUCOT0jaJdPruQPjlN2Iu6/iYBC0M1pPBRN3D85kSkI9IE7W?= =?us-ascii?Q?G6YBj8jaiF/STYahfdocCom2/c89KTmrIQy2F3htwD86wr7jQJmwWScJnONS?= =?us-ascii?Q?vKQLKn13W4FWIAxYLsrpj9cud2YEn2yPfZSSLzli9QUYeQEqtIko99VdDx8I?= =?us-ascii?Q?V0BUVWC6ToafZ9Ypvm+ixZICZKfGJ7HUyxhIrBvQWKLaT6xNLsNzyfnJnywK?= =?us-ascii?Q?iEzmQqt1hu3aRQ9+tlfvvEAiNhiUNcEo1Q+IcA0NkdUzRXD75fb7OaSVQ25S?= =?us-ascii?Q?T0HmgJeoMmYQUC7YhI3mVm5/MlyEGVggEpjthnLZ177JusYBXlt4OIRrwp0z?= =?us-ascii?Q?rr5QdiK6yjByTKEIx0yHHtQPMOLiaMkRl3cGWPsxTa+A+vtVHInLf+g6MPpB?= =?us-ascii?Q?WH0Ma6xKgVuyRwfid/XJ//7/MiKZua0VoWCd8xu6t5So8JdMsp9bS7EOYInr?= =?us-ascii?Q?nqBCshLEGcaUyUSsFUiblnXVcTO0makLeBtPhUrHeY5jFwQdLD3ulAGEIhi3?= =?us-ascii?Q?9uXfxPfV4aSlX4qgi2/N8GI2R0xTX/A1Xk7MrPOI?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR18MB4368.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc53257d-fcdb-44d6-5e9c-08daff784b55 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jan 2023 08:35:35.1078 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2aw204G6gStkt7EzKS3u5tNGDghIovBUGdH9KJXuDn0ooDoe8Kze0sTZwaHM5KpodBf06RBO51FjCOOFFDn4KA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB5116 X-Proofpoint-GUID: r_ai_AKF09Lubg5-HY8xaQeHnBXoa4bd X-Proofpoint-ORIG-GUID: r_ai_AKF09Lubg5-HY8xaQeHnBXoa4bd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-26_02,2023-01-25_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >-----Original Message----- >From: Thomas Monjalon >Sent: Wednesday, January 25, 2023 11:40 AM >To: Tomasz Duszynski >Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; stephen@= networkplumber.org; >chenbo.xia@intel.com; david.marchand@redhat.com; bruce.richardson@intel.co= m >Subject: [EXT] Re: [PATCH 1/2] lib: add helper to read strings from sysfs = files > >External Email > >---------------------------------------------------------------------- >25/01/2023 11:33, Tomasz Duszynski: >> Reading strings from sysfs files is a re-occurring pattern hence add >> helper for doing that. > >In general it would be to nice to clean sysfs parsing in libs and drivers,= so they all use some >functions from EAL. > That's generally true. Here I wanted to avoid tree-wide changes caused by u= nrelated work i.e a new bus and do a cleanup, i.e use this read string util where applicable, later on.= =20 =20